46904 2010-09-30 08:38:24 -0700 The backreference checking isn't working in some cases with YARR Interpreter 2010-10-14 11:01:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 46719 1 pvarga pvarga abecsi barraclough commit-queue msaboff zherczeg oldest_to_newest 287561 0 pvarga 2010-09-30 08:38:24 -0700 The YARR Interpreter doesn't handle the case when a backreference points to the same parentheses where it is. Therefore the YARR Interpreter causes assertion in debug mode and a regression in a JSC test. Eg.: "a".match(/(a\1)/; result: , expected: a,a 287566 1 69338 pvarga 2010-09-30 08:45:11 -0700 Created attachment 69338 proposed patch 294188 2 69338 barraclough 2010-10-14 10:41:05 -0700 Comment on attachment 69338 proposed patch Nice fix, thank you! 294203 3 69338 commit-queue 2010-10-14 11:01:12 -0700 Comment on attachment 69338 proposed patch Clearing flags on attachment: 69338 Committed r69781: <http://trac.webkit.org/changeset/69781> 294204 4 commit-queue 2010-10-14 11:01:17 -0700 All reviewed patches have been landed. Closing bug. 69338 2010-09-30 08:45:11 -0700 2010-10-14 11:01:12 -0700 proposed patch 0001-backref.patch text/plain 2047 pvarga RnJvbSAyNTJhOTJlOWM1MTRlMTc3OTk4MjlkZWE4YmM2MjUyOWMyOTJkNTk3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBWYXJnYSA8cHZhcmdhQGluZi51LXN6ZWdlZC5odT4K RGF0ZTogVGh1LCAzMCBTZXAgMjAxMCAwODo0MzoyNiAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIGJh Y2tyZWYKCi0tLQogSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICB8ICAg MTMgKysrKysrKysrKysrKwogSmF2YVNjcmlwdENvcmUveWFyci9SZWdleEludGVycHJldGVyLmNw cCB8ICAgIDcgKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAwIGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFT Y3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBlNzkzOTU1Li40MmFjOThmIDEwMDY0NAotLS0gYS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBA IC0xLDUgKzEsMTggQEAKIDIwMTAtMDktMzAgIFBldGVyIFZhcmdhICA8cHZhcmdhQGluZi51LXN6 ZWdlZC5odT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGUgYmFja3JlZmVyZW5jZSBjaGVja2luZyBpc24ndCB3b3JraW5nIGluIHNvbWUgY2FzZXMg d2l0aCBZQVJSIEludGVycHJldGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00NjkwNAorCisgICAgICAgIFRoZSBJbnRlcnByZXRlcjo6bWF0Y2hCYWNr UmVmZXJlbmNlKCkgZnVuY3Rpb24gcmV0dXJucyB0cnVlIHdpdGhvdXQgbWF0Y2hpbmcKKyAgICAg ICAgd2hlbiBhIGJhY2tyZWZlcmVuY2UgcG9pbnRzIHRvIHRoZSBzYW1lIHBhcmVudGhlc2VzIHdo ZXJlIGl0IGlzLgorCisgICAgICAgICogeWFyci9SZWdleEludGVycHJldGVyLmNwcDoKKyAgICAg ICAgKEpTQzo6WWFycjo6SW50ZXJwcmV0ZXI6Om1hdGNoQmFja1JlZmVyZW5jZSk6CisKKzIwMTAt MDktMzAgIFBldGVyIFZhcmdhICA8cHZhcmdhQGluZi51LXN6ZWdlZC5odT4KKwogICAgICAgICBS ZXZpZXdlZCBieSBHYXZpbiBCYXJyYWNsb3VnaC4KIAogICAgICAgICBUaGUgY2FzZS1pbnNlbnNp dGl2aXR5IGJhY2tyZWZlcmVuY2UgY2hlY2tpbmcgaXNuJ3Qgd29ya2luZyB3aXRoIFlBUlIKZGlm ZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3lhcnIvUmVnZXhJbnRlcnByZXRlci5jcHAgYi9KYXZh U2NyaXB0Q29yZS95YXJyL1JlZ2V4SW50ZXJwcmV0ZXIuY3BwCmluZGV4IDFiM2Y2MjAuLmVmZWFl ODAgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3lhcnIvUmVnZXhJbnRlcnByZXRlci5jcHAK KysrIGIvSmF2YVNjcmlwdENvcmUveWFyci9SZWdleEludGVycHJldGVyLmNwcApAQCAtNDk1LDYg KzQ5NSwxMyBAQCBwdWJsaWM6CiAKICAgICAgICAgaW50IG1hdGNoQmVnaW4gPSBvdXRwdXRbKHRl cm0uYXRvbS5zdWJwYXR0ZXJuSWQgPDwgMSldOwogICAgICAgICBpbnQgbWF0Y2hFbmQgPSBvdXRw dXRbKHRlcm0uYXRvbS5zdWJwYXR0ZXJuSWQgPDwgMSkgKyAxXTsKKworICAgICAgICAvLyBJZiB0 aGUgZW5kIHBvc2l0aW9uIG9mIHRoZSByZWZlcmVuY2VkIG1hdGNoIGhhc24ndCBzZXQgeWV0IHRo ZW4gdGhlIGJhY2tyZWZlcmVuY2UgaW4gdGhlIHNhbWUgcGFyZW50aGVzZXMgd2hlcmUgaXQgcmVm ZXJlbmNlcyB0byB0aGF0LgorICAgICAgICAvLyBJbiB0aGlzIGNhc2UgdGhlIHJlc3VsdCBvZiBt YXRjaCBpcyBlbXB0eSBzdHJpbmcgbGlrZSB3aGVuIGl0IHJlZmVyZW5jZXMgdG8gYSBwYXJlbnRo ZXNlcyB3aXRoIHplcm8td2lkdGggbWF0Y2guCisgICAgICAgIC8vIEVnLjogLyhhXDEpLworICAg ICAgICBpZiAobWF0Y2hFbmQgPT0gLTEpCisgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKwogICAg ICAgICBBU1NFUlQoKG1hdGNoQmVnaW4gPT0gLTEpID09IChtYXRjaEVuZCA9PSAtMSkpOwogICAg ICAgICBBU1NFUlQobWF0Y2hCZWdpbiA8PSBtYXRjaEVuZCk7CiAKLS0gCjEuNy4yLjIKCg==