46901 2010-09-30 08:14:48 -0700 Spatial Navigation: Press key "down" after page load should bring the focus to the 1st focusable element 2010-10-05 07:53:43 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 46905 1 cshu cshu ademar commit-queue tonikitoo yael oldest_to_newest 287551 0 cshu 2010-09-30 08:14:48 -0700 After page is loaded, pressing key "arrowdown" should bring the focus to the 1st element. But currently, focus goes to the last element. 287631 1 69346 cshu 2010-09-30 10:32:37 -0700 Created attachment 69346 fix patch 288267 2 tonikitoo 2010-10-01 08:59:25 -0700 will review it soon... 288938 3 tonikitoo 2010-10-04 08:22:06 -0700 Chang, before we go on, could you check how Opera handles the initial focused element for (SHITF+) ARROW_{UP, DOWN}? 288954 4 cshu 2010-10-04 08:54:12 -0700 (In reply to comment #3) > Chang, before we go on, could you check how Opera handles the initial focused element for (SHITF+) ARROW_{UP, DOWN}? I just checked Opera and it focuses on the 1st node initially. Btw, it is a great idea to use Opera as our reference. 288956 5 cshu 2010-10-04 08:55:36 -0700 (In reply to comment #4) > (In reply to comment #3) > > Chang, before we go on, could you check how Opera handles the initial focused element for (SHITF+) ARROW_{UP, DOWN}? > > I just checked Opera and it focuses on the 1st node initially. Btw, it is a great idea to use Opera as our reference. Just to make it clear, in Opera, shift+down brings the focus to the 1st element and shift+up to the last element. This matches the behavior of the patch. 288959 6 69346 tonikitoo 2010-10-04 08:58:15 -0700 Comment on attachment 69346 fix patch r=me 289376 7 69346 commit-queue 2010-10-04 21:03:47 -0700 Comment on attachment 69346 fix patch Clearing flags on attachment: 69346 Committed r69063: <http://trac.webkit.org/changeset/69063> 289377 8 commit-queue 2010-10-04 21:03:53 -0700 All reviewed patches have been landed. Closing bug. 289605 9 ademar 2010-10-05 07:53:35 -0700 Revision r69063 cherry-picked into qtwebkit-2.1 with commit c99c5e7 <http://gitorious.org/webkit/qtwebkit/commit/c99c5e7> 69346 2010-09-30 10:32:37 -0700 2010-10-04 21:03:47 -0700 fix patch 46901_1.patch text/plain 5647 cshu SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2ODc5OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDktMzAgIENoYW5nIFNodSAgPGNoYW5nLnNodUBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4 ZWQgdGhlIHR5cG8gdGhhdCBzZWFyY2hlcyB0aGUgd3JvbmcgZGlyZWN0aW9uIGluIHRoZSBuby1m b2N1cy1ub2RlIGNhc2UuCisgICAgICAgIEFzIGEgcmVzdWx0LCBhZnRlciBwYWdlIGlzIGxvYWRl ZCwgcHJlc3Npbmcga2V5ICJhcnJvd2Rvd24iIHdpbGwgYnJpbmcgdGhlCisgICAgICAgIGZvY3Vz IHRvIHRoZSAxc3QgZWxlbWVudCBpbnN0ZWFkIG9mIHRoZSBsYXN0IGVsZW1lbnQuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjkwMQorCisgICAgICAg IFRlc3Q6IGZhc3QvZXZlbnRzL3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LTFzdC1zdG9wLmh0bWwK KworICAgICAgICAqIHBhZ2UvRm9jdXNDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkZvY3VzQ29udHJvbGxlcjo6YWR2YW5jZUZvY3VzRGlyZWN0aW9uYWxseSk6CisKIDIwMTAtMDkt MzAgIFJlbmF0YSBIb2RvdmFuICA8cmVuaUBpbmYudS1zemVnZWQuaHU+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGlyayBTY2h1bHplLgpJbmRleDogV2ViQ29yZS9wYWdlL0ZvY3VzQ29udHJvbGxl ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL0ZvY3VzQ29udHJvbGxlci5jcHAJKHJl dmlzaW9uIDY4Nzg1KQorKysgV2ViQ29yZS9wYWdlL0ZvY3VzQ29udHJvbGxlci5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTI5OCw3ICsyOTgsNyBAQCBib29sIEZvY3VzQ29udHJvbGxlcjo6YWR2YW5j ZUZvY3VzRGlyZWN0CiAgICAgaWYgKCFmb2N1c2VkTm9kZSkgewogICAgICAgICAvLyBKdXN0IG1v dmUgdG8gdGhlIGZpcnN0IGZvY3VzYWJsZSBub2RlLgogICAgICAgICBGb2N1c0RpcmVjdGlvbiB0 YWJEaXJlY3Rpb24gPSAoZGlyZWN0aW9uID09IEZvY3VzRGlyZWN0aW9uVXAgfHwgZGlyZWN0aW9u ID09IEZvY3VzRGlyZWN0aW9uTGVmdCkgPwotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgRm9jdXNEaXJlY3Rpb25Gb3J3YXJkIDogRm9jdXNEaXJlY3Rpb25CYWNrd2FyZDsK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEZvY3VzRGlyZWN0aW9uQmFj a3dhcmQgOiBGb2N1c0RpcmVjdGlvbkZvcndhcmQ7CiAgICAgICAgIC8vICdpbml0aWFsRm9jdXMn IGlzIHNldCB0byB0cnVlIHNvIHRoZSBjaHJvbWUgaXMgbm90IGZvY3VzZWQuCiAgICAgICAgIHJl dHVybiBhZHZhbmNlRm9jdXNJbkRvY3VtZW50T3JkZXIodGFiRGlyZWN0aW9uLCBldmVudCwgdHJ1 ZSk7CiAgICAgfQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNjg3OTgpCisrKyBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOS0zMCAgQ2hhbmcg U2h1ICA8Y2hhbmcuc2h1QG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGaXhlZCB0aGUgdHlwbyB0aGF0IHNlYXJjaGVzIHRoZSB3cm9u ZyBkaXJlY3Rpb24gaW4gdGhlIG5vLWZvY3VzLW5vZGUgY2FzZS4KKyAgICAgICAgQXMgYSByZXN1 bHQsIGFmdGVyIHBhZ2UgaXMgbG9hZGVkLCBwcmVzc2luZyBrZXkgImFycm93ZG93biIgd2lsbCBi cmluZyB0aGUKKyAgICAgICAgZm9jdXMgdG8gdGhlIDFzdCBlbGVtZW50IGluc3RlYWQgb2YgdGhl IGxhc3QgZWxlbWVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQ2OTAxCisKKyAgICAgICAgKiBmYXN0L2V2ZW50cy9zcGF0aWFsLW5hdmlnYXRpb24v c25hdi0xc3Qtc3RvcC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZXZlbnRz L3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LTFzdC1zdG9wLmh0bWw6IEFkZGVkLgorCiAyMDEwLTA5 LTMwICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIFdpbmRv d3MgbWF0Y2ggdGhlIE1hYyBmYWxsYmFjayBmb250IGZvciB0aGUgaHlwaGVuIGNoYXJhY3RlciBp bgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvc3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYt MXN0LXN0b3AtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZXZl bnRzL3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LTFzdC1zdG9wLWV4cGVjdGVkLnR4dAkocmV2aXNp b24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2 LTFzdC1zdG9wLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw1IEBACisxCTIJ MworNAk1CTYKKzcJOAk5CitQQVNTIGdGb2N1c2VkRG9jdW1lbnQuYWN0aXZlRWxlbWVudC5nZXRB dHRyaWJ1dGUoImlkIikgaXMgIjEiCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3Nw YXRpYWwtbmF2aWdhdGlvbi9zbmF2LTFzdC1zdG9wLmh0bWwKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvZmFzdC9ldmVudHMvc3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYtMXN0LXN0b3AuaHRtbAko cmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3NwYXRpYWwtbmF2aWdhdGlv bi9zbmF2LTFzdC1zdG9wLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNjggQEAKKzxodG1s PgorICA8IS0tCisgICAgVGhpcyB0ZXN0IGVuc3VyZXMgdGhlIGNvcnJlY3RuZXNzIG9mIFNwYXRp YWwgTmF2aWdhdGlvbiAoU05hdikgYWxnb3JpdGhtIGZyb20gYSBub24tZm9jdXMgc2NlbmFyaW8u CisKKyAgICAqIFByZS1jb25kaXRpb25zOgorICAgIDEpIERSVCBzdXBwb3J0IGZvciBTTmF2IGVu YWJsZS9kaXNhYmxlLgorCisgICAgKiBOYXZpZ2F0aW9uIHN0ZXBzOgorICAgIDEpIExvYWRzIHRo aXMgcGFnZSBhbmQgc2VuZCBrZXkgZG93bi4KKyAgICAyKSBUaGUgMXN0IGxpbmsgc2hvdWxkIGJl IGZvY3VzZWQuCisgIC0tPgorICA8aGVhZD4KKyAgICA8c2NyaXB0IHNyYz0iLi4vLi4vanMvcmVz b3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKyAgICA8c2NyaXB0IHNyYz0icmVzb3Vy Y2VzL3NwYXRpYWwtbmF2aWdhdGlvbi11dGlscy5qcyI+PC9zY3JpcHQ+CisgICAgPHNjcmlwdCB0 eXBlPSJhcHBsaWNhdGlvbi9qYXZhc2NyaXB0Ij4KKworICAgIHZhciByZXN1bHRNYXAgPSBbCisg ICAgICBbIkRvd24iLCAiMSJdLAorICAgICAgWyJET05FIiwgIkRPTkUiXQorICAgIF07CisKKyAg ICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgICBsYXlvdXRUZXN0Q29u dHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5zZXRTcGF0 aWFsTmF2aWdhdGlvbkVuYWJsZWQodHJ1ZSk7CisgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5v dmVycmlkZVByZWZlcmVuY2UoIldlYktpdFRhYlRvTGlua3NQcmVmZXJlbmNlS2V5IiwgMSk7Cisg ICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CisgICAgfQorCisgICAg ZnVuY3Rpb24gcnVuVGVzdCgpCisgICAgeworICAgICAgLy8gc3RhcnRpbmcgdGhlIHRlc3QgZnJv bSBubyBmb2N1c2VkIG5vZGUuCisgICAgICBpbml0VGVzdChyZXN1bHRNYXAsIHRlc3RDb21wbGV0 ZWQpOworICAgIH0KKworICAgIGZ1bmN0aW9uIHRlc3RDb21wbGV0ZWQoKQorICAgIHsKKyAgICAg IGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgIGxheW91dFRlc3RDb250 cm9sbGVyLm5vdGlmeURvbmUoKTsKKyAgICB9CisKKyAgICB3aW5kb3cub25sb2FkID0gcnVuVGVz dDsKKworICAgIDwvc2NyaXB0PgorICAgIDxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMt dGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKyAgPC9oZWFkPgorICA8Ym9keSBpZD0ic29tZS1jb250 ZW50IiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94aHRtbCI+CisgICAgPHRhYmxlIHN0 eWxlPSJ0ZXh0LWFsaWduOiBsZWZ0OyB3aWR0aDogMTAwJTsgbWFyZ2luLWxlZnQ6IGF1dG87IG1h cmdpbi1yaWdodDogYXV0bzsiIGJvcmRlcj0iMSIgY2VsbHBhZGRpbmc9IjIiIGNlbGxzcGFjaW5n PSIxIj4KKyAgICAgIDx0Ym9keT4KKyAgICAgICAgPHRyPgorICAgICAgICAgIDx0ZCBzdHlsZT0i dmVydGljYWwtYWxpZ246IHRvcDsgdGV4dC1hbGlnbjogY2VudGVyOyI+PGEgaWQ9IjEiIGhyZWY9 ImEiPjE8L2E+PC90ZD4KKyAgICAgICAgICA8dGQgc3R5bGU9InZlcnRpY2FsLWFsaWduOiB0b3A7 IHRleHQtYWxpZ246IGNlbnRlcjsiPjxhIGlkPSIyIiBocmVmPSJhIj4yPC9hPjwvdGQ+CisgICAg ICAgICAgPHRkIHN0eWxlPSJ2ZXJ0aWNhbC1hbGlnbjogdG9wOyB0ZXh0LWFsaWduOiBjZW50ZXI7 Ij48YSBpZD0iMyIgaHJlZj0iYSI+MzwvYT48L3RkPgorICAgICAgICA8L3RyPgorICAgICAgICA8 dHI+CisgICAgICAgICAgPHRkIHN0eWxlPSJ2ZXJ0aWNhbC1hbGlnbjogdG9wOyB0ZXh0LWFsaWdu OiBjZW50ZXI7Ij48YSBpZD0iNCIgaHJlZj0iYSI+NDwvYT48L3RkPgorICAgICAgICAgIDx0ZCBz dHlsZT0idmVydGljYWwtYWxpZ246IHRvcDsgdGV4dC1hbGlnbjogY2VudGVyOyI+PGEgaWQ9IjUi IGhyZWY9ImEiPjU8L3RkPgorICAgICAgICAgIDx0ZCBzdHlsZT0idmVydGljYWwtYWxpZ246IHRv cDsgdGV4dC1hbGlnbjogY2VudGVyOyI+PGEgaWQ9IjYiIGhyZWY9ImEiPjY8L2E+PC90ZD4KKyAg ICAgICAgPC90cj4KKyAgICAgICAgPHRyPgorICAgICAgICAgIDx0ZCBzdHlsZT0idmVydGljYWwt YWxpZ246IHRvcDsgdGV4dC1hbGlnbjogY2VudGVyOyI+PGEgaWQ9IjciIGhyZWY9ImEiPjc8L2E+ PC90ZD4KKyAgICAgICAgICA8dGQgc3R5bGU9InZlcnRpY2FsLWFsaWduOiB0b3A7IHRleHQtYWxp Z246IGNlbnRlcjsiPjxhIGlkPSI4IiBocmVmPSJhIj44PC9hPjwvdGQ+CisgICAgICAgICAgPHRk IHN0eWxlPSJ2ZXJ0aWNhbC1hbGlnbjogdG9wOyB0ZXh0LWFsaWduOiBjZW50ZXI7Ij48YSBpZD0i OSIgaHJlZj0iYSI+OTwvYT48L3RkPgorICAgICAgICA8L3RyPgorICAgICAgPC90Ym9keT4KKyAg ICA8L3RhYmxlPgorICAgIDxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorICA8L2JvZHk+Cis8L2h0 bWw+Cg==