46602 2010-09-26 19:13:27 -0700 new-run-webkit-httpd fails if Perl is not installed 2010-09-27 09:50:39 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other All RESOLVED FIXED P2 Normal --- 1 mihaip mihaip abarth commit-queue eric ojan tony oldest_to_newest 285243 0 mihaip 2010-09-26 19:13:27 -0700 new-run-webkit-httpd fails if Perl is not installed 285245 1 68869 mihaip 2010-09-26 19:17:40 -0700 Created attachment 68869 Patch 285246 2 mihaip 2010-09-26 19:20:05 -0700 Adam, Eric or Ojan, would you mind taking a look? This is preventing Chromium WebKit rolls. 285256 3 68869 commit-queue 2010-09-26 19:58:29 -0700 Comment on attachment 68869 Patch Clearing flags on attachment: 68869 Committed r68365: <http://trac.webkit.org/changeset/68365> 285257 4 commit-queue 2010-09-26 19:58:35 -0700 All reviewed patches have been landed. Closing bug. 285504 5 tony 2010-09-27 09:37:09 -0700 BTW, all the bots should have perl installed (e.g., generating bindings from IDL files is a perl script). Perhaps we need to fix a #! line or make sure cygwin is setup or something. 285508 6 mihaip 2010-09-27 09:40:46 -0700 (In reply to comment #5) > BTW, all the bots should have perl installed (e.g., generating bindings from IDL files is a perl script). Perhaps we need to fix a #! line or make sure cygwin is setup or something. _webkit_build_directory assumes that perl is in the path: http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/base.py?rev=68365#L670 Not sure if that's valid under cygwin. 285513 7 tony 2010-09-27 09:50:39 -0700 (In reply to comment #6) > _webkit_build_directory assumes that perl is in the path: > > http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/base.py?rev=68365#L670 > > Not sure if that's valid under cygwin. I think it is valid as long as third_party/cygwin/setup_mount.bat is run. It looks like there's code in ChromiumWinPort for this. Maybe that code isn't run when using new-run-webkit-httpd (but is when running NRWT)? 68869 2010-09-26 19:17:40 -0700 2010-09-26 19:58:29 -0700 Patch bug-46602-20100926191738.patch text/plain 3682 mihaip ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlYzY3MWY1ZDYxMDFhNWZjN2RlZDA3MDMwZWI3ZGY5ZDI5ZTEwM2QyLi5kNTFhZTMy MGQyZDYxMWMzNjkxMzNiNTkzZDQ2ZDdjOTQ0NzFhNDNhIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAK KzIwMTAtMDktMjYgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbmV3LXJ1bi13ZWJr aXQtaHR0cGQgZmFpbHMgaWYgUGVybCBpcyBub3QgaW5zdGFsbGVkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjYwMgorICAgICAgICAKKyAgICAgICAg TWFrZSBQb3J0Ll9yZWFkX2NvbmZpZ3VyYXRpb24gY2F0Y2ggYWxsIGV4Y2VwdGlvbnMsIHNpbmNl IHRyeWluZyB0byBydW4KKyAgICAgICAgcGVybCAoYmVjYXVzZSBvZiBfd2Via2l0X2J1aWxkX2Rp cmVjdG9yeSkgd2hlbiBpdCdzIG5vdCBpbnN0YWxsZWQgdGhyb3dzCisgICAgICAgIGEgV2luZG93 c0Vycm9yIG9yIE9TRXJyb3IsIG5vdCBhbiBJT0Vycm9yICh0aGlzIGJlY2FtZSBhbiBpc3N1ZSBh ZnRlciAKKyAgICAgICAgcjY4MjY4LCBzaW5jZSBDaHJvbWl1bVBvcnQgZW5kcyB1cCBjYWxsaW5n IFBvcnQuZGVmYXVsdF9jb25maWd1cmF0aW9uIGluCisgICAgICAgIGl0cyBjb25zdHJ1Y3Rvciwg d2hpY2ggbWVhbnMgdGhhdCB3ZSdyZSBlbmRpbmcgdXAgb24gdGhpcyBjb2RlcGF0aCBpbgorICAg ICAgICBub24tTlJXVCBjYXNlcyB0b28sIGUuZy4gZm9yIHRoZSBDaHJvbWl1bSBOYUNsIHRlc3Rz LCB3aGljaCB1c2UKKyAgICAgICAgbmV3LXJ1bi13ZWJraXQtaHR0cGQpLgorCisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5OgorICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZV91bml0dGVzdC5weToKKwogMjAx MC0wOS0yNSAgTmljb2xhcyBXZWJlciAgPHRoYWtpc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weQppbmRleCAzMmE0ZTE3Mjk2NTAxNjBl YTRkNzdiZTY5NmE0YjEzOWYxNWYyNjdjLi42YTVkNDNiZjkxMTY2YzUxOGI3NDQ1NmZlMDJlNTM2 MzE3Y2I2MWNiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L2Jhc2UucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5CkBAIC02ODMsNyArNjgzLDcgQEAgY2xhc3MgUG9ydChv YmplY3QpOgogICAgICAgICB0cnk6CiAgICAgICAgICAgICB3aXRoIHNlbGYuX29wZW5fY29uZmln dXJhdGlvbl9maWxlKCkgYXMgZmlsZToKICAgICAgICAgICAgICAgICByZXR1cm4gZmlsZS5yZWFk bGluZSgpLnJzdHJpcCgpCi0gICAgICAgIGV4Y2VwdCBJT0Vycm9yLCBlOgorICAgICAgICBleGNl cHQ6CiAgICAgICAgICAgICByZXR1cm4gTm9uZQogCiAgICAgIyBGSVhNRTogVGhpcyBsaXN0IG1h eSBiZSBpbmNvbXBsZXRlIGFzIEFwcGxlIGhhcyBzb21lIHNla3JldCBjb25maWdzLgpkaWZmIC0t Z2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNl X3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC9iYXNlX3VuaXR0ZXN0LnB5CmluZGV4IDFhNmU0MTAwMzhkOWIxYzU2ODAzYjg0OWJkODYz MTFhY2UwNzJlNjIuLjcxODc3YjNlMmU0NmRiYTYxODMzYTdlNGY5ZGQ0YjNkYTI5YTQxNmQgMTAw NjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv YmFzZV91bml0dGVzdC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L2Jhc2VfdW5pdHRlc3QucHkKQEAgLTU3LDE2ICs1NywxNyBAQCBjbGFzcyBN b2NrRXhlY3V0aXZlKCk6CiAKIGNsYXNzIFVuaXRUZXN0UG9ydChiYXNlLlBvcnQpOgogICAgICIi IlN1YmNsYXNzIG9mIGJhc2UuUG9ydCB1c2VkIGZvciB1bml0IHRlc3RpbmcuIiIiCi0gICAgZGVm IF9faW5pdF9fKHNlbGYsIGNvbmZpZ3VyYXRpb25fY29udGVudHM9Tm9uZSwgZXhlY3V0aXZlX2V4 Y2VwdGlvbj1Ob25lKToKKyAgICBkZWYgX19pbml0X18oc2VsZiwgY29uZmlndXJhdGlvbl9jb250 ZW50cz1Ob25lLCBjb25maWd1cmF0aW9uX2V4Y2VwdGlvbj1JT0Vycm9yLCBleGVjdXRpdmVfZXhj ZXB0aW9uPU5vbmUpOgogICAgICAgICBiYXNlLlBvcnQuX19pbml0X18oc2VsZikKICAgICAgICAg c2VsZi5fY29uZmlndXJhdGlvbl9jb250ZW50cyA9IGNvbmZpZ3VyYXRpb25fY29udGVudHMKKyAg ICAgICAgc2VsZi5fY29uZmlndXJhdGlvbl9leGNlcHRpb24gPSBjb25maWd1cmF0aW9uX2V4Y2Vw dGlvbgogICAgICAgICBpZiBleGVjdXRpdmVfZXhjZXB0aW9uOgogICAgICAgICAgICAgc2VsZi5f ZXhlY3V0aXZlID0gTW9ja0V4ZWN1dGl2ZShleGVjdXRpdmVfZXhjZXB0aW9uKQogCiAgICAgZGVm IF9vcGVuX2NvbmZpZ3VyYXRpb25fZmlsZShzZWxmKToKICAgICAgICAgaWYgc2VsZi5fY29uZmln dXJhdGlvbl9jb250ZW50czoKICAgICAgICAgICAgIHJldHVybiBOZXdTdHJpbmdJTyhzZWxmLl9j b25maWd1cmF0aW9uX2NvbnRlbnRzKQotICAgICAgICByYWlzZSBJT0Vycm9yCisgICAgICAgIHJh aXNlIHNlbGYuX2NvbmZpZ3VyYXRpb25fZXhjZXB0aW9uCiAKIAogY2xhc3MgUG9ydFRlc3QodW5p dHRlc3QuVGVzdENhc2UpOgpAQCAtMTkxLDkgKzE5MiwxNCBAQCBjbGFzcyBQb3J0VGVzdCh1bml0 dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgIHNlbGYuYXNzZXJ0RmFsc2UoJ25vc3VjaHRoaW5nJyBp biBkaWZmKQogCiAgICAgZGVmIHRlc3RfZGVmYXVsdF9jb25maWd1cmF0aW9uX25vdGZvdW5kKHNl bGYpOgorICAgICAgICAjIFJlZ3VsYXIgSU9FcnJvciB0aHJvd24gd2hpbGUgdHJ5aW5nIHRvIGdl dCB0aGUgY29uZmlndXJhdGlvbi4KICAgICAgICAgcG9ydCA9IFVuaXRUZXN0UG9ydCgpCiAgICAg ICAgIHNlbGYuYXNzZXJ0RXF1YWwocG9ydC5kZWZhdWx0X2NvbmZpZ3VyYXRpb24oKSwgIlJlbGVh c2UiKQogCisgICAgICAgICMgTW9yZSBleG90aWMgT1NFcnJvciB0aHJvd24uCisgICAgICAgIHBv cnQgPSBVbml0VGVzdFBvcnQoY29uZmlndXJhdGlvbl9leGNlcHRpb249T1NFcnJvcikKKyAgICAg ICAgc2VsZi5hc3NlcnRFcXVhbChwb3J0LmRlZmF1bHRfY29uZmlndXJhdGlvbigpLCAiUmVsZWFz ZSIpCisKICAgICBkZWYgdGVzdF9sYXlvdXRfdGVzdHNfc2tpcHBpbmcoc2VsZik6CiAgICAgICAg IHBvcnQgPSBiYXNlLlBvcnQoKQogICAgICAgICBwb3J0LnNraXBwZWRfbGF5b3V0X3Rlc3RzID0g bGFtYmRhOiBbJ2Zvby9iYXIuaHRtbCcsICdtZWRpYSddCg==