46314 2010-09-22 15:18:28 -0700 The RenderView's block-flow should match the root element's block-flow. 2010-09-23 10:18:21 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 46123 1 hyatt hyatt simon.fraser oldest_to_newest 283287 0 hyatt 2010-09-22 15:18:28 -0700 Make sure the RenderView uses the block-flow of the root when laying out the root. This isn't in the spec, but it just seems patently obvious to me that it should work this way. Otherwise there's no way to control the overall direction of the document, since the <html> wouldn't lay out right. 283292 1 68453 hyatt 2010-09-22 15:24:37 -0700 Created attachment 68453 Patch 283312 2 68453 simon.fraser 2010-09-22 15:51:01 -0700 Comment on attachment 68453 Patch Got tests? 283502 3 hyatt 2010-09-22 21:22:27 -0700 (In reply to comment #2) > (From update of attachment 68453 [details]) > Got tests? It's untestable. You can't see the RenderView's style, and we don't yet do anything layout-wise with block-flow. Once we do it will be testable. 283648 4 68453 simon.fraser 2010-09-23 08:11:40 -0700 Comment on attachment 68453 Patch Explain lack of tests in the changelog. 283737 5 hyatt 2010-09-23 10:18:21 -0700 Fixed in r68157. 68453 2010-09-22 15:24:37 -0700 2010-09-23 08:11:40 -0700 Patch patch.txt text/plain 2625 hyatt SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2ODA4OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTAtMDktMjIgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjMxNC4KKyAgICAgICAgCisgICAg ICAgIFRoZSBSZW5kZXJWaWV3J3MgYmxvY2stZmxvdyBzaG91bGQgbWF0Y2ggdGhlIHJvb3QgZWxl bWVudCdzIGJsb2NrLWZsb3cuICBXaGVuIHdlIGNyZWF0ZSAob3IgcmUtY3JlYXRlKSB0aGUgc3R5 bGUgZm9yIHRoZSBkb2N1bWVudCwgdGFrZQorICAgICAgICB0aGUgYmxvY2stZmxvdyBmcm9tIHRo ZSBkb2N1bWVudCBlbGVtZW50J3Mgc3R5bGUgYW5kIHVzZSBpdCBpZiBpdCdzIGF2YWlsYWJsZS4K KyAgICAgICAgCisgICAgICAgIEFsc28gcGF0Y2ggc3R5bGVEaWRDaGFuZ2Ugc28gdGhhdCBpZiB0 aGUgYmxvY2stZmxvdyBjaGFuZ2VzIGR5bmFtaWNhbGx5IGFmdGVyIHdlIGhhdmUgYWxyZWFkeSBt YWRlIHRoZSBkb2N1bWVudCBzdHlsZSwgd2UnbGwgcHJvcGFnYXRlCisgICAgICAgIHRoZSBjaGFu Z2UgYmFjayB1cCB0byB0aGUgUmVuZGVyVmlldyBhbmQgaGF2ZSBpdCBkbyBhIHJlbGF5b3V0Lgor CisgICAgICAgICogY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Q1NTU3R5bGVTZWxlY3Rvcjo6c3R5bGVGb3JEb2N1bWVudCk6CisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlckJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3g6OnN0eWxlRGlkQ2hh bmdlKToKKwogMjAxMC0wOS0yMiAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KSW5kZXg6IFdlYkNvcmUvY3NzL0NTU1N0 eWxlU2VsZWN0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0 b3IuY3BwCShyZXZpc2lvbiA2ODA4MykKKysrIFdlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3Iu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTA2LDYgKzExMDYsMTAgQEAgUGFzc1JlZlB0cjxSZW5k ZXJTdHlsZT4gQ1NTU3R5bGVTZWxlY3RvcgogICAgIGRvY3VtZW50U3R5bGUtPnNldFZpc3VhbGx5 T3JkZXJlZChkb2N1bWVudC0+dmlzdWFsbHlPcmRlcmVkKCkpOwogICAgIGRvY3VtZW50U3R5bGUt PnNldFpvb20oZnJhbWUgPyBmcmFtZS0+cGFnZVpvb21GYWN0b3IoKSA6IDEpOwogICAgIAorICAg IEVsZW1lbnQqIGRvY0VsZW1lbnQgPSBkb2N1bWVudC0+ZG9jdW1lbnRFbGVtZW50KCk7CisgICAg aWYgKGRvY0VsZW1lbnQgJiYgZG9jRWxlbWVudC0+cmVuZGVyZXIoKSkKKyAgICAgICAgZG9jdW1l bnRTdHlsZS0+c2V0QmxvY2tGbG93KGRvY0VsZW1lbnQtPnJlbmRlcmVyKCktPnN0eWxlKCktPmJs b2NrRmxvdygpKTsKKwogICAgIEZvbnREZXNjcmlwdGlvbiBmb250RGVzY3JpcHRpb247CiAgICAg Zm9udERlc2NyaXB0aW9uLnNldFVzZVByaW50ZXJGb250KGRvY3VtZW50LT5wcmludGluZygpKTsK ICAgICBpZiAoU2V0dGluZ3MqIHNldHRpbmdzID0gZG9jdW1lbnQtPnNldHRpbmdzKCkpIHsKSW5k ZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAkocmV2aXNpb24gNjgwNzcpCisrKyBXZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJCb3guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNjAsNiArMjYwLDEyIEBA IHZvaWQgUmVuZGVyQm94OjpzdHlsZURpZENoYW5nZShTdHlsZURpZmYKICAgICAvLyBTZXQgdGhl IHRleHQgY29sb3IgaWYgd2UncmUgdGhlIGJvZHkuCiAgICAgaWYgKGlzQm9keSgpKQogICAgICAg ICBkb2N1bWVudCgpLT5zZXRUZXh0Q29sb3Ioc3R5bGUoKS0+dmlzaXRlZERlcGVuZGVudENvbG9y KENTU1Byb3BlcnR5Q29sb3IpKTsKKyAgICBlbHNlIGlmIChvbGRTdHlsZSAmJiBpc1Jvb3QoKSAm JiBvbGRTdHlsZS0+YmxvY2tGbG93KCkgIT0gc3R5bGUoKS0+YmxvY2tGbG93KCkpIHsKKyAgICAg ICAgLy8gUHJvcGFnYXRlIHRoZSBuZXcgYmxvY2sgZmxvdyB1cCB0byB0aGUgUmVuZGVyVmlldy4K KyAgICAgICAgUmVuZGVyVmlldyogdmlld1JlbmRlcmVyID0gdmlldygpOworICAgICAgICB2aWV3 UmVuZGVyZXItPnN0eWxlKCktPnNldEJsb2NrRmxvdyhzdHlsZSgpLT5ibG9ja0Zsb3coKSk7Cisg ICAgICAgIHZpZXdSZW5kZXJlci0+c2V0TmVlZHNMYXlvdXRBbmRQcmVmV2lkdGhzUmVjYWxjKCk7 CisgICAgfQogfQogCiB2b2lkIFJlbmRlckJveDo6dXBkYXRlQm94TW9kZWxJbmZvRnJvbVN0eWxl KCkK