46124 2010-09-20 14:51:53 -0700 Support logical padding on RenderBoxModelObject 2010-09-20 15:43:26 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 46126 46123 1 hyatt hyatt webkit-ews oldest_to_newest 281832 0 hyatt 2010-09-20 14:51:53 -0700 This patch tracks adding support for logical padding on RenderBoxModelObject. 281857 1 68148 hyatt 2010-09-20 15:30:24 -0700 Created attachment 68148 Patch 281863 2 hyatt 2010-09-20 15:38:53 -0700 Fixed in r67887. 281866 3 webkit-ews 2010-09-20 15:43:26 -0700 Attachment 68148 did not build on qt: Build output: http://queues.webkit.org/results/4046092 68148 2010-09-20 15:30:24 -0700 2010-09-20 15:35:09 -0700 Patch patch.txt text/plain 7183 hyatt SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2Nzg4NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjQgQEAKKzIwMTAtMDktMjAgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjEyNCwgYWRkIHN1cHBvcnQgZm9y IGxvZ2ljYWwgcGFkZGluZyBhY2Nlc3NvcnMgdG8KKyAgICAgICAgUmVuZGVyQm94TW9kZWxPYmpl Y3QuCisKKyAgICAgICAgQWRkZWQgZmFzdC9ibG9ja2Zsb3cvcGVyY2VudGFnZS1wYWRkaW5nLmh0 bWwgZXZlbiB0aG91Z2ggaXQgZmFpbHMsIHNvIHRoYXQgd2hlbiBtb3JlIG9mIGxheW91dCBpcyBw YXRjaGVkCisgICAgICAgIHdlIGNhbiBzZWUgaXQgc3RhcnQgcGFzc2luZy4KKyAgICAgICAgCisg ICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlckJveE1vZGVsT2JqZWN0OjpwYWRkaW5nVG9wKToKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlckJveE1vZGVsT2JqZWN0OjpwYWRkaW5nQm90dG9tKToKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlckJveE1vZGVsT2JqZWN0OjpwYWRkaW5nTGVmdCk6CisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJCb3hNb2RlbE9iamVjdDo6cGFkZGluZ1JpZ2h0KToKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlckJveE1vZGVsT2JqZWN0OjpwYWRkaW5nQmVmb3JlKToKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlckJveE1vZGVsT2JqZWN0OjpwYWRkaW5nQWZ0ZXIpOgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyQm94TW9kZWxPYmplY3Q6OnBhZGRpbmdTdGFydCk6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJCb3hNb2RlbE9iamVjdDo6cGFkZGluZ0VuZCk6CisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlckJveE1vZGVsT2JqZWN0Lmg6CisKIDIwMTAtMDktMjAgIERhdmlkIEh5YXR0ICA8aHlhdHRA YXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCkluZGV4OiBX ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3BwCShyZXZpc2lvbiA2Nzg2 MCkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNDMyLDcgKzQzMiw3IEBAIGludCBSZW5kZXJCb3hNb2RlbE9iamVjdDo6cGFk ZGluZ1RvcChib28KICAgICBpbnQgdyA9IDA7CiAgICAgTGVuZ3RoIHBhZGRpbmcgPSBzdHlsZSgp LT5wYWRkaW5nVG9wKCk7CiAgICAgaWYgKHBhZGRpbmcuaXNQZXJjZW50KCkpCi0gICAgICAgIHcg PSBjb250YWluaW5nQmxvY2soKS0+YXZhaWxhYmxlV2lkdGgoKTsKKyAgICAgICAgdyA9IGNvbnRh aW5pbmdCbG9jaygpLT5hdmFpbGFibGVMb2dpY2FsV2lkdGgoKTsKICAgICByZXR1cm4gcGFkZGlu Zy5jYWxjTWluVmFsdWUodyk7CiB9CiAKQEAgLTQ0MSw3ICs0NDEsNyBAQCBpbnQgUmVuZGVyQm94 TW9kZWxPYmplY3Q6OnBhZGRpbmdCb3R0b20oCiAgICAgaW50IHcgPSAwOwogICAgIExlbmd0aCBw YWRkaW5nID0gc3R5bGUoKS0+cGFkZGluZ0JvdHRvbSgpOwogICAgIGlmIChwYWRkaW5nLmlzUGVy Y2VudCgpKQotICAgICAgICB3ID0gY29udGFpbmluZ0Jsb2NrKCktPmF2YWlsYWJsZVdpZHRoKCk7 CisgICAgICAgIHcgPSBjb250YWluaW5nQmxvY2soKS0+YXZhaWxhYmxlTG9naWNhbFdpZHRoKCk7 CiAgICAgcmV0dXJuIHBhZGRpbmcuY2FsY01pblZhbHVlKHcpOwogfQogCkBAIC00NTAsNyArNDUw LDcgQEAgaW50IFJlbmRlckJveE1vZGVsT2JqZWN0OjpwYWRkaW5nTGVmdChibwogICAgIGludCB3 ID0gMDsKICAgICBMZW5ndGggcGFkZGluZyA9IHN0eWxlKCktPnBhZGRpbmdMZWZ0KCk7CiAgICAg aWYgKHBhZGRpbmcuaXNQZXJjZW50KCkpCi0gICAgICAgIHcgPSBjb250YWluaW5nQmxvY2soKS0+ YXZhaWxhYmxlV2lkdGgoKTsKKyAgICAgICAgdyA9IGNvbnRhaW5pbmdCbG9jaygpLT5hdmFpbGFi bGVMb2dpY2FsV2lkdGgoKTsKICAgICByZXR1cm4gcGFkZGluZy5jYWxjTWluVmFsdWUodyk7CiB9 CiAKQEAgLTQ1OSw3ICs0NTksNDMgQEAgaW50IFJlbmRlckJveE1vZGVsT2JqZWN0OjpwYWRkaW5n UmlnaHQoYgogICAgIGludCB3ID0gMDsKICAgICBMZW5ndGggcGFkZGluZyA9IHN0eWxlKCktPnBh ZGRpbmdSaWdodCgpOwogICAgIGlmIChwYWRkaW5nLmlzUGVyY2VudCgpKQotICAgICAgICB3ID0g Y29udGFpbmluZ0Jsb2NrKCktPmF2YWlsYWJsZVdpZHRoKCk7CisgICAgICAgIHcgPSBjb250YWlu aW5nQmxvY2soKS0+YXZhaWxhYmxlTG9naWNhbFdpZHRoKCk7CisgICAgcmV0dXJuIHBhZGRpbmcu Y2FsY01pblZhbHVlKHcpOworfQorCitpbnQgUmVuZGVyQm94TW9kZWxPYmplY3Q6OnBhZGRpbmdC ZWZvcmUoYm9vbCkgY29uc3QKK3sKKyAgICBpbnQgdyA9IDA7CisgICAgTGVuZ3RoIHBhZGRpbmcg PSBzdHlsZSgpLT5wYWRkaW5nQmVmb3JlKCk7CisgICAgaWYgKHBhZGRpbmcuaXNQZXJjZW50KCkp CisgICAgICAgIHcgPSBjb250YWluaW5nQmxvY2soKS0+YXZhaWxhYmxlTG9naWNhbFdpZHRoKCk7 CisgICAgcmV0dXJuIHBhZGRpbmcuY2FsY01pblZhbHVlKHcpOworfQorCitpbnQgUmVuZGVyQm94 TW9kZWxPYmplY3Q6OnBhZGRpbmdBZnRlcihib29sKSBjb25zdAoreworICAgIGludCB3ID0gMDsK KyAgICBMZW5ndGggcGFkZGluZyA9IHN0eWxlKCktPnBhZGRpbmdBZnRlcigpOworICAgIGlmIChw YWRkaW5nLmlzUGVyY2VudCgpKQorICAgICAgICB3ID0gY29udGFpbmluZ0Jsb2NrKCktPmF2YWls YWJsZUxvZ2ljYWxXaWR0aCgpOworICAgIHJldHVybiBwYWRkaW5nLmNhbGNNaW5WYWx1ZSh3KTsK K30KKworaW50IFJlbmRlckJveE1vZGVsT2JqZWN0OjpwYWRkaW5nU3RhcnQoYm9vbCkgY29uc3QK K3sKKyAgICBpbnQgdyA9IDA7CisgICAgTGVuZ3RoIHBhZGRpbmcgPSBzdHlsZSgpLT5wYWRkaW5n U3RhcnQoKTsKKyAgICBpZiAocGFkZGluZy5pc1BlcmNlbnQoKSkKKyAgICAgICAgdyA9IGNvbnRh aW5pbmdCbG9jaygpLT5hdmFpbGFibGVMb2dpY2FsV2lkdGgoKTsKKyAgICByZXR1cm4gcGFkZGlu Zy5jYWxjTWluVmFsdWUodyk7Cit9CisKK2ludCBSZW5kZXJCb3hNb2RlbE9iamVjdDo6cGFkZGlu Z0VuZChib29sKSBjb25zdAoreworICAgIGludCB3ID0gMDsKKyAgICBMZW5ndGggcGFkZGluZyA9 IHN0eWxlKCktPnBhZGRpbmdFbmQoKTsKKyAgICBpZiAocGFkZGluZy5pc1BlcmNlbnQoKSkKKyAg ICAgICAgdyA9IGNvbnRhaW5pbmdCbG9jaygpLT5hdmFpbGFibGVMb2dpY2FsV2lkdGgoKTsKICAg ICByZXR1cm4gcGFkZGluZy5jYWxjTWluVmFsdWUodyk7CiB9CiAKSW5kZXg6IFdlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuaAkocmV2aXNpb24gNjc4NjApCisrKyBXZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5oCSh3b3JraW5nIGNvcHkpCkBAIC03MCw2 ICs3MCwxMCBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBpbnQgcGFkZGluZ0JvdHRvbShib29sIGlu Y2x1ZGVJbnRyaW5zaWNQYWRkaW5nID0gdHJ1ZSkgY29uc3Q7CiAgICAgdmlydHVhbCBpbnQgcGFk ZGluZ0xlZnQoYm9vbCBpbmNsdWRlSW50cmluc2ljUGFkZGluZyA9IHRydWUpIGNvbnN0OwogICAg IHZpcnR1YWwgaW50IHBhZGRpbmdSaWdodChib29sIGluY2x1ZGVJbnRyaW5zaWNQYWRkaW5nID0g dHJ1ZSkgY29uc3Q7CisgICAgdmlydHVhbCBpbnQgcGFkZGluZ0JlZm9yZShib29sIGluY2x1ZGVJ bnRyaW5zaWNQYWRkaW5nID0gdHJ1ZSkgY29uc3Q7CisgICAgdmlydHVhbCBpbnQgcGFkZGluZ0Fm dGVyKGJvb2wgaW5jbHVkZUludHJpbnNpY1BhZGRpbmcgPSB0cnVlKSBjb25zdDsKKyAgICB2aXJ0 dWFsIGludCBwYWRkaW5nU3RhcnQoYm9vbCBpbmNsdWRlSW50cmluc2ljUGFkZGluZyA9IHRydWUp IGNvbnN0OworICAgIHZpcnR1YWwgaW50IHBhZGRpbmdFbmQoYm9vbCBpbmNsdWRlSW50cmluc2lj UGFkZGluZyA9IHRydWUpIGNvbnN0OwogCiAgICAgdmlydHVhbCBpbnQgYm9yZGVyVG9wKCkgY29u c3QgeyByZXR1cm4gc3R5bGUoKS0+Ym9yZGVyVG9wV2lkdGgoKTsgfQogICAgIHZpcnR1YWwgaW50 IGJvcmRlckJvdHRvbSgpIGNvbnN0IHsgcmV0dXJuIHN0eWxlKCktPmJvcmRlckJvdHRvbVdpZHRo KCk7IH0KSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDY3ODg0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTAtMDktMjAgIERhdmlkIEh5YXR0 ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NjEy NCwgYWRkIHN1cHBvcnQgZm9yIGxvZ2ljYWwgcGFkZGluZyBhY2Nlc3NvcnMgdG8KKyAgICAgICAg UmVuZGVyQm94TW9kZWxPYmplY3QuCisKKyAgICAgICAgQWRkZWQgZmFzdC9ibG9ja2Zsb3cvcGVy Y2VudGFnZS1wYWRkaW5nLmh0bWwgZXZlbiB0aG91Z2ggaXQgZmFpbHMsIHNvIHRoYXQgd2hlbiBt b3JlIG9mIGxheW91dCBpcyBwYXRjaGVkCisgICAgICAgIHdlIGNhbiBzZWUgaXQgc3RhcnQgcGFz c2luZy4KKworICAgICAgICAqIGZhc3QvYmxvY2tmbG93OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0 L2Jsb2NrZmxvdy9wZXJjZW50YWdlLXBhZGRpbmctZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAg ICAgKiBmYXN0L2Jsb2NrZmxvdy9wZXJjZW50YWdlLXBhZGRpbmcuaHRtbDogQWRkZWQuCisKKzIw MTAtMDktMjAgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5lZWQgYSBzaG9ydCBkZXNjcmlwdGlv biBhbmQgYnVnIFVSTCAoT09QUyEpCisKKyAgICAgICAgKiBmYXN0L2Jsb2NrZmxvdzogQWRkZWQu CisgICAgICAgICogZmFzdC9ibG9ja2Zsb3cvcGVyY2VudGFnZS1wYWRkaW5nLWV4cGVjdGVkLnR4 dDogQWRkZWQuCisgICAgICAgICogZmFzdC9ibG9ja2Zsb3cvcGVyY2VudGFnZS1wYWRkaW5nLmh0 bWw6IEFkZGVkLgorCiAyMDEwLTA5LTIwICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBw bGUuY29tPgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IGJ5IFNpbW9uIEZyYXNlci4KSW5k ZXg6IExheW91dFRlc3RzL2Zhc3QvYmxvY2tmbG93L3BlcmNlbnRhZ2UtcGFkZGluZy1leHBlY3Rl ZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9ibG9ja2Zsb3cvcGVyY2VudGFn ZS1wYWRkaW5nLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3Qv YmxvY2tmbG93L3BlcmNlbnRhZ2UtcGFkZGluZy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBA IC0wLDAgKzEgQEAKK0ZBSUw6IFRoZSBmbG9hdGluZyBibG9jayBzaG91bGQgYmUgMzAweDQwMCBw aXhlbHMgaW4gc2l6ZS4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvYmxvY2tmbG93L3BlcmNlbnRh Z2UtcGFkZGluZy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvYmxvY2tmbG93 L3BlcmNlbnRhZ2UtcGFkZGluZy5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFz dC9ibG9ja2Zsb3cvcGVyY2VudGFnZS1wYWRkaW5nLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsMzIgQEAKKzxodG1sPgorPGhlYWQ+Cis8c3R5bGU+CisuYmxvY2sKK3sKKyAgICB3aWR0aDox MDBweDsKKyAgICBoZWlnaHQ6MjAwcHg7CisgICAgcGFkZGluZzo1MCU7CisgICAgYmFja2dyb3Vu ZC1jb2xvcjpncmVlbjsKK30KKzwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKzxkaXYgc3R5bGU9 IndpZHRoOjEwMHB4O2hlaWdodDoyMDBweDsgLXdlYmtpdC1ibG9jay1mbG93OmxyOyI+Cis8ZGl2 IGlkPSJ0ZXN0IiBjbGFzcz0iYmxvY2siPjwvZGl2PgorPC9kaXY+Cis8ZGl2IGlkPSJjb25zb2xl Ij48L2Rpdj4KKzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAg IHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cit0ZXN0ID0gZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoInRlc3QiKTsKK3JlY3QgPSB0ZXN0LmdldEJvdW5kaW5nQ2xpZW50 UmVjdCgpOword2lkdGggPSByZWN0LnJpZ2h0IC0gcmVjdC5sZWZ0OworaGVpZ2h0ID0gcmVjdC50 b3AgLSByZWN0LmJvdHRvbTsKK2lmICh3aWR0aCAhPSAzMDAgfHwgaGVpZ2h0ICE9IDQwMCkgewor ICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnY29uc29sZScpLmlubmVySFRNTCA9ICJGQUlMOiBU aGUgZmxvYXRpbmcgYmxvY2sgc2hvdWxkIGJlIDMwMHg0MDAgcGl4ZWxzIGluIHNpemUuIjsKKyAg dGVzdC5zdHlsZS5iYWNrZ3JvdW5kQ29sb3IgPSAncmVkJzsKK30gZWxzZQorICBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgnY29uc29sZScpLmlubmVySFRNTCA9ICJQQVNTOiBUaGUgZmxvYXRpbmcg YmxvY2sgaXMgdGhlIGNvcnJlY3Qgc2l6ZS4iOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+ Cg==