<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>46032</bug_id>
          
          <creation_ts>2010-09-18 05:35:21 -0700</creation_ts>
          <short_desc>check-webkit-style complains about unincluded config.h in WebKit2 code</short_desc>
          <delta_ts>2010-11-02 14:01:47 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>48638</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Andras Becsi">abecsi</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cjerdonek</cc>
    
    <cc>levin</cc>
    
    <cc>ossy</cc>
    
    <cc>sam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>281126</commentid>
    <comment_count>0</comment_count>
    <who name="Andras Becsi">abecsi</who>
    <bug_when>2010-09-18 05:35:21 -0700</bug_when>
    <thetext>In WebKit2 code including config.h is not needed but check-webkit-style complains about it&apos;s absence:

Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>282193</commentid>
    <comment_count>1</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2010-09-21 03:57:34 -0700</bug_when>
    <thetext>Additionally we should mention in &quot;WebKit Coding Style Guidelines&quot;
that including config.h is unnecessary.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>303638</commentid>
    <comment_count>2</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2010-11-02 14:01:47 -0700</bug_when>
    <thetext>Sounds like this was fixed in 48638.

*** This bug has been marked as a duplicate of bug 48638 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>