46008 2010-09-17 15:46:31 -0700 XMLHttpRequest: open() does not throw a SYNTAX_ERR exception if method is empty or url cannot be resolved 2018-09-12 16:20:17 -0700 1 1 1 Unclassified WebKit XML 528+ (Nightly build) PC All RESOLVED FIXED InRadar P2 Normal --- 1 jianli rwlbuis aboya ap cdumez commit-queue dimich fishd fred.wang jianli levin rbuis webkit-bug-importer oldest_to_newest 280946 0 jianli 2010-09-17 15:46:31 -0700 open() does not throw a SYNTAX_ERR exception if method is empty. It does throw if method contains invalid string. The XHR spec says: open(method, url, async, user, password) Sets the request method, request URL, asynchronous flag, request username, and request password. Throws a SYNTAX_ERR exception if one of the following is true: method is not a valid HTTP method. TEST: http://tc.labs.opera.com/apis/XMLHttpRequest/open-method-bogus.htm 280999 1 jianli 2010-09-17 17:05:39 -0700 Per the XHR spec, we should also throw a SYNTAX_ERR exception if url cannot be resolved. http://tc.labs.opera.com/apis/XMLHttpRequest/open-url-bogus.htm 517293 2 118359 deqing.huang 2011-12-08 03:47:18 -0800 Created attachment 118359 This patch checks if a url is invalid and throw syntax error if that's the case 517442 3 118359 ap 2011-12-08 08:44:23 -0800 Comment on attachment 118359 This patch checks if a url is invalid and throw syntax error if that's the case A fix like this needs to come with regression tests. A good place to add one is fast/xmlhttprequest. 1457626 4 349179 rbuis 2018-09-07 12:32:36 -0700 Created attachment 349179 Patch 1457631 5 fred.wang 2018-09-07 12:40:25 -0700 *** Bug 189426 has been marked as a duplicate of this bug. *** 1457680 6 349179 cdumez 2018-09-07 14:18:12 -0700 Comment on attachment 349179 Patch r=me 1457692 7 349179 commit-queue 2018-09-07 14:43:42 -0700 Comment on attachment 349179 Patch Clearing flags on attachment: 349179 Committed r235808: <https://trac.webkit.org/changeset/235808> 1457693 8 commit-queue 2018-09-07 14:43:44 -0700 All reviewed patches have been landed. Closing bug. 1457694 9 webkit-bug-importer 2018-09-07 14:44:25 -0700 <rdar://problem/44239386> 1459153 10 aboya 2018-09-12 16:14:31 -0700 This patch has regressed the following test in all platforms: imported/w3c/web-platform-tests/url/failure.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#tests=imported%2Fw3c%2Fweb-platform-tests%2Furl%2Ffailure.html&revision=235825 e.g: FAIL XHR: http://user@/www.example.com should throw assert_throws: function "() => client.open("GET", test.input)" did not throw 1459154 11 cdumez 2018-09-12 16:17:35 -0700 New passes. The test merely needs rebaselining. 1459155 12 cdumez 2018-09-12 16:20:17 -0700 (In reply to Chris Dumez from comment #11) > New passes. The test merely needs rebaselining. Done in <https://trac.webkit.org/changeset/235958>. 118359 2011-12-08 03:47:18 -0800 2018-09-07 12:44:42 -0700 This patch checks if a url is invalid and throw syntax error if that's the case 0001-Throw-a-SYNTAX_ERR-exception-if-url-is-invalid.patch text/plain 830 deqing.huang RnJvbSA0ZmY4NDgyZDRjOTI3ZmZmYjJlNTY5Y2M5MjMwNDJkMDFkNDY1MmE4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEZXFpbmcgSHVhbmcgPGRlcWluZy5odWFuZ0BpbnRlbC5jb20+ CkRhdGU6IFRodSwgOCBEZWMgMjAxMSAxOTo0MjoyNiArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIFRo cm93IGEgU1lOVEFYX0VSUiBleGNlcHRpb24gaWYgdXJsIGlzIGludmFsaWQKCkJVRz00NjAwOAot LS0KIFNvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAgfCAgICA0ICsrKysKIDEg ZmlsZXMgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS94bWwvWE1MSHR0cFJlcXVlc3QuY3BwCmluZGV4IGFkNjgyZmUuLjNjNzdmZjUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcApAQCAtNDI4LDYgKzQyOCwxMCBAQCB2b2lkIFhN TEh0dHBSZXF1ZXN0OjpvcGVuKGNvbnN0IFN0cmluZyYgbWV0aG9kLCBjb25zdCBLVVJMJiB1cmws IGJvb2wgYXN5bmMsIEV4YwogCiAgICAgbV9tZXRob2QgPSB1cHBlcmNhc2VLbm93bkhUVFBNZXRo b2QobWV0aG9kKTsKIAorICAgIGlmICghdXJsLmlzVmFsaWQoKSkgeworICAgICAgICBlYyA9IFNZ TlRBWF9FUlI7CisgICAgICAgIHJldHVybjsKKyAgICB9CiAgICAgbV91cmwgPSB1cmw7CiAKICAg ICBtX2FzeW5jID0gYXN5bmM7Ci0tIAoxLjcuNS40Cgo= 349179 2018-09-07 12:32:36 -0700 2018-09-07 14:43:42 -0700 Patch attempt.diff text/plain 4634 rbuis Y29tbWl0IDlkNjcxNjgwMzcyZmYxNzQyMmViMGE5YmZjNmNiOGRiNWE0NmM2YWUKQXV0aG9yOiBS b2IgQnVpcyA8cmJ1aXNAaWdhbGlhLmNvbT4KRGF0ZTogICBGcmkgU2VwIDcgMjE6MDY6MzMgMjAx OCArMDIwMAoKICAgIFlvCgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0No YW5nZUxvZyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKaW5kZXggMmVjY2Jk ODBiZGMuLjAyZGY4Mjg3NzY1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mv Q2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOC0wOS0wNyAgUm9iIEJ1aXMgIDxyYnVpc0BpZ2FsaWEuY29tPgorCisg ICAgICAgIFhNTEh0dHBSZXF1ZXN0OiBvcGVuKCkgZG9lcyBub3QgdGhyb3cgYSBTWU5UQVhfRVJS IGV4Y2VwdGlvbiBpZiBtZXRob2QgaXMgZW1wdHkgb3IgdXJsIGNhbm5vdCBiZSByZXNvbHZlZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDYwMDgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdlYi1wbGF0 Zm9ybS10ZXN0cy94aHIvb3Blbi11cmwtYm9ndXMtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHdl Yi1wbGF0Zm9ybS10ZXN0cy94aHIvb3Blbi11cmwtbXVsdGktd2luZG93LTYtZXhwZWN0ZWQudHh0 OgorCiAyMDE4LTA5LTA1ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAg ICAgICBFeHBvc2UgUlRDUnRwU2VuZGVyLnNldFBhcmFtZXRlcnMKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMveGhyL29wZW4tdXJsLWJvZ3Vz LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVz dHMveGhyL29wZW4tdXJsLWJvZ3VzLWV4cGVjdGVkLnR4dAppbmRleCBhZjUyODYxN2RmOC4uZmQ0 ZTU1Yjg4Y2MgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZv cm0tdGVzdHMveGhyL29wZW4tdXJsLWJvZ3VzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0 cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3hoci9vcGVuLXVybC1ib2d1cy1leHBl Y3RlZC50eHQKQEAgLTEsNyArMSw3IEBACiAKLUZBSUwgWE1MSHR0cFJlcXVlc3Q6IG9wZW4oKSAt IGJvZ3VzIFVSTHMgKC8vWykgYXNzZXJ0X3Rocm93czogZnVuY3Rpb24gImZ1bmN0aW9uICgpIHsg Y2xpZW50Lm9wZW4oIkdFVCIsIHVybCkgfSIgZGlkIG5vdCB0aHJvdworUEFTUyBYTUxIdHRwUmVx dWVzdDogb3BlbigpIC0gYm9ndXMgVVJMcyAoLy9bKSAKIEZBSUwgWE1MSHR0cFJlcXVlc3Q6IG9w ZW4oKSAtIGJvZ3VzIFVSTHMgKGZ0cDopIGFzc2VydF90aHJvd3M6IGZ1bmN0aW9uICJmdW5jdGlv biAoKSB7IGNsaWVudC5vcGVuKCJHRVQiLCB1cmwpIH0iIGRpZCBub3QgdGhyb3cKLUZBSUwgWE1M SHR0cFJlcXVlc3Q6IG9wZW4oKSAtIGJvZ3VzIFVSTHMgKGh0dHA6Ly9hIGEvKSBhc3NlcnRfdGhy b3dzOiBmdW5jdGlvbiAiZnVuY3Rpb24gKCkgeyBjbGllbnQub3BlbigiR0VUIiwgdXJsKSB9IiBk aWQgbm90IHRocm93Ci1GQUlMIFhNTEh0dHBSZXF1ZXN0OiBvcGVuKCkgLSBib2d1cyBVUkxzICho dHRwOi8vLy8vLy8vLy8vLykgYXNzZXJ0X3Rocm93czogZnVuY3Rpb24gImZ1bmN0aW9uICgpIHsg Y2xpZW50Lm9wZW4oIkdFVCIsIHVybCkgfSIgZGlkIG5vdCB0aHJvdwotRkFJTCBYTUxIdHRwUmVx dWVzdDogb3BlbigpIC0gYm9ndXMgVVJMcyAoaHR0cDovL3U6cEAvKSBhc3NlcnRfdGhyb3dzOiBm dW5jdGlvbiAiZnVuY3Rpb24gKCkgeyBjbGllbnQub3BlbigiR0VUIiwgdXJsKSB9IiBkaWQgbm90 IHRocm93CitQQVNTIFhNTEh0dHBSZXF1ZXN0OiBvcGVuKCkgLSBib2d1cyBVUkxzIChodHRwOi8v YSBhLykgCitQQVNTIFhNTEh0dHBSZXF1ZXN0OiBvcGVuKCkgLSBib2d1cyBVUkxzIChodHRwOi8v Ly8vLy8vLy8vLykgCitQQVNTIFhNTEh0dHBSZXF1ZXN0OiBvcGVuKCkgLSBib2d1cyBVUkxzICho dHRwOi8vdTpwQC8pIAogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2Vi LXBsYXRmb3JtLXRlc3RzL3hoci9vcGVuLXVybC1tdWx0aS13aW5kb3ctNi1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3hoci9vcGVuLXVy bC1tdWx0aS13aW5kb3ctNi1leHBlY3RlZC50eHQKaW5kZXggZjZhMWJhOTc5ZGEuLmFjODY1MzY5 NTE2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL3hoci9vcGVuLXVybC1tdWx0aS13aW5kb3ctNi1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0 VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy94aHIvb3Blbi11cmwtbXVsdGkt d2luZG93LTYtZXhwZWN0ZWQudHh0CkBAIC0xLDMgKzEsMyBAQAogCi1GQUlMIFhNTEh0dHBSZXF1 ZXN0OiBvcGVuKCkgaW4gZG9jdW1lbnQgdGhhdCBpcyBub3QgZnVsbHkgYWN0aXZlIChidXQgbWF5 IGJlIGFjdGl2ZSkgc2hvdWxkIHRocm93IGFzc2VydF90aHJvd3M6IGZ1bmN0aW9uICJmdW5jdGlv biAoKSB7IGNsaWVudC5vcGVuKCJHRVQiLCAiLi4uIikgfSIgZGlkIG5vdCB0aHJvdworRkFJTCBY TUxIdHRwUmVxdWVzdDogb3BlbigpIGluIGRvY3VtZW50IHRoYXQgaXMgbm90IGZ1bGx5IGFjdGl2 ZSAoYnV0IG1heSBiZSBhY3RpdmUpIHNob3VsZCB0aHJvdyBhc3NlcnRfdGhyb3dzOiBmdW5jdGlv biAiZnVuY3Rpb24gKCkgeyBjbGllbnQub3BlbigiR0VUIiwgIi4uLiIpIH0iIHRocmV3IG9iamVj dCAiU3ludGF4RXJyb3I6IFRoZSBzdHJpbmcgZGlkIG5vdCBtYXRjaCB0aGUgZXhwZWN0ZWQgcGF0 dGVybi4iIHRoYXQgaXMgbm90IGEgRE9NRXhjZXB0aW9uIEludmFsaWRTdGF0ZUVycm9yOiBwcm9w ZXJ0eSAiY29kZSIgaXMgZXF1YWwgdG8gMTIsIGV4cGVjdGVkIDExCiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3 OWJiNTkyNTAyOS4uNTdiNjdjNWM3MDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAx OC0wOS0wNyAgUm9iIEJ1aXMgIDxyYnVpc0BpZ2FsaWEuY29tPgorCisgICAgICAgIFhNTEh0dHBS ZXF1ZXN0OiBvcGVuKCkgZG9lcyBub3QgdGhyb3cgYSBTWU5UQVhfRVJSIGV4Y2VwdGlvbiBpZiBt ZXRob2QgaXMgZW1wdHkgb3IgdXJsIGNhbm5vdCBiZSByZXNvbHZlZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDYwMDgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGVjayBpZiBwYXNzZWQgVVJMIGlzIHZh bGlkIGFzIHNwZWNpZmllZCBoZXJlIFsxXS4KKworICAgICAgICBUZXN0OiB3ZWItcGxhdGZvcm0t dGVzdHMveGhyL29wZW4tdXJsLWJvZ3VzLmh0bQorCisgICAgICAgIFsxXSBodHRwczovL3hoci5z cGVjLndoYXR3Zy5vcmcvI3RoZS1vcGVuKCktbWV0aG9kIFN0ZXAgNworCisgICAgICAgICogeG1s L1hNTEh0dHBSZXF1ZXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlhNTEh0dHBSZXF1ZXN0Ojpv cGVuKToKKwogMjAxOC0wOS0wNSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAK ICAgICAgICAgTW92ZSBvd25lcnNoaXAgb2Ygb3V0Z29pbmcgc291cmNlIHRvIFJUQ1J0cFNlbmRl ciBiYWNrZW5kCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3Qu Y3BwIGIvU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcAppbmRleCBlODk1YTNi YzIwMy4uYTlhYjM2MmVmNjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRw UmVxdWVzdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcApA QCAtMzQzLDYgKzM0Myw5IEBAIEV4Y2VwdGlvbk9yPHZvaWQ+IFhNTEh0dHBSZXF1ZXN0OjpvcGVu KGNvbnN0IFN0cmluZyYgbWV0aG9kLCBjb25zdCBVUkwmIHVybCwgYm9vCiAgICAgaWYgKGlzRm9y YmlkZGVuTWV0aG9kKG1ldGhvZCkpCiAgICAgICAgIHJldHVybiBFeGNlcHRpb24geyBTZWN1cml0 eUVycm9yIH07CiAKKyAgICBpZiAoIXVybC5pc1ZhbGlkKCkpCisgICAgICAgIHJldHVybiBFeGNl cHRpb24geyBTeW50YXhFcnJvciB9OworCiAgICAgaWYgKCFhc3luYyAmJiBzY3JpcHRFeGVjdXRp b25Db250ZXh0KCktPmlzRG9jdW1lbnQoKSkgewogICAgICAgICAvLyBOZXdlciBmdW5jdGlvbmFs aXR5IGlzIG5vdCBhdmFpbGFibGUgdG8gc3luY2hyb25vdXMgcmVxdWVzdHMgaW4gd2luZG93IGNv bnRleHRzLCBhcyBhIHNwZWMtbWFuZGF0ZWQKICAgICAgICAgLy8gYXR0ZW1wdCB0byBkaXNjb3Vy YWdlIHN5bmNocm9ub3VzIFhIUiB1c2UuIHJlc3BvbnNlVHlwZSBpcyBvbmUgc3VjaCBwaWVjZSBv ZiBmdW5jdGlvbmFsaXR5Lgo=