46005 2010-09-17 15:36:19 -0700 [BREWMP] Wrong key code type in keyIdentifierForBrewKeyCode 2010-09-18 15:48:57 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 33564 0 skyul webkit-unassigned commit-queue oldest_to_newest 280929 0 skyul 2010-09-17 15:36:19 -0700 The type of key code in Brew MP is uint16. Take uint16 instead of int16 in keyIdentifierForBrewKeyCode. 280932 1 67964 skyul 2010-09-17 15:37:27 -0700 Created attachment 67964 Patch 281065 2 67964 kling 2010-09-17 19:09:33 -0700 Comment on attachment 67964 Patch r=me 281191 3 67964 commit-queue 2010-09-18 15:48:52 -0700 Comment on attachment 67964 Patch Clearing flags on attachment: 67964 Committed r67794: <http://trac.webkit.org/changeset/67794> 281192 4 commit-queue 2010-09-18 15:48:57 -0700 All reviewed patches have been landed. Closing bug. 67964 2010-09-17 15:37:27 -0700 2010-09-18 15:48:52 -0700 Patch type.patch text/plain 1198 skyul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2Nzc1MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDktMTcgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbQlJFV01QXSBXcm9uZyBrZXkgY29kZSB0eXBlIGluIGtleUlkZW50aWZpZXJGb3JCcmV3S2V5 Q29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDYw MDUKKworICAgICAgICBUaGUgdHlwZSBvZiBrZXkgY29kZSBpbiBCcmV3IE1QIGlzIHVpbnQxNi4g VGFrZSB1aW50MTYgaW5zdGVhZCBvZiBpbnQxNiBpbiBrZXlJZGVudGlmaWVyRm9yQnJld0tleUNv ZGUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9icmV3L1BsYXRmb3JtS2V5Ym9hcmRFdmVudEJyZXcu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6a2V5SWRlbnRpZmllckZvckJyZXdLZXlDb2RlKToKKwog MjAxMC0wOS0xNyAgTWFyYy1BbnRvaW5lIFJ1ZWwgIDxtYXJ1ZWxAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZv cm0vYnJldy9QbGF0Zm9ybUtleWJvYXJkRXZlbnRCcmV3LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL3BsYXRmb3JtL2JyZXcvUGxhdGZvcm1LZXlib2FyZEV2ZW50QnJldy5jcHAJKHJldmlzaW9u IDY3NzUxKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9icmV3L1BsYXRmb3JtS2V5Ym9hcmRFdmVudEJy ZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNSw3ICszNSw3IEBACiAKIG5hbWVzcGFjZSBXZWJD b3JlIHsKIAotc3RhdGljIFN0cmluZyBrZXlJZGVudGlmaWVyRm9yQnJld0tleUNvZGUoaW50MTYg a2V5Q29kZSkKK3N0YXRpYyBTdHJpbmcga2V5SWRlbnRpZmllckZvckJyZXdLZXlDb2RlKHVpbnQx NiBrZXlDb2RlKQogewogICAgIHN3aXRjaCAoa2V5Q29kZSkgewogICAgIGNhc2UgQVZLX0xBTFQ6 Cg==