45794 2010-09-14 17:38:47 -0700 [BREWMP] Don't use new in static initializers 2010-09-21 11:21:04 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 33564 0 skyul webkit-unassigned darin eric oldest_to_newest 279274 0 skyul 2010-09-14 17:38:47 -0700 Calling new in static initializers causes a crash in Brew MP because Brew MP heap is not yet initialized at this time. 279279 1 67625 skyul 2010-09-14 17:43:57 -0700 Created attachment 67625 Patch I know this patch is ugly by adding PLATFORM guard. However, if I remove new here, it causes a crash in other ports. See bug 23681 for the reason. Any smart solution here? 279412 2 eric 2010-09-14 23:49:24 -0700 I don't understand how this changes things. 279421 3 skyul 2010-09-15 00:06:24 -0700 (In reply to comment #2) > I don't understand how this changes things. 1) static HashSet<Structure*>& ignoreSet = *(new HashSet<Structure*>); allocates the HashSet memory in the heap. 2) static HashSet<Structure*> ignoreSet; allocates the HashSet memory in the data section. BMP heap is not yet initialized at C++ static initialization time. So it is illegal to call new (which eventually calls Brew MP's MALLOC) in static initializers. 2) never calls MALLOC. So it is okay. 279596 4 darin 2010-09-15 10:10:56 -0700 But the project doesn’t allow global initializers anyway, so this should never come up. What’s an example of an object where this happens? 279603 5 skyul 2010-09-15 10:24:46 -0700 (In reply to comment #4) > But the project doesn’t allow global initializers anyway, so this should never come up. > > What’s an example of an object where this happens? Yes, I know WebKit does not use global initializers. However, there are a few places where global initializers are used to count memory leaks. This happens only in Debug build. For example, in JavaScriptCore/runtime/Structure.cpp static Mutex& ignoreSetMutex = *(new Mutex); static HashSet<Structure*>& ignoreSet = *(new HashSet<Structure*>); static HashSet<Structure*>& liveStructureSet = *(new HashSet<Structure*>); The above three lines call new in global initializers. 280945 6 skyul 2010-09-17 15:46:20 -0700 I think the better way to solve this problem is to remove the use of global initializers even in Debug build. We can use lazy initialization in memory leak counting and other statistics. I will come up with new patch. Close the bug as "won't fix". 67625 2010-09-14 17:43:57 -0700 2010-09-21 11:21:04 -0700 Patch staticinit.patch text/plain 1632 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDY3NTIwKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDktMTQgIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbQlJFV01QXSBEb24ndCB1c2UgbmV3IGluIHN0YXRpYyBp bml0aWFsaXplcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQ1Nzk0CisKKyAgICAgICAgQ2FsbGluZyBuZXcgaW4gc3RhdGljIGluaXRpYWxpemVycyBj YXVzZXMgYSBjcmFzaCBpbiBCcmV3IE1QIGJlY2F1c2UgQnJldyBNUCBoZWFwCisgICAgICAgIGlz IG5vdCB5ZXQgaW5pdGlhbGl6ZWQgYXQgdGhpcyB0aW1lLgorCisgICAgICAgICogcnVudGltZS9T dHJ1Y3R1cmUuY3BwOgorCiAyMDEwLTA5LTE0ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHZW9mZnJleSBHYXJlbi4KSW5kZXg6IEphdmFTY3Jp cHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29y ZS9ydW50aW1lL1N0cnVjdHVyZS5jcHAJKHJldmlzaW9uIDY3NTE4KQorKysgSmF2YVNjcmlwdENv cmUvcnVudGltZS9TdHJ1Y3R1cmUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MCwxMiArNzAsMjIg QEAgc3RhdGljIE11dGV4JiBpZ25vcmVTZXRNdXRleCA9ICoobmV3IE11dAogI2VuZGlmCiAKIHN0 YXRpYyBib29sIHNob3VsZElnbm9yZUxlYWtzOworI2lmIFBMQVRGT1JNKEJSRVdNUCkKKy8vIG5l dyBpbiBzdGF0aWMgaW5pdGlhbGl6ZXJzIGNhdXNlcyBhIGNyYXNoIGJlY2F1c2UgQnJldyBNUCBo ZWFwIGlzIG5vdCB5ZXQgcHJvcGVybHkgaW5pdGlhbGl6ZWQuCitzdGF0aWMgSGFzaFNldDxTdHJ1 Y3R1cmUqPiBpZ25vcmVTZXQ7CisjZWxzZQogc3RhdGljIEhhc2hTZXQ8U3RydWN0dXJlKj4mIGln bm9yZVNldCA9ICoobmV3IEhhc2hTZXQ8U3RydWN0dXJlKj4pOwogI2VuZGlmCisjZW5kaWYKIAog I2lmIERVTVBfU1RSVUNUVVJFX0lEX1NUQVRJU1RJQ1MKKyNpZiBQTEFURk9STShCUkVXTVApCisv LyBuZXcgaW4gc3RhdGljIGluaXRpYWxpemVycyBjYXVzZXMgYSBjcmFzaCBiZWNhdXNlIEJyZXcg TVAgaGVhcCBpcyBub3QgeWV0IHByb3Blcmx5IGluaXRpYWxpemVkLgorc3RhdGljIEhhc2hTZXQ8 U3RydWN0dXJlKj4gbGl2ZVN0cnVjdHVyZVNldDsKKyNlbHNlCiBzdGF0aWMgSGFzaFNldDxTdHJ1 Y3R1cmUqPiYgbGl2ZVN0cnVjdHVyZVNldCA9ICoobmV3IEhhc2hTZXQ8U3RydWN0dXJlKj4pOwog I2VuZGlmCisjZW5kaWYKIAogc3RhdGljIGludCBjb21wYXJlUHJvcGVydHlNYXBFbnRyeUluZGlj ZXMoY29uc3Qgdm9pZCogYSwgY29uc3Qgdm9pZCogYik7CiAK