<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>45760</bug_id>
          
          <creation_ts>2010-09-14 09:49:29 -0700</creation_ts>
          <short_desc>PrettyPatch doesn&apos;t handle UTF-8 characters correctly</short_desc>
          <delta_ts>2022-03-31 14:47:22 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=238630</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Patrick R. Gansterer">paroga</reporter>
          <assigned_to name="Martin Robinson">mrobinson</assigned_to>
          <cc>aroben</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>mitz</cc>
    
    <cc>mrobinson</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>278980</commentid>
    <comment_count>0</comment_count>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2010-09-14 09:49:29 -0700</bug_when>
    <thetext>When you open the following patch you see wrong characters at &quot;LayoutTests/fast/dom/Window/atob-btoa-expected.txt&quot;:
https://bugs.webkit.org/attachment.cgi?id=66276&amp;action=review

The following path looks correct, but doesn&apos;t apply via svn-apply:
https://bugs.webkit.org/attachment.cgi?id=66070&amp;action=review

It seams that PrettyPatch reads ASCII instead of UTF-8.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>907162</commentid>
    <comment_count>1</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-07-09 10:07:56 -0700</bug_when>
    <thetext>*** Bug 75394 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>907163</commentid>
    <comment_count>2</comment_count>
      <attachid>206334</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-07-09 10:10:45 -0700</bug_when>
    <thetext>Created attachment 206334
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>907174</commentid>
    <comment_count>3</comment_count>
      <attachid>206334</attachid>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2013-07-09 10:22:04 -0700</bug_when>
    <thetext>Comment on attachment 206334
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>907181</commentid>
    <comment_count>4</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-07-09 10:33:22 -0700</bug_when>
    <thetext>Committed r152496: &lt;http://trac.webkit.org/changeset/152496&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>206334</attachid>
            <date>2013-07-09 10:10:45 -0700</date>
            <delta_ts>2013-07-09 10:22:04 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-45760-20130709100832.patch</filename>
            <type>text/plain</type>
            <size>1379</size>
            <attacher name="Martin Robinson">mrobinson</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNDk1CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9idWdzLndl
YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZwpp
bmRleCBhYmUxZGFjODBiM2E0YTZiYjRjZmU4YTlhZmUxNTkwZTAzNDRjNDA5Li43YmE2MTA2NDE1
ZWNkY2FmN2NlYjRjZDgwOTA2OTc0YjBjMjM3N2JmIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9idWdz
LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFu
Z2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMy0wNy0wOSAgTWFydGluIFJvYmluc29uICA8bXJv
Ymluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAgUHJldHR5UGF0Y2ggZG9lc24ndCBoYW5kbGUg
VVRGLTggY2hhcmFjdGVycyBjb3JyZWN0bHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTQ1NzYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP
T1BTISkuCisKKyAgICAgICAgKiBQcmV0dHlQYXRjaC9QcmV0dHlQYXRjaC5yYjogU2luY2UgdGhl
IGRpZmYgbGluZXMgYXJlIHR5cGljYWxseSBpbiBVVEYtOCBhbmQgdGhlIHJlc3VsdHMKKyAgICAg
ICAgb2YgUHJldHR5UGF0Y2ggbWF5IGJlIHNlcnZlZCBieSBhIHdlYiBzZXJ2ZXIgb3Igbm90IChm
b3IgaW5zdGFuY2Ugd2hlbiBhY2Nlc3NlZCB2aWEKKyAgICAgICAgd2Via2l0LXBhdGNoIHByZXR0
eS1kaWZmKSwgd2Ugc2hvdWxkIHVzZSBhIG1ldGEgdGFnIHRvIGZvcmNlIHRoZSBwYWdlIGVuY29k
aW5nIHRvIFVURi04LgorCiAyMDEzLTA1LTIzICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3
ZWJraXQub3JnPgogCiAgICAgICAgIEVXUyBidWJibGVzIG5lZWQgbW9yZSBzcGFjZQpkaWZmIC0t
Z2l0IGEvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJi
IGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiCmlu
ZGV4IDc0NThiYWYyMzA4Njk4NTcyZDc2NDA4YjZlOTNmOTQ5YzY4NmUwMWUuLmRjMjhlNTQ4NTNm
Mzg4MzkyMGM0YmI1MGNmMjQzY2UwZDkwYzRiZDEgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mu
d2Via2l0Lm9yZy9QcmV0dHlQYXRjaC9QcmV0dHlQYXRjaC5yYgorKysgYi9XZWJzaXRlcy9idWdz
LndlYmtpdC5vcmcvUHJldHR5UGF0Y2gvUHJldHR5UGF0Y2gucmIKQEAgLTE2MCw2ICsxNjAsNyBA
QCBwcml2YXRlCiAgICAgSEVBREVSID08PEVPRgogPGh0bWw+CiA8aGVhZD4KKzxtZXRhIGNoYXJz
ZXQ9J3V0Zi04Jz4KIDxzdHlsZT4KIDpsaW5rLCA6dmlzaXRlZCB7CiAgICAgdGV4dC1kZWNvcmF0
aW9uOiBub25lOwo=
</data>
<flag name="review"
          id="228005"
          type_id="1"
          status="+"
          setter="aroben"
    />
          </attachment>
      

    </bug>

</bugzilla>