4573 2005-08-21 17:43:06 -0700 click DOM method not working on check boxes or radio buttons 2005-09-04 13:05:53 -0700 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 4565 1 darin darin andersca oldest_to_newest 17073 0 darin 2005-08-21 17:43:06 -0700 After the recent changes to forms, the "click" DOM method isn't working any more. This is breaking the HTMLInputElement21 test. 17075 1 3496 darin 2005-08-21 17:51:10 -0700 Created attachment 3496 patch to check on khtmlClick rather than click, not insist on a mouse event 17076 2 3496 darin 2005-08-21 17:51:38 -0700 Comment on attachment 3496 patch to check on khtmlClick rather than click, not insist on a mouse event I need Dave's input on whether this is the right way to fix this. 17825 3 mjs 2005-08-28 19:53:30 -0700 The change itself looks ok, however, I think the whole pre-dispatch event handling concept may be bogus. Other browsers will allow the click event handler for a radio button or checkbox to prevent the default action of toggling its checked state. 17827 4 3496 mjs 2005-08-28 23:11:54 -0700 Comment on attachment 3496 patch to check on khtmlClick rather than click, not insist on a mouse event Assuming you tested this with both click() and real mouse clicks, r=me. However - our handling here is somewhat wrong. Preventing default in or returning false from a mouse handler will not prevent the checkbox or radio button from being checked, and it should. 17828 5 3496 mjs 2005-08-28 23:18:26 -0700 Comment on attachment 3496 patch to check on khtmlClick rather than click, not insist on a mouse event Assuming you tested this with both click() and real mouse clicks, r=me. However - our handling here is somewhat wrong. Preventing default in or returning false from a mouse handler will not prevent the checkbox or radio button from being checked, and it should. 17829 6 3496 mjs 2005-08-28 23:34:47 -0700 Comment on attachment 3496 patch to check on khtmlClick rather than click, not insist on a mouse event Assuming you tested this with both click() and real mouse clicks, r=me. However - our handling here is somewhat wrong. Preventing default in or returning false from a mouse handler will not prevent the checkbox or radio button from being checked, and it should. 17981 7 hyatt 2005-08-30 15:32:42 -0700 Actually it's much weirder than that. onmousedown preventDefault does not stop checking. onclick preventDefault actually *reverses* the checking/unchecking in WinIE and Firefox. In other words you let the checking/unchecking happen and then undo it! I'm not sure if this is going to be necessary or not... Anyway, r- on the patch since the real bug is just that the click method was sending a KHTML_CLICK and not a real CLICK event. 17982 8 hyatt 2005-08-30 15:33:45 -0700 KHTML_CLICK needs to be eliminated as well, since its presence causes onclick to fire at the wrong time, after bubbling has happened in the real DOM. I'm going to file a follow-up bug to eliminate KHTML_CLICK. 17983 9 hyatt 2005-08-30 15:57:04 -0700 Fixed. 3496 2005-08-21 17:51:10 -0700 2005-08-30 15:31:10 -0700 patch to check on khtmlClick rather than click, not insist on a mouse event ClickPatch.txt text/plain 1635 darin SW5kZXg6IGtodG1sL2h0bWwvaHRtbF9mb3JtaW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTog L2N2cy9yb290L1dlYkNvcmUva2h0bWwvaHRtbC9odG1sX2Zvcm1pbXBsLmNwcCx2CnJldHJpZXZp bmcgcmV2aXNpb24gMS4xODUKZGlmZiAtcCAtdSAtcjEuMTg1IGtodG1sL2h0bWwvaHRtbF9mb3Jt aW1wbC5jcHAKLS0tIGtodG1sL2h0bWwvaHRtbF9mb3JtaW1wbC5jcHAJMTQgQXVnIDIwMDUgMDg6 MDc6MjIgLTAwMDAJMS4xODUKKysrIGtodG1sL2h0bWwvaHRtbF9mb3JtaW1wbC5jcHAJMjIgQXVn IDIwMDUgMDA6NTE6MjcgLTAwMDAKQEAgLTIyNzYsNyArMjI3Niw3IEBAIHZvaWQgSFRNTElucHV0 RWxlbWVudEltcGw6OmZvY3VzKCkKIAogdm9pZCBIVE1MSW5wdXRFbGVtZW50SW1wbDo6cHJlRGlz cGF0Y2hFdmVudEhhbmRsZXIoRXZlbnRJbXBsICpldnQpCiB7Ci0gICAgaWYgKGV2dC0+aXNNb3Vz ZUV2ZW50KCkgJiYgZXZ0LT5pZCgpID09IEV2ZW50SW1wbDo6Q0xJQ0tfRVZFTlQgJiYgc3RhdGlj X2Nhc3Q8TW91c2VFdmVudEltcGwqPihldnQpLT5idXR0b24oKSA9PSAwKSB7CisgICAgaWYgKGV2 dC0+aWQoKSA9PSBFdmVudEltcGw6OktIVE1MX0NMSUNLX0VWRU5UICYmICghZXZ0LT5pc01vdXNl RXZlbnQoKSB8fCBzdGF0aWNfY2FzdDxNb3VzZUV2ZW50SW1wbCo+KGV2dCktPmJ1dHRvbigpID09 IDApKSB7CiAgICAgICAgIGlmIChtX3R5cGUgPT0gQ0hFQ0tCT1ggfHwgbV90eXBlID09IFJBRElP KQogICAgICAgICAgICAgc2V0Q2hlY2tlZCghY2hlY2tlZCgpKTsKICAgICB9CkluZGV4OiBsYXlv dXQtdGVzdHMvZG9tL2h0bWwvbGV2ZWwyL2h0bWwvSFRNTElucHV0RWxlbWVudDIxLWV4cGVjdGVk LnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29yZS9sYXlvdXQtdGVzdHMv ZG9tL2h0bWwvbGV2ZWwyL2h0bWwvSFRNTElucHV0RWxlbWVudDIxLWV4cGVjdGVkLnR4dCx2CnJl dHJpZXZpbmcgcmV2aXNpb24gMS4xCmRpZmYgLXAgLXUgLXIxLjEgbGF5b3V0LXRlc3RzL2RvbS9o dG1sL2xldmVsMi9odG1sL0hUTUxJbnB1dEVsZW1lbnQyMS1leHBlY3RlZC50eHQKLS0tIGxheW91 dC10ZXN0cy9kb20vaHRtbC9sZXZlbDIvaHRtbC9IVE1MSW5wdXRFbGVtZW50MjEtZXhwZWN0ZWQu dHh0CTI2IEp1bCAyMDA1IDA4OjM1OjQyIC0wMDAwCTEuMQorKysgbGF5b3V0LXRlc3RzL2RvbS9o dG1sL2xldmVsMi9odG1sL0hUTUxJbnB1dEVsZW1lbnQyMS1leHBlY3RlZC50eHQJMjIgQXVnIDIw MDUgMDA6NTI6MzUgLTAwMDAKQEAgLTEsMyArMSwyIEBACi1UZXN0OglodHRwOi8vd3d3LnczLm9y Zy8yMDAxL0RPTS1UZXN0LVN1aXRlL2xldmVsMi9odG1sL0hUTUxJbnB1dEVsZW1lbnQyMQkKLVN0 YXR1czoJZmFpbHVyZQotRGV0YWlsOgljaGVja2VkQWZ0ZXJDbGljazogYXNzZXJ0VHJ1ZSBmYWls ZWQKK1Rlc3Q6CWh0dHA6Ly93d3cudzMub3JnLzIwMDEvRE9NLVRlc3QtU3VpdGUvbGV2ZWwyL2h0 bWwvSFRNTElucHV0RWxlbWVudDIxCitTdGF0dXM6CVN1Y2Nlc3MK