45705 2010-09-13 13:35:43 -0700 [BREWMP] Always set LeftButton in PlatformMouseEvent 2010-09-14 09:20:13 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 33564 0 skyul webkit-unassigned beergun commit-queue maniagoon oldest_to_newest 278442 0 skyul 2010-09-13 13:35:43 -0700 AEE_POINTER_GET_MOUSE_MODIFIERS always returns 0, so it is impossible to know which button is pressed or released. The current code erroneously sets NoButton. Set LeftButton unconditionally because Brew MP usually runs on touch device. 278443 1 67466 skyul 2010-09-13 13:37:28 -0700 Created attachment 67466 Patch 278732 2 67466 tkent 2010-09-13 22:39:19 -0700 Comment on attachment 67466 Patch Looks ok. 278958 3 67466 commit-queue 2010-09-14 09:20:09 -0700 Comment on attachment 67466 Patch Clearing flags on attachment: 67466 Committed r67473: <http://trac.webkit.org/changeset/67473> 278959 4 commit-queue 2010-09-14 09:20:13 -0700 All reviewed patches have been landed. Closing bug. 67466 2010-09-13 13:37:28 -0700 2010-09-14 09:20:09 -0700 Patch button.patch text/plain 2008 skyul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NzQwNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDktMTMgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbQlJFV01QXSBBbHdheXMgc2V0IExlZnRCdXR0b24gaW4gUGxhdGZvcm1Nb3VzZUV2ZW50Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTcwNQorCisg ICAgICAgIEFFRV9QT0lOVEVSX0dFVF9NT1VTRV9NT0RJRklFUlMgYWx3YXlzIHJldHVybnMgMCwg c28gaXQgaXMgaW1wb3NzaWJsZSB0byBrbm93CisgICAgICAgIHdoaWNoIGJ1dHRvbiBpcyBwcmVz c2VkIG9yIHJlbGVhc2VkLiBUaGUgY3VycmVudCBjb2RlIGVycm9uZW91c2x5IHNldHMgTm9CdXR0 b24uCisgICAgICAgIFNldCBMZWZ0QnV0dG9uIHVuY29uZGl0aW9uYWxseSBiZWNhdXNlIEJyZXcg TVAgdXN1YWxseSBydW5zIG9uIHRvdWNoIGRldmljZS4KKworICAgICAgICAqIHBsYXRmb3JtL2Jy ZXcvUGxhdGZvcm1Nb3VzZUV2ZW50QnJldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbGF0Zm9y bU1vdXNlRXZlbnQ6OlBsYXRmb3JtTW91c2VFdmVudCk6CisKIDIwMTAtMDktMTMgIEVucmljYSBD YXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2Vp bmluZy4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vYnJldy9QbGF0Zm9ybU1vdXNlRXZlbnRCcmV3 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2JyZXcvUGxhdGZvcm1Nb3VzZUV2 ZW50QnJldy5jcHAJKHJldmlzaW9uIDY3NDA0KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9icmV3L1Bs YXRmb3JtTW91c2VFdmVudEJyZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NSwxNSArNjUsMTAg QEAgUGxhdGZvcm1Nb3VzZUV2ZW50OjpQbGF0Zm9ybU1vdXNlRXZlbnQoQQogICAgIG1fYWx0S2V5 ICAgPSBrZXlNb2RpZmllcnMgJiAoS0JfTEFMVCB8IEtCX1JBTFQpOwogICAgIG1fbWV0YUtleSAg PSBtX2FsdEtleTsKIAotICAgIHVpbnQxNiBtb3VzZU1vZGlmaWVycyA9IEFFRV9QT0lOVEVSX0dF VF9NT1VTRV9NT0RJRklFUlMoZHdQYXJhbVN0cik7Ci0gICAgaWYgKG1vdXNlTW9kaWZpZXJzICYg QUVFX1BPSU5URVJfTU9VU0VfTEJVVFRPTikKLSAgICAgICAgbV9idXR0b24gPSBMZWZ0QnV0dG9u OwotICAgIGVsc2UgaWYgKG1vdXNlTW9kaWZpZXJzICYgQUVFX1BPSU5URVJfTU9VU0VfUkJVVFRP TikKLSAgICAgICAgbV9idXR0b24gPSBSaWdodEJ1dHRvbjsKLSAgICBlbHNlIGlmIChtb3VzZU1v ZGlmaWVycyAmIEFFRV9QT0lOVEVSX01PVVNFX01CVVRUT04pCi0gICAgICAgIG1fYnV0dG9uID0g TWlkZGxlQnV0dG9uOwotICAgIGVsc2UKLSAgICAgICAgbV9idXR0b24gPSBOb0J1dHRvbjsKKyAg ICAvLyBBRUVfUE9JTlRFUl9HRVRfTU9VU0VfTU9ESUZJRVJTKGR3UGFyYW1TdHIpIGFsd2F5cyBy ZXR1cm5zIDAsCisgICAgLy8gc28gaXQgaXMgaW1wb3NzaWJsZSB0byBrbm93IHdoaWNoIGJ1dHRv biBpcyBwcmVzc2VkIG9yIHJlbGVhc2VkLgorICAgIC8vIEp1c3QgdXNlIExlZnRCdXR0b24gYmVj YXVzZSBCcmV3IE1QIHVzdWFsbHkgcnVucyBvbiB0b3VjaCBkZXZpY2UuCisgICAgbV9idXR0b24g PSBMZWZ0QnV0dG9uOwogCiAgICAgLy8gQUVFX1BPSU5URVJfR0VUX1RJTUUgcmV0dXJucyBtaWxs aXNlY29uZHMKICAgICBtX3RpbWVzdGFtcCA9IEFFRV9QT0lOVEVSX0dFVF9USU1FKGR3UGFyYW1T dHIpICogMC4wMDE7Cg==