45701 2010-09-13 13:06:49 -0700 [BREWMP] Set m_size in SharedBuffer::createWithContentsOfFile(); 2010-09-14 09:14:21 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 33564 0 beergun webkit-unassigned abarth commit-queue eric skyul webkit.review.bot oldest_to_newest 278417 0 beergun 2010-09-13 13:06:49 -0700 SharedBuffer::createWithContentsOfFile() reads file content and saves to result.m_buffer directly, leaving result.m_size unchanged. 278422 1 67462 beergun 2010-09-13 13:14:33 -0700 Created attachment 67462 Patch 278890 2 67462 commit-queue 2010-09-14 07:43:06 -0700 Comment on attachment 67462 Patch Clearing flags on attachment: 67462 Committed r67468: <http://trac.webkit.org/changeset/67468> 278891 3 commit-queue 2010-09-14 07:43:10 -0700 All reviewed patches have been landed. Closing bug. 278954 4 webkit.review.bot 2010-09-14 09:14:21 -0700 http://trac.webkit.org/changeset/67468 might have broken GTK Linux 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/67465 http://trac.webkit.org/changeset/67466 http://trac.webkit.org/changeset/67467 http://trac.webkit.org/changeset/67468 67462 2010-09-13 13:14:33 -0700 2010-09-14 07:43:06 -0700 Patch sharedbufferbrew.patch text/plain 1458 beergun SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NzQwNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDktMTMgIEh5dW5nIFNvbmcgIDxiZWVyZ3VuQGNvbXBhbnkx MDAubmV0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtCUkVXTVBdIFNldCBtX3NpemUgaW4gU2hhcmVkQnVmZmVyOjpjcmVhdGVXaXRoQ29udGVudHNP ZkZpbGUoKTsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ1NzAxCisKKyAgICAgICAgU2hhcmVkQnVmZmVyOjpjcmVhdGVXaXRoQ29udGVudHNPZkZpbGUo KSByZWFkcyBmaWxlIGNvbnRlbnQgYW5kIHNhdmVzIHRvIAorICAgICAgICByZXN1bHQubV9idWZm ZXIgZGlyZWN0bHksIGxlYXZpbmcgcmVzdWx0Lm1fc2l6ZSB1bmNoYW5nZWQuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9icmV3L1NoYXJlZEJ1ZmZlckJyZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 U2hhcmVkQnVmZmVyOjpjcmVhdGVXaXRoQ29udGVudHNPZkZpbGUpOgorCiAyMDEwLTA5LTEzICBF bnJpY2EgQ2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg U2FtIFdlaW5pbmcuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2JyZXcvU2hhcmVkQnVmZmVyQnJl dy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9icmV3L1NoYXJlZEJ1ZmZlckJy ZXcuY3BwCShyZXZpc2lvbiA2NzM5NSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vYnJldy9TaGFyZWRC dWZmZXJCcmV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjQsNiArNjQsNyBAQCBQYXNzUmVmUHRy PFNoYXJlZEJ1ZmZlcj4gU2hhcmVkQnVmZmVyOjpjCiAgICAgaW50MzIgYnl0ZXNSZWFkOwogICAg IHdoaWxlICgoYnl0ZXNSZWFkID0gSUZJTEVfUmVhZChmaWxlLmdldCgpLCByZXN1bHQtPm1fYnVm ZmVyLmRhdGEoKSArIHRvdGFsQnl0ZXNSZWFkLCBmaWxlU2l6ZSAtIHRvdGFsQnl0ZXNSZWFkKSkg PiAwKQogICAgICAgICB0b3RhbEJ5dGVzUmVhZCArPSBieXRlc1JlYWQ7CisgICAgcmVzdWx0LT5t X3NpemUgPSB0b3RhbEJ5dGVzUmVhZDsKIAogICAgIGlmICh0b3RhbEJ5dGVzUmVhZCAhPSBmaWxl U2l6ZSkgewogICAgICAgICBMT0dfRVJST1IoIkZhaWxlZCB0byBmdWxseSByZWFkIGNvbnRlbnRz IG9mIGZpbGUgJXMgLSBlcnJubyglaSkiLCBmaWxlUGF0aC5hc2NpaSgpLmRhdGEoKSwgSUZJTEVN R1JfR2V0TGFzdEVycm9yKGZpbGVNZ3IuZ2V0KCkpKTsK