45492 2010-09-09 14:16:59 -0700 Remove useless FrameLoader method 2010-09-10 13:10:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 29947 1 abarth abarth commit-queue eric japhet oldest_to_newest 276758 0 abarth 2010-09-09 14:16:59 -0700 Remove useless FrameLoader method 276761 1 67097 abarth 2010-09-09 14:18:43 -0700 Created attachment 67097 Patch 277389 2 67097 abarth 2010-09-10 13:02:10 -0700 Comment on attachment 67097 Patch Clearing flags on attachment: 67097 Committed r67224: <http://trac.webkit.org/changeset/67224> 277390 3 abarth 2010-09-10 13:02:15 -0700 All reviewed patches have been landed. Closing bug. 277393 4 67097 commit-queue 2010-09-10 13:10:27 -0700 Comment on attachment 67097 Patch Rejecting patch 67097 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1 Last 500 characters of output: k #1 succeeded at 1 with fuzz 3. patching file WebCore/loader/FrameLoader.cpp Hunk #1 FAILED at 1501. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/loader/FrameLoader.cpp.rej patching file WebCore/loader/FrameLoader.h Hunk #1 FAILED at 153. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/loader/FrameLoader.h.rej patching file WebCore/loader/MainResourceLoader.cpp Hunk #1 FAILED at 146. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/loader/MainResourceLoader.cpp.rej Full output: http://queues.webkit.org/results/3989027 67097 2010-09-09 14:18:43 -0700 2010-09-10 13:10:27 -0700 Patch bug-45492-20100909141841.patch text/plain 2715 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2QxODk5MGM2N2NiZDI4MDIwYWQxODM1YjViYzkwMGQ3ODNkMmRjMS4uMzMxMDNlODY3OTI4NjJh YTc2NTM0MjVmOGRmMmM5YThhYzExYzE0YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAxMC0wOS0wOSAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSB1c2VsZXNzIEZyYW1lTG9hZGVyIG1ldGhvZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDU0OTIKKwor ICAgICAgICBUaGlzIG1ldGhvZCBoYXMgb25lIGNhbGxlciwgYW5kIHRoYXQgY2FsbGVyIGFscmVh ZHkgaGFzIGEgbW9yZSBkaXJlY3QKKyAgICAgICAgd2F5IG9mIGFjY2Vzc2luZyB0aGUgY29ycmVj dCBEb2N1bWVudExvYWRlci4KKworICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRlci5jcHA6Cisg ICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVyLmg6CisgICAgICAgICogbG9hZGVyL01haW5SZXNv dXJjZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNYWluUmVzb3VyY2VMb2FkZXI6OmFk ZERhdGEpOgorCisyMDEwLTA5LTA5ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisK ICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCiAKICAgICAgICAgSW5saW5lIEZyYW1l TG9hZGVyOjpjb21taXR0ZWRMb2FkIGludG8gaXRzIG9uZSBjYWxsZXIKZGlmZiAtLWdpdCBhL1dl YkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcCBiL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVy LmNwcAppbmRleCBiZjE3ZWQ5YmE5ZWViNTM0ZDJhN2NmMWEzZWM5NGMxMjdjNzE0NmFkLi4wOWVm M2M4YjIyNTZjOGFlMWY2ODRiNGExMDM4OGQwNjU1MGJiOTZhIDEwMDY0NAotLS0gYS9XZWJDb3Jl L2xvYWRlci9GcmFtZUxvYWRlci5jcHAKKysrIGIvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIu Y3BwCkBAIC0xNTAxLDExICsxNTAxLDYgQEAgY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiBGcmFtZUxv YWRlcjo6aW5pdGlhbFJlcXVlc3QoKSBjb25zdAogICAgIHJldHVybiBhY3RpdmVEb2N1bWVudExv YWRlcigpLT5vcmlnaW5hbFJlcXVlc3QoKTsKIH0KIAotdm9pZCBGcmFtZUxvYWRlcjo6cmVjZWl2 ZWREYXRhKGNvbnN0IGNoYXIqIGRhdGEsIGludCBsZW5ndGgpCi17Ci0gICAgYWN0aXZlRG9jdW1l bnRMb2FkZXIoKS0+cmVjZWl2ZWREYXRhKGRhdGEsIGxlbmd0aCk7Ci19Ci0KIGJvb2wgRnJhbWVM b2FkZXI6OndpbGxMb2FkTWVkaWFFbGVtZW50VVJMKEtVUkwmIHVybCkKIHsKICAgICBSZXNvdXJj ZVJlcXVlc3QgcmVxdWVzdCh1cmwpOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9sb2FkZXIvRnJhbWVM b2FkZXIuaCBiL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmgKaW5kZXggYjM4OGQ5ZjAxODkz ODA1NWZmNjg5NGFjYWU1YmUzYjcxODE2NWJlZC4uMjg0ZmVkMWQ3OTFlZWUzZmQxM2U3OTc3MmE4 NTZlNjdlNTU0YmJmNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuaAor KysgYi9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5oCkBAIC0xNTMsNyArMTUzLDYgQEAgcHVi bGljOgogICAgIGNvbnN0IFJlc291cmNlUmVxdWVzdCYgb3JpZ2luYWxSZXF1ZXN0KCkgY29uc3Q7 CiAgICAgY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiBpbml0aWFsUmVxdWVzdCgpIGNvbnN0OwogICAg IHZvaWQgcmVjZWl2ZWRNYWluUmVzb3VyY2VFcnJvcihjb25zdCBSZXNvdXJjZUVycm9yJiwgYm9v bCBpc0NvbXBsZXRlKTsKLSAgICB2b2lkIHJlY2VpdmVkRGF0YShjb25zdCBjaGFyKiwgaW50KTsK IAogICAgIGJvb2wgd2lsbExvYWRNZWRpYUVsZW1lbnRVUkwoS1VSTCYpOwogCmRpZmYgLS1naXQg YS9XZWJDb3JlL2xvYWRlci9NYWluUmVzb3VyY2VMb2FkZXIuY3BwIGIvV2ViQ29yZS9sb2FkZXIv TWFpblJlc291cmNlTG9hZGVyLmNwcAppbmRleCBhN2E1OTY4NzYxZWE3ZTlhMDdiYjdjZmIxNzE5 ZmQ1ZThjZGYzOWRhLi41N2FkOTUwMGZlODNlMWJlMWZlNGUzMDI2MzNmMmJjNmI5ODY2ZTE4IDEw MDY0NAotLS0gYS9XZWJDb3JlL2xvYWRlci9NYWluUmVzb3VyY2VMb2FkZXIuY3BwCisrKyBiL1dl YkNvcmUvbG9hZGVyL01haW5SZXNvdXJjZUxvYWRlci5jcHAKQEAgLTE0Niw3ICsxNDYsNyBAQCBi b29sIE1haW5SZXNvdXJjZUxvYWRlcjo6aXNQb3N0T3JSZWRpcmVjdEFmdGVyUG9zdChjb25zdCBS ZXNvdXJjZVJlcXVlc3QmIG5ld1JlcQogdm9pZCBNYWluUmVzb3VyY2VMb2FkZXI6OmFkZERhdGEo Y29uc3QgY2hhciogZGF0YSwgaW50IGxlbmd0aCwgYm9vbCBhbGxBdE9uY2UpCiB7CiAgICAgUmVz b3VyY2VMb2FkZXI6OmFkZERhdGEoZGF0YSwgbGVuZ3RoLCBhbGxBdE9uY2UpOwotICAgIGZyYW1l TG9hZGVyKCktPnJlY2VpdmVkRGF0YShkYXRhLCBsZW5ndGgpOworICAgIGRvY3VtZW50TG9hZGVy KCktPnJlY2VpdmVkRGF0YShkYXRhLCBsZW5ndGgpOwogfQogCiB2b2lkIE1haW5SZXNvdXJjZUxv YWRlcjo6d2lsbFNlbmRSZXF1ZXN0KFJlc291cmNlUmVxdWVzdCYgbmV3UmVxdWVzdCwgY29uc3Qg UmVzb3VyY2VSZXNwb25zZSYgcmVkaXJlY3RSZXNwb25zZSkK