45309 2010-09-07 10:37:31 -0700 ActiveDOMObjects::hasPendingActivity doesn't prevent element wrapper collection 2012-11-16 13:29:39 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All NEW InRadar P1 Normal --- 1 eric.carlson webkit-unassigned abarth antonm ap ggaren jorlow vestbo oldest_to_newest 275141 0 66738 eric.carlson 2010-09-07 10:37:31 -0700 Created attachment 66738 test case (may crash) Even with the changes for https://bugs.webkit.org/show_bug.cgi?id=45306, the attached test case asserts in JSEventListener::jsFunction when a media element tries to fire an event after the js wrapper has been collected. Those changes should prevent this because they make HTMLMediaElement inherit from ActiveDOMObject and 1) return true from hasPendingActivity when events are in the queue, and 2) flush pending events in suspend/stop. It doesn't prevent the object from being collected because when markActiveObjectsForContext sees that a media element has pending activity it calls markDOMObjectWrapper, but the media element has a DOMNodeWrapper so the mark never happens and the element is collected. 276020 1 ap 2010-09-08 13:16:37 -0700 We're hitting this for media elements and with marquee. 341541 2 ap 2011-01-28 11:09:44 -0800 <rdar://problem/8931194> ActiveDOMObjects::hasPendingActivity doesn't prevent element wrapper collection 394020 3 ggaren 2011-04-27 17:14:00 -0700 I believe that all we need to do to fix this bug is to mark these elements with the ActiveDOMObject IDL attribute. 482522 4 ap 2011-10-12 10:54:45 -0700 This test doesn't ASSERT in ToT, although there is no ActiveDOMObject IDL attribute on the elements. I'm not sure if this is just because of some unrelated behavior change that renders the test ineffective, or the problem is somehow fully fixed. 769545 5 abarth 2012-11-16 12:00:54 -0800 This will likely be fixed when I fix bug 101428. It might actually be fixed on trunk currently given that we're using the ActiveDOMObject owner for HTMLMediaElement rather than the Node owner. 66738 2010-09-07 10:37:31 -0700 2010-09-07 13:15:33 -0700 test case (may crash) async-event-crash.html text/html 5056 eric.carlson PCFET0NUWVBFIGh0bWw+CjxodG1sPgogICAgPGhlYWQ+CiAgICAgICAgPHNjcmlwdCBzcmM9bWVk aWEtZmlsZS5qcz48L3NjcmlwdD4KCiAgICAgICAgPHNjcmlwdD4KICAgICAgICAgICAgY29uc3Qg bG9vcENvdW50ID0gMjA7CiAgICAgICAgICAgIGNvbnN0IHNlZWtDb3VudCA9IDYwOwogICAgICAg ICAgICBjb25zdCBtb3ZpZUNvdW50ID0gMTA7CiAgICAgICAgICAgIHZhciBjb3VudCA9IDA7CiAg ICAgICAgICAgIHZhciBkb25lID0gZmFsc2U7CgogICAgICAgICAgICBpZiAod2luZG93LmxheW91 dFRlc3RDb250cm9sbGVyKSB7CiAgICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5k dW1wQXNUZXh0KCk7CiAgICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50 aWxEb25lKCk7CiAgICAgICAgICAgIH0KCiAgICAgICAgICAgIGZ1bmN0aW9uIGxvZyhtc2cpCiAg ICAgICAgICAgIHsKICAgICAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdjb25z b2xlJykuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUobXNnICsgIlxuIikpOwog ICAgICAgICAgICB9CgogICAgICAgICAgICBmdW5jdGlvbiBmaW5pc2goKQogICAgICAgICAgICB7 CiAgICAgICAgICAgICAgICBsb2coIioqIEhhbmRsZWQgIiArIGNvdW50ICsgIiAndGltZXVwZGF0 ZScgZXZlbnRzLiIpOwogICAgICAgICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJv bGxlcikKICAgICAgICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25l KCk7CiAgICAgICAgICAgIH0KCiAgICAgICAgICAgIGZ1bmN0aW9uIHRpbWV1cGRhdGUoKQogICAg ICAgICAgICB7CiAgICAgICAgICAgICAgICArK2NvdW50OwogICAgICAgICAgICAgICAgdmFyIHZp ZGVvID0gZXZlbnQudGFyZ2V0OwogICAgICAgICAgICAgICAgdmFyIHZpZGVvcyA9IGRvY3VtZW50 LmdldEVsZW1lbnRzQnlUYWdOYW1lKCd2aWRlbycpOwoKICAgICAgICAgICAgICAgIC8vIERlbGV0 ZSB0aGUgdmlkZW8gZWxlbWVudCBpZiBpdCBpcyBzdGlsbCBpbiB0aGUgRE9NCiAgICAgICAgICAg ICAgICBmb3IgKG5keCA9IDA7IG5keCA8IHZpZGVvcy5sZW5ndGg7IG5keCsrKSB7CiAgICAgICAg ICAgICAgICAgICAgaWYgKHZpZGVvID0gdmlkZW9zW25keF0pIHsKICAgICAgICAgICAgICAgICAg ICAgICAgZm9yY2VHQygpOwogICAgICAgICAgICAgICAgICAgICAgICBsb2coIioqIERlbGV0aW5n IHZpZGVvLiIpOwogICAgICAgICAgICAgICAgICAgICAgICB2aWRlby5wYXJlbnROb2RlLnJlbW92 ZUNoaWxkKHZpZGVvKTsKICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAg ICAgICAgICAgIH0KICAgICAgICAgICAgICAgIH0KCiAgICAgICAgICAgICAgICAvLyBEb25lIHdp dGggdGhlIHRlc3Qgb25jZSB0aGVyZSBhcmUgbm8gbW9yZSB2aWRlbyBlbGVtZW50cy4KICAgICAg ICAgICAgICAgIGlmICghZG9uZSAmJiAhZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ3Zp ZGVvJykubGVuZ3RoKSB7CiAgICAgICAgICAgICAgICAgICAgZm9yY2VHQygpOwogICAgICAgICAg ICAgICAgICAgIGRvbmUgPSB0cnVlOwogICAgICAgICAgICAgICAgICAgIHNldFRpbWVvdXQoZmlu aXNoLCAyMDApOwogICAgICAgICAgICAgICAgfQogICAgICAgICAgICB9CgogICAgICAgICAgICBm dW5jdGlvbiBmb3JjZUdDKCkKICAgICAgICAgICAgewogICAgICAgICAgICAgICAgbG9nKCIqKiBG b3JjaW5nIGdhcmJhZ2UgY29sbGVjdGlvbi4iKTsKICAgICAgICAgICAgICAgIGlmICh3aW5kb3cu R0NDb250cm9sbGVyKQogICAgICAgICAgICAgICAgICAgIHJldHVybiBHQ0NvbnRyb2xsZXIuY29s bGVjdCgpOwoKICAgICAgICAgICAgICAgIC8vIEZvcmNlIGdhcmJhZ2UgY29sbGVjdGlvbiB0aGUg b2xkIGZhc2hpb25lZCB3YXkuCiAgICAgICAgICAgICAgICBmb3IgKHZhciBuZHggPSAwOyBuZHgg PCA5OTAwMDsgbmR4KyspCiAgICAgICAgICAgICAgICAgICAgdmFyIHN0ciA9IG5ldyBTdHJpbmco IjEyMzQxMjM0Iik7CiAgICAgICAgICAgIH0KCiAgICAgICAgICAgIGZ1bmN0aW9uIGxvYWRlZG1l dGFkYXRhKCkKICAgICAgICAgICAgewogICAgICAgICAgICAgICAgdmFyIHZpZGVvID0gZXZlbnQu dGFyZ2V0OwoKICAgICAgICAgICAgICAgIGxvZygiKiogU2Vla2luZyB0byBnZW5lcmF0ZSBxdWV1 ZSBvZiAiICsgKGxvb3BDb3VudCAqIHNlZWtDb3VudCkgKyAiICd0aW1ldXBkYXRlJyBldmVudHMu Iik7CiAgICAgICAgICAgICAgICBmb3IgKHZhciBuZHg9MDsgbmR4IDwgbG9vcENvdW50OyBuZHgr KykKICAgICAgICAgICAgICAgICAgICBmb3IgKHZhciBzZWVrTmR4PTA7IHNlZWtOZHggPCBzZWVr Q291bnQ7IHNlZWtOZHgrKykKICAgICAgICAgICAgICAgICAgICAgICAgdmlkZW8uY3VycmVudFRp bWUgPSBzZWVrTmR4ICogMC4xOwogICAgICAgICAgICB9CgogICAgICAgICAgICBmdW5jdGlvbiBz ZXR1cCh2aWRlbykKICAgICAgICAgICAgewogICAgICAgICAgICAgICAgdmFyIGRvTm90aGluZyA9 IGZ1bmN0aW9uKCkgeyB9OwogICAgICAgICAgICAgICAgdmlkZW8uYWRkRXZlbnRMaXN0ZW5lcigi bG9hZGVkbWV0YWRhdGEiLCBsb2FkZWRtZXRhZGF0YSwgZmFsc2UpOwogICAgICAgICAgICAgICAg dmlkZW8uYWRkRXZlbnRMaXN0ZW5lcigidGltZXVwZGF0ZSIsIHRpbWV1cGRhdGUsIGZhbHNlKTsK ICAgICAgICAgICAgICAgIHZpZGVvLmFkZEV2ZW50TGlzdGVuZXIoImxvYWRzdGFydCIsIGRvTm90 aGluZyk7CiAgICAgICAgICAgICAgICB2aWRlby5hZGRFdmVudExpc3RlbmVyKCJwcm9ncmVzcyIs IGRvTm90aGluZyk7CiAgICAgICAgICAgICAgICB2aWRlby5hZGRFdmVudExpc3RlbmVyKCJzdXNw ZW5kIiwgZG9Ob3RoaW5nKTsKICAgICAgICAgICAgICAgIHZpZGVvLmFkZEV2ZW50TGlzdGVuZXIo ImxvYWQiLCBkb05vdGhpbmcpOwogICAgICAgICAgICAgICAgdmlkZW8uYWRkRXZlbnRMaXN0ZW5l cigiYWJvcnQiLCBkb05vdGhpbmcpOwogICAgICAgICAgICAgICAgdmlkZW8uYWRkRXZlbnRMaXN0 ZW5lcigiZXJyb3IiLCBkb05vdGhpbmcpOwogICAgICAgICAgICAgICAgdmlkZW8uYWRkRXZlbnRM aXN0ZW5lcigiZW1wdGllZCIsIGRvTm90aGluZyk7CiAgICAgICAgICAgICAgICB2aWRlby5hZGRF dmVudExpc3RlbmVyKCJzdGFsbGVkIiwgZG9Ob3RoaW5nKTsKICAgICAgICAgICAgICAgIHZpZGVv LmFkZEV2ZW50TGlzdGVuZXIoInBsYXkiLCBkb05vdGhpbmcpOwogICAgICAgICAgICAgICAgdmlk ZW8uYWRkRXZlbnRMaXN0ZW5lcigicGF1c2UiLCBkb05vdGhpbmcpOwogICAgICAgICAgICAgICAg dmlkZW8uYWRkRXZlbnRMaXN0ZW5lcigibG9hZGVkZGF0YSAiLCBkb05vdGhpbmcpOwogICAgICAg ICAgICAgICAgdmlkZW8uYWRkRXZlbnRMaXN0ZW5lcigid2FpdGluZyIsIGRvTm90aGluZyk7CiAg ICAgICAgICAgICAgICB2aWRlby5hZGRFdmVudExpc3RlbmVyKCJjYW5wbGF5IiwgZG9Ob3RoaW5n KTsKICAgICAgICAgICAgICAgIHZpZGVvLmFkZEV2ZW50TGlzdGVuZXIoImNhbnBsYXl0aHJvdWdo IiwgZG9Ob3RoaW5nKTsKICAgICAgICAgICAgICAgIHZpZGVvLmFkZEV2ZW50TGlzdGVuZXIoInNl ZWtpbmciLCBkb05vdGhpbmcpOwogICAgICAgICAgICAgICAgdmlkZW8uYWRkRXZlbnRMaXN0ZW5l cigic2Vla2VkIiwgZG9Ob3RoaW5nKTsKICAgICAgICAgICAgICAgIHZpZGVvLmFkZEV2ZW50TGlz dGVuZXIoImVuZGVkIiwgZG9Ob3RoaW5nKTsKICAgICAgICAgICAgICAgIHZpZGVvLmFkZEV2ZW50 TGlzdGVuZXIoInJhdGVjaGFuZ2UiLCBkb05vdGhpbmcpOwogICAgICAgICAgICAgICAgdmlkZW8u YWRkRXZlbnRMaXN0ZW5lcigiZHVyYXRpb25jaGFuZ2UiLCBkb05vdGhpbmcpOwogICAgICAgICAg ICAgICAgdmlkZW8uYWRkRXZlbnRMaXN0ZW5lcigidm9sdW1lY2hhbmdlIiwgZG9Ob3RoaW5nKTsJ CiAgICAgICAgICAgICAgICB2aWRlby5hZGRFdmVudExpc3RlbmVyKCJjYW5zaG93Y3VycmVudGZy YW1lIiwgZG9Ob3RoaW5nKTsJCiAgICAgICAgICAgICAgICB2aWRlby5hZGRFdmVudExpc3RlbmVy KCJkYXRhdW5hdmFpbGFibGUiLCBkb05vdGhpbmcpOwkKCiAgICAgICAgICAgICAgICB2aWRlby5z ZXRBdHRyaWJ1dGUoImNvbnRyb2xzIiwgIiIpOwogICAgICAgICAgICAgICAgdmlkZW8uc2V0QXR0 cmlidXRlKCJzcmMiLCBmaW5kTWVkaWFGaWxlKCJ2aWRlbyIsICJjb250ZW50L3Rlc3QiKSk7CiAg ICAgICAgICAgIH0KCiAgICAgICAgICAgIGZ1bmN0aW9uIGNyZWF0ZVZpZGVvRWxlbWVudCgpCiAg ICAgICAgICAgIHsKICAgICAgICAgICAgICAgIGxvZygiIik7CgogICAgICAgICAgICAgICAgdmFy IHdyYXBwZXIgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnbWVkaWEtd3JhcHBlcicpOwoKICAg ICAgICAgICAgICAgIGxvZygiKiogR2VuZXJhdGluZyA8dmlkZW8+ICIgKyBtb3ZpZUNvdW50ICsg IiBlbGVtZW50cy4iKTsKICAgICAgICAgICAgICAgIGZvciAodmFyIG5keD0wOyBuZHggPCBtb3Zp ZUNvdW50OyBuZHgrKykgewogICAgICAgICAgICAgICAgICAgIHZhciB2aWRlbyA9IGRvY3VtZW50 LmNyZWF0ZUVsZW1lbnQoJ3ZpZGVvJyk7CiAgICAgICAgICAgICAgICAgICAgc2V0dXAodmlkZW8p OwogICAgICAgICAgICAgICAgICAgIHdyYXBwZXIuaW5zZXJ0QmVmb3JlKHZpZGVvLCB3cmFwcGVy LmZpcnN0Q2hpbGQpOwogICAgICAgICAgICAgICAgfQogICAgICAgICAgICB9CiAgICAgICAgPC9z Y3JpcHQ+CiAgICA8L2hlYWQ+CiAgICA8Ym9keSBvbmxvYWQ9ImNyZWF0ZVZpZGVvRWxlbWVudCgp Ij4KICAgICAgICA8c3BhbiBpZD0ibWVkaWEtd3JhcHBlciI+PC9zcGFuPiAgICAKICAgICAgICAK ICAgICAgICA8cD5UZXN0cyB0aGF0IHdlIGRvbid0IGNyYXNoIHdoZW4gYSB2aWRlbyBlbGVtZW50 IHdpdGggcGVuZGluZyBhc3luYyBldmVudHMgaXMgZGVsZXRlZC48L3A+CiAgICAgICAgPHByZSBp ZD0iY29uc29sZSI+PC9wcmU+CiAgICA8L2JvZHk+CjwvaHRtbD4KCg==