45016 2010-08-31 21:15:23 -0700 [Chromium] Add WebKitClient::callOnMainThreadWithDelay() 2010-09-01 17:26:36 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Other All RESOLVED INVALID P2 Normal --- 36641 1 tkent tkent dglazkov fishd oldest_to_newest 272615 0 tkent 2010-08-31 21:15:23 -0700 [Chromium] Add WebKitClient::callOnMainThreadWithDelay() 272616 1 66164 tkent 2010-08-31 21:16:59 -0700 Created attachment 66164 Patch 272617 2 66164 dglazkov 2010-08-31 21:18:16 -0700 Comment on attachment 66164 Patch ok. I am assuming you're adding callers of this after rolling chromium? 272618 3 tkent 2010-08-31 21:24:26 -0700 (In reply to comment #2) > (From update of attachment 66164 [details]) > ok. I am assuming you're adding callers of this after rolling chromium? Right. 1. commit this. 2. commit an implementation of callOnMainThreadWithDelay() in Chromium 3. roll Chromium revision and use callOnMainThreadWithDelay() in DRT 272645 4 66164 tkent 2010-08-31 22:46:32 -0700 Comment on attachment 66164 Patch Clearing flags on attachment: 66164 Committed r66576: <http://trac.webkit.org/changeset/66576> 272646 5 tkent 2010-08-31 22:46:41 -0700 All reviewed patches have been landed. Closing bug. 272842 6 66164 fishd 2010-09-01 09:28:05 -0700 Comment on attachment 66164 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=66164&action=prettypatch > WebKit/chromium/public/WebKitClient.h:263 > + virtual void callOnMainThreadWithDelay(void (*func)(void*), void* context, long long delayMilliseconds) { } delayMilliseconds does not need to be 'long long'. a simple int would do here. i'm curious... what are the consumers that require this? 273044 7 tkent 2010-09-01 14:57:42 -0700 (In reply to comment #6) > (From update of attachment 66164 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=66164&action=prettypatch > > > WebKit/chromium/public/WebKitClient.h:263 > > + virtual void callOnMainThreadWithDelay(void (*func)(void*), void* context, long long delayMilliseconds) { } > delayMilliseconds does not need to be 'long long'. a simple int would do here. > > i'm curious... what are the consumers that require this? I used "long long" because MessageLoop::postDelayedTask() uses int64 though int is enough for my purpose. http://trac.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp#L324 will be replaced with code using callOnMainThreadWithDelay(). 273098 8 tkent 2010-09-01 16:24:32 -0700 I have change my mind :-) The function can be implemented in webkit_support and we don't need to pollute WebKit API. I'll revert r66576. 273122 9 tkent 2010-09-01 17:25:53 -0700 Reverted r66576 for reason: This change is not needed. Committed r66627: <http://trac.webkit.org/changeset/66627> 66164 2010-08-31 21:16:59 -0700 2010-09-01 09:28:05 -0700 Patch bug-45016-20100901131657.patch text/plain 1371 tkent ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDFmNWIyZjdiMWU2MGMyN2M5YTNjOWFhZWJiMTg0YjM4ZTAzZWRiY2Eu LjJjYTk4ZTFiNDMyZWM2YWFlYmFlMTQyN2M2YWJmNWMyODlhMTBlNzIgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE2IEBACisyMDEwLTA4LTMxICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb Q2hyb21pdW1dIEFkZCBXZWJLaXRDbGllbnQ6OmNhbGxPbk1haW5UaHJlYWRXaXRoRGVsYXkoKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDUwMTYKKwor ICAgICAgICBJdCBpcyByZXF1aXJlZCB0byByZW1vdmUgYmFzZS90YXNrLmggYW5kIGJhc2UvdGlt ZXIuaCBkZXBlbmRlbmN5CisgICAgICAgIGZyb20gRFJUL0Nocm9taXVtLgorCisgICAgICAgICog cHVibGljL1dlYktpdENsaWVudC5oOgorICAgICAgICAoV2ViS2l0OjpXZWJLaXRDbGllbnQ6OmNh bGxPbk1haW5UaHJlYWRXaXRoRGVsYXkpOiBBZGRlZC4KKwogMjAxMC0wOC0yNCAgSmVyZW15IE9y bG93ICA8am9ybG93QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBTdGV2ZSBC bG9jay4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViS2l0Q2xpZW50Lmgg Yi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktpdENsaWVudC5oCmluZGV4IDljMGI0YzJhNTc5 ZjRiMjczYjZjMDE1ZWZmOTc2MmUxZWYxYjI0YzcuLmUzOWZiMmEyOWNmZTMyNTU0NDRmOGJkYzM1 NjdhYzFjODhmZDJlZDUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViS2l0 Q2xpZW50LmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJLaXRDbGllbnQuaApAQCAt MjYwLDYgKzI2MCw3IEBAIHB1YmxpYzoKIAogICAgIC8vIENhbGxhYmxlIGZyb20gYSBiYWNrZ3Jv dW5kIFdlYktpdCB0aHJlYWQuCiAgICAgdmlydHVhbCB2b2lkIGNhbGxPbk1haW5UaHJlYWQodm9p ZCAoKmZ1bmMpKHZvaWQqKSwgdm9pZCogY29udGV4dCkgeyB9CisgICAgdmlydHVhbCB2b2lkIGNh bGxPbk1haW5UaHJlYWRXaXRoRGVsYXkodm9pZCAoKmZ1bmMpKHZvaWQqKSwgdm9pZCogY29udGV4 dCwgbG9uZyBsb25nIGRlbGF5TWlsbGlzZWNvbmRzKSB7IH0KIAogICAgIC8vIFdlYkdMIC0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t CiAK