4491 2005-08-17 08:49:47 -0700 DOM L2 Events tests using addEventListener broken 2005-08-17 14:12:28 -0700 1 1 1 Unclassified WebKit DOM 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 curt.arnold darin darin oldest_to_newest 16856 0 curt.arnold 2005-08-17 08:49:47 -0700 The initial load the the DOM L2 Events tests in WebCore/layout-tests/html/level2/events were from a stale snapshot that did not include the changes resulting from the fix to http://www.w3.org/Bugs/Public/ show_bug.cgi?id=1137. The major observable change was that the second parameter to addEventListener should have been monitor.handleEvent and not monitor. 16860 1 3437 curt.arnold 2005-08-17 08:57:34 -0700 Created attachment 3437 Patch for l2 events tests The whitespace in the rendered tests have also been changed since the snapshot. This patch ignores the whitespace changes within the test scripts. The patch does not contain changes to the -expected files that may result from the test changes. Before committing, the -expected.txt's for the modified tests should be deleted and run-webkit-tests run twice (once to produce the -expected.txt and once to make sure they don't change). 16874 2 darin 2005-08-17 11:24:14 -0700 *** Bug 4492 has been marked as a duplicate of this bug. *** 3437 2005-08-17 08:57:34 -0700 2005-08-17 11:25:01 -0700 Patch for l2 events tests events.fix text/plain 5688 curt.arnold SW5kZXg6IGRpc3BhdGNoRXZlbnQwOC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3Qv V2ViQ29yZS9sYXlvdXQtdGVzdHMvZG9tL2h0bWwvbGV2ZWwyL2V2ZW50cy9kaXNwYXRjaEV2ZW50 MDguanMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMQpkaWZmIC1iIC11IC1yMS4xIGRpc3BhdGNo RXZlbnQwOC5qcwotLS0gZGlzcGF0Y2hFdmVudDA4LmpzCTI2IEp1bCAyMDA1IDA4OjM1OjEzIC0w MDAwCTEuMQorKysgZGlzcGF0Y2hFdmVudDA4LmpzCTE3IEF1ZyAyMDA1IDE1OjQ4OjM4IC0wMDAw CkBAIC0xMDUsNyArMTA1LDcgQEAKICAgICAgICAgZG9jUmVmID0gdGhpcy5kb2M7CiAgICAgICB9 CiAgICAgICBkb2MgPSBsb2FkKGRvY1JlZiwgImRvYyIsICJoY19zdGFmZiIpOwotICAgICAgZG9j LmFkZEV2ZW50TGlzdGVuZXIoImZvbyIsbW9uaXRvcixmYWxzZSk7CisgICAgICBkb2MuYWRkRXZl bnRMaXN0ZW5lcigiZm9vIiwgbW9uaXRvci5oYW5kbGVFdmVudCwgZmFsc2UpOwogICAgICAgZXZ0 ID0gZG9jLmNyZWF0ZUV2ZW50KCJFdmVudHMiKTsKICAgICAgIGV2dC5pbml0RXZlbnQoImZvbyIs dHJ1ZSxmYWxzZSk7CiAgICAgICBwcmV2ZW50RGVmYXVsdCA9IGRvYy5kaXNwYXRjaEV2ZW50KGV2 dCk7CkluZGV4OiBkaXNwYXRjaEV2ZW50MDkuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9y b290L1dlYkNvcmUvbGF5b3V0LXRlc3RzL2RvbS9odG1sL2xldmVsMi9ldmVudHMvZGlzcGF0Y2hF dmVudDA5LmpzLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjEKZGlmZiAtYiAtdSAtcjEuMSBkaXNw YXRjaEV2ZW50MDkuanMKLS0tIGRpc3BhdGNoRXZlbnQwOS5qcwkyNiBKdWwgMjAwNSAwODozNTox MyAtMDAwMAkxLjEKKysrIGRpc3BhdGNoRXZlbnQwOS5qcwkxNyBBdWcgMjAwNSAxNTo0ODozOCAt MDAwMApAQCAtMTA1LDcgKzEwNSw3IEBACiAgICAgICAgIGRvY1JlZiA9IHRoaXMuZG9jOwogICAg ICAgfQogICAgICAgZG9jID0gbG9hZChkb2NSZWYsICJkb2MiLCAiaGNfc3RhZmYiKTsKLSAgICAg IGRvYy5hZGRFdmVudExpc3RlbmVyKCJmb28iLG1vbml0b3IsdHJ1ZSk7CisgICAgICBkb2MuYWRk RXZlbnRMaXN0ZW5lcigiZm9vIiwgbW9uaXRvci5oYW5kbGVFdmVudCwgdHJ1ZSk7CiAgICAgICBl dnQgPSBkb2MuY3JlYXRlRXZlbnQoIkV2ZW50cyIpOwogICAgICAgZXZ0LmluaXRFdmVudCgiZm9v Iix0cnVlLGZhbHNlKTsKICAgICAgIHByZXZlbnREZWZhdWx0ID0gZG9jLmRpc3BhdGNoRXZlbnQo ZXZ0KTsKSW5kZXg6IGRpc3BhdGNoRXZlbnQxMC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3Zz L3Jvb3QvV2ViQ29yZS9sYXlvdXQtdGVzdHMvZG9tL2h0bWwvbGV2ZWwyL2V2ZW50cy9kaXNwYXRj aEV2ZW50MTAuanMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMQpkaWZmIC1iIC11IC1yMS4xIGRp c3BhdGNoRXZlbnQxMC5qcwotLS0gZGlzcGF0Y2hFdmVudDEwLmpzCTI2IEp1bCAyMDA1IDA4OjM1 OjEzIC0wMDAwCTEuMQorKysgZGlzcGF0Y2hFdmVudDEwLmpzCTE3IEF1ZyAyMDA1IDE1OjQ4OjM4 IC0wMDAwCkBAIC0xMDUsOCArMTA1LDggQEAKICAgICAgICAgZG9jUmVmID0gdGhpcy5kb2M7CiAg ICAgICB9CiAgICAgICBkb2MgPSBsb2FkKGRvY1JlZiwgImRvYyIsICJoY19zdGFmZiIpOwotICAg ICAgZG9jLmFkZEV2ZW50TGlzdGVuZXIoImZvbyIsbW9uaXRvcixmYWxzZSk7Ci0gICAgICBkb2Mu YWRkRXZlbnRMaXN0ZW5lcigiZm9vIixtb25pdG9yLGZhbHNlKTsKKyAgICAgIGRvYy5hZGRFdmVu dExpc3RlbmVyKCJmb28iLCBtb25pdG9yLmhhbmRsZUV2ZW50LCBmYWxzZSk7CisJIGRvYy5hZGRF dmVudExpc3RlbmVyKCJmb28iLCBtb25pdG9yLmhhbmRsZUV2ZW50LCBmYWxzZSk7CiAgICAgICBl dnQgPSBkb2MuY3JlYXRlRXZlbnQoIkV2ZW50cyIpOwogICAgICAgZXZ0LmluaXRFdmVudCgiZm9v Iix0cnVlLGZhbHNlKTsKICAgICAgIHByZXZlbnREZWZhdWx0ID0gZG9jLmRpc3BhdGNoRXZlbnQo ZXZ0KTsKSW5kZXg6IGRpc3BhdGNoRXZlbnQxMS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3Zz L3Jvb3QvV2ViQ29yZS9sYXlvdXQtdGVzdHMvZG9tL2h0bWwvbGV2ZWwyL2V2ZW50cy9kaXNwYXRj aEV2ZW50MTEuanMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMQpkaWZmIC1iIC11IC1yMS4xIGRp c3BhdGNoRXZlbnQxMS5qcwotLS0gZGlzcGF0Y2hFdmVudDExLmpzCTI2IEp1bCAyMDA1IDA4OjM1 OjEzIC0wMDAwCTEuMQorKysgZGlzcGF0Y2hFdmVudDExLmpzCTE3IEF1ZyAyMDA1IDE1OjQ4OjM4 IC0wMDAwCkBAIC0xMDEsOCArMTAxLDggQEAKICAgICAgICAgZG9jUmVmID0gdGhpcy5kb2M7CiAg ICAgICB9CiAgICAgICBkb2MgPSBsb2FkKGRvY1JlZiwgImRvYyIsICJoY19zdGFmZiIpOwotICAg ICAgZG9jLmFkZEV2ZW50TGlzdGVuZXIoImZvbyIsbW9uaXRvcixmYWxzZSk7Ci0gICAgICBkb2Mu YWRkRXZlbnRMaXN0ZW5lcigiZm9vIixtb25pdG9yLGZhbHNlKTsKKyAgICAgIGRvYy5hZGRFdmVu dExpc3RlbmVyKCJmb28iLCBtb25pdG9yLmhhbmRsZUV2ZW50LCBmYWxzZSk7CisJIGRvYy5hZGRF dmVudExpc3RlbmVyKCJmb28iLCBtb25pdG9yLmhhbmRsZUV2ZW50LCBmYWxzZSk7CiAgICAgICBk b2MucmVtb3ZlRXZlbnRMaXN0ZW5lcigiZm9vIiwgbW9uaXRvci5oYW5kbGVFdmVudCwgZmFsc2Up OwogCSBldnQgPSBkb2MuY3JlYXRlRXZlbnQoIkV2ZW50cyIpOwogICAgICAgZXZ0LmluaXRFdmVu dCgiZm9vIix0cnVlLGZhbHNlKTsKSW5kZXg6IGRpc3BhdGNoRXZlbnQxMi5qcwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29yZS9sYXlvdXQtdGVzdHMvZG9tL2h0bWwvbGV2ZWwy L2V2ZW50cy9kaXNwYXRjaEV2ZW50MTIuanMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMQpkaWZm IC1iIC11IC1yMS4xIGRpc3BhdGNoRXZlbnQxMi5qcwotLS0gZGlzcGF0Y2hFdmVudDEyLmpzCTI2 IEp1bCAyMDA1IDA4OjM1OjEzIC0wMDAwCTEuMQorKysgZGlzcGF0Y2hFdmVudDEyLmpzCTE3IEF1 ZyAyMDA1IDE1OjQ4OjM4IC0wMDAwCkBAIC03NSw2ICs3NSwzMyBAQAogLy9FdmVudE1vbml0b3In cyByZXF1aXJlIGEgZG9jdW1lbnQgbGV2ZWwgdmFyaWFibGUgbmFtZWQgbW9uaXRvcgogdmFyIG1v bml0b3I7CiAJIAorICAgICAvKioKKyAgICAgICogICAgSW5uZXIgY2xhc3MgaW1wbGVtZW50YXRp b24gZm9yIHZhcmlhYmxlIG90aGVyIAorICAgICAgKi8KK3ZhciBvdGhlcjsKKworLyoqCisgICAg ICAgICogQ29uc3RydWN0b3IKKworICAgICAgICAqLworCSAgICAgIAorZnVuY3Rpb24gRXZlbnRM aXN0ZW5lck4xMDAzNSgpIHsgCisgICAgICAgICAgIH0KKyAgIAorICAgICAgICAvKioKKyAgICAg ICAgICogICAgCitUaGlzIG1ldGhvZCBpcyBjYWxsZWQgd2hlbmV2ZXIgYW4gZXZlbnQgb2NjdXJz IG9mIHRoZSB0eXBlIGZvciB3aGljaCB0aGVFdmVudExpc3RlbmVyaW50ZXJmYWNlIHdhcyByZWdp c3RlcmVkLgorCisgICAgICAgICAqIEBwYXJhbSBldnQgCitUaGVFdmVudGNvbnRhaW5zIGNvbnRl eHR1YWwgaW5mb3JtYXRpb24gYWJvdXQgdGhlIGV2ZW50LiBJdCBhbHNvIGNvbnRhaW5zIHRoZXN0 b3BQcm9wYWdhdGlvbmFuZCBwcmV2ZW50RGVmYXVsdG1ldGhvZHMgd2hpY2ggYXJlIHVzZWQgaW4g ZGV0ZXJtaW5pbmcgdGhlIGV2ZW50J3MgZmxvdyBhbmQgZGVmYXVsdCBhY3Rpb24uCisKKyAgICAg ICAgICovCitFdmVudExpc3RlbmVyTjEwMDM1LnByb3RvdHlwZS5oYW5kbGVFdmVudCA9IGZ1bmN0 aW9uKGV2dCkgeworICAgICAgICAgLy8KKyAgICAgICAgIC8vICAgYnJpbmcgY2xhc3MgdmFyaWFi bGVzIGludG8gZnVuY3Rpb24gc2NvcGUKKyAgICAgICAgIC8vCisgICAgICAgIH0KKwogLyoqCiAq IAogQSBtb25pdG9yIGlzIGFkZGVkLCBtdWx0aXBsZSBjYWxscyB0byByZW1vdmVFdmVudExpc3Rl bmVyCkBAIC05NCw3ICsxMjEsNyBAQAogICAgICAgdmFyIHByZXZlbnREZWZhdWx0OwogICAgICAg bW9uaXRvciA9IG5ldyBFdmVudE1vbml0b3IoKTsKICAgICAgIAotICAgICAgb3RoZXIgPSBuZXcg RXZlbnRNb25pdG9yKCk7CisgICAgICBvdGhlciA9IG5ldyBFdmVudExpc3RlbmVyTjEwMDM1KCk7 CiAgICAgICAKICAgICAgIHZhciBldmVudHMgPSBuZXcgQXJyYXkoKTsKIApAQCAtMTA0LDcgKzEz MSw3IEBACiAgICAgICAgIGRvY1JlZiA9IHRoaXMuZG9jOwogICAgICAgfQogICAgICAgZG9jID0g bG9hZChkb2NSZWYsICJkb2MiLCAiaGNfc3RhZmYiKTsKLSAgICAgIGRvYy5hZGRFdmVudExpc3Rl bmVyKCJmb28iLG1vbml0b3IsZmFsc2UpOworICAgICAgZG9jLmFkZEV2ZW50TGlzdGVuZXIoImZv byIsIG1vbml0b3IuaGFuZGxlRXZlbnQsIGZhbHNlKTsKICAgICAgIGRvYy5yZW1vdmVFdmVudExp c3RlbmVyKCJmb28iLCBtb25pdG9yLmhhbmRsZUV2ZW50LCB0cnVlKTsKIAkgZG9jLnJlbW92ZUV2 ZW50TGlzdGVuZXIoImZvb2QiLCBtb25pdG9yLmhhbmRsZUV2ZW50LCBmYWxzZSk7CiAJIGRvYy5y ZW1vdmVFdmVudExpc3RlbmVyKCJmb28iLCBvdGhlci5oYW5kbGVFdmVudCwgZmFsc2UpOwpJbmRl eDogZGlzcGF0Y2hFdmVudDEzLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJD b3JlL2xheW91dC10ZXN0cy9kb20vaHRtbC9sZXZlbDIvZXZlbnRzL2Rpc3BhdGNoRXZlbnQxMy5q cyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xCmRpZmYgLWIgLXUgLXIxLjEgZGlzcGF0Y2hFdmVu dDEzLmpzCi0tLSBkaXNwYXRjaEV2ZW50MTMuanMJMjYgSnVsIDIwMDUgMDg6MzU6MTMgLTAwMDAJ MS4xCisrKyBkaXNwYXRjaEV2ZW50MTMuanMJMTcgQXVnIDIwMDUgMTU6NDg6MzggLTAwMDAKQEAg LTE5Miw4ICsxOTIsOCBAQAogICAgICAgZG9jID0gbG9hZChkb2NSZWYsICJkb2MiLCAiaGNfc3Rh ZmYiKTsKICAgICAgIGxpc3RlbmVyc1tsaXN0ZW5lcnMubGVuZ3RoXSA9IGxpc3RlbmVyMTsKIGxp c3RlbmVyc1tsaXN0ZW5lcnMubGVuZ3RoXSA9IGxpc3RlbmVyMjsKLWRvYy5hZGRFdmVudExpc3Rl bmVyKCJmb28iLGxpc3RlbmVyMSxmYWxzZSk7Ci0gICAgICBkb2MuYWRkRXZlbnRMaXN0ZW5lcigi Zm9vIixsaXN0ZW5lcjIsZmFsc2UpOworZG9jLmFkZEV2ZW50TGlzdGVuZXIoImZvbyIsIGxpc3Rl bmVyMS5oYW5kbGVFdmVudCwgZmFsc2UpOworCSBkb2MuYWRkRXZlbnRMaXN0ZW5lcigiZm9vIiwg bGlzdGVuZXIyLmhhbmRsZUV2ZW50LCBmYWxzZSk7CiAgICAgICBldnQgPSBkb2MuY3JlYXRlRXZl bnQoIkV2ZW50cyIpOwogICAgICAgZXZ0LmluaXRFdmVudCgiZm9vIix0cnVlLGZhbHNlKTsKICAg ICAgIHByZXZlbnREZWZhdWx0ID0gZG9jLmRpc3BhdGNoRXZlbnQoZXZ0KTsK