44764 2010-08-27 06:47:56 -0700 [BREWMP] Add IMemGroup and IMemSpace to OwnPtr type. 2010-09-14 19:31:59 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 33564 0 skyul webkit-unassigned beergun commit-queue tkent webkit.review.bot oldest_to_newest 270469 0 skyul 2010-08-27 06:47:56 -0700 Add IMemGroup and IMemSpace to OwnPtr type. 270470 1 65709 skyul 2010-08-27 06:51:09 -0700 Created attachment 65709 Patch IMemSpace and IMemGroup are used to implement WTF PageAllocation and PageReservation. 270471 2 webkit.review.bot 2010-08-27 06:54:29 -0700 Attachment 65709 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/wtf/brew/OwnPtrBrew.cpp:34: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 270472 3 65710 skyul 2010-08-27 06:57:08 -0700 Created attachment 65710 Patch Fix style error. 278731 4 65710 tkent 2010-09-13 22:37:44 -0700 Comment on attachment 65710 Patch > Index: JavaScriptCore/ChangeLog > =================================================================== > --- JavaScriptCore/ChangeLog (revision 66217) > +++ JavaScriptCore/ChangeLog (working copy) > @@ -1,3 +1,14 @@ > +2010-08-27 Hyung Song <beergun@company100.net> > + Just confirmation: Wasn't it written by Kwang? 279303 5 skyul 2010-09-14 18:36:44 -0700 (In reply to comment #4) > (From update of attachment 65710 [details]) > > Index: JavaScriptCore/ChangeLog > > =================================================================== > > --- JavaScriptCore/ChangeLog (revision 66217) > > +++ JavaScriptCore/ChangeLog (working copy) > > @@ -1,3 +1,14 @@ > > +2010-08-27 Hyung Song <beergun@company100.net> > > + > > Just confirmation: Wasn't it written by Kwang? The ChangeLog is correct. The patch is written by Hyung and I submitted the patch instead of him. He will submit patches by himself next time. 279306 6 tkent 2010-09-14 18:39:53 -0700 > The ChangeLog is correct. The patch is written by Hyung and I submitted the patch instead of him. He will submit patches by himself next time. ok, I understand. 279335 7 65710 commit-queue 2010-09-14 19:31:54 -0700 Comment on attachment 65710 Patch Clearing flags on attachment: 65710 Committed r67529: <http://trac.webkit.org/changeset/67529> 279336 8 commit-queue 2010-09-14 19:31:59 -0700 All reviewed patches have been landed. Closing bug. 65709 2010-08-27 06:51:09 -0700 2010-08-27 06:57:08 -0700 Patch OwnPtr.patch text/plain 2011 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDY2MjE3KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDgtMjcgIEh5dW5nIFNv bmcgIDxiZWVyZ3VuQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtCUkVXTVBdIEFkZCBJTWVtR3JvdXAgYW5kIElNZW1TcGFj ZSB0byBPd25QdHIgdHlwZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQ0NzY0CisKKyAgICAgICAgKiB3dGYvT3duUHRyQ29tbW9uLmg6CisgICAgICAg ICogd3RmL2JyZXcvT3duUHRyQnJldy5jcHA6CisgICAgICAgIChXVEY6OmRlbGV0ZU93bmVkUHRy KToKKwogMjAxMC0wOC0yNyAgQ2hhby15aW5nIEZ1ICA8ZnVAbWlwcy5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvT3duUHRy Q29tbW9uLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL093blB0ckNvbW1vbi5o CShyZXZpc2lvbiA2NjIxNSkKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9Pd25QdHJDb21tb24uaAko d29ya2luZyBjb3B5KQpAQCAtNDYsNiArNDYsOCBAQCB0eXBlZGVmIHN0cnVjdCBfSUZpbGVNZ3Ig SUZpbGVNZ3I7CiB0eXBlZGVmIHN0cnVjdCBfSUZpbGUgSUZpbGU7CiB0eXBlZGVmIHN0cnVjdCBJ Qml0bWFwIElCaXRtYXA7CiB0eXBlZGVmIHN0cnVjdCBJU1NMIElTU0w7Cit0eXBlZGVmIHN0cnVj dCBJTWVtR3JvdXAgSU1lbUdyb3VwOwordHlwZWRlZiBzdHJ1Y3QgSU1lbVNwYWNlIElNZW1TcGFj ZTsKICNlbmRpZgogCiBuYW1lc3BhY2UgV1RGIHsKQEAgLTczLDYgKzc1LDggQEAgbmFtZXNwYWNl IFdURiB7CiAgICAgdm9pZCBkZWxldGVPd25lZFB0cihJQml0bWFwKik7CiAgICAgdm9pZCBkZWxl dGVPd25lZFB0cihJU1NMKik7CiAgICAgdm9pZCBkZWxldGVPd25lZFB0cihJU29ja2V0Kik7Cisg ICAgdm9pZCBkZWxldGVPd25lZFB0cihJTWVtR3JvdXAqKTsKKyAgICB2b2lkIGRlbGV0ZU93bmVk UHRyKElNZW1TcGFjZSopOwogI2VuZGlmCiAKIH0gLy8gbmFtZXNwYWNlIFdURgpJbmRleDogSmF2 YVNjcmlwdENvcmUvd3RmL2JyZXcvT3duUHRyQnJldy5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNj cmlwdENvcmUvd3RmL2JyZXcvT3duUHRyQnJldy5jcHAJKHJldmlzaW9uIDY2MjE1KQorKysgSmF2 YVNjcmlwdENvcmUvd3RmL2JyZXcvT3duUHRyQnJldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMx LDYgKzMxLDggQEAKICNpbmNsdWRlIDxBRUVOZXQuaD4KICNpbmNsdWRlIDxBRUVTU0wuaD4KICNp bmNsdWRlIDxBRUVTdGRMaWIuaD4KKyNpbmNsdWRlIDxBRUVJTWVtR3JvdXAuaD4KKyNpbmNsdWRl IDxBRUVJTWVtU3BhY2UuaD4KIAogbmFtZXNwYWNlIFdURiB7CiAKQEAgLTU4LDYgKzYwLDE4IEBA IHZvaWQgZGVsZXRlT3duZWRQdHIoSVNTTCogcHRyKQogICAgICAgICBJU1NMX1JlbGVhc2UocHRy KTsKIH0KIAordm9pZCBkZWxldGVPd25lZFB0cihJTWVtR3JvdXAqIHB0cikKK3sKKyAgICBpZiAo cHRyKQorICAgICAgICBJTWVtR3JvdXBfUmVsZWFzZShwdHIpOworfQorCit2b2lkIGRlbGV0ZU93 bmVkUHRyKElNZW1TcGFjZSogcHRyKQoreworICAgIGlmIChwdHIpCisgICAgICAgIElNZW1TcGFj ZV9SZWxlYXNlKHB0cik7Cit9CisKIHZvaWQgZGVsZXRlT3duZWRQdHIoSVNvY2tldCogcHRyKQog ewogICAgIGlmIChwdHIpCg== 65710 2010-08-27 06:57:08 -0700 2010-09-14 19:31:54 -0700 Patch OwnPtr.patch text/plain 2038 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDY2MjE3KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDgtMjcgIEh5dW5nIFNv bmcgIDxiZWVyZ3VuQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtCUkVXTVBdIEFkZCBJTWVtR3JvdXAgYW5kIElNZW1TcGFj ZSB0byBPd25QdHIgdHlwZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQ0NzY0CisKKyAgICAgICAgKiB3dGYvT3duUHRyQ29tbW9uLmg6CisgICAgICAg ICogd3RmL2JyZXcvT3duUHRyQnJldy5jcHA6CisgICAgICAgIChXVEY6OmRlbGV0ZU93bmVkUHRy KToKKwogMjAxMC0wOC0yNyAgQ2hhby15aW5nIEZ1ICA8ZnVAbWlwcy5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvT3duUHRy Q29tbW9uLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL093blB0ckNvbW1vbi5o CShyZXZpc2lvbiA2NjIxNSkKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9Pd25QdHJDb21tb24uaAko d29ya2luZyBjb3B5KQpAQCAtNDYsNiArNDYsOCBAQCB0eXBlZGVmIHN0cnVjdCBfSUZpbGVNZ3Ig SUZpbGVNZ3I7CiB0eXBlZGVmIHN0cnVjdCBfSUZpbGUgSUZpbGU7CiB0eXBlZGVmIHN0cnVjdCBJ Qml0bWFwIElCaXRtYXA7CiB0eXBlZGVmIHN0cnVjdCBJU1NMIElTU0w7Cit0eXBlZGVmIHN0cnVj dCBJTWVtR3JvdXAgSU1lbUdyb3VwOwordHlwZWRlZiBzdHJ1Y3QgSU1lbVNwYWNlIElNZW1TcGFj ZTsKICNlbmRpZgogCiBuYW1lc3BhY2UgV1RGIHsKQEAgLTczLDYgKzc1LDggQEAgbmFtZXNwYWNl IFdURiB7CiAgICAgdm9pZCBkZWxldGVPd25lZFB0cihJQml0bWFwKik7CiAgICAgdm9pZCBkZWxl dGVPd25lZFB0cihJU1NMKik7CiAgICAgdm9pZCBkZWxldGVPd25lZFB0cihJU29ja2V0Kik7Cisg ICAgdm9pZCBkZWxldGVPd25lZFB0cihJTWVtR3JvdXAqKTsKKyAgICB2b2lkIGRlbGV0ZU93bmVk UHRyKElNZW1TcGFjZSopOwogI2VuZGlmCiAKIH0gLy8gbmFtZXNwYWNlIFdURgpJbmRleDogSmF2 YVNjcmlwdENvcmUvd3RmL2JyZXcvT3duUHRyQnJldy5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNj cmlwdENvcmUvd3RmL2JyZXcvT3duUHRyQnJldy5jcHAJKHJldmlzaW9uIDY2MjE1KQorKysgSmF2 YVNjcmlwdENvcmUvd3RmL2JyZXcvT3duUHRyQnJldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4 LDYgKzI4LDggQEAKIAogI2luY2x1ZGUgPEFFRUJpdG1hcC5oPgogI2luY2x1ZGUgPEFFRUZpbGUu aD4KKyNpbmNsdWRlIDxBRUVJTWVtR3JvdXAuaD4KKyNpbmNsdWRlIDxBRUVJTWVtU3BhY2UuaD4K ICNpbmNsdWRlIDxBRUVOZXQuaD4KICNpbmNsdWRlIDxBRUVTU0wuaD4KICNpbmNsdWRlIDxBRUVT dGRMaWIuaD4KQEAgLTU4LDYgKzYwLDE4IEBAIHZvaWQgZGVsZXRlT3duZWRQdHIoSVNTTCogcHRy KQogICAgICAgICBJU1NMX1JlbGVhc2UocHRyKTsKIH0KIAordm9pZCBkZWxldGVPd25lZFB0cihJ TWVtR3JvdXAqIHB0cikKK3sKKyAgICBpZiAocHRyKQorICAgICAgICBJTWVtR3JvdXBfUmVsZWFz ZShwdHIpOworfQorCit2b2lkIGRlbGV0ZU93bmVkUHRyKElNZW1TcGFjZSogcHRyKQoreworICAg IGlmIChwdHIpCisgICAgICAgIElNZW1TcGFjZV9SZWxlYXNlKHB0cik7Cit9CisKIHZvaWQgZGVs ZXRlT3duZWRQdHIoSVNvY2tldCogcHRyKQogewogICAgIGlmIChwdHIpCg==