44701 2010-08-26 11:32:35 -0700 [Qt] tst_QWebFrame::hitTestContent() fails on Meego Handset 2010-08-27 16:17:49 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other Other RESOLVED FIXED Qt, QtTriaged P2 Major --- 44675 1 benjamin benjamin ademar commit-queue oldest_to_newest 269995 0 benjamin 2010-08-26 11:32:35 -0700 On Meego Handset, the test tst_QWebFrame::hitTestContent() fails because the hit test content never reports the link: FAIL! : tst_QWebFrame::hitTestContent() Compared values are not the same Actual (result.linkText()): Expected (QString("link text")): link text 269999 1 65589 benjamin 2010-08-26 11:38:18 -0700 Created attachment 65589 Patch to make the test more robust Actually I cannot reproduce the issue on either on my hardware, but it is reported by the integration bot. I suspect the problem is similar to https://bugs.webkit.org/show_bug.cgi?id=44674, the fonts of the test bots are probably different from mine. 270001 2 65589 kenneth 2010-08-26 11:40:58 -0700 Comment on attachment 65589 Patch to make the test more robust WebKit/qt/ChangeLog:5 + [Qt] tst_QWebFrame::hitTestContent() fails on Meego Handset I believe it is called "MeeGo" 270040 3 65589 commit-queue 2010-08-26 12:39:35 -0700 Comment on attachment 65589 Patch to make the test more robust Rejecting patch 65589 from commit-queue. benjamin.poulain@nokia.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights. 270476 4 65589 commit-queue 2010-08-27 07:03:42 -0700 Comment on attachment 65589 Patch to make the test more robust Clearing flags on attachment: 65589 Committed r66219: <http://trac.webkit.org/changeset/66219> 270477 5 commit-queue 2010-08-27 07:03:47 -0700 All reviewed patches have been landed. Closing bug. 270797 6 ademar 2010-08-27 16:17:49 -0700 Revision r66219 cherry-picked into qtwebkit-2.1 with commit a5aac3cdeddc29cfc8cf9151240417518afc2781 65589 2010-08-26 11:38:18 -0700 2010-08-27 07:03:42 -0700 Patch to make the test more robust 44701.patch text/plain 1848 benjamin ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IDk5NjllYmQuLjdiNzExNDkgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEwLTA4LTI2ICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW4ucG91bGFpbkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSB0c3RfUVdlYkZyYW1lOjpo aXRUZXN0Q29udGVudCgpIGZhaWxzIG9uIE1lZWdvIEhhbmRzZXQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0NzAxCisKKyAgICAgICAgTWFrZSB0aGUg dGVzdCBtb3JlIHJvYnVzdC4gVGhlIHBvc2l0aW9uIG9mIHRoZSB0ZXh0IGlzIG5vdCByZWx5aW5n CisgICAgICAgIG9uIHRoZSBzaXplIG9mIHRoZSBmb250cyBhbnltb3JlLgorCisgICAgICAgICog dGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwOgorCiAyMDEwLTA4LTI1ICBMZW8gWWFu ZyAgPGxlby55YW5nQHRvcmNobW9iaWxlLmNvbS5jbj4KIAogICAgICAgICBSZXZpZXdlZCBieSBT aW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBhL1dlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvdHN0 X3F3ZWJmcmFtZS5jcHAgYi9XZWJLaXQvcXQvdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUu Y3BwCmluZGV4IDgzYjg2MDAuLjFiMzliZmEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC90ZXN0cy9x d2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5jcHAKKysrIGIvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFt ZS90c3RfcXdlYmZyYW1lLmNwcApAQCAtMjcxMywxMyArMjcxMywxNCBAQCB2b2lkIHRzdF9RV2Vi RnJhbWU6OmlucHV0RmllbGRGb2N1cygpCiAKIHZvaWQgdHN0X1FXZWJGcmFtZTo6aGl0VGVzdENv bnRlbnQoKQogewotICAgIFFTdHJpbmcgaHRtbCgiPGh0bWw+PGJvZHk+PHA+QSBwYXJhZ3JhcGg8 L3A+PGJyLz48YnIvPjxici8+PGEgaHJlZj1cImFib3V0OmJsYW5rXCIgdGFyZ2V0PVwiX2Zvb1wi PmxpbmsgdGV4dDwvYT48L2JvZHk+PC9odG1sPiIpOworICAgIFFTdHJpbmcgaHRtbCgiPGh0bWw+ PGJvZHk+PHA+QSBwYXJhZ3JhcGg8L3A+PGJyLz48YnIvPjxici8+PGEgaHJlZj1cImFib3V0OmJs YW5rXCIgdGFyZ2V0PVwiX2Zvb1wiIGlkPVwibGlua1wiPmxpbmsgdGV4dDwvYT48L2JvZHk+PC9o dG1sPiIpOwogCiAgICAgUVdlYlBhZ2UgcGFnZTsKICAgICBRV2ViRnJhbWUqIGZyYW1lID0gcGFn ZS5tYWluRnJhbWUoKTsKICAgICBmcmFtZS0+c2V0SHRtbChodG1sKTsKICAgICBwYWdlLnNldFZp ZXdwb3J0U2l6ZShRU2l6ZSgyMDAsIDApKTsgLy9ubyBoZWlnaHQgc28gbGluayBpcyBub3Qgdmlz aWJsZQotICAgIFFXZWJIaXRUZXN0UmVzdWx0IHJlc3VsdCA9IGZyYW1lLT5oaXRUZXN0Q29udGVu dChRUG9pbnQoMTAsIDEwMCkpOworICAgIGNvbnN0IFFXZWJFbGVtZW50IGxpbmtFbGVtZW50ID0g ZnJhbWUtPmRvY3VtZW50RWxlbWVudCgpLmZpbmRGaXJzdChRTGF0aW4xU3RyaW5nKCJhI2xpbmsi KSk7CisgICAgUVdlYkhpdFRlc3RSZXN1bHQgcmVzdWx0ID0gZnJhbWUtPmhpdFRlc3RDb250ZW50 KGxpbmtFbGVtZW50Lmdlb21ldHJ5KCkuY2VudGVyKCkpOwogICAgIFFDT01QQVJFKHJlc3VsdC5s aW5rVGV4dCgpLCBRU3RyaW5nKCJsaW5rIHRleHQiKSk7CiAgICAgUVdlYkVsZW1lbnQgbGluayA9 IHJlc3VsdC5saW5rRWxlbWVudCgpOwogICAgIFFDT01QQVJFKGxpbmsuYXR0cmlidXRlKCJ0YXJn ZXQiKSwgUVN0cmluZygiX2ZvbyIpKTsK