<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>44158</bug_id>
          
          <creation_ts>2010-08-18 02:14:59 -0700</creation_ts>
          <short_desc>[soup] implement ResourceHandle::platformSetDefersLoading</short_desc>
          <delta_ts>2010-12-06 04:32:06 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>44261</dependson>
    
    <dependson>50009</dependson>
          <blocked>44157</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Philippe Normand">pnormand</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>eric</cc>
    
    <cc>mrobinson</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>265997</commentid>
    <comment_count>0</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-08-18 02:14:59 -0700</bug_when>
    <thetext>as in subject, using soup_session_pause_message and soup_session_unpause_message</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>266017</commentid>
    <comment_count>1</comment_count>
      <attachid>64680</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-08-18 03:19:25 -0700</bug_when>
    <thetext>Created attachment 64680
proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>266185</commentid>
    <comment_count>2</comment_count>
      <attachid>64680</attachid>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2010-08-18 10:06:37 -0700</bug_when>
    <thetext>Comment on attachment 64680
proposed patch

I think this is a good thing to have, since other platforms support it, but do we have an idea of what this gains us? Is there a way to test it? It looks like we want to also check whether the message should start deferred: the constructor has a boolean: ResourceHandle(const ResourceRequest&amp;, ResourceHandleClient*, bool defersLoading, bool shouldContentSniff);. Mac checks m_defersLoading when a new message is queued, and pauses it, it seems. I&apos;ll say r- for the lack of checking if we should start deferred, but it would be great if we could know why we are implementing this before we do.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>266191</commentid>
    <comment_count>3</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2010-08-18 10:11:54 -0700</bug_when>
    <thetext>A quick grep shows that this is used throughout WebCore including extensively in PluginStream code to avoid bugs with plugins. It will also soon be used to pause/resume the download in WebKitWebSourceGStreamer.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>266192</commentid>
    <comment_count>4</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2010-08-18 10:12:58 -0700</bug_when>
    <thetext>I should also mention that I originally suggested to pnormand that he use this instead of reimplementing the functionality behind #ifdefs in https://bugs.webkit.org/show_bug.cgi?id=41512 .</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>267205</commentid>
    <comment_count>5</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-08-20 04:48:18 -0700</bug_when>
    <thetext>Oh right, I forgot about this one.

Not sure I have time today but monday for sure I will revise the patch. Thanks kov for this first look at the code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>267855</commentid>
    <comment_count>6</comment_count>
      <attachid>65105</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-08-23 05:08:38 -0700</bug_when>
    <thetext>Created attachment 65105
proposed patch

About a test that would cover this I was thinking that maybe bug 42152
could be a good candidate but not sure yet. Opinions?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>267926</commentid>
    <comment_count>7</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2010-08-23 08:39:36 -0700</bug_when>
    <thetext>Yes, that&apos;s an excellent idea. If you implement those things, pass the test and then add them to this patch I will r+ it. Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>269749</commentid>
    <comment_count>8</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-08-25 23:41:49 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; Yes, that&apos;s an excellent idea. If you implement those things, pass the test and then add them to this patch I will r+ it. Thanks!

Filed a patch there but I only had to add the required DRT stuff to make the test pass, so not sure anymore it is a good test to test this patch ;)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>271444</commentid>
    <comment_count>9</comment_count>
      <attachid>65917</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-08-30 08:38:24 -0700</bug_when>
    <thetext>Created attachment 65917
proposed patch

Added a check for d-&gt;m_msg before using it and a note about GIO</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>271466</commentid>
    <comment_count>10</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-08-30 09:35:11 -0700</bug_when>
    <thetext>The WebCore/manual-tests/xhr-failure-behind-alert.html test triggers the platformSetDefersLoading() code path but in that case d-&gt;m_msg is NULL because no connection to the server was made (because none is running at 127.0.0.1:7 ...) ;)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>271520</commentid>
    <comment_count>11</comment_count>
      <attachid>65917</attachid>
    <who name="Dan Winship">danw</who>
    <bug_when>2010-08-30 11:35:23 -0700</bug_when>
    <thetext>Comment on attachment 65917
proposed patch

&gt;      soup_session_queue_message(session, d-&gt;m_msg, finishedCallback, handle);
&gt;  
&gt; +    if (d-&gt;m_defersLoading)
&gt; +        soup_session_pause_message(session, d-&gt;m_msg);

This won&apos;t work; pause/unpause are sort of lame, and only work once I/O has actually started (eg, after the message has been assigned to a connection). If you want the message to be deferred right away, you need to just not queue it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>271985</commentid>
    <comment_count>12</comment_count>
      <attachid>65917</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-08-31 01:56:21 -0700</bug_when>
    <thetext>Comment on attachment 65917
proposed patch

Unmarking for review, I think it&apos;d be better to wait the patch from bug 44261 to land so we can implement a better patch for this bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>296220</commentid>
    <comment_count>13</comment_count>
      <attachid>71174</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-10-19 09:01:56 -0700</bug_when>
    <thetext>Created attachment 71174
updated patch

As Dan suggested, in startHttp I avoid sending the requested if it&apos;s
initially deferred.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>296224</commentid>
    <comment_count>14</comment_count>
      <attachid>71176</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-10-19 09:07:59 -0700</bug_when>
    <thetext>Created attachment 71176
updated patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>296240</commentid>
    <comment_count>15</comment_count>
      <attachid>71176</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2010-10-19 09:48:32 -0700</bug_when>
    <thetext>Comment on attachment 71176
updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71176&amp;action=review

&gt; WebCore/platform/network/soup/ResourceHandleSoup.cpp:739
&gt; +    // Only supported for http(s) transfers. Something similar would
&gt; +    // probably be needed for data transfers done with GIO.

This comment is inaccurate now that data URLs are handled by soup, I think. :)

&gt; WebCore/platform/network/soup/ResourceHandleSoup.cpp:746
&gt; +    else
&gt; +        soup_session_unpause_message(defaultSession(), d-&gt;m_soupMessage.get());

I think this presents a problem. The time between the creation of m_soupRequest and m_soupMessage is an asynchronous call. If setDefersLoading(...) was called while that call was in progress, the message would not be paused properly. Perhaps there should be a companion call to soup_session_pause_message if the message is m_defersLoading is true in sendRequestCallback.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>296695</commentid>
    <comment_count>16</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-10-20 01:26:11 -0700</bug_when>
    <thetext>(In reply to comment #15)
&gt; (From update of attachment 71176 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=71176&amp;action=review
&gt; 
&gt; &gt; WebCore/platform/network/soup/ResourceHandleSoup.cpp:739
&gt; &gt; +    // Only supported for http(s) transfers. Something similar would
&gt; &gt; +    // probably be needed for data transfers done with GIO.
&gt; 
&gt; This comment is inaccurate now that data URLs are handled by soup, I think. :)
&gt; 

Well I think it&apos;s still accurate ;) m_soupMessage is created only in startHttp(). startData and the data uri loading doesn&apos;t use it, afaics.

&gt; &gt; WebCore/platform/network/soup/ResourceHandleSoup.cpp:746
&gt; &gt; +    else
&gt; &gt; +        soup_session_unpause_message(defaultSession(), d-&gt;m_soupMessage.get());
&gt; 
&gt; I think this presents a problem. The time between the creation of m_soupRequest and m_soupMessage is an asynchronous call. If setDefersLoading(...) was called while that call was in progress, the message would not be paused properly. Perhaps there should be a companion call to soup_session_pause_message if the message is m_defersLoading is true in sendRequestCallback.

Hum, that&apos;s right indeed. Will send a new patch, thanks for reviewing :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>297762</commentid>
    <comment_count>17</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2010-10-21 18:00:01 -0700</bug_when>
    <thetext>This should be fixed since r67722. Closing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>297850</commentid>
    <comment_count>18</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-10-21 23:42:54 -0700</bug_when>
    <thetext>How come a style bot commit have fixed this bug?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>298000</commentid>
    <comment_count>19</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2010-10-22 08:54:50 -0700</bug_when>
    <thetext>(In reply to comment #18)
&gt; How come a style bot commit have fixed this bug?

Sorry, wrong bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>312857</commentid>
    <comment_count>20</comment_count>
      <attachid>74669</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-11-23 08:17:09 -0800</bug_when>
    <thetext>Created attachment 74669
updated patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>312865</commentid>
    <comment_count>21</comment_count>
      <attachid>74669</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2010-11-23 08:36:38 -0800</bug_when>
    <thetext>Comment on attachment 74669
updated patch

Great.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>313158</commentid>
    <comment_count>22</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-11-24 00:26:38 -0800</bug_when>
    <thetext>Committed r72647: &lt;http://trac.webkit.org/changeset/72647&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>313169</commentid>
    <comment_count>23</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-11-24 01:21:21 -0800</bug_when>
    <thetext>This patch broke the build (yes I checked here before landing :/). Rollout is in progress, see bug 50009</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>313174</commentid>
    <comment_count>24</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-11-24 01:32:56 -0800</bug_when>
    <thetext>http://trac.webkit.org/changeset/72647 might have broken GTK Linux 32-bit Release</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>317524</commentid>
    <comment_count>25</comment_count>
      <attachid>75664</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-12-06 03:38:36 -0800</bug_when>
    <thetext>Created attachment 75664
updated patch

The tests were failing because loadResourceSynchronously() was
creating a deferred ResourceHandle.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>317548</commentid>
    <comment_count>26</comment_count>
      <attachid>75664</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2010-12-06 04:25:16 -0800</bug_when>
    <thetext>Comment on attachment 75664
updated patch

Nice catch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>317553</commentid>
    <comment_count>27</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-12-06 04:32:06 -0800</bug_when>
    <thetext>Committed r73357: &lt;http://trac.webkit.org/changeset/73357&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>64680</attachid>
            <date>2010-08-18 03:19:25 -0700</date>
            <delta_ts>2010-08-23 05:08:38 -0700</delta_ts>
            <desc>proposed patch</desc>
            <filename>proposed-patch.patch</filename>
            <type>text/plain</type>
            <size>1750</size>
            <attacher name="Philippe Normand">pnormand</attacher>
            
              <data encoding="base64">RnJvbSBhYWZiYTdjNTJhNzdiZWFjMDliMTFkMzQwODg4ZjkyZDE4MzBlMjYwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t
PgpEYXRlOiBXZWQsIDE4IEF1ZyAyMDEwIDExOjE2OjU1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g
cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgfCAgIDExICsrKysrKysrKysrCiAuLi4vcGxhdGZvcm0vbmV0d29yay9z
b3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAgICB8ICAgIDcgKysrKystLQogMiBmaWxlcyBjaGFu
Z2VkLCAxNiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNv
cmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWQyNmYxOC4uZWY3M2IzMyAx
MDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg
LTEsMyArMSwxNCBAQAorMjAxMC0wOC0xOCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGln
YWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgW3NvdXBdIGltcGxlbWVudCBSZXNvdXJjZUhhbmRsZTo6cGxhdGZvcm1TZXREZWZlcnNMb2Fk
aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDE1
OAorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5j
cHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6cGxhdGZvcm1TZXREZWZlcnNM
b2FkaW5nKTogSW1wbGVtZW50ZWQKKyAgICAgICAgdXNpbmcgdGhlIHNvdXBfc2Vzc2lvbl97LHVu
fXBhdXNlX21lc3NhZ2UgQVBJcy4KKwogMjAxMC0wOC0xOCAgU2hpbmljaGlybyBIYW1hamkgIDxo
YW1hamlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtv
di4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFu
ZGxlU291cC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRs
ZVNvdXAuY3BwCmluZGV4IDk2YTJmMjUuLmY5ZmVlOTMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxh
dGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKKysrIGIvV2ViQ29yZS9w
bGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcApAQCAtNjM3LDkgKzYz
NywxMiBAQCBib29sIFJlc291cmNlSGFuZGxlOjpzdXBwb3J0c0J1ZmZlcmVkRGF0YSgpCiAgICAg
cmV0dXJuIGZhbHNlOwogfQogCi12b2lkIFJlc291cmNlSGFuZGxlOjpwbGF0Zm9ybVNldERlZmVy
c0xvYWRpbmcoYm9vbCkKK3ZvaWQgUmVzb3VyY2VIYW5kbGU6OnBsYXRmb3JtU2V0RGVmZXJzTG9h
ZGluZyhib29sIGRlZmVyc0xvYWRpbmcpCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICBp
ZiAoZGVmZXJzTG9hZGluZykKKyAgICAgICAgc291cF9zZXNzaW9uX3BhdXNlX21lc3NhZ2UoZGVm
YXVsdFNlc3Npb24oKSwgZC0+bV9tc2cpOworICAgIGVsc2UKKyAgICAgICAgc291cF9zZXNzaW9u
X3VucGF1c2VfbWVzc2FnZShkZWZhdWx0U2Vzc2lvbigpLCBkLT5tX21zZyk7CiB9CiAKIGJvb2wg
UmVzb3VyY2VIYW5kbGU6OmxvYWRzQmxvY2tlZCgpCi0tIAoxLjcuMQ==
</data>
<flag name="review"
          id="53301"
          type_id="1"
          status="-"
          setter="gustavo"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>65105</attachid>
            <date>2010-08-23 05:08:38 -0700</date>
            <delta_ts>2010-08-30 08:38:24 -0700</delta_ts>
            <desc>proposed patch</desc>
            <filename>proposed-patch.patch</filename>
            <type>text/plain</type>
            <size>2115</size>
            <attacher name="Philippe Normand">pnormand</attacher>
            
              <data encoding="base64">RnJvbSBiNGU4MmRjNWU4MjBlMDY4YzU2NDllMjg3M2EwZDVhYThmMzY4MjZhIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t
PgpEYXRlOiBNb24sIDIzIEF1ZyAyMDEwIDA5OjIwOjIzICswMjAwClN1YmplY3Q6IFtQQVRDSF0g
cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgfCAgIDExICsrKysrKysrKysrCiAuLi4vcGxhdGZvcm0vbmV0d29yay9z
b3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAgICB8ICAgMTIgKysrKysrKysrKy0tCiAyIGZpbGVz
IGNoYW5nZWQsIDIxIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv
V2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkM2M5MjE2Li5mYWNl
NWI2IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxv
ZwpAQCAtMSwzICsxLDE0IEBACisyMDEwLTA4LTE4ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1h
bmRAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICBbc291cF0gaW1wbGVtZW50IFJlc291cmNlSGFuZGxlOjpwbGF0Zm9ybVNldERlZmVy
c0xvYWRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTQ0MTU4CisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVT
b3VwLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlOjpwbGF0Zm9ybVNldERl
ZmVyc0xvYWRpbmcpOiBJbXBsZW1lbnRlZAorICAgICAgICB1c2luZyB0aGUgc291cF9zZXNzaW9u
X3ssdW59cGF1c2VfbWVzc2FnZSBBUElzLgorCiAyMDEwLTA4LTIzICBNaWtoYWlsIE5hZ2Fub3Yg
IDxtbmFnYW5vdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVs
ZG1hbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNl
SGFuZGxlU291cC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhh
bmRsZVNvdXAuY3BwCmluZGV4IDk2YTJmMjUuLjc3MDJjMGQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv
cGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKKysrIGIvV2ViQ29y
ZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcApAQCAtNTc1LDYg
KzU3NSw5IEBAIHN0YXRpYyBib29sIHN0YXJ0SHR0cChSZXNvdXJjZUhhbmRsZSogaGFuZGxlKQog
ICAgIGdfb2JqZWN0X3JlZihkLT5tX21zZyk7CiAgICAgc291cF9zZXNzaW9uX3F1ZXVlX21lc3Nh
Z2Uoc2Vzc2lvbiwgZC0+bV9tc2csIGZpbmlzaGVkQ2FsbGJhY2ssIGhhbmRsZSk7CiAKKyAgICBp
ZiAoZC0+bV9kZWZlcnNMb2FkaW5nKQorICAgICAgICBzb3VwX3Nlc3Npb25fcGF1c2VfbWVzc2Fn
ZShzZXNzaW9uLCBkLT5tX21zZyk7CisKICAgICByZXR1cm4gdHJ1ZTsKIH0KIApAQCAtNjM3LDkg
KzY0MCwxNCBAQCBib29sIFJlc291cmNlSGFuZGxlOjpzdXBwb3J0c0J1ZmZlcmVkRGF0YSgpCiAg
ICAgcmV0dXJuIGZhbHNlOwogfQogCi12b2lkIFJlc291cmNlSGFuZGxlOjpwbGF0Zm9ybVNldERl
ZmVyc0xvYWRpbmcoYm9vbCkKK3ZvaWQgUmVzb3VyY2VIYW5kbGU6OnBsYXRmb3JtU2V0RGVmZXJz
TG9hZGluZyhib29sIGRlZmVyc0xvYWRpbmcpCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKKyAg
ICAvLyBJbml0aWFsIGltcGxlbWVudGF0aW9uIG9mIHRoaXMgbWV0aG9kIHdhcyByZXF1aXJlZCBm
b3IgYnVnICM0NDE1Ny4KKworICAgIGlmIChkZWZlcnNMb2FkaW5nKQorICAgICAgICBzb3VwX3Nl
c3Npb25fcGF1c2VfbWVzc2FnZShkZWZhdWx0U2Vzc2lvbigpLCBkLT5tX21zZyk7CisgICAgZWxz
ZQorICAgICAgICBzb3VwX3Nlc3Npb25fdW5wYXVzZV9tZXNzYWdlKGRlZmF1bHRTZXNzaW9uKCks
IGQtPm1fbXNnKTsKIH0KIAogYm9vbCBSZXNvdXJjZUhhbmRsZTo6bG9hZHNCbG9ja2VkKCkKLS0g
CjEuNy4x
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>65917</attachid>
            <date>2010-08-30 08:38:24 -0700</date>
            <delta_ts>2010-10-19 09:01:56 -0700</delta_ts>
            <desc>proposed patch</desc>
            <filename>proposed-patch.patch</filename>
            <type>text/plain</type>
            <size>2291</size>
            <attacher name="Philippe Normand">pnormand</attacher>
            
              <data encoding="base64">RnJvbSA4ZDg4MjMyYjQ4OTk0ZTUzMTZkZGRiZTQ3ODdkNjZjNzU2NWFkMjU3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t
PgpEYXRlOiBNb24sIDIzIEF1ZyAyMDEwIDA5OjIwOjIzICswMjAwClN1YmplY3Q6IFtQQVRDSF0g
cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgfCAgIDExICsrKysrKysrKysrCiAuLi4vcGxhdGZvcm0vbmV0d29yay9z
b3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAgICB8ICAgMTcgKysrKysrKysrKysrKysrLS0KIDIg
ZmlsZXMgY2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1n
aXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDZlMWY5N2Qu
LjllYzdmY2IgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDgtMTggIFBoaWxpcHBlIE5vcm1hbmQgIDxw
bm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIFtzb3VwXSBpbXBsZW1lbnQgUmVzb3VyY2VIYW5kbGU6OnBsYXRmb3JtU2V0
RGVmZXJzTG9hZGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9NDQxNTgKKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhh
bmRsZVNvdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OnBsYXRmb3Jt
U2V0RGVmZXJzTG9hZGluZyk6IEltcGxlbWVudGVkCisgICAgICAgIHVzaW5nIHRoZSBzb3VwX3Nl
c3Npb25feyx1bn1wYXVzZV9tZXNzYWdlIEFQSXMuCisKIDIwMTAtMDgtMzAgIFBhdmVsIEZlbGRt
YW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBT
ZW1pa2hhdHNreS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jl
c291cmNlSGFuZGxlU291cC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNv
dXJjZUhhbmRsZVNvdXAuY3BwCmluZGV4IDk2YTJmMjUuLjM0Yzg2NWQgMTAwNjQ0Ci0tLSBhL1dl
YkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKKysrIGIv
V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcApAQCAt
NTc1LDYgKzU3NSw5IEBAIHN0YXRpYyBib29sIHN0YXJ0SHR0cChSZXNvdXJjZUhhbmRsZSogaGFu
ZGxlKQogICAgIGdfb2JqZWN0X3JlZihkLT5tX21zZyk7CiAgICAgc291cF9zZXNzaW9uX3F1ZXVl
X21lc3NhZ2Uoc2Vzc2lvbiwgZC0+bV9tc2csIGZpbmlzaGVkQ2FsbGJhY2ssIGhhbmRsZSk7CiAK
KyAgICBpZiAoZC0+bV9kZWZlcnNMb2FkaW5nKQorICAgICAgICBzb3VwX3Nlc3Npb25fcGF1c2Vf
bWVzc2FnZShzZXNzaW9uLCBkLT5tX21zZyk7CisKICAgICByZXR1cm4gdHJ1ZTsKIH0KIApAQCAt
NjM3LDkgKzY0MCwxOSBAQCBib29sIFJlc291cmNlSGFuZGxlOjpzdXBwb3J0c0J1ZmZlcmVkRGF0
YSgpCiAgICAgcmV0dXJuIGZhbHNlOwogfQogCi12b2lkIFJlc291cmNlSGFuZGxlOjpwbGF0Zm9y
bVNldERlZmVyc0xvYWRpbmcoYm9vbCkKK3ZvaWQgUmVzb3VyY2VIYW5kbGU6OnBsYXRmb3JtU2V0
RGVmZXJzTG9hZGluZyhib29sIGRlZmVyc0xvYWRpbmcpCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQo
KTsKKyAgICAvLyBJbml0aWFsIGltcGxlbWVudGF0aW9uIG9mIHRoaXMgbWV0aG9kIHdhcyByZXF1
aXJlZCBmb3IgYnVnICM0NDE1Ny4KKworICAgIC8vIE9ubHkgc3VwcG9ydGVkIGZvciBodHRwKHMp
IHRyYW5zZmVycy4gU29tZXRoaW5nIHNpbWlsYXIgd291bGQKKyAgICAvLyBwcm9iYWJseSBiZSBu
ZWVkZWQgZm9yIGRhdGEgdHJhbnNmZXJzIGRvbmUgd2l0aCBHSU8uCisgICAgaWYgKCFkLT5tX21z
ZykKKyAgICAgICAgcmV0dXJuOworCisgICAgaWYgKGRlZmVyc0xvYWRpbmcpCisgICAgICAgIHNv
dXBfc2Vzc2lvbl9wYXVzZV9tZXNzYWdlKGRlZmF1bHRTZXNzaW9uKCksIGQtPm1fbXNnKTsKKyAg
ICBlbHNlCisgICAgICAgIHNvdXBfc2Vzc2lvbl91bnBhdXNlX21lc3NhZ2UoZGVmYXVsdFNlc3Np
b24oKSwgZC0+bV9tc2cpOwogfQogCiBib29sIFJlc291cmNlSGFuZGxlOjpsb2Fkc0Jsb2NrZWQo
KQotLSAKMS43LjE=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>71174</attachid>
            <date>2010-10-19 09:01:56 -0700</date>
            <delta_ts>2010-10-19 09:07:59 -0700</delta_ts>
            <desc>updated patch</desc>
            <filename>updated-patch.patch</filename>
            <type>text/plain</type>
            <size>3108</size>
            <attacher name="Philippe Normand">pnormand</attacher>
            
              <data encoding="base64">RnJvbSBmNzRhZTU4YmVmNjk5YWUxNjZhZGI4MWM5NmVkN2I2NDhkOTZlMmEwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t
PgpEYXRlOiBUdWUsIDE5IE9jdCAyMDEwIDE4OjAyOjU2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g
dXBkYXRlZCBwYXRjaAoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICB8ICAgMTEgKysrKysrKwogLi4uL3BsYXRmb3JtL25ldHdvcmsvc291cC9S
ZXNvdXJjZUhhbmRsZVNvdXAuY3BwICAgfCAgIDMyICsrKysrKysrKysrKysrKysrLS0KIDIgZmls
ZXMgY2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg
YS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDlmYjFlNTQuLjI5
NGNiNWIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdl
TG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDgtMTggIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9y
bWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgIFtzb3VwXSBpbXBsZW1lbnQgUmVzb3VyY2VIYW5kbGU6OnBsYXRmb3JtU2V0RGVm
ZXJzTG9hZGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9NDQxNTgKKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRs
ZVNvdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OnBsYXRmb3JtU2V0
RGVmZXJzTG9hZGluZyk6IEltcGxlbWVudGVkCisgICAgICAgIHVzaW5nIHRoZSBzb3VwX3Nlc3Np
b25feyx1bn1wYXVzZV9tZXNzYWdlIEFQSXMuCisKIDIwMTAtMTAtMTkgIFBoaWxpcHBlIE5vcm1h
bmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFhhbiBMb3Bl
ei4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFu
ZGxlU291cC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRs
ZVNvdXAuY3BwCmluZGV4IDA1YzY1OWYuLjBmNWQ0NjYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxh
dGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKKysrIGIvV2ViQ29yZS9w
bGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcApAQCAtNjU0LDggKzY1
NCwxMSBAQCBzdGF0aWMgYm9vbCBzdGFydEh0dHAoUmVzb3VyY2VIYW5kbGUqIGhhbmRsZSkKICAg
ICBpZiAoIXNvdXBfbWVzc2FnZV9oZWFkZXJzX2dldF9vbmUoc291cE1lc3NhZ2UtPnJlcXVlc3Rf
aGVhZGVycywgIkFjY2VwdCIpKQogICAgICAgICBzb3VwX21lc3NhZ2VfaGVhZGVyc19hcHBlbmQo
c291cE1lc3NhZ2UtPnJlcXVlc3RfaGVhZGVycywgIkFjY2VwdCIsICIqLyoiKTsKIAotICAgIGQt
Pm1fY2FuY2VsbGFibGUgPSBhZG9wdFBsYXRmb3JtUmVmKGdfY2FuY2VsbGFibGVfbmV3KCkpOwot
ICAgIHdlYmtpdF9zb3VwX3JlcXVlc3Rfc2VuZF9hc3luYyhkLT5tX3NvdXBSZXF1ZXN0LmdldCgp
LCBkLT5tX2NhbmNlbGxhYmxlLmdldCgpLCBzZW5kUmVxdWVzdENhbGxiYWNrLCAwKTsKKyAgICAv
LyBTZW5kIHRoZSByZXF1ZXN0IG9ubHkgaWYgaXQncyBub3QgYmVlbiBleHBsaWNpdGVseSBkZWZl
cnJlZC4KKyAgICBpZiAoIWQtPm1fZGVmZXJzTG9hZGluZykgeworICAgICAgICBkLT5tX2NhbmNl
bGxhYmxlID0gYWRvcHRQbGF0Zm9ybVJlZihnX2NhbmNlbGxhYmxlX25ldygpKTsKKyAgICAgICAg
d2Via2l0X3NvdXBfcmVxdWVzdF9zZW5kX2FzeW5jKGQtPm1fc291cFJlcXVlc3QuZ2V0KCksIGQt
Pm1fY2FuY2VsbGFibGUuZ2V0KCksIHNlbmRSZXF1ZXN0Q2FsbGJhY2ssIDApOworICAgIH0KIAog
ICAgIHJldHVybiB0cnVlOwogfQpAQCAtNzE5LDkgKzcyMiwzMCBAQCBib29sIFJlc291cmNlSGFu
ZGxlOjpzdXBwb3J0c0J1ZmZlcmVkRGF0YSgpCiAgICAgcmV0dXJuIGZhbHNlOwogfQogCi12b2lk
IFJlc291cmNlSGFuZGxlOjpwbGF0Zm9ybVNldERlZmVyc0xvYWRpbmcoYm9vbCkKK3ZvaWQgUmVz
b3VyY2VIYW5kbGU6OnBsYXRmb3JtU2V0RGVmZXJzTG9hZGluZyhib29sIGRlZmVyc0xvYWRpbmcp
CiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICAvLyBJbml0aWFsIGltcGxlbWVudGF0aW9u
IG9mIHRoaXMgbWV0aG9kIHdhcyByZXF1aXJlZCBmb3IgYnVnICM0NDE1Ny4KKworICAgIGlmIChk
LT5tX2NhbmNlbGxlZCkKKyAgICAgICAgcmV0dXJuOworCisgICAgaWYgKCFkLT5tX2NhbmNlbGxh
YmxlICYmIGQtPm1fc291cFJlcXVlc3QuZ2V0KCkpIHsKKyAgICAgICAgaWYgKCFkZWZlcnNMb2Fk
aW5nKSB7CisgICAgICAgICAgICBkLT5tX2NhbmNlbGxhYmxlID0gYWRvcHRQbGF0Zm9ybVJlZihn
X2NhbmNlbGxhYmxlX25ldygpKTsKKyAgICAgICAgICAgIHdlYmtpdF9zb3VwX3JlcXVlc3Rfc2Vu
ZF9hc3luYyhkLT5tX3NvdXBSZXF1ZXN0LmdldCgpLCBkLT5tX2NhbmNlbGxhYmxlLmdldCgpLCBz
ZW5kUmVxdWVzdENhbGxiYWNrLCAwKTsKKyAgICAgICAgfQorICAgICAgICByZXR1cm47CisgICAg
fQorCisgICAgLy8gT25seSBzdXBwb3J0ZWQgZm9yIGh0dHAocykgdHJhbnNmZXJzLiBTb21ldGhp
bmcgc2ltaWxhciB3b3VsZAorICAgIC8vIHByb2JhYmx5IGJlIG5lZWRlZCBmb3IgZGF0YSB0cmFu
c2ZlcnMgZG9uZSB3aXRoIEdJTy4KKyAgICBpZiAoIWQtPm1fc291cE1lc3NhZ2UpCisgICAgICAg
IHJldHVybjsKKworICAgIGlmIChkZWZlcnNMb2FkaW5nKQorICAgICAgICBzb3VwX3Nlc3Npb25f
cGF1c2VfbWVzc2FnZShkZWZhdWx0U2Vzc2lvbigpLCBkLT5tX3NvdXBNZXNzYWdlLmdldCgpKTsK
KyAgICBlbHNlCisgICAgICAgIHNvdXBfc2Vzc2lvbl91bnBhdXNlX21lc3NhZ2UoZGVmYXVsdFNl
c3Npb24oKSwgZC0+bV9zb3VwTWVzc2FnZS5nZXQoKSk7CiB9CiAKIGJvb2wgUmVzb3VyY2VIYW5k
bGU6OmxvYWRzQmxvY2tlZCgpCi0tIAoxLjcuMi4z
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>71176</attachid>
            <date>2010-10-19 09:07:59 -0700</date>
            <delta_ts>2010-11-23 08:17:09 -0800</delta_ts>
            <desc>updated patch</desc>
            <filename>updated-patch.patch</filename>
            <type>text/plain</type>
            <size>3076</size>
            <attacher name="Philippe Normand">pnormand</attacher>
            
              <data encoding="base64">RnJvbSA5NmZiOTViMWM2OGI3Yzg2MWNkNjI0ZTIzZmM3ZjVhNmNmODY2MDI2IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t
PgpEYXRlOiBUdWUsIDE5IE9jdCAyMDEwIDE4OjA5OjA1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g
dXBkYXRlZCBwYXRjaAoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICB8ICAgMTEgKysrKysrKwogLi4uL3BsYXRmb3JtL25ldHdvcmsvc291cC9S
ZXNvdXJjZUhhbmRsZVNvdXAuY3BwICAgfCAgIDMwICsrKysrKysrKysrKysrKysrLS0KIDIgZmls
ZXMgY2hhbmdlZCwgMzcgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg
YS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDlmYjFlNTQuLjI5
NGNiNWIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdl
TG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDgtMTggIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9y
bWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgIFtzb3VwXSBpbXBsZW1lbnQgUmVzb3VyY2VIYW5kbGU6OnBsYXRmb3JtU2V0RGVm
ZXJzTG9hZGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9NDQxNTgKKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRs
ZVNvdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OnBsYXRmb3JtU2V0
RGVmZXJzTG9hZGluZyk6IEltcGxlbWVudGVkCisgICAgICAgIHVzaW5nIHRoZSBzb3VwX3Nlc3Np
b25feyx1bn1wYXVzZV9tZXNzYWdlIEFQSXMuCisKIDIwMTAtMTAtMTkgIFBoaWxpcHBlIE5vcm1h
bmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFhhbiBMb3Bl
ei4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFu
ZGxlU291cC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRs
ZVNvdXAuY3BwCmluZGV4IDA1YzY1OWYuLmE4NWVhODcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxh
dGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKKysrIGIvV2ViQ29yZS9w
bGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcApAQCAtNjU0LDggKzY1
NCwxMSBAQCBzdGF0aWMgYm9vbCBzdGFydEh0dHAoUmVzb3VyY2VIYW5kbGUqIGhhbmRsZSkKICAg
ICBpZiAoIXNvdXBfbWVzc2FnZV9oZWFkZXJzX2dldF9vbmUoc291cE1lc3NhZ2UtPnJlcXVlc3Rf
aGVhZGVycywgIkFjY2VwdCIpKQogICAgICAgICBzb3VwX21lc3NhZ2VfaGVhZGVyc19hcHBlbmQo
c291cE1lc3NhZ2UtPnJlcXVlc3RfaGVhZGVycywgIkFjY2VwdCIsICIqLyoiKTsKIAotICAgIGQt
Pm1fY2FuY2VsbGFibGUgPSBhZG9wdFBsYXRmb3JtUmVmKGdfY2FuY2VsbGFibGVfbmV3KCkpOwot
ICAgIHdlYmtpdF9zb3VwX3JlcXVlc3Rfc2VuZF9hc3luYyhkLT5tX3NvdXBSZXF1ZXN0LmdldCgp
LCBkLT5tX2NhbmNlbGxhYmxlLmdldCgpLCBzZW5kUmVxdWVzdENhbGxiYWNrLCAwKTsKKyAgICAv
LyBTZW5kIHRoZSByZXF1ZXN0IG9ubHkgaWYgaXQncyBub3QgYmVlbiBleHBsaWNpdGVseSBkZWZl
cnJlZC4KKyAgICBpZiAoIWQtPm1fZGVmZXJzTG9hZGluZykgeworICAgICAgICBkLT5tX2NhbmNl
bGxhYmxlID0gYWRvcHRQbGF0Zm9ybVJlZihnX2NhbmNlbGxhYmxlX25ldygpKTsKKyAgICAgICAg
d2Via2l0X3NvdXBfcmVxdWVzdF9zZW5kX2FzeW5jKGQtPm1fc291cFJlcXVlc3QuZ2V0KCksIGQt
Pm1fY2FuY2VsbGFibGUuZ2V0KCksIHNlbmRSZXF1ZXN0Q2FsbGJhY2ssIDApOworICAgIH0KIAog
ICAgIHJldHVybiB0cnVlOwogfQpAQCAtNzE5LDkgKzcyMiwyOCBAQCBib29sIFJlc291cmNlSGFu
ZGxlOjpzdXBwb3J0c0J1ZmZlcmVkRGF0YSgpCiAgICAgcmV0dXJuIGZhbHNlOwogfQogCi12b2lk
IFJlc291cmNlSGFuZGxlOjpwbGF0Zm9ybVNldERlZmVyc0xvYWRpbmcoYm9vbCkKK3ZvaWQgUmVz
b3VyY2VIYW5kbGU6OnBsYXRmb3JtU2V0RGVmZXJzTG9hZGluZyhib29sIGRlZmVyc0xvYWRpbmcp
CiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICAvLyBJbml0aWFsIGltcGxlbWVudGF0aW9u
IG9mIHRoaXMgbWV0aG9kIHdhcyByZXF1aXJlZCBmb3IgYnVnICM0NDE1Ny4KKworICAgIGlmIChk
LT5tX2NhbmNlbGxlZCkKKyAgICAgICAgcmV0dXJuOworCisgICAgaWYgKCFkZWZlcnNMb2FkaW5n
ICYmICFkLT5tX2NhbmNlbGxhYmxlICYmIGQtPm1fc291cFJlcXVlc3QuZ2V0KCkpIHsKKyAgICAg
ICAgZC0+bV9jYW5jZWxsYWJsZSA9IGFkb3B0UGxhdGZvcm1SZWYoZ19jYW5jZWxsYWJsZV9uZXco
KSk7CisgICAgICAgIHdlYmtpdF9zb3VwX3JlcXVlc3Rfc2VuZF9hc3luYyhkLT5tX3NvdXBSZXF1
ZXN0LmdldCgpLCBkLT5tX2NhbmNlbGxhYmxlLmdldCgpLCBzZW5kUmVxdWVzdENhbGxiYWNrLCAw
KTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKworICAgIC8vIE9ubHkgc3VwcG9ydGVkIGZvciBo
dHRwKHMpIHRyYW5zZmVycy4gU29tZXRoaW5nIHNpbWlsYXIgd291bGQKKyAgICAvLyBwcm9iYWJs
eSBiZSBuZWVkZWQgZm9yIGRhdGEgdHJhbnNmZXJzIGRvbmUgd2l0aCBHSU8uCisgICAgaWYgKCFk
LT5tX3NvdXBNZXNzYWdlKQorICAgICAgICByZXR1cm47CisKKyAgICBpZiAoZGVmZXJzTG9hZGlu
ZykKKyAgICAgICAgc291cF9zZXNzaW9uX3BhdXNlX21lc3NhZ2UoZGVmYXVsdFNlc3Npb24oKSwg
ZC0+bV9zb3VwTWVzc2FnZS5nZXQoKSk7CisgICAgZWxzZQorICAgICAgICBzb3VwX3Nlc3Npb25f
dW5wYXVzZV9tZXNzYWdlKGRlZmF1bHRTZXNzaW9uKCksIGQtPm1fc291cE1lc3NhZ2UuZ2V0KCkp
OwogfQogCiBib29sIFJlc291cmNlSGFuZGxlOjpsb2Fkc0Jsb2NrZWQoKQotLSAKMS43LjIuMw==
</data>
<flag name="review"
          id="61169"
          type_id="1"
          status="-"
          setter="mrobinson"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>74669</attachid>
            <date>2010-11-23 08:17:09 -0800</date>
            <delta_ts>2010-12-06 03:38:36 -0800</delta_ts>
            <desc>updated patch</desc>
            <filename>updated-patch.patch</filename>
            <type>text/plain</type>
            <size>3495</size>
            <attacher name="Philippe Normand">pnormand</attacher>
            
              <data encoding="base64">RnJvbSA2MDJmYTJiMDc0ZWFiN2QyYWYzZTViMGI2NzI1MjBiNDNkOGYyNmZiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t
PgpEYXRlOiBUdWUsIDE5IE9jdCAyMDEwIDE4OjA5OjA1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g
dXBkYXRlZCBwYXRjaAoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICB8ICAgMTEgKysrKysrCiAuLi4vcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jl
c291cmNlSGFuZGxlU291cC5jcHAgICB8ICAgMzMgKysrKysrKysrKysrKysrKystLQogMiBmaWxl
cyBjaGFuZ2VkLCA0MCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh
L1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTFmNzJhOC4uZWU0
NWE3NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VM
b2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0xMS0yMyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3Jt
YW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgW3NvdXBdIGltcGxlbWVudCBSZXNvdXJjZUhhbmRsZTo6cGxhdGZvcm1TZXREZWZl
cnNMb2FkaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD00NDE1OAorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxl
U291cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6cGxhdGZvcm1TZXRE
ZWZlcnNMb2FkaW5nKTogSW1wbGVtZW50ZWQKKyAgICAgICAgdXNpbmcgdGhlIHNvdXBfc2Vzc2lv
bl97LHVufXBhdXNlX21lc3NhZ2UgQVBJcy4KKwogMjAxMC0xMS0yMyAgSmVyZW15IE9ybG93ICA8
am9ybG93QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBTdGV2ZSBCbG9jay4K
ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxl
U291cC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNv
dXAuY3BwCmluZGV4IDBmOTc4NjcuLjdhMTA4NGUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZv
cm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0
Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcApAQCAtNTQ1LDYgKzU0NSw5
IEBAIHN0YXRpYyB2b2lkIHNlbmRSZXF1ZXN0Q2FsbGJhY2soR09iamVjdCogc291cmNlLCBHQXN5
bmNSZXN1bHQqIHJlcywgZ3BvaW50ZXIgdXNlCiAgICAgICAgIH0KICAgICB9CiAKKyAgICBpZiAo
ZC0+bV9kZWZlcnNMb2FkaW5nKQorICAgICAgICAgc291cF9zZXNzaW9uX3BhdXNlX21lc3NhZ2Uo
aGFuZGxlLT5kZWZhdWx0U2Vzc2lvbigpLCBkLT5tX3NvdXBNZXNzYWdlLmdldCgpKTsKKwogICAg
IGdfaW5wdXRfc3RyZWFtX3JlYWRfYXN5bmMoZC0+bV9pbnB1dFN0cmVhbS5nZXQoKSwgZC0+bV9i
dWZmZXIsIFJFQURfQlVGRkVSX1NJWkUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBH
X1BSSU9SSVRZX0RFRkFVTFQsIGQtPm1fY2FuY2VsbGFibGUuZ2V0KCksIHJlYWRDYWxsYmFjaywg
MCk7CiB9CkBAIC02NTQsOCArNjU3LDExIEBAIHN0YXRpYyBib29sIHN0YXJ0SHR0cChSZXNvdXJj
ZUhhbmRsZSogaGFuZGxlKQogICAgIGlmICghc291cF9tZXNzYWdlX2hlYWRlcnNfZ2V0X29uZShz
b3VwTWVzc2FnZS0+cmVxdWVzdF9oZWFkZXJzLCAiQWNjZXB0IikpCiAgICAgICAgIHNvdXBfbWVz
c2FnZV9oZWFkZXJzX2FwcGVuZChzb3VwTWVzc2FnZS0+cmVxdWVzdF9oZWFkZXJzLCAiQWNjZXB0
IiwgIiovKiIpOwogCi0gICAgZC0+bV9jYW5jZWxsYWJsZSA9IGFkb3B0UGxhdGZvcm1SZWYoZ19j
YW5jZWxsYWJsZV9uZXcoKSk7Ci0gICAgd2Via2l0X3NvdXBfcmVxdWVzdF9zZW5kX2FzeW5jKGQt
Pm1fc291cFJlcXVlc3QuZ2V0KCksIGQtPm1fY2FuY2VsbGFibGUuZ2V0KCksIHNlbmRSZXF1ZXN0
Q2FsbGJhY2ssIDApOworICAgIC8vIFNlbmQgdGhlIHJlcXVlc3Qgb25seSBpZiBpdCdzIG5vdCBi
ZWVuIGV4cGxpY2l0ZWx5IGRlZmVycmVkLgorICAgIGlmICghZC0+bV9kZWZlcnNMb2FkaW5nKSB7
CisgICAgICAgIGQtPm1fY2FuY2VsbGFibGUgPSBhZG9wdFBsYXRmb3JtUmVmKGdfY2FuY2VsbGFi
bGVfbmV3KCkpOworICAgICAgICB3ZWJraXRfc291cF9yZXF1ZXN0X3NlbmRfYXN5bmMoZC0+bV9z
b3VwUmVxdWVzdC5nZXQoKSwgZC0+bV9jYW5jZWxsYWJsZS5nZXQoKSwgc2VuZFJlcXVlc3RDYWxs
YmFjaywgMCk7CisgICAgfQogCiAgICAgcmV0dXJuIHRydWU7CiB9CkBAIC03MjgsOSArNzM0LDI4
IEBAIGJvb2wgUmVzb3VyY2VIYW5kbGU6OnN1cHBvcnRzQnVmZmVyZWREYXRhKCkKICAgICByZXR1
cm4gZmFsc2U7CiB9CiAKLXZvaWQgUmVzb3VyY2VIYW5kbGU6OnBsYXRmb3JtU2V0RGVmZXJzTG9h
ZGluZyhib29sKQordm9pZCBSZXNvdXJjZUhhbmRsZTo6cGxhdGZvcm1TZXREZWZlcnNMb2FkaW5n
KGJvb2wgZGVmZXJzTG9hZGluZykKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIC8vIElu
aXRpYWwgaW1wbGVtZW50YXRpb24gb2YgdGhpcyBtZXRob2Qgd2FzIHJlcXVpcmVkIGZvciBidWcg
IzQ0MTU3LgorCisgICAgaWYgKGQtPm1fY2FuY2VsbGVkKQorICAgICAgICByZXR1cm47CisKKyAg
ICBpZiAoIWRlZmVyc0xvYWRpbmcgJiYgIWQtPm1fY2FuY2VsbGFibGUgJiYgZC0+bV9zb3VwUmVx
dWVzdC5nZXQoKSkgeworICAgICAgICBkLT5tX2NhbmNlbGxhYmxlID0gYWRvcHRQbGF0Zm9ybVJl
ZihnX2NhbmNlbGxhYmxlX25ldygpKTsKKyAgICAgICAgd2Via2l0X3NvdXBfcmVxdWVzdF9zZW5k
X2FzeW5jKGQtPm1fc291cFJlcXVlc3QuZ2V0KCksIGQtPm1fY2FuY2VsbGFibGUuZ2V0KCksIHNl
bmRSZXF1ZXN0Q2FsbGJhY2ssIDApOworICAgICAgICByZXR1cm47CisgICAgfQorCisgICAgLy8g
T25seSBzdXBwb3J0ZWQgZm9yIGh0dHAocykgdHJhbnNmZXJzLiBTb21ldGhpbmcgc2ltaWxhciB3
b3VsZAorICAgIC8vIHByb2JhYmx5IGJlIG5lZWRlZCBmb3IgZGF0YSB0cmFuc2ZlcnMgZG9uZSB3
aXRoIEdJTy4KKyAgICBpZiAoIWQtPm1fc291cE1lc3NhZ2UpCisgICAgICAgIHJldHVybjsKKwor
ICAgIGlmIChkZWZlcnNMb2FkaW5nKQorICAgICAgICBzb3VwX3Nlc3Npb25fcGF1c2VfbWVzc2Fn
ZShkZWZhdWx0U2Vzc2lvbigpLCBkLT5tX3NvdXBNZXNzYWdlLmdldCgpKTsKKyAgICBlbHNlCisg
ICAgICAgIHNvdXBfc2Vzc2lvbl91bnBhdXNlX21lc3NhZ2UoZGVmYXVsdFNlc3Npb24oKSwgZC0+
bV9zb3VwTWVzc2FnZS5nZXQoKSk7CiB9CiAKIGJvb2wgUmVzb3VyY2VIYW5kbGU6OmxvYWRzQmxv
Y2tlZCgpCi0tIAoxLjcuMi4z
</data>
<flag name="review"
          id="65331"
          type_id="1"
          status="+"
          setter="mrobinson"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>75664</attachid>
            <date>2010-12-06 03:38:36 -0800</date>
            <delta_ts>2010-12-06 04:25:16 -0800</delta_ts>
            <desc>updated patch</desc>
            <filename>updated-patch.patch</filename>
            <type>text/plain</type>
            <size>4092</size>
            <attacher name="Philippe Normand">pnormand</attacher>
            
              <data encoding="base64">RnJvbSAwMzBkMTliNWRlZDM0NGZkYWM2ODhkZDE2NDBlYmJjNGMyMmM2Yjk3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t
PgpEYXRlOiBNb24sIDYgRGVjIDIwMTAgMTI6Mzc6MDUgKzAxMDAKU3ViamVjdDogW1BBVENIXSB1
cGRhdGVkIHBhdGNoCgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIHwgICAxMSArKysrKysKIC4uLi9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVz
b3VyY2VIYW5kbGVTb3VwLmNwcCAgIHwgICAzNSArKysrKysrKysrKysrKysrKy0tLQogMiBmaWxl
cyBjaGFuZ2VkLCA0MSBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh
L1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjA4OGQ5Yi4uZjQx
MDJiNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VM
b2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0xMi0wNiAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3Jt
YW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgor
CisgICAgICAgIFtzb3VwXSBpbXBsZW1lbnQgUmVzb3VyY2VIYW5kbGU6OnBsYXRmb3JtU2V0RGVm
ZXJzTG9hZGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9NDQxNTgKKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRs
ZVNvdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OnBsYXRmb3JtU2V0
RGVmZXJzTG9hZGluZyk6IEltcGxlbWVudGVkCisgICAgICAgIHVzaW5nIHRoZSBzb3VwX3Nlc3Np
b25feyx1bn1wYXVzZV9tZXNzYWdlIEFQSXMuCisKIDIwMTAtMTItMDUgIEtlbnQgVGFtdXJhICA8
dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFJ1biBzb3J0LVhjb2Rl
LXByb2plY3QtZmlsZS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3Vw
L1Jlc291cmNlSGFuZGxlU291cC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9S
ZXNvdXJjZUhhbmRsZVNvdXAuY3BwCmluZGV4IGEzZmZlYjIuLjA5ZTFlYmUgMTAwNjQ0Ci0tLSBh
L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKKysr
IGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcApA
QCAtNTUwLDYgKzU1MCw5IEBAIHN0YXRpYyB2b2lkIHNlbmRSZXF1ZXN0Q2FsbGJhY2soR09iamVj
dCogc291cmNlLCBHQXN5bmNSZXN1bHQqIHJlcywgZ3BvaW50ZXIgdXNlCiAgICAgICAgIH0KICAg
ICB9CiAKKyAgICBpZiAoZC0+bV9kZWZlcnNMb2FkaW5nKQorICAgICAgICAgc291cF9zZXNzaW9u
X3BhdXNlX21lc3NhZ2UoaGFuZGxlLT5kZWZhdWx0U2Vzc2lvbigpLCBkLT5tX3NvdXBNZXNzYWdl
LmdldCgpKTsKKwogICAgIGdfaW5wdXRfc3RyZWFtX3JlYWRfYXN5bmMoZC0+bV9pbnB1dFN0cmVh
bS5nZXQoKSwgZC0+bV9idWZmZXIsIFJFQURfQlVGRkVSX1NJWkUsCiAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBHX1BSSU9SSVRZX0RFRkFVTFQsIGQtPm1fY2FuY2VsbGFibGUuZ2V0KCks
IHJlYWRDYWxsYmFjaywgMCk7CiB9CkBAIC02NjAsOCArNjYzLDExIEBAIHN0YXRpYyBib29sIHN0
YXJ0SHR0cChSZXNvdXJjZUhhbmRsZSogaGFuZGxlKQogICAgIGlmICghc291cF9tZXNzYWdlX2hl
YWRlcnNfZ2V0X29uZShzb3VwTWVzc2FnZS0+cmVxdWVzdF9oZWFkZXJzLCAiQWNjZXB0IikpCiAg
ICAgICAgIHNvdXBfbWVzc2FnZV9oZWFkZXJzX2FwcGVuZChzb3VwTWVzc2FnZS0+cmVxdWVzdF9o
ZWFkZXJzLCAiQWNjZXB0IiwgIiovKiIpOwogCi0gICAgZC0+bV9jYW5jZWxsYWJsZSA9IGFkb3B0
UGxhdGZvcm1SZWYoZ19jYW5jZWxsYWJsZV9uZXcoKSk7Ci0gICAgd2Via2l0X3NvdXBfcmVxdWVz
dF9zZW5kX2FzeW5jKGQtPm1fc291cFJlcXVlc3QuZ2V0KCksIGQtPm1fY2FuY2VsbGFibGUuZ2V0
KCksIHNlbmRSZXF1ZXN0Q2FsbGJhY2ssIDApOworICAgIC8vIFNlbmQgdGhlIHJlcXVlc3Qgb25s
eSBpZiBpdCdzIG5vdCBiZWVuIGV4cGxpY2l0ZWx5IGRlZmVycmVkLgorICAgIGlmICghZC0+bV9k
ZWZlcnNMb2FkaW5nKSB7CisgICAgICAgIGQtPm1fY2FuY2VsbGFibGUgPSBhZG9wdFBsYXRmb3Jt
UmVmKGdfY2FuY2VsbGFibGVfbmV3KCkpOworICAgICAgICB3ZWJraXRfc291cF9yZXF1ZXN0X3Nl
bmRfYXN5bmMoZC0+bV9zb3VwUmVxdWVzdC5nZXQoKSwgZC0+bV9jYW5jZWxsYWJsZS5nZXQoKSwg
c2VuZFJlcXVlc3RDYWxsYmFjaywgMCk7CisgICAgfQogCiAgICAgcmV0dXJuIHRydWU7CiB9CkBA
IC03MzQsOSArNzQwLDI4IEBAIGJvb2wgUmVzb3VyY2VIYW5kbGU6OnN1cHBvcnRzQnVmZmVyZWRE
YXRhKCkKICAgICByZXR1cm4gZmFsc2U7CiB9CiAKLXZvaWQgUmVzb3VyY2VIYW5kbGU6OnBsYXRm
b3JtU2V0RGVmZXJzTG9hZGluZyhib29sKQordm9pZCBSZXNvdXJjZUhhbmRsZTo6cGxhdGZvcm1T
ZXREZWZlcnNMb2FkaW5nKGJvb2wgZGVmZXJzTG9hZGluZykKIHsKLSAgICBub3RJbXBsZW1lbnRl
ZCgpOworICAgIC8vIEluaXRpYWwgaW1wbGVtZW50YXRpb24gb2YgdGhpcyBtZXRob2Qgd2FzIHJl
cXVpcmVkIGZvciBidWcgIzQ0MTU3LgorCisgICAgaWYgKGQtPm1fY2FuY2VsbGVkKQorICAgICAg
ICByZXR1cm47CisKKyAgICBpZiAoIWRlZmVyc0xvYWRpbmcgJiYgIWQtPm1fY2FuY2VsbGFibGUg
JiYgZC0+bV9zb3VwUmVxdWVzdC5nZXQoKSkgeworICAgICAgICBkLT5tX2NhbmNlbGxhYmxlID0g
YWRvcHRQbGF0Zm9ybVJlZihnX2NhbmNlbGxhYmxlX25ldygpKTsKKyAgICAgICAgd2Via2l0X3Nv
dXBfcmVxdWVzdF9zZW5kX2FzeW5jKGQtPm1fc291cFJlcXVlc3QuZ2V0KCksIGQtPm1fY2FuY2Vs
bGFibGUuZ2V0KCksIHNlbmRSZXF1ZXN0Q2FsbGJhY2ssIDApOworICAgICAgICByZXR1cm47Cisg
ICAgfQorCisgICAgLy8gT25seSBzdXBwb3J0ZWQgZm9yIGh0dHAocykgdHJhbnNmZXJzLiBTb21l
dGhpbmcgc2ltaWxhciB3b3VsZAorICAgIC8vIHByb2JhYmx5IGJlIG5lZWRlZCBmb3IgZGF0YSB0
cmFuc2ZlcnMgZG9uZSB3aXRoIEdJTy4KKyAgICBpZiAoIWQtPm1fc291cE1lc3NhZ2UpCisgICAg
ICAgIHJldHVybjsKKworICAgIGlmIChkZWZlcnNMb2FkaW5nKQorICAgICAgICBzb3VwX3Nlc3Np
b25fcGF1c2VfbWVzc2FnZShkZWZhdWx0U2Vzc2lvbigpLCBkLT5tX3NvdXBNZXNzYWdlLmdldCgp
KTsKKyAgICBlbHNlCisgICAgICAgIHNvdXBfc2Vzc2lvbl91bnBhdXNlX21lc3NhZ2UoZGVmYXVs
dFNlc3Npb24oKSwgZC0+bV9zb3VwTWVzc2FnZS5nZXQoKSk7CiB9CiAKIGJvb2wgUmVzb3VyY2VI
YW5kbGU6OmxvYWRzQmxvY2tlZCgpCkBAIC03NTgsNyArNzgzLDcgQEAgdm9pZCBSZXNvdXJjZUhh
bmRsZTo6bG9hZFJlc291cmNlU3luY2hyb25vdXNseShOZXR3b3JraW5nQ29udGV4dCogY29udGV4
dCwgY29uc3QKICAgICAvLyBGSVhNRTogd2Ugc2hvdWxkIHVzZSB0aGUgUmVzb3VyY2VIYW5kbGU6
OmNyZWF0ZSBtZXRob2QgaGVyZSwKICAgICAvLyBidXQgaXQgbWFrZXMgdXMgdGltZW91dCBpbiBh
IGNvdXBsZSBvZiB0ZXN0cy4gU2VlCiAgICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTQxODIzCi0gICAgUmVmUHRyPFJlc291cmNlSGFuZGxlPiBoYW5kbGUgPSBh
ZG9wdFJlZihuZXcgUmVzb3VyY2VIYW5kbGUocmVxdWVzdCwgJnN5bmNMb2FkZXIsIHRydWUsIGZh
bHNlKSk7CisgICAgUmVmUHRyPFJlc291cmNlSGFuZGxlPiBoYW5kbGUgPSBhZG9wdFJlZihuZXcg
UmVzb3VyY2VIYW5kbGUocmVxdWVzdCwgJnN5bmNMb2FkZXIsIGZhbHNlIC8qZGVmZXJzTG9hZGlu
ZyovLCBmYWxzZSAvKnNob3VsZENvbnRlbnRTbmlmZiovKSk7CiAgICAgaGFuZGxlLT5zdGFydChj
b250ZXh0KTsKIAogICAgIHN5bmNMb2FkZXIucnVuKCk7Ci0tIAoxLjcuMy4z
</data>
<flag name="review"
          id="66497"
          type_id="1"
          status="+"
          setter="mrobinson"
    />
          </attachment>
      

    </bug>

</bugzilla>