43978 2010-08-13 08:55:51 -0700 [CMake] Set target properties only if available 2010-08-14 08:18:23 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 43906 0 paroga webkit-unassigned commit-queue leandro zimmermann oldest_to_newest 264392 0 paroga 2010-08-13 08:55:51 -0700 CMake throws an error if you call e.g. ADD_TARGET_PROPERTIES with an empty argument. 264402 1 64351 paroga 2010-08-13 09:22:30 -0700 Created attachment 64351 Patch 264426 2 leandro 2010-08-13 10:15:00 -0700 I'm not a reviewer, but the patch looks fine to me. 264686 3 64351 commit-queue 2010-08-14 08:18:18 -0700 Comment on attachment 64351 Patch Clearing flags on attachment: 64351 Committed r65366: <http://trac.webkit.org/changeset/65366> 264687 4 commit-queue 2010-08-14 08:18:23 -0700 All reviewed patches have been landed. Closing bug. 64351 2010-08-13 09:22:30 -0700 2010-08-14 08:18:18 -0700 Patch 0001-CMake-target-properties.patch text/plain 5716 paroga ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0IGIvSmF2YVNjcmlwdENv cmUvQ01ha2VMaXN0cy50eHQKaW5kZXggYTk0NDM2My4uNGE4NGRlYyAxMDA2NDQKLS0tIGEvSmF2 YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0 cy50eHQKQEAgLTI2NCw3ICsyNjQsMTAgQEAgSU5DTFVERV9ESVJFQ1RPUklFUygke0phdmFTY3Jp cHRDb3JlX0lOQ0xVREVfRElSRUNUT1JJRVN9KQogQUREX0RFRklOSVRJT05TKC1EQlVJTERJTkdf SmF2YVNjcmlwdENvcmUpCiBBRERfTElCUkFSWSgke0phdmFTY3JpcHRDb3JlX0xJQlJBUllfTkFN RX0gJHtKYXZhU2NyaXB0Q29yZV9MSUJSQVJZX1RZUEV9ICR7SmF2YVNjcmlwdENvcmVfSEVBREVS U30gJHtKYXZhU2NyaXB0Q29yZV9TT1VSQ0VTfSkKIFRBUkdFVF9MSU5LX0xJQlJBUklFUygke0ph dmFTY3JpcHRDb3JlX0xJQlJBUllfTkFNRX0gJHtKYXZhU2NyaXB0Q29yZV9MSUJSQVJJRVN9KQot QUREX1RBUkdFVF9QUk9QRVJUSUVTKCR7SmF2YVNjcmlwdENvcmVfTElCUkFSWV9OQU1FfSBMSU5L X0ZMQUdTICR7SmF2YVNjcmlwdENvcmVfTElOS19GTEFHU30pCisKK0lGICgke0phdmFTY3JpcHRD b3JlX0xJTktfRkxBR1N9KQorICAgIEFERF9UQVJHRVRfUFJPUEVSVElFUygke0phdmFTY3JpcHRD b3JlX0xJQlJBUllfTkFNRX0gTElOS19GTEFHUyAiJHtKYXZhU2NyaXB0Q29yZV9MSU5LX0ZMQUdT fSIpCitFTkRJRiAoKQogCiBJRiAoU0hBUkVEX0NPUkUpCiAgICAgU0VUX1RBUkdFVF9QUk9QRVJU SUVTKCR7SmF2YVNjcmlwdENvcmVfTElCUkFSWV9OQU1FfSBQUk9QRVJUSUVTIFZFUlNJT04gJHtQ Uk9KRUNUX1ZFUlNJT059IFNPVkVSU0lPTiAke1BST0pFQ1RfVkVSU0lPTl9NQUpPUn0pCmRpZmYg LS1naXQgYS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM b2cKaW5kZXggMDI0ZTY4Yy4uNTk3MTI1YyAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nCisrKyBiL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisy MDEwLTA4LTEzICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUBwYXJvZ2EuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDTWFrZV0gU2V0IHRh cmdldCBwcm9wZXJ0aWVzIG9ubHkgaWYgYXZhaWxhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Mzk3OAorCisgICAgICAgICogQ01ha2VMaXN0cy50 eHQ6CisgICAgICAgICoganNjL0NNYWtlTGlzdHMudHh0OgorICAgICAgICAqIHd0Zi9DTWFrZUxp c3RzLnR4dDoKKwogMjAxMC0wOC0xMyAgR2Fib3IgTG9raSAgPGxva2lAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBHYXZpbiBCYXJyYWNsb3VnaC4KZGlmZiAtLWdpdCBhL0phdmFT Y3JpcHRDb3JlL2pzYy9DTWFrZUxpc3RzLnR4dCBiL0phdmFTY3JpcHRDb3JlL2pzYy9DTWFrZUxp c3RzLnR4dAppbmRleCA3NTZiYTkyLi45ZDc5MmYwIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9qc2MvQ01ha2VMaXN0cy50eHQKKysrIGIvSmF2YVNjcmlwdENvcmUvanNjL0NNYWtlTGlzdHMu dHh0CkBAIC0xNSw1ICsxNSwxMSBAQCBXRUJLSVRfV1JBUF9TT1VSQ0VMSVNUKCR7SlNDX1NPVVJD RVN9KQogSU5DTFVERV9ESVJFQ1RPUklFUyguLyAke0phdmFTY3JpcHRDb3JlX0lOQ0xVREVfRElS RUNUT1JJRVN9KQogQUREX0VYRUNVVEFCTEUoJHtKU0NfRVhFQ1VUQUJMRV9OQU1FfSAke0pTQ19I RUFERVJTfSAke0pTQ19TT1VSQ0VTfSkKIFRBUkdFVF9MSU5LX0xJQlJBUklFUygke0pTQ19FWEVD VVRBQkxFX05BTUV9ICR7SlNDX0xJQlJBUklFU30pCi1BRERfVEFSR0VUX1BST1BFUlRJRVMoJHtK U0NfRVhFQ1VUQUJMRV9OQU1FfSBMSU5LX0ZMQUdTICR7SlNDX0xJTktfRkxBR1N9KQotU0VUX1RB UkdFVF9QUk9QRVJUSUVTKCR7SlNDX0VYRUNVVEFCTEVfTkFNRX0gUFJPUEVSVElFUyBWRVJTSU9O ICR7UFJPSkVDVF9WRVJTSU9OfSkKKworSUYgKCR7SlNDX0xJTktfRkxBR1N9KQorICAgIEFERF9U QVJHRVRfUFJPUEVSVElFUygke0pTQ19FWEVDVVRBQkxFX05BTUV9IExJTktfRkxBR1MgIiR7SlND X0xJTktfRkxBR1N9IikKK0VORElGICgpCisKK0lGIChTSEFSRURfQ09SRSkKKyAgICBTRVRfVEFS R0VUX1BST1BFUlRJRVMoJHtKU0NfRVhFQ1VUQUJMRV9OQU1FfSBQUk9QRVJUSUVTIFZFUlNJT04g JHtQUk9KRUNUX1ZFUlNJT059KQorRU5ESUYgKCkKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3Jl L3d0Zi9DTWFrZUxpc3RzLnR4dCBiL0phdmFTY3JpcHRDb3JlL3d0Zi9DTWFrZUxpc3RzLnR4dApp bmRleCA1Y2YxMDhmLi43OTQ0NTQ3IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvQ01h a2VMaXN0cy50eHQKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL0NNYWtlTGlzdHMudHh0CkBAIC0z OSw3ICszOSw5IEBAIEFERF9ERUZJTklUSU9OUygtREJVSUxESU5HX1dURikKIEFERF9MSUJSQVJZ KCR7V1RGX0xJQlJBUllfTkFNRX0gJHtXVEZfTElCUkFSWV9UWVBFfSAke1dURl9TT1VSQ0VTfSkK IFRBUkdFVF9MSU5LX0xJQlJBUklFUygke1dURl9MSUJSQVJZX05BTUV9ICR7V1RGX0xJQlJBUklF U30pCiAKLUFERF9UQVJHRVRfUFJPUEVSVElFUygke1dURl9MSUJSQVJZX05BTUV9IExJTktfRkxB R1MgJHtXVEZfTElOS19GTEFHU30pCitJRiAoJHtXVEZfTElOS19GTEFHU30pCisgICAgQUREX1RB UkdFVF9QUk9QRVJUSUVTKCR7V1RGX0xJQlJBUllfTkFNRX0gTElOS19GTEFHUyAiJHtXVEZfTElO S19GTEFHU30iKQorRU5ESUYgKCkKIAogSUYgKFNIQVJFRF9DT1JFKQogICAgIFNFVF9UQVJHRVRf UFJPUEVSVElFUygke1dURl9MSUJSQVJZX05BTUV9IFBST1BFUlRJRVMgVkVSU0lPTiAke1BST0pF Q1RfVkVSU0lPTn0gU09WRVJTSU9OICR7UFJPSkVDVF9WRVJTSU9OX01BSk9SfSkKZGlmZiAtLWdp dCBhL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQgYi9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CmluZGV4 IDQzN2RlMjMuLjI5Zjg4YTkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKKysr IGIvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dApAQCAtMTkxNiw4ICsxOTE2LDEwIEBAIEFERF9ERUZJ TklUSU9OUygtREJVSUxESU5HX1dlYkNvcmUpCiBJTkNMVURFX0RJUkVDVE9SSUVTKCR7V2ViQ29y ZV9JTkNMVURFX0RJUkVDVE9SSUVTfSkKIEFERF9MSUJSQVJZKCR7V2ViQ29yZV9MSUJSQVJZX05B TUV9ICR7V2ViQ29yZV9MSUJSQVJZX1RZUEV9ICR7V2ViQ29yZV9TT1VSQ0VTfSkKIFRBUkdFVF9M SU5LX0xJQlJBUklFUygke1dlYkNvcmVfTElCUkFSWV9OQU1FfSAke1dlYkNvcmVfTElCUkFSSUVT fSkKLUFERF9UQVJHRVRfUFJPUEVSVElFUygke1dlYkNvcmVfTElCUkFSWV9OQU1FfSBMSU5LX0ZM QUdTICR7V2ViQ29yZV9MSU5LX0ZMQUdTfSkKIAorSUYgKCR7V2ViQ29yZV9MSU5LX0ZMQUdTfSkK KyAgICBBRERfVEFSR0VUX1BST1BFUlRJRVMoJHtXZWJDb3JlX0xJQlJBUllfTkFNRX0gTElOS19G TEFHUyAiJHtXZWJDb3JlX0xJTktfRkxBR1N9IikKK0VORElGICgpCiAKIElGIChTSEFSRURfQ09S RSkKICAgICBTRVRfVEFSR0VUX1BST1BFUlRJRVMoJHtXZWJDb3JlX0xJQlJBUllfTkFNRX0gUFJP UEVSVElFUyBWRVJTSU9OICR7UFJPSkVDVF9WRVJTSU9OfSBTT1ZFUlNJT04gJHtQUk9KRUNUX1ZF UlNJT05fTUFKT1J9KQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzMWIwMzBlLi5jYmEzNjFlIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5n ZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEwLTA4LTEz ICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUBwYXJvZ2EuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDTWFrZV0gU2V0IHRhcmdldCBwcm9w ZXJ0aWVzIG9ubHkgaWYgYXZhaWxhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00Mzk3OAorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisKIDIw MTAtMDgtMTIgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0BjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCmRpZmYgLS1naXQgYS9XZWJLaXQvQ01ha2VM aXN0cy50eHQgYi9XZWJLaXQvQ01ha2VMaXN0cy50eHQKaW5kZXggM2ZlZTJjNi4uMmQyNzI5MyAx MDA2NDQKLS0tIGEvV2ViS2l0L0NNYWtlTGlzdHMudHh0CisrKyBiL1dlYktpdC9DTWFrZUxpc3Rz LnR4dApAQCAtNjYsOCArNjYsMTIgQEAgQUREX0RFRklOSVRJT05TKC1EQlVJTERJTkdfV2ViS2l0 KQogSU5DTFVERV9ESVJFQ1RPUklFUygke1dlYktpdF9JTkNMVURFX0RJUkVDVE9SSUVTfSkKIEFE RF9MSUJSQVJZKCR7V2ViS2l0X0xJQlJBUllfTkFNRX0gJHtXZWJLaXRfTElCUkFSWV9UWVBFfSAk e1dlYktpdF9TT1VSQ0VTfSkKIFRBUkdFVF9MSU5LX0xJQlJBUklFUygke1dlYktpdF9MSUJSQVJZ X05BTUV9ICR7V2ViS2l0X0xJQlJBUklFU30pCi1BRERfVEFSR0VUX1BST1BFUlRJRVMoJHtXZWJL aXRfTElCUkFSWV9OQU1FfSBMSU5LX0ZMQUdTICIke1dlYktpdF9MSU5LX0ZMQUdTfSIpCi1TRVRf VEFSR0VUX1BST1BFUlRJRVMoJHtXZWJLaXRfTElCUkFSWV9OQU1FfSBQUk9QRVJUSUVTIFZFUlNJ T04gJHtQUk9KRUNUX1ZFUlNJT059IFNPVkVSU0lPTiAke1BST0pFQ1RfVkVSU0lPTl9NQUpPUn0p CiAKLUlOU1RBTEwoVEFSR0VUUyAke1dlYktpdF9MSUJSQVJZX05BTUV9IERFU1RJTkFUSU9OIGxp YikKK0lGICgke1dlYktpdF9MSU5LX0ZMQUdTfSkKKyAgICBBRERfVEFSR0VUX1BST1BFUlRJRVMo JHtXZWJLaXRfTElCUkFSWV9OQU1FfSBMSU5LX0ZMQUdTICIke1dlYktpdF9MSU5LX0ZMQUdTfSIp CitFTkRJRiAoKQogCitJRiAoU0hBUkVEX0NPUkUpCisgICAgU0VUX1RBUkdFVF9QUk9QRVJUSUVT KCR7V2ViS2l0X0xJQlJBUllfTkFNRX0gUFJPUEVSVElFUyBWRVJTSU9OICR7UFJPSkVDVF9WRVJT SU9OfSBTT1ZFUlNJT04gJHtQUk9KRUNUX1ZFUlNJT05fTUFKT1J9KQorICAgIElOU1RBTEwoVEFS R0VUUyAke1dlYktpdF9MSUJSQVJZX05BTUV9IERFU1RJTkFUSU9OIGxpYikKK0VORElGICgpCmRp ZmYgLS1naXQgYS9XZWJLaXQvQ2hhbmdlTG9nIGIvV2ViS2l0L0NoYW5nZUxvZwppbmRleCA5Mjk3 NmRiLi42MzE5ZjU1IDEwMDY0NAotLS0gYS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wOC0xMyAgUGF0cmljayBHYW5zdGVyZXIg IDxwYXJvZ2FAcGFyb2dhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBbQ01ha2VdIFNldCB0YXJnZXQgcHJvcGVydGllcyBvbmx5IGlmIGF2YWls YWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDM5 NzgKKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDEwLTA4LTA2ICBHYXZpbiBCYXJy YWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBSdWJiZXIgc3RhbXBl ZCBieSBTYW0gV2VpbmlnCg==