43943 2010-08-12 17:27:20 -0700 [V8] Support readonly Date attribute 2010-09-01 23:18:12 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 42903 0 kinuko webkit-unassigned abarth jam japhet oldest_to_newest 264099 0 kinuko 2010-08-12 17:27:20 -0700 Current CodeGeneratorV8 tries to create a hidden reference for a readonly Date attribute, but this makes compilation fail. Date is represented as a double (or v8::Date) and is not a RefPtr type, so I think we shouldn't generate the hidden reference code for Date. 264118 1 64289 kinuko 2010-08-12 18:43:27 -0700 Created attachment 64289 Patch 264121 2 kinuko 2010-08-12 18:50:40 -0700 I don't fully understand the code but I think it needs to go around the if statement around line 778 for Date (as we talked on chat). Can you take a look at the patch? 272596 3 abarth 2010-08-31 20:03:25 -0700 Seems related to jam magic. 272597 4 abarth 2010-08-31 20:04:13 -0700 Sorry, John. Turns out its not. 272598 5 64289 abarth 2010-08-31 20:04:48 -0700 Comment on attachment 64289 Patch ok. 273233 6 kinuko 2010-09-01 23:18:12 -0700 Committed r66642: <http://trac.webkit.org/changeset/66642> 64289 2010-08-12 18:43:27 -0700 2010-08-31 20:04:47 -0700 Patch bug-43943-20100812184326.patch text/plain 1666 kinuko ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg M2Q5NTRjYjRjM2QwMGZjZTkzYjZlOGZjZDlmMTc3NjgyZTNiNzQ3OS4uMGQ1NTM3YjkzZWY3MWFh MTY1NWQ0NDUwOGRlNDNhNDNiMzBlZmQ2OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wOC0xMiAgS2lu dWtvIFlhc3VkYSAgPGtpbnVrb0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtWOF0gU3VwcG9ydCByZWFkb25seSBEYXRlIGF0dHJp YnV0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDM5 NDMKKworICAgICAgICBBZGRzIERhdGUgdG8gbm9uX3dyYXBwZXJfdHlwZXMgaW4gQ29kZUdlbmVy YXRvclY4LnBtLgorCisgICAgICAgIE5ldyB0ZXN0cyB3aWxsIGJlIGFkZGVkIGZvciBNZXRhZGF0 YSB3aGVuIHdlIGFkZCBGaWxlU3lzdGVtIGltcGxlbWVudGF0aW9uLgorCisgICAgICAgICogYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06CisgICAgICAgICogc3RvcmFnZS9NZXRh ZGF0YS5pZGw6CisKIDIwMTAtMDgtMTIgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbSBiL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KaW5kZXggZWJiY2Y4YjQ2ZGFhNDBlN2JmNjdlOTA4 NzRkYTdlZTc2NTI0OTc0NS4uOTRjNGQ1ODZkZWZhZjZjZmIxNjJlNDQyMmYxMjQ0ZjE0NjE3M2Ez NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5w bQorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC0z MDM1LDcgKzMwMzUsOCBAQCBteSAlbm9uX3dyYXBwZXJfdHlwZXMgPSAoCiAgICAgJ0V2ZW50VGFy Z2V0JyA9PiAxLAogICAgICdOb2RlRmlsdGVyJyA9PiAxLAogICAgICdFdmVudExpc3RlbmVyJyA9 PiAxLAotICAgICdJREJLZXknID0+IDEKKyAgICAnSURCS2V5JyA9PiAxLAorICAgICdEYXRlJyA9 PiAxCiApOwogCiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvc3RvcmFnZS9NZXRhZGF0YS5pZGwgYi9X ZWJDb3JlL3N0b3JhZ2UvTWV0YWRhdGEuaWRsCmluZGV4IDcxMWZhZThhNjFjOGQxMzUyYThmMzU0 ZmUxNTUwYjM1OGUxY2M4NTAuLmE1YTkwYmM2NjcxMjliODlmN2ExMzFmNDZjMWM2MTJjMGJlMmYw ZTUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvc3RvcmFnZS9NZXRhZGF0YS5pZGwKKysrIGIvV2ViQ29y ZS9zdG9yYWdlL01ldGFkYXRhLmlkbApAQCAtMzIsNiArMzIsNiBAQCBtb2R1bGUgc3RvcmFnZSB7 CiAgICAgaW50ZXJmYWNlIFsKICAgICAgICAgQ29uZGl0aW9uYWw9RklMRV9TWVNURU0KICAgICBd IE1ldGFkYXRhIHsKLSAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIGRvdWJsZSBtb2RpZmljYXRp b25UaW1lOworICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgRGF0ZSBtb2RpZmljYXRpb25UaW1l OwogICAgIH07CiB9Cg==