43837 2010-08-11 01:21:18 -0700 [Qt] PathQt should give back pointAtLength and length 2011-01-11 03:17:48 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 krit webkit-unassigned ariya.hidayat commit-queue hausmann jhanssen krit zimmermann oldest_to_newest 263110 0 krit 2010-08-11 01:21:18 -0700 PathQt should give back pointAtLength and length itself. At the moment Qt is using PathTraversalState in Path.cpp, like most other platforms. But I could be a performance win to use qreal percentAtLength ( qreal len ) const QPointF pointAtPercent for pointAtLength and qreal length () const for length(). 263219 1 ariya.hidayat 2010-08-11 06:36:36 -0700 Adding myself. 273223 2 66332 jhanssen 2010-09-01 22:28:36 -0700 Created attachment 66332 Proposed patch 274138 3 66332 jhanssen 2010-09-03 12:58:45 -0700 Comment on attachment 66332 Proposed patch The test case for path-totalLength is wrong, it passes for Qt but not any of the other platforms. Will upload a new patch later. 274348 4 krit 2010-09-03 23:09:51 -0700 Sorry, I thougt I commented on this bug. Iam not sure about pointAtLength. IIRC we give back the last possible point if the given length is larger than the totalLength of the path. Can you check this first please? 274858 5 jhanssen 2010-09-06 23:53:28 -0700 (In reply to comment #4) > Sorry, I thougt I commented on this bug. Iam not sure about pointAtLength. IIRC we give back the last possible point if the given length is larger than the totalLength of the path. Can you check this first please? I'll have a look before uploading a revised patch. Thanks. 275632 6 66847 jhanssen 2010-09-07 23:25:21 -0700 Created attachment 66847 Proposed patch v2 Adding a test for Path::pointAtLength() for the case where the length argument is beyond the length of the path. Path::length() is already tested. 275639 7 krit 2010-09-07 23:39:24 -0700 Why did you remove normalAngleAtLength from your first patch. Doen't http://doc.trolltech.com/4.6/qpainterpath.html#angleAtPercent make what you want? 275642 8 jhanssen 2010-09-07 23:47:39 -0700 (In reply to comment #7) > Why did you remove normalAngleAtLength from your first patch. Doen't http://doc.trolltech.com/4.6/qpainterpath.html#angleAtPercent make what you want? It probably does. Path::normalAngleAtLength() not directly exposed from JS though, making it a bit more tricky to write a test case for that. Probably need to trigger a test via some SVG animation if that's possible (I haven't looked extensively at this yet). 275647 9 krit 2010-09-07 23:58:50 -0700 (In reply to comment #8) > (In reply to comment #7) > > Why did you remove normalAngleAtLength from your first patch. Doen't http://doc.trolltech.com/4.6/qpainterpath.html#angleAtPercent make what you want? > > It probably does. Path::normalAngleAtLength() not directly exposed from JS though, making it a bit more tricky to write a test case for that. Probably need to trigger a test via some SVG animation if that's possible (I haven't looked extensively at this yet). It is used for text on path in SVG. So if it doesn't work you break some SVG tests. IIRC Qt has pixel tests, so you should recognize it. If you want to check it your own, visit http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObject/text-path-01-b.html 275657 10 jhanssen 2010-09-08 00:34:35 -0700 (In reply to comment #9) > It is used for text on path in SVG. So if it doesn't work you break some SVG tests. IIRC Qt has pixel tests, so you should recognize it. If you want to check it your own, visit http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObject/text-path-01-b.html You're right, LayoutTests/svg/text/text-hkern.svg fails if Path::normalAngleAtLength() returns incorrect results. That should be sufficient for testing this, I'll attach a new patch. 275662 11 66854 jhanssen 2010-09-08 00:43:52 -0700 Created attachment 66854 Proposed patch v3 275665 12 66854 krit 2010-09-08 01:01:32 -0700 Comment on attachment 66854 Proposed patch v3 View in context: https://bugs.webkit.org/attachment.cgi?id=66854&action=prettypatch LGTM. r=me. 275812 13 66854 commit-queue 2010-09-08 07:07:27 -0700 Comment on attachment 66854 Proposed patch v3 Clearing flags on attachment: 66854 Committed r66979: <http://trac.webkit.org/changeset/66979> 275813 14 commit-queue 2010-09-08 07:07:32 -0700 All reviewed patches have been landed. Closing bug. 66332 2010-09-01 22:28:36 -0700 2010-09-07 23:25:21 -0700 Proposed patch 43837.patch text/plain 5260 jhanssen SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NjYzNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTAtMDktMDEgIEphbiBFcmlrIEhhbnNzZW4gIDxqaGFuc3NlbkBz ZW5jaGEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFtRdF0gUGF0aFF0IHNob3VsZCB1c2UgdGhlIFFQYWludGVyUGF0aCBmdW5jdGlvbmFsaXR5 IGZvciBjYWxjdWxhdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQzODM3CisKKyAgICAgICAgQ2hhbmdlIFBhdGhRdCB0byB1c2UgdGhlIGJ1aWx0 LWluIGZ1bmN0aW9uYWxpdHkgb2YgUVBhaW50ZXJQYXRoIGZvcgorICAgICAgICBjYWxjdWxhdGlu ZyBsZW5ndGgoKSwgcG9pbnRBdExlbmd0aCgpIGFuZCBhbmdsZUF0TGVuZ3RoKCkuCisKKyAgICAg ICAgVGVzdDogc3ZnL2RvbS9wYXRoLXRvdGFsTGVuZ3RoLmh0bWwKKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL1BhdGguY3BwOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L1Bh dGhRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYXRoOjpsZW5ndGgpOgorICAgICAgICAoV2Vi Q29yZTo6UGF0aDo6cG9pbnRBdExlbmd0aCk6CisgICAgICAgIChXZWJDb3JlOjpQYXRoOjpub3Jt YWxBbmdsZUF0TGVuZ3RoKToKKwogMjAxMC0wOS0wMSAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJs c29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6 IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGF0aC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9QYXRoLmNwcAkocmV2aXNpb24gNjY2MzQpCisrKyBXZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL1BhdGguY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zOSw3ICszOSw3 IEBAIHN0YXRpYyBjb25zdCBmbG9hdCBRVUFSVEVSID0gMC41NTJmOyAvLyAKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIC8vIHRvIHNpbXVsYXRlIGEgcXVhcnRlciBvZiBhIGNpcmNsZS4K IG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotI2lmICFQTEFURk9STShPUEVOVkcpCisjaWYgIVBMQVRG T1JNKE9QRU5WRykgJiYgIVBMQVRGT1JNKFFUKQogc3RhdGljIHZvaWQgcGF0aExlbmd0aEFwcGxp ZXJGdW5jdGlvbih2b2lkKiBpbmZvLCBjb25zdCBQYXRoRWxlbWVudCogZWxlbWVudCkKIHsKICAg ICBQYXRoVHJhdmVyc2FsU3RhdGUmIHRyYXZlcnNhbFN0YXRlID0gKnN0YXRpY19jYXN0PFBhdGhU cmF2ZXJzYWxTdGF0ZSo+KGluZm8pOwpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9x dC9QYXRoUXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQv UGF0aFF0LmNwcAkocmV2aXNpb24gNjY2MzQpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3F0L1BhdGhRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ2OSw2ICs0NjksMzEgQEAgdm9pZCBQ YXRoOjp0cmFuc2Zvcm0oY29uc3QgQWZmaW5lVHJhbnNmbwogICAgICAgICBtX3BhdGggPSBxVHJh bnNmb3JtLm1hcChtX3BhdGgpOwogfQogCitmbG9hdCBQYXRoOjpsZW5ndGgoKQoreworICAgIHJl dHVybiBtX3BhdGgubGVuZ3RoKCk7Cit9CisKK0Zsb2F0UG9pbnQgUGF0aDo6cG9pbnRBdExlbmd0 aChmbG9hdCBsZW5ndGgsIGJvb2wmIG9rKQoreworICAgIG9rID0gKGxlbmd0aCA+PSAwICYmIGxl bmd0aCA8PSBtX3BhdGgubGVuZ3RoKCkpOworCisgICAgcXJlYWwgcGVyY2VudCA9IG1fcGF0aC5w ZXJjZW50QXRMZW5ndGgobGVuZ3RoKTsKKyAgICBRUG9pbnRGIHBvaW50ID0gbV9wYXRoLnBvaW50 QXRQZXJjZW50KHBlcmNlbnQpOworCisgICAgcmV0dXJuIHBvaW50OworfQorCitmbG9hdCBQYXRo Ojpub3JtYWxBbmdsZUF0TGVuZ3RoKGZsb2F0IGxlbmd0aCwgYm9vbCYgb2spCit7CisgICAgb2sg PSAobGVuZ3RoID49IDAgJiYgbGVuZ3RoIDw9IG1fcGF0aC5sZW5ndGgoKSk7CisKKyAgICBxcmVh bCBwZXJjZW50ID0gbV9wYXRoLnBlcmNlbnRBdExlbmd0aChsZW5ndGgpOworICAgIHFyZWFsIGFu Z2xlID0gbV9wYXRoLmFuZ2xlQXRQZXJjZW50KHBlcmNlbnQpOworCisgICAgcmV0dXJuIGFuZ2xl OworfQorCiB9CiAKIC8vIHZpbTogdHM9NCBzdz00IGV0CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA2NjYz NykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1 IEBACisyMDEwLTA5LTAxICBKYW4gRXJpayBIYW5zc2VuICA8amhhbnNzZW5Ac2VuY2hhLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSB0 ZXN0IGZvciBQYXRoOjpsZW5ndGgoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDM4MzcKKworICAgICAgICAqIHN2Zy9kb20vcGF0aC10b3RhbExlbmd0 aC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHN2Zy9kb20vcGF0aC10b3RhbExlbmd0 aC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBzdmcvZG9tL3NjcmlwdC10ZXN0cy9wYXRoLXRvdGFs TGVuZ3RoLmpzOiBBZGRlZC4KKyAgICAgICAgKHBvaW50QXRMZW5ndGhPZlBhdGgpOgorCiAyMDEw LTA5LTAxICBNYXR0aGV3IFdpbGxpcyAgPGxpbG1hdHRAZmxvY2suY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCkluZGV4OiBMYXlvdXRUZXN0cy9zdmcvZG9t L3BhdGgtdG90YWxMZW5ndGgtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L3N2Zy9kb20vcGF0aC10b3RhbExlbmd0aC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBM YXlvdXRUZXN0cy9zdmcvZG9tL3BhdGgtdG90YWxMZW5ndGgtZXhwZWN0ZWQudHh0CShyZXZpc2lv biAwKQpAQCAtMCwwICsxLDEyIEBACitUaGlzIHRlc3RzIGdldFBvaW50QXRMZW5ndGggb2YgU1ZH IHBhdGguCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVz c2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIHBvaW50QXRMZW5n dGhPZlBhdGgoJ00wLDIwIEw0MDAsMjAgTDY0MCwyMCcpIGlzIDY0MAorUEFTUyBwb2ludEF0TGVu Z3RoT2ZQYXRoKCdNMCwyMCBMNDAwLDIwIEw2NDAsMjAgeicpIGlzIDEyODAKK1BBU1MgcG9pbnRB dExlbmd0aE9mUGF0aCgnTTAsMjAgTDQwMCwyMCB6IE0gMzIwLDIwIEw2NDAsMjAnKSBpcyA3MjAK K1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4 OiBMYXlvdXRUZXN0cy9zdmcvZG9tL3BhdGgtdG90YWxMZW5ndGguaHRtbAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9zdmcvZG9tL3BhdGgtdG90YWxMZW5ndGguaHRtbAkocmV2aXNpb24gMCkK KysrIExheW91dFRlc3RzL3N2Zy9kb20vcGF0aC10b3RhbExlbmd0aC5odG1sCShyZXZpc2lvbiAw KQpAQCAtMCwwICsxLDEzIEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBI VE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIu Li8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0i Li4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFk PgorPGJvZHk+Cis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwv ZGl2PgorPHNjcmlwdCBzcmM9InNjcmlwdC10ZXN0cy9wYXRoLXRvdGFsTGVuZ3RoLmpzIj48L3Nj cmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3Qu anMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpJbmRleDogTGF5b3V0VGVzdHMvc3ZnL2Rv bS9zY3JpcHQtdGVzdHMvcGF0aC10b3RhbExlbmd0aC5qcwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9zdmcvZG9tL3NjcmlwdC10ZXN0cy9wYXRoLXRvdGFsTGVuZ3RoLmpzCShyZXZpc2lvbiAw KQorKysgTGF5b3V0VGVzdHMvc3ZnL2RvbS9zY3JpcHQtdGVzdHMvcGF0aC10b3RhbExlbmd0aC5q cwkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxNiBAQAorZGVzY3JpcHRpb24oIlRoaXMgdGVzdHMg Z2V0VG90YWxMZW5ndGggb2YgU1ZHIHBhdGguIik7CisKK3ZhciBwYXRoRWxlbWVudCA9IGRvY3Vt ZW50LmNyZWF0ZUVsZW1lbnROUygiaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciLCAicGF0aCIp OworCitmdW5jdGlvbiBwb2ludEF0TGVuZ3RoT2ZQYXRoKHN0cmluZykgeworICAgIHBhdGhFbGVt ZW50LnNldEF0dHJpYnV0ZU5TKG51bGwsICJkIiwgc3RyaW5nKTsKKworICAgIHZhciBwb2ludCA9 IHBhdGhFbGVtZW50LmdldFRvdGFsTGVuZ3RoKCk7CisgICAgcmV0dXJuIHBvaW50OworfQorCitz aG91bGRCZSgicG9pbnRBdExlbmd0aE9mUGF0aCgnTTAsMjAgTDQwMCwyMCBMNjQwLDIwJykiLCAi NjQwIik7CitzaG91bGRCZSgicG9pbnRBdExlbmd0aE9mUGF0aCgnTTAsMjAgTDQwMCwyMCBMNjQw LDIwIHonKSIsICIxMjgwIik7CitzaG91bGRCZSgicG9pbnRBdExlbmd0aE9mUGF0aCgnTTAsMjAg TDQwMCwyMCB6IE0gMzIwLDIwIEw2NDAsMjAnKSIsICI3MjAiKTsKKwordmFyIHN1Y2Nlc3NmdWxs eVBhcnNlZCA9IHRydWU7Cg== 66847 2010-09-07 23:25:21 -0700 2010-09-08 00:43:52 -0700 Proposed patch v2 43837.patch text/plain 3972 jhanssen SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2Njk1NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDktMDcgIEphbiBFIEhhbnNzZW4gIDxqaGFuc3NlbkBzZW5j aGEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gUGF0aFF0IHNob3VsZCB1c2UgdGhlIFFQYWludGVyUGF0aCBmdW5jdGlvbmFsaXR5IGZv ciBjYWxjdWxhdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQzODM3CisKKyAgICAgICAgVXNlIFFQYWludGVyUGF0aCBmdW5jdGlvbmFsaXR5IGZv ciBQYXRoOjpsZW5ndGgoKSBhbmQgCisgICAgICAgIFBhdGg6OnBvaW50QXRMZW5ndGgoKQorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvUGF0aC5jcHA6CisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvcXQvUGF0aFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBhdGg6Omxlbmd0aCk6 CisgICAgICAgIChXZWJDb3JlOjpQYXRoOjpwb2ludEF0TGVuZ3RoKToKKwogMjAxMC0wOS0wNyAg U2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBC ZXJuc3RlaW4uCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1BhdGguY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGF0aC5jcHAJKHJldmlzaW9uIDY2 OTUyKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9QYXRoLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtODQsNiArODQsNyBAQCBzdGF0aWMgdm9pZCBwYXRoTGVuZ3RoQXBwbGllckZ1bmN0aW9u KHZvCiAgICAgfQogfQogCisjaWYgIVBMQVRGT1JNKFFUKQogZmxvYXQgUGF0aDo6bGVuZ3RoKCkK IHsKICAgICBQYXRoVHJhdmVyc2FsU3RhdGUgdHJhdmVyc2FsU3RhdGUoUGF0aFRyYXZlcnNhbFN0 YXRlOjpUcmF2ZXJzYWxUb3RhbExlbmd0aCk7CkBAIC05OSw2ICsxMDAsNyBAQCBGbG9hdFBvaW50 IFBhdGg6OnBvaW50QXRMZW5ndGgoZmxvYXQgbGVuCiAgICAgb2sgPSB0cmF2ZXJzYWxTdGF0ZS5t X3N1Y2Nlc3M7CiAgICAgcmV0dXJuIHRyYXZlcnNhbFN0YXRlLm1fY3VycmVudDsKIH0KKyNlbmRp ZgogCiBmbG9hdCBQYXRoOjpub3JtYWxBbmdsZUF0TGVuZ3RoKGZsb2F0IGxlbmd0aCwgYm9vbCYg b2spCiB7CkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L1BhdGhRdC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9QYXRoUXQuY3BwCShyZXZp c2lvbiA2Njk1MikKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvUGF0aFF0LmNwcAko d29ya2luZyBjb3B5KQpAQCAtNDc0LDYgKzQ3NCwyMSBAQCB2b2lkIFBhdGg6OnRyYW5zZm9ybShj b25zdCBBZmZpbmVUcmFuc2ZvCiAgICAgICAgIG1fcGF0aCA9IHFUcmFuc2Zvcm0ubWFwKG1fcGF0 aCk7CiB9CiAKK2Zsb2F0IFBhdGg6Omxlbmd0aCgpCit7CisgICAgcmV0dXJuIG1fcGF0aC5sZW5n dGgoKTsKK30KKworRmxvYXRQb2ludCBQYXRoOjpwb2ludEF0TGVuZ3RoKGZsb2F0IGxlbmd0aCwg Ym9vbCYgb2spCit7CisgICAgb2sgPSAobGVuZ3RoID49IDAgJiYgbGVuZ3RoIDw9IG1fcGF0aC5s ZW5ndGgoKSk7CisKKyAgICBxcmVhbCBwZXJjZW50ID0gbV9wYXRoLnBlcmNlbnRBdExlbmd0aChs ZW5ndGgpOworICAgIFFQb2ludEYgcG9pbnQgPSBtX3BhdGgucG9pbnRBdFBlcmNlbnQocGVyY2Vu dCk7CisKKyAgICByZXR1cm4gcG9pbnQ7Cit9CisKIH0KIAogLy8gdmltOiB0cz00IHN3PTQgZXQK SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY2OTU0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDktMDcgIEphbiBFIEhhbnNzZW4gIDxq aGFuc3NlbkBzZW5jaGEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFkZCBhIHRlc3QgZm9yIGdldHRpbmcgYSBwb2ludCBiZXlvbmQgdGhlIGxl bmd0aCBvZiB0aGUgcGF0aAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDM4MzcKKworICAgICAgICAqIHN2Zy9kb20vcGF0aC1wb2ludEF0TGVuZ3RoLWV4 cGVjdGVkLnR4dDoKKyAgICAgICAgKiBzdmcvZG9tL3NjcmlwdC10ZXN0cy9wYXRoLXBvaW50QXRM ZW5ndGguanM6CisKIDIwMTAtMDktMDcgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpJbmRleDogTGF5b3V0VGVzdHMvc3Zn L2RvbS9wYXRoLXBvaW50QXRMZW5ndGgtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL3N2Zy9kb20vcGF0aC1wb2ludEF0TGVuZ3RoLWV4cGVjdGVkLnR4dAkocmV2aXNpb24g NjY5NTIpCisrKyBMYXlvdXRUZXN0cy9zdmcvZG9tL3BhdGgtcG9pbnRBdExlbmd0aC1leHBlY3Rl ZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTYsNiArNiw3IEBAIE9uIHN1Y2Nlc3MsIHlvdSB3aWxs IHNlZSBhIHNlcmllcyBvZiAiUEEKIFBBU1MgcG9pbnRBdExlbmd0aE9mUGF0aCgnTTAsMjAgTDQw MCwyMCBMNjQwLDIwJykgaXMgJyg2NDAsIDIwKScKIFBBU1MgcG9pbnRBdExlbmd0aE9mUGF0aCgn TTAsMjAgTDQwMCwyMCBMNjQwLDIwIHonKSBpcyAnKDU4MCwgMjApJwogUEFTUyBwb2ludEF0TGVu Z3RoT2ZQYXRoKCdNMCwyMCBMNDAwLDIwIHogTSAzMjAsMjAgTDY0MCwyMCcpIGlzICcoMTAwLCAy MCknCitQQVNTIHBvaW50QXRMZW5ndGhPZlBhdGgoJ00wLDIwIEwyMCw0MCcpIGlzICcoMjAsIDQw KScKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKIAogVEVTVCBDT01QTEVURQpJbmRl eDogTGF5b3V0VGVzdHMvc3ZnL2RvbS9zY3JpcHQtdGVzdHMvcGF0aC1wb2ludEF0TGVuZ3RoLmpz Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3N2Zy9kb20vc2NyaXB0LXRlc3RzL3BhdGgtcG9p bnRBdExlbmd0aC5qcwkocmV2aXNpb24gNjY5NTIpCisrKyBMYXlvdXRUZXN0cy9zdmcvZG9tL3Nj cmlwdC10ZXN0cy9wYXRoLXBvaW50QXRMZW5ndGguanMJKHdvcmtpbmcgY29weSkKQEAgLTEyLDUg KzEyLDYgQEAgZnVuY3Rpb24gcG9pbnRBdExlbmd0aE9mUGF0aChzdHJpbmcpIHsKIHNob3VsZEJl KCJwb2ludEF0TGVuZ3RoT2ZQYXRoKCdNMCwyMCBMNDAwLDIwIEw2NDAsMjAnKSIsICInKDY0MCwg MjApJyIpOwogc2hvdWxkQmUoInBvaW50QXRMZW5ndGhPZlBhdGgoJ00wLDIwIEw0MDAsMjAgTDY0 MCwyMCB6JykiLCAiJyg1ODAsIDIwKSciKTsKIHNob3VsZEJlKCJwb2ludEF0TGVuZ3RoT2ZQYXRo KCdNMCwyMCBMNDAwLDIwIHogTSAzMjAsMjAgTDY0MCwyMCcpIiwgIicoMTAwLCAyMCknIik7Citz aG91bGRCZSgicG9pbnRBdExlbmd0aE9mUGF0aCgnTTAsMjAgTDIwLDQwJykiLCAiJygyMCwgNDAp JyIpOwogCiB2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsK 66854 2010-09-08 00:43:52 -0700 2010-09-08 07:07:27 -0700 Proposed patch v3 43837.patch text/plain 4312 jhanssen SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2Njk1NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDktMDggIEphbiBFIEhhbnNzZW4gIDxqaGFuc3NlbkBzZW5j aGEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gUGF0aFF0IHNob3VsZCB1c2UgdGhlIFFQYWludGVyUGF0aCBmdW5jdGlvbmFsaXR5IGZv ciBjYWxjdWxhdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQzODM3CisKKyAgICAgICAgQ2hhbmdlIFBhdGhRdCB0byB1c2UgdGhlIGJ1aWx0LWlu IGZ1bmN0aW9uYWxpdHkgb2YgUVBhaW50ZXJQYXRoIGZvcgorICAgICAgICBjYWxjdWxhdGluZyBs ZW5ndGgoKSwgcG9pbnRBdExlbmd0aCgpIGFuZCBub3JtYWxBbmdsZUF0TGVuZ3RoKCkuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9QYXRoLmNwcDoKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9xdC9QYXRoUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGF0aDo6bGVuZ3RoKToK KyAgICAgICAgKFdlYkNvcmU6OlBhdGg6OnBvaW50QXRMZW5ndGgpOgorICAgICAgICAoV2ViQ29y ZTo6UGF0aDo6bm9ybWFsQW5nbGVBdExlbmd0aCk6CisKIDIwMTAtMDktMDggIFpvbHRhbiBIZXJj emVnICA8emhlcmN6ZWdAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaXJrIFNj aHVsemUuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1BhdGguY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGF0aC5jcHAJKHJldmlzaW9uIDY2OTUy KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9QYXRoLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMzksNyArMzksNyBAQCBzdGF0aWMgY29uc3QgZmxvYXQgUVVBUlRFUiA9IDAuNTUyZjsgLy8g CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAvLyB0byBzaW11bGF0ZSBhIHF1YXJ0ZXIg b2YgYSBjaXJjbGUuCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLSNpZiAhUExBVEZPUk0oT1BFTlZH KQorI2lmICFQTEFURk9STShPUEVOVkcpICYmICFQTEFURk9STShRVCkKIHN0YXRpYyB2b2lkIHBh dGhMZW5ndGhBcHBsaWVyRnVuY3Rpb24odm9pZCogaW5mbywgY29uc3QgUGF0aEVsZW1lbnQqIGVs ZW1lbnQpCiB7CiAgICAgUGF0aFRyYXZlcnNhbFN0YXRlJiB0cmF2ZXJzYWxTdGF0ZSA9ICpzdGF0 aWNfY2FzdDxQYXRoVHJhdmVyc2FsU3RhdGUqPihpbmZvKTsKSW5kZXg6IFdlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvcXQvUGF0aFF0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3F0L1BhdGhRdC5jcHAJKHJldmlzaW9uIDY2OTUyKQorKysgV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9xdC9QYXRoUXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NzQsNiArNDc0 LDMxIEBAIHZvaWQgUGF0aDo6dHJhbnNmb3JtKGNvbnN0IEFmZmluZVRyYW5zZm8KICAgICAgICAg bV9wYXRoID0gcVRyYW5zZm9ybS5tYXAobV9wYXRoKTsKIH0KIAorZmxvYXQgUGF0aDo6bGVuZ3Ro KCkKK3sKKyAgICByZXR1cm4gbV9wYXRoLmxlbmd0aCgpOworfQorCitGbG9hdFBvaW50IFBhdGg6 OnBvaW50QXRMZW5ndGgoZmxvYXQgbGVuZ3RoLCBib29sJiBvaykKK3sKKyAgICBvayA9IChsZW5n dGggPj0gMCAmJiBsZW5ndGggPD0gbV9wYXRoLmxlbmd0aCgpKTsKKworICAgIHFyZWFsIHBlcmNl bnQgPSBtX3BhdGgucGVyY2VudEF0TGVuZ3RoKGxlbmd0aCk7CisgICAgUVBvaW50RiBwb2ludCA9 IG1fcGF0aC5wb2ludEF0UGVyY2VudChwZXJjZW50KTsKKworICAgIHJldHVybiBwb2ludDsKK30K KworZmxvYXQgUGF0aDo6bm9ybWFsQW5nbGVBdExlbmd0aChmbG9hdCBsZW5ndGgsIGJvb2wmIG9r KQoreworICAgIG9rID0gKGxlbmd0aCA+PSAwICYmIGxlbmd0aCA8PSBtX3BhdGgubGVuZ3RoKCkp OworCisgICAgcXJlYWwgcGVyY2VudCA9IG1fcGF0aC5wZXJjZW50QXRMZW5ndGgobGVuZ3RoKTsK KyAgICBxcmVhbCBhbmdsZSA9IG1fcGF0aC5hbmdsZUF0UGVyY2VudChwZXJjZW50KTsKKworICAg IHJldHVybiBhbmdsZTsKK30KKwogfQogCiAvLyB2aW06IHRzPTQgc3c9NCBldApJbmRleDogTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwko cmV2aXNpb24gNjY5NTUpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxMyBAQAorMjAxMC0wOS0wOCAgSmFuIEUgSGFuc3NlbiAgPGpoYW5zc2VuQHNl bmNoYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkIGEgdGVzdCBmb3IgZ2V0dGluZyBhIHBvaW50IGJleW9uZCB0aGUgbGVuZ3RoIG9mIHRo ZSBwYXRoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 MzgzNworCisgICAgICAgICogc3ZnL2RvbS9wYXRoLXBvaW50QXRMZW5ndGgtZXhwZWN0ZWQudHh0 OgorICAgICAgICAqIHN2Zy9kb20vc2NyaXB0LXRlc3RzL3BhdGgtcG9pbnRBdExlbmd0aC5qczoK KwogMjAxMC0wOS0wOCAgWm9sdGFuIEhlcmN6ZWcgIDx6aGVyY3plZ0B3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IERpcmsgU2NodWx6ZS4KSW5kZXg6IExheW91dFRlc3RzL3N2Zy9k b20vcGF0aC1wb2ludEF0TGVuZ3RoLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9zdmcvZG9tL3BhdGgtcG9pbnRBdExlbmd0aC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDY2 OTUyKQorKysgTGF5b3V0VGVzdHMvc3ZnL2RvbS9wYXRoLXBvaW50QXRMZW5ndGgtZXhwZWN0ZWQu dHh0CSh3b3JraW5nIGNvcHkpCkBAIC02LDYgKzYsNyBAQCBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBz ZWUgYSBzZXJpZXMgb2YgIlBBCiBQQVNTIHBvaW50QXRMZW5ndGhPZlBhdGgoJ00wLDIwIEw0MDAs MjAgTDY0MCwyMCcpIGlzICcoNjQwLCAyMCknCiBQQVNTIHBvaW50QXRMZW5ndGhPZlBhdGgoJ00w LDIwIEw0MDAsMjAgTDY0MCwyMCB6JykgaXMgJyg1ODAsIDIwKScKIFBBU1MgcG9pbnRBdExlbmd0 aE9mUGF0aCgnTTAsMjAgTDQwMCwyMCB6IE0gMzIwLDIwIEw2NDAsMjAnKSBpcyAnKDEwMCwgMjAp JworUEFTUyBwb2ludEF0TGVuZ3RoT2ZQYXRoKCdNMCwyMCBMMjAsNDAnKSBpcyAnKDIwLCA0MCkn CiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUKSW5kZXg6 IExheW91dFRlc3RzL3N2Zy9kb20vc2NyaXB0LXRlc3RzL3BhdGgtcG9pbnRBdExlbmd0aC5qcwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9zdmcvZG9tL3NjcmlwdC10ZXN0cy9wYXRoLXBvaW50 QXRMZW5ndGguanMJKHJldmlzaW9uIDY2OTUyKQorKysgTGF5b3V0VGVzdHMvc3ZnL2RvbS9zY3Jp cHQtdGVzdHMvcGF0aC1wb2ludEF0TGVuZ3RoLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0xMiw1ICsx Miw2IEBAIGZ1bmN0aW9uIHBvaW50QXRMZW5ndGhPZlBhdGgoc3RyaW5nKSB7CiBzaG91bGRCZSgi cG9pbnRBdExlbmd0aE9mUGF0aCgnTTAsMjAgTDQwMCwyMCBMNjQwLDIwJykiLCAiJyg2NDAsIDIw KSciKTsKIHNob3VsZEJlKCJwb2ludEF0TGVuZ3RoT2ZQYXRoKCdNMCwyMCBMNDAwLDIwIEw2NDAs MjAgeicpIiwgIicoNTgwLCAyMCknIik7CiBzaG91bGRCZSgicG9pbnRBdExlbmd0aE9mUGF0aCgn TTAsMjAgTDQwMCwyMCB6IE0gMzIwLDIwIEw2NDAsMjAnKSIsICInKDEwMCwgMjApJyIpOworc2hv dWxkQmUoInBvaW50QXRMZW5ndGhPZlBhdGgoJ00wLDIwIEwyMCw0MCcpIiwgIicoMjAsIDQwKSci KTsKIAogdmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cg==