43443 2010-08-03 13:42:46 -0700 Accelerometer tests need V8 results 2010-08-11 02:05:48 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 42865 1 dino webkit-unassigned commit-queue dino eric hans jorlow steveblock oldest_to_newest 259672 0 dino 2010-08-03 13:42:46 -0700 The new test fast/dom/Accelerometer/window-property.html does not pass with v8. It needs platform-specific results. 262396 1 63950 steveblock 2010-08-09 16:30:56 -0700 Created attachment 63950 Patch 262559 2 63950 jorlow 2010-08-10 02:01:53 -0700 Comment on attachment 63950 Patch r=me 262561 3 jorlow 2010-08-10 02:02:39 -0700 Hans, can you please make a patch that sets the expected results for Chromium as well? 262573 4 hans 2010-08-10 02:29:00 -0700 (In reply to comment #3) > Hans, can you please make a patch that sets the expected results for Chromium as well? Will do once we enable it. 262583 5 63950 commit-queue 2010-08-10 02:57:44 -0700 Comment on attachment 63950 Patch Rejecting patch 63950 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20806 test cases. fast/loader/recursive-before-unload-crash.html -> failed Exiting early after 1 failures. 14219 tests run. 252.83s total testing time 14218 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://queues.webkit.org/results/3730017 262588 6 63950 steveblock 2010-08-10 03:13:31 -0700 Comment on attachment 63950 Patch Queue failure looks like flakiness. Trying again. 262598 7 63950 commit-queue 2010-08-10 03:37:36 -0700 Comment on attachment 63950 Patch Rejecting patch 63950 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20806 test cases. fast/loader/recursive-before-unload-crash.html -> failed Exiting early after 1 failures. 14219 tests run. 249.35s total testing time 14218 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://queues.webkit.org/results/3747017 262619 8 steveblock 2010-08-10 04:22:01 -0700 Committed r65066: <http://trac.webkit.org/changeset/65066> 262732 9 eric 2010-08-10 10:01:15 -0700 Did it flake twice? or did this really cause a regression? Either way, we should get a bug on the flaky test so it can be fixed. 262821 10 steveblock 2010-08-10 12:50:32 -0700 > Did it flake twice? Yes, it did. I couldn't reproduce the failure locally so I landed manually and it didn't seem to cause any failures in the continuous build. Would you like me to file a bug against the test or against the commit queue? 262859 11 eric 2010-08-10 14:42:15 -0700 In a perfect world, anytime we see a test flake (on the commit-queue or build.webkit.org) we should file a bug. 263126 12 steveblock 2010-08-11 02:05:48 -0700 Have filed Bug 43840 to track the test flakiness 63950 2010-08-09 16:30:56 -0700 2010-08-10 03:37:36 -0700 Patch bug-43443-20100810003050.patch text/plain 3267 steveblock SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY1MDEzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDgtMDkgIFN0ZXZlIEJsb2NrICA8c3Rl dmVibG9ja0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFjY2VsZXJvbWV0ZXIgdGVzdHMgbmVlZCBWOCByZXN1bHRzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MzQ0MworCisgICAgICAg IFRoaXMgcGF0Y2ggYWRkcyBWOC1zcGVjaWZpYyByZXN1bHRzIGZvciBBbmRyb2lkIGZvciB0aGUg ZXhpc3Rpbmcgd2luZG93LXByb3BlcnR5Lmh0bWwgdGVzdC4KKworICAgICAgICAqIGZhc3QvZG9t L0RldmljZU1vdGlvbi9zY3JpcHQtdGVzdHMvd2luZG93LXByb3BlcnR5LmpzOgorICAgICAgICAq IGZhc3QvZG9tL0RldmljZU1vdGlvbi93aW5kb3ctcHJvcGVydHktZXhwZWN0ZWQudHh0OgorICAg ICAgICAqIHBsYXRmb3JtL2FuZHJvaWQtdjgvZmFzdC9kb20vRGV2aWNlTW90aW9uOiBBZGRlZC4K KyAgICAgICAgKiBwbGF0Zm9ybS9hbmRyb2lkLXY4L2Zhc3QvZG9tL0RldmljZU1vdGlvbi93aW5k b3ctcHJvcGVydHktZXhwZWN0ZWQudHh0OiBBZGRlZC4KKwogMjAxMC0wOC0wOSAgRXJpYyBTZWlk ZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4K SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL0RldmljZU1vdGlvbi93aW5kb3ctcHJvcGVydHkt ZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL0RldmljZU1v dGlvbi93aW5kb3ctcHJvcGVydHktZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA2NTAwOSkKKysrIExh eW91dFRlc3RzL2Zhc3QvZG9tL0RldmljZU1vdGlvbi93aW5kb3ctcHJvcGVydHktZXhwZWN0ZWQu dHh0CSh3b3JraW5nIGNvcHkpCkBAIC00LDYgKzQsNyBAQCBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBz ZWUgYSBzZXJpZXMgb2YgIlBBCiAKIAogUEFTUyB0eXBlb2Ygd2luZG93LkRldmljZU1vdGlvbkV2 ZW50ID09ICdvYmplY3QnIGlzIHRydWUKK1BBU1MgdHlwZW9mIHdpbmRvdy5EZXZpY2VNb3Rpb25F dmVudCA9PSAnZnVuY3Rpb24nIGlzIGZhbHNlCiBQQVNTIGhhc0RldmljZU1vdGlvbkV2ZW50UHJv cGVydHkoKSBpcyB0cnVlCiBQQVNTICdEZXZpY2VNb3Rpb25FdmVudCcgaW4gd2luZG93IGlzIHRy dWUKIFBBU1Mgd2luZG93Lmhhc093blByb3BlcnR5KCdEZXZpY2VNb3Rpb25FdmVudCcpIGlzIHRy dWUKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL0RldmljZU1vdGlvbi9zY3JpcHQtdGVzdHMv d2luZG93LXByb3BlcnR5LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL0Rl dmljZU1vdGlvbi9zY3JpcHQtdGVzdHMvd2luZG93LXByb3BlcnR5LmpzCShyZXZpc2lvbiA2NTAw OSkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL0RldmljZU1vdGlvbi9zY3JpcHQtdGVzdHMvd2lu ZG93LXByb3BlcnR5LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0xMCw2ICsxMCw3IEBAIGZ1bmN0aW9u IGhhc0RldmljZU1vdGlvbkV2ZW50UHJvcGVydHkoKQogfQogCiBzaG91bGRCZVRydWUoInR5cGVv ZiB3aW5kb3cuRGV2aWNlTW90aW9uRXZlbnQgPT0gJ29iamVjdCciKTsKK3Nob3VsZEJlRmFsc2Uo InR5cGVvZiB3aW5kb3cuRGV2aWNlTW90aW9uRXZlbnQgPT0gJ2Z1bmN0aW9uJyIpOwogc2hvdWxk QmVUcnVlKCJoYXNEZXZpY2VNb3Rpb25FdmVudFByb3BlcnR5KCkiKTsKIHNob3VsZEJlVHJ1ZSgi J0RldmljZU1vdGlvbkV2ZW50JyBpbiB3aW5kb3ciKTsKIHNob3VsZEJlVHJ1ZSgid2luZG93Lmhh c093blByb3BlcnR5KCdEZXZpY2VNb3Rpb25FdmVudCcpIik7CkluZGV4OiBMYXlvdXRUZXN0cy9w bGF0Zm9ybS9hbmRyb2lkLXY4L2Zhc3QvZG9tL0RldmljZU1vdGlvbi93aW5kb3ctcHJvcGVydHkt ZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2FuZHJvaWQt djgvZmFzdC9kb20vRGV2aWNlTW90aW9uL3dpbmRvdy1wcm9wZXJ0eS1leHBlY3RlZC50eHQJKHJl dmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9hbmRyb2lkLXY4L2Zhc3QvZG9tL0Rl dmljZU1vdGlvbi93aW5kb3ctcHJvcGVydHktZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAt MCwwICsxLDE4IEBACitUZXN0cyB0aGF0IHRoZSB3aW5kb3cuRGV2aWNlTW90aW9uRXZlbnQgYW5k IHdpbmRvdy5vbmRldmljZW1vdGlvbiBwcm9wZXJ0aWVzIGFyZSBwcmVzZW50LgorCitPbiBzdWNj ZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBi eSAiVEVTVCBDT01QTEVURSIuCisKKworRkFJTCB0eXBlb2Ygd2luZG93LkRldmljZU1vdGlvbkV2 ZW50ID09ICdvYmplY3QnIHNob3VsZCBiZSB0cnVlLiBXYXMgZmFsc2UuCitGQUlMIHR5cGVvZiB3 aW5kb3cuRGV2aWNlTW90aW9uRXZlbnQgPT0gJ2Z1bmN0aW9uJyBzaG91bGQgYmUgZmFsc2UuIFdh cyB0cnVlLgorUEFTUyBoYXNEZXZpY2VNb3Rpb25FdmVudFByb3BlcnR5KCkgaXMgdHJ1ZQorUEFT UyAnRGV2aWNlTW90aW9uRXZlbnQnIGluIHdpbmRvdyBpcyB0cnVlCitQQVNTIHdpbmRvdy5oYXNP d25Qcm9wZXJ0eSgnRGV2aWNlTW90aW9uRXZlbnQnKSBpcyB0cnVlCitQQVNTIHR5cGVvZiB3aW5k b3cub25kZXZpY2Vtb3Rpb24gPT0gJ29iamVjdCcgaXMgdHJ1ZQorUEFTUyBoYXNPbkRldmljZU1v dGlvblByb3BlcnR5KCkgaXMgdHJ1ZQorUEFTUyAnb25kZXZpY2Vtb3Rpb24nIGluIHdpbmRvdyBp cyB0cnVlCitGQUlMIHdpbmRvdy5oYXNPd25Qcm9wZXJ0eSgnb25kZXZpY2Vtb3Rpb24nKSBzaG91 bGQgYmUgdHJ1ZS4gV2FzIGZhbHNlLgorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQor CitURVNUIENPTVBMRVRFCisK