<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>43397</bug_id>
          
          <creation_ts>2010-08-02 19:06:23 -0700</creation_ts>
          <short_desc>[BREWMP] Define htonl, htons, ntohl and ntohs</short_desc>
          <delta_ts>2010-09-01 10:10:06 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>33564</blocked>
          <everconfirmed>0</everconfirmed>
          <reporter name="Kwang Yul Seo">skyul</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>morrita</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>259251</commentid>
    <comment_count>0</comment_count>
    <who name="Kwang Yul Seo">skyul</who>
    <bug_when>2010-08-02 19:06:23 -0700</bug_when>
    <thetext>In BREWMP, AEEStdLib.h provides macros for byte order conversion: HTONL, HTONS, NTOHL and NTOHS. Use these macros to define htonl, htons, ntohl and ntohs used by WOFFFileFormat.cpp.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>259253</commentid>
    <comment_count>1</comment_count>
      <attachid>63287</attachid>
    <who name="Kwang Yul Seo">skyul</who>
    <bug_when>2010-08-02 19:10:09 -0700</bug_when>
    <thetext>Created attachment 63287
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>260417</commentid>
    <comment_count>2</comment_count>
    <who name="Hajime Morrita">morrita</who>
    <bug_when>2010-08-04 23:13:01 -0700</bug_when>
    <thetext>Although I&apos;m not a reviewer, the patch looks no problem. It&apos;s small, limited impact, and trivial.
Hopes someone to just r+ this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>260452</commentid>
    <comment_count>3</comment_count>
      <attachid>63287</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-08-05 00:37:02 -0700</bug_when>
    <thetext>Comment on attachment 63287
Patch

Clearing flags on attachment: 63287

Committed r64720: &lt;http://trac.webkit.org/changeset/64720&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>260453</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-08-05 00:37:06 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>63287</attachid>
            <date>2010-08-02 19:10:09 -0700</date>
            <delta_ts>2010-08-05 00:37:01 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>htonl.patch</filename>
            <type>text/plain</type>
            <size>1237</size>
            <attacher name="Kwang Yul Seo">skyul</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA2NDUyMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDgtMDIgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55
MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICBbQlJFV01QXSBEZWZpbmUgaHRvbmwsIGh0b25zLCBudG9obCBhbmQgbnRvaHMKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzMzk3CisKKyAgICAgICAg
SW4gQlJFV01QLCBBRUVTdGRMaWIuaCBwcm92aWRlcyBtYWNyb3MgZm9yIGJ5dGUgb3JkZXIgY29u
dmVyc2lvbjogSFRPTkwsIEhUT05TLCBOVE9ITCBhbmQgTlRPSFMuCisgICAgICAgIFVzZSB0aGVz
ZSBtYWNyb3MgdG8gZGVmaW5lIGh0b25sLCBodG9ucywgbnRvaGwgYW5kIG50b2hzIHVzZWQgYnkg
V09GRkZpbGVGb3JtYXQuY3BwLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvV09GRkZp
bGVGb3JtYXQuY3BwOgorCiAyMDEwLTA4LTAyICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxl
LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2FybHNzb24uCkluZGV4OiBXZWJD
b3JlL3BsYXRmb3JtL2dyYXBoaWNzL1dPRkZGaWxlRm9ybWF0LmNwcAo9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX
ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1dPRkZGaWxlRm9ybWF0LmNwcAkocmV2aXNpb24gNjQ0
NTEpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1dPRkZGaWxlRm9ybWF0LmNwcAkod29y
a2luZyBjb3B5KQpAQCAtMzIsNiArMzIsMTMgQEAKIAogI2lmICFQTEFURk9STShXSU4pCiAjaW5j
bHVkZSA8emxpYi5oPgorI2lmIFBMQVRGT1JNKEJSRVdNUCkKKyNpbmNsdWRlIDxBRUVTdGRMaWIu
aD4KKyNkZWZpbmUgaHRvbmwoeCkgSFRPTkwoeCkKKyNkZWZpbmUgaHRvbnMoeCkgSFRPTlMoeCkK
KyNkZWZpbmUgbnRvaGwoeCkgTlRPSEwoeCkKKyNkZWZpbmUgbnRvaHMoeCkgTlRPSFMoeCkKKyNl
bmRpZgogI2Vsc2UKICNpbmNsdWRlICJTb2Z0TGlua2luZy5oIgogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>