43240 2010-07-30 05:23:10 -0700 Add a check for WebViewClient being null. 2010-07-30 09:57:01 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 39485 0 satish webkit-unassigned fishd hans jorlow oldest_to_newest 258151 0 satish 2010-07-30 05:23:10 -0700 It seems valid to pass in a null WebViewClient in the chromium port of WebKit, so check for that before invoking methods on it in the speech input code. 258152 1 63050 satish 2010-07-30 05:25:53 -0700 Created attachment 63050 Patch 258154 2 63050 jorlow 2010-07-30 05:29:45 -0700 Comment on attachment 63050 Patch r=me 258171 3 63050 jorlow 2010-07-30 06:19:40 -0700 Comment on attachment 63050 Patch Clearing flags on attachment: 63050 Committed r64352: <http://trac.webkit.org/changeset/64352> 258172 4 jorlow 2010-07-30 06:19:48 -0700 All reviewed patches have been landed. Closing bug. 258236 5 fishd 2010-07-30 09:51:10 -0700 FYI, it is more conventional to pass WebViewImpl* around within chromium/src/ than to pass WebViewClient*. You will frequently see code like this: if (viewImpl->client()) viewImpl->client()->someMethod() 258239 6 satish 2010-07-30 09:57:01 -0700 Thanks for the comment, I'll use that pattern going forward and change this the next time this code is touched. 63050 2010-07-30 05:25:53 -0700 2010-07-30 06:19:40 -0700 Patch bug-43240-20100730132551.patch text/plain 1583 satish ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDMyMjJjZDhhNjlkNDY0NzU0MzJhMTYwMDMwNTNkOWRkYzY5OWFiMDAu LmFiOTJkODBhODk5ZmU0Zjg4NzUwOTYzOWJiZTFjNWE3YzZmNzI0OTEgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEzIEBACisyMDEwLTA3LTMwICBTYXRpc2ggU2FtcGF0aCAgPHNhdGlzaEBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkIGEgY2hlY2sgZm9yIFdlYlZpZXdDbGllbnQgYmVpbmcgbnVsbC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzMjQwCisKKyAgICAgICAgKiBz cmMvU3BlZWNoSW5wdXRDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6U3BlZWNoSW5w dXRDbGllbnRJbXBsOjpTcGVlY2hJbnB1dENsaWVudEltcGwpOgorCiAyMDEwLTA3LTMwICBIYW5z IFdlbm5ib3JnICA8aGFuc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU3Rl dmUgQmxvY2suCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL1NwZWVjaElucHV0Q2xp ZW50SW1wbC5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1NwZWVjaElucHV0Q2xpZW50SW1wbC5j cHAKaW5kZXggNmJkMGEyY2U2NmFmZmZjNTUzYmRlMzA4NGFjMGEwYzM0YWU0MGY1Mi4uNjY1MjVl MzRlOWI1OWYzNzk2YmRkYjJmYWY4YjMwMDg0MzdlNDVkYiAxMDA2NDQKLS0tIGEvV2ViS2l0L2No cm9taXVtL3NyYy9TcGVlY2hJbnB1dENsaWVudEltcGwuY3BwCisrKyBiL1dlYktpdC9jaHJvbWl1 bS9zcmMvU3BlZWNoSW5wdXRDbGllbnRJbXBsLmNwcApAQCAtNDIsMTQgKzQyLDkgQEAKIG5hbWVz cGFjZSBXZWJLaXQgewogCiBTcGVlY2hJbnB1dENsaWVudEltcGw6OlNwZWVjaElucHV0Q2xpZW50 SW1wbChXZWJWaWV3Q2xpZW50KiB3ZWJfdmlld19jbGllbnQpCi0gICAgOiBtX2NvbnRyb2xsZXIo d2ViX3ZpZXdfY2xpZW50LT5zcGVlY2hJbnB1dENvbnRyb2xsZXIodGhpcykpCisgICAgOiBtX2Nv bnRyb2xsZXIod2ViX3ZpZXdfY2xpZW50ID8gd2ViX3ZpZXdfY2xpZW50LT5zcGVlY2hJbnB1dENv bnRyb2xsZXIodGhpcykgOiAwKQogICAgICwgbV9saXN0ZW5lcigwKQogewotICAgIC8vIEZJWE1F OiBSaWdodCBub3cgV2ViVmlld0NsaWVudCBnaXZlcyBhIG51bGwgcG9pbnRlciwgYW5kIHdpdGgg dGhlCi0gICAgLy8gcnVudGltZSBmbGFnIGZvciBzcGVlY2ggaW5wdXQgZmVhdHVyZSBzZXQgdG8g dHJ1ZSBieSBkZWZhdWx0IHRoaXMgd2lsbAotICAgIC8vIGFsd2F5cyBhc3NlcnQuIEVuYWJsZSB0 aGlzIGFzc2VydCBvbmNlIHRoZSBXZWJWaWV3Q2xpZW50IHN0YXJ0cyB0bwotICAgIC8vIGdpdmUg YSB2YWxpZCBwb2ludGVyLgotICAgIC8vIEFTU0VSVChtX2NvbnRyb2xsZXIpOwogfQogCiBTcGVl Y2hJbnB1dENsaWVudEltcGw6On5TcGVlY2hJbnB1dENsaWVudEltcGwoKQo=