43115 2010-07-28 05:13:08 -0700 [Qt] QScriptValue should hhave API for accessing a private data. 2011-07-07 07:52:58 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED WONTFIX Qt, QtTriaged P2 Enhancement --- 31863 1 jedrzej.nowacki jedrzej.nowacki cmarcelo jedrzej.nowacki kent.hansen oldest_to_newest 257114 0 jedrzej.nowacki 2010-07-28 05:13:08 -0700 See http://doc.trolltech.com/4.6/qscriptvalue.html#data http://doc.trolltech.com/4.6/qscriptvalue.html#setData 257115 1 62814 jedrzej.nowacki 2010-07-28 05:16:15 -0700 Created attachment 62814 Fix v1 261925 2 62814 ariya.hidayat 2010-08-08 12:51:07 -0700 Comment on attachment 62814 Fix v1 > + [Qt] QScriptValue should hhave API for accessing a private data. Typo at "hhave". > + QExplicitlySharedDataPointer<QScriptValuePrivate> m_objectData; Can't you use the new QSharedPointer instead? > +QScriptValuePrivate* QScriptValuePrivate::data() const > +{ > + if (m_objectData) > + return m_objectData.data(); > + return new QScriptValuePrivate(); > +} Is this asking for a leak? If there is a way to use QSharedPointer, we can even pass QSharedPointer back instead of raw pointer? r- for these minor issues. Otherwise LGTM. 433452 3 jedrzej.nowacki 2011-07-07 07:52:58 -0700 Porting QtScript API over JSC C API will not be continued. 62814 2010-07-28 05:16:15 -0700 2010-09-15 00:02:35 -0700 Fix v1 qsv.diff text/plain 6476 jedrzej.nowacki ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3F0L0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3Jl L3F0L0NoYW5nZUxvZwppbmRleCBlODA0OTNiLi5kMGRjMGVmIDEwMDY0NAotLS0gYS9KYXZhU2Ny aXB0Q29yZS9xdC9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvcXQvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjYgQEAKKzIwMTAtMDctMjggIEplZHJ6ZWogTm93YWNraSAgPGplZHJ6ZWoubm93 YWNraUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgSW1wbGVtZW50IFFTY3JpcHRWYWx1ZSBkYXRhKCkgYW5kIHNldERhdGEoKSBtZXRo b2RzLgorCisgICAgICAgIFRoZXNlIGZ1bmN0aW9ucyBjYW4gYmUgdXNlZCB0byBzZXQgb3IgZ2V0 IGFuIGludGVybmFsIGRhdGEgZnJvbQorICAgICAgICBhIFFTY3JpcHRWYWx1ZSBvYmplY3QgaW5z dGFuY2UuCisKKyAgICAgICAgW1F0XSBRU2NyaXB0VmFsdWUgc2hvdWxkIGhoYXZlIEFQSSBmb3Ig YWNjZXNzaW5nIGEgcHJpdmF0ZSBkYXRhLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDMxMTUKKworICAgICAgICAqIGFwaS9xc2NyaXB0dmFsdWUuY3Bw OgorICAgICAgICAoUVNjcmlwdFZhbHVlOjpkYXRhKToKKyAgICAgICAgKFFTY3JpcHRWYWx1ZTo6 c2V0RGF0YSk6CisgICAgICAgICogYXBpL3FzY3JpcHR2YWx1ZS5oOgorICAgICAgICAqIGFwaS9x c2NyaXB0dmFsdWVfcC5oOgorICAgICAgICAoUVNjcmlwdFZhbHVlUHJpdmF0ZTo6ZGF0YSk6Cisg ICAgICAgIChRU2NyaXB0VmFsdWVQcml2YXRlOjpzZXREYXRhKToKKyAgICAgICAgKiB0ZXN0cy9x c2NyaXB0dmFsdWUvdHN0X3FzY3JpcHR2YWx1ZS5jcHA6CisgICAgICAgICh0c3RfUVNjcmlwdFZh bHVlOjpnZXRTZXREYXRhKToKKyAgICAgICAgKiB0ZXN0cy9xc2NyaXB0dmFsdWUvdHN0X3FzY3Jp cHR2YWx1ZS5oOgorCiAyMDEwLTA3LTI3ICBKZWRyemVqIE5vd2Fja2kgIDxqZWRyemVqLm5vd2Fj a2lAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0 aWFuc2VuLgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvcXQvYXBpL3FzY3JpcHR2YWx1ZS5j cHAgYi9KYXZhU2NyaXB0Q29yZS9xdC9hcGkvcXNjcmlwdHZhbHVlLmNwcAppbmRleCBhN2QwYjdi Li41MmMyNGI5IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9xdC9hcGkvcXNjcmlwdHZhbHVl LmNwcAorKysgYi9KYXZhU2NyaXB0Q29yZS9xdC9hcGkvcXNjcmlwdHZhbHVlLmNwcApAQCAtNzc3 LDMgKzc3NywzMSBAQCBRU2NyaXB0VmFsdWU6OlByb3BlcnR5RmxhZ3MgUVNjcmlwdFZhbHVlOjpw cm9wZXJ0eUZsYWdzKGNvbnN0IFFTY3JpcHRTdHJpbmcmIG5hbQogewogICAgIHJldHVybiBkX3B0 ci0+cHJvcGVydHlGbGFncyhRU2NyaXB0U3RyaW5nUHJpdmF0ZTo6Z2V0KG5hbWUpLmNvbnN0RGF0 YSgpLCBtb2RlKTsKIH0KKworLyohCisgICAgXHNpbmNlIDQuNAorCisgICAgUmV0dXJucyB0aGUg aW50ZXJuYWwgZGF0YSBvZiB0aGlzIFFTY3JpcHRWYWx1ZSBvYmplY3QuIFF0U2NyaXB0IHVzZXMK KyAgICB0aGlzIHByb3BlcnR5IHRvIHN0b3JlIHRoZSBwcmltaXRpdmUgdmFsdWUgb2YgRGF0ZSwg U3RyaW5nLCBOdW1iZXIKKyAgICBhbmQgQm9vbGVhbiBvYmplY3RzLiBGb3Igb3RoZXIgdHlwZXMg b2Ygb2JqZWN0LCBjdXN0b20gZGF0YSBtYXkgYmUKKyAgICBzdG9yZWQgdXNpbmcgc2V0RGF0YSgp LgorKi8KK1FTY3JpcHRWYWx1ZSBRU2NyaXB0VmFsdWU6OmRhdGEoKSBjb25zdAoreworICAgIHJl dHVybiBRU2NyaXB0VmFsdWVQcml2YXRlOjpnZXQoZF9wdHItPmRhdGEoKSk7Cit9CisKKy8qIQor ICAgIFxzaW5jZSA0LjQKKworICAgIFNldHMgdGhlIGludGVybmFsIFxhIGRhdGEgb2YgdGhpcyBR U2NyaXB0VmFsdWUgb2JqZWN0LiBZb3UgY2FuIHVzZQorICAgIHRoaXMgZnVuY3Rpb24gdG8gc2V0 IG9iamVjdC1zcGVjaWZpYyBkYXRhIHRoYXQgd29uJ3QgYmUgZGlyZWN0bHkKKyAgICBhY2Nlc3Np YmxlIHRvIHNjcmlwdHMsIGJ1dCBtYXkgYmUgcmV0cmlldmVkIGluIEMrKyB1c2luZyB0aGUgZGF0 YSgpCisgICAgZnVuY3Rpb24uCisKKyAgICBcc2EgUVNjcmlwdEVuZ2luZTo6cmVwb3J0QWRkaXRp b25hbE1lbW9yeUNvc3QoKQorKi8KK3ZvaWQgUVNjcmlwdFZhbHVlOjpzZXREYXRhKGNvbnN0IFFT Y3JpcHRWYWx1ZSYgZGF0YSkKK3sKKyAgICBkX3B0ci0+c2V0RGF0YShRU2NyaXB0VmFsdWVQcml2 YXRlOjpnZXQoZGF0YSkpOworfQpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvcXQvYXBpL3Fz Y3JpcHR2YWx1ZS5oIGIvSmF2YVNjcmlwdENvcmUvcXQvYXBpL3FzY3JpcHR2YWx1ZS5oCmluZGV4 IDk5MWE2YTAuLjBmMzkyMDUgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3F0L2FwaS9xc2Ny aXB0dmFsdWUuaAorKysgYi9KYXZhU2NyaXB0Q29yZS9xdC9hcGkvcXNjcmlwdHZhbHVlLmgKQEAg LTk5LDYgKzk5LDkgQEAgcHVibGljOgogICAgIFByb3BlcnR5RmxhZ3MgcHJvcGVydHlGbGFncyhj b25zdCBRU3RyaW5nJiBuYW1lLCBjb25zdCBSZXNvbHZlRmxhZ3MmIG1vZGUgPSBSZXNvbHZlUHJv dG90eXBlKSBjb25zdDsKICAgICBQcm9wZXJ0eUZsYWdzIHByb3BlcnR5RmxhZ3MoY29uc3QgUVNj cmlwdFN0cmluZyYgbmFtZSwgY29uc3QgUmVzb2x2ZUZsYWdzJiBtb2RlID0gUmVzb2x2ZVByb3Rv dHlwZSkgY29uc3Q7CiAKKyAgICBRU2NyaXB0VmFsdWUgZGF0YSgpIGNvbnN0OworICAgIHZvaWQg c2V0RGF0YShjb25zdCBRU2NyaXB0VmFsdWUmIGRhdGEpOworCiAgICAgUVNjcmlwdEVuZ2luZSog ZW5naW5lKCkgY29uc3Q7CiAKICAgICBib29sIGlzVmFsaWQoKSBjb25zdDsKZGlmZiAtLWdpdCBh L0phdmFTY3JpcHRDb3JlL3F0L2FwaS9xc2NyaXB0dmFsdWVfcC5oIGIvSmF2YVNjcmlwdENvcmUv cXQvYXBpL3FzY3JpcHR2YWx1ZV9wLmgKaW5kZXggNmZiZjk4Yi4uYmU5ZWU3NyAxMDA2NDQKLS0t IGEvSmF2YVNjcmlwdENvcmUvcXQvYXBpL3FzY3JpcHR2YWx1ZV9wLmgKKysrIGIvSmF2YVNjcmlw dENvcmUvcXQvYXBpL3FzY3JpcHR2YWx1ZV9wLmgKQEAgLTE0NSw2ICsxNDUsOSBAQCBwdWJsaWM6 CiAgICAgUVNjcmlwdFZhbHVlOjpQcm9wZXJ0eUZsYWdzIHByb3BlcnR5RmxhZ3MoY29uc3QgUVNj cmlwdFN0cmluZ1ByaXZhdGUqIG5hbWUsIGNvbnN0IFFTY3JpcHRWYWx1ZTo6UmVzb2x2ZUZsYWdz JiBtb2RlKTsKICAgICBRU2NyaXB0VmFsdWU6OlByb3BlcnR5RmxhZ3MgcHJvcGVydHlGbGFncyhj b25zdCBKU1N0cmluZ1JlZiBuYW1lLCBjb25zdCBRU2NyaXB0VmFsdWU6OlJlc29sdmVGbGFncyYg bW9kZSk7CiAKKyAgICBpbmxpbmUgUVNjcmlwdFZhbHVlUHJpdmF0ZSogZGF0YSgpIGNvbnN0Owor ICAgIGlubGluZSB2b2lkIHNldERhdGEoUVNjcmlwdFZhbHVlUHJpdmF0ZSogZGF0YSk7CisKICAg ICBpbmxpbmUgUVNjcmlwdFZhbHVlUHJpdmF0ZSogY2FsbChjb25zdCBRU2NyaXB0VmFsdWVQcml2 YXRlKiAsIGNvbnN0IFFTY3JpcHRWYWx1ZUxpc3QmIGFyZ3MpOwogCiAgICAgaW5saW5lIG9wZXJh dG9yIEpTVmFsdWVSZWYoKSBjb25zdDsKQEAgLTE2Niw2ICsxNjksNyBAQCBwcml2YXRlOgogICAg ICAgICBKU09iamVjdAogICAgIH0gbV9zdGF0ZTsKICAgICBRU2NyaXB0RW5naW5lUHRyIG1fZW5n aW5lOworICAgIFFFeHBsaWNpdGx5U2hhcmVkRGF0YVBvaW50ZXI8UVNjcmlwdFZhbHVlUHJpdmF0 ZT4gbV9vYmplY3REYXRhOwogICAgIHVuaW9uIFZhbHVlCiAgICAgewogICAgICAgICBib29sIG1f Ym9vbDsKQEAgLTEwODgsNiArMTA5MiwxOSBAQCBpbmxpbmUgUVNjcmlwdFZhbHVlOjpQcm9wZXJ0 eUZsYWdzIFFTY3JpcHRWYWx1ZVByaXZhdGU6OnByb3BlcnR5RmxhZ3MoSlNTdHJpbmdSZQogICAg IHJldHVybiBRU2NyaXB0VmFsdWU6OlByb3BlcnR5RmxhZ3MoZmxhZ3MpOwogfQogCitRU2NyaXB0 VmFsdWVQcml2YXRlKiBRU2NyaXB0VmFsdWVQcml2YXRlOjpkYXRhKCkgY29uc3QKK3sKKyAgICBp ZiAobV9vYmplY3REYXRhKQorICAgICAgICByZXR1cm4gbV9vYmplY3REYXRhLmRhdGEoKTsKKyAg ICByZXR1cm4gbmV3IFFTY3JpcHRWYWx1ZVByaXZhdGUoKTsKK30KKwordm9pZCBRU2NyaXB0VmFs dWVQcml2YXRlOjpzZXREYXRhKFFTY3JpcHRWYWx1ZVByaXZhdGUqIGRhdGEpCit7CisgICAgaWYg KGlzT2JqZWN0KCkpCisgICAgICAgIG1fb2JqZWN0RGF0YSA9IGRhdGE7Cit9CisKIFFTY3JpcHRW YWx1ZVByaXZhdGUqIFFTY3JpcHRWYWx1ZVByaXZhdGU6OmNhbGwoY29uc3QgUVNjcmlwdFZhbHVl UHJpdmF0ZSosIGNvbnN0IFFTY3JpcHRWYWx1ZUxpc3QmIGFyZ3MpCiB7CiAgICAgc3dpdGNoICht X3N0YXRlKSB7CmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9xdC90ZXN0cy9xc2NyaXB0dmFs dWUvdHN0X3FzY3JpcHR2YWx1ZS5jcHAgYi9KYXZhU2NyaXB0Q29yZS9xdC90ZXN0cy9xc2NyaXB0 dmFsdWUvdHN0X3FzY3JpcHR2YWx1ZS5jcHAKaW5kZXggZTA0ZDNlOS4uNTRhZWExMyAxMDA2NDQK LS0tIGEvSmF2YVNjcmlwdENvcmUvcXQvdGVzdHMvcXNjcmlwdHZhbHVlL3RzdF9xc2NyaXB0dmFs dWUuY3BwCisrKyBiL0phdmFTY3JpcHRDb3JlL3F0L3Rlc3RzL3FzY3JpcHR2YWx1ZS90c3RfcXNj cmlwdHZhbHVlLmNwcApAQCAtMTI5Myw0ICsxMjkzLDM5IEBAIHZvaWQgdHN0X1FTY3JpcHRWYWx1 ZTo6YXNzaWduQW5kQ29weUNvbnN0cnVjdCgpCiAgICAgUUNPTVBBUkUoYXNzaWduZWQuZW5naW5l KCksIG90aGVyLmVuZ2luZSgpKTsKIH0KIAordm9pZCB0c3RfUVNjcmlwdFZhbHVlOjpnZXRTZXRE YXRhKCkKK3sKKyAgICBRU2NyaXB0RW5naW5lIGVuZzsKKyAgICB7CisgICAgICAgIFFTY3JpcHRW YWx1ZSBvYmplY3QgPSBlbmcubmV3T2JqZWN0KCk7CisgICAgICAgIFFWRVJJRlkoIW9iamVjdC5k YXRhKCkuaXNWYWxpZCgpKTsKKyAgICAgICAgUVNjcmlwdFZhbHVlIHYxKHRydWUpOworICAgICAg ICBvYmplY3Quc2V0RGF0YSh2MSk7CisgICAgICAgIFFWRVJJRlkob2JqZWN0LmRhdGEoKS5zdHJp Y3RseUVxdWFscyh2MSkpOworICAgICAgICBRU2NyaXB0VmFsdWUgdjIoMTIzKTsKKyAgICAgICAg b2JqZWN0LnNldERhdGEodjIpOworICAgICAgICBRVkVSSUZZKG9iamVjdC5kYXRhKCkuc3RyaWN0 bHlFcXVhbHModjIpKTsKKyAgICAgICAgUVNjcmlwdFZhbHVlIHYzID0gZW5nLm5ld09iamVjdCgp OworICAgICAgICBvYmplY3Quc2V0RGF0YSh2Myk7CisgICAgICAgIFFWRVJJRlkob2JqZWN0LmRh dGEoKS5zdHJpY3RseUVxdWFscyh2MykpOworICAgICAgICBvYmplY3Quc2V0RGF0YShRU2NyaXB0 VmFsdWUoKSk7CisgICAgICAgIFFWRVJJRlkoIW9iamVjdC5kYXRhKCkuaXNWYWxpZCgpKTsKKyAg ICB9CisgICAgeworICAgICAgICBRU2NyaXB0VmFsdWUgdmFsdWUgPSBlbmcudW5kZWZpbmVkVmFs dWUoKTsKKyAgICAgICAgUVZFUklGWSghdmFsdWUuZGF0YSgpLmlzVmFsaWQoKSk7CisgICAgICAg IFFTY3JpcHRWYWx1ZSB2MSh0cnVlKTsKKyAgICAgICAgdmFsdWUuc2V0RGF0YSh2MSk7CisgICAg ICAgIFFWRVJJRlkoIXZhbHVlLmRhdGEoKS5pc1ZhbGlkKCkpOworICAgICAgICBRU2NyaXB0VmFs dWUgdjIoMTIzKTsKKyAgICAgICAgdmFsdWUuc2V0RGF0YSh2Mik7CisgICAgICAgIFFWRVJJRlko IXZhbHVlLmRhdGEoKS5pc1ZhbGlkKCkpOworICAgICAgICBRU2NyaXB0VmFsdWUgdjMgPSBlbmcu bmV3T2JqZWN0KCk7CisgICAgICAgIHZhbHVlLnNldERhdGEodjMpOworICAgICAgICBRVkVSSUZZ KCF2YWx1ZS5kYXRhKCkuaXNWYWxpZCgpKTsKKyAgICAgICAgdmFsdWUuc2V0RGF0YShRU2NyaXB0 VmFsdWUoKSk7CisgICAgICAgIFFWRVJJRlkoIXZhbHVlLmRhdGEoKS5pc1ZhbGlkKCkpOworICAg IH0KK30KKwogUVRFU1RfTUFJTih0c3RfUVNjcmlwdFZhbHVlKQpkaWZmIC0tZ2l0IGEvSmF2YVNj cmlwdENvcmUvcXQvdGVzdHMvcXNjcmlwdHZhbHVlL3RzdF9xc2NyaXB0dmFsdWUuaCBiL0phdmFT Y3JpcHRDb3JlL3F0L3Rlc3RzL3FzY3JpcHR2YWx1ZS90c3RfcXNjcmlwdHZhbHVlLmgKaW5kZXgg N2I3ZDliYy4uMDhmNGUyZCAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvcXQvdGVzdHMvcXNj cmlwdHZhbHVlL3RzdF9xc2NyaXB0dmFsdWUuaAorKysgYi9KYXZhU2NyaXB0Q29yZS9xdC90ZXN0 cy9xc2NyaXB0dmFsdWUvdHN0X3FzY3JpcHR2YWx1ZS5oCkBAIC02NSw2ICs2NSw3IEBAIHByaXZh dGUgc2xvdHM6CiAgICAgdm9pZCBnbG9iYWxPYmplY3RDaGFuZ2VzKCk7CiAgICAgdm9pZCBhc3Np Z25BbmRDb3B5Q29uc3RydWN0X2RhdGEoKTsKICAgICB2b2lkIGFzc2lnbkFuZENvcHlDb25zdHJ1 Y3QoKTsKKyAgICB2b2lkIGdldFNldERhdGEoKTsKIAogICAgIC8vIEdlbmVyYXRlZCB0ZXN0IGZ1 bmN0aW9ucy4KICAgICB2b2lkIGlzQXJyYXlfZGF0YSgpOwo=