42879 2010-07-23 00:58:01 -0700 Inline HTMLElementStack::top 2010-07-23 11:54:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41123 1 abarth abarth commit-queue eric oldest_to_newest 255245 0 abarth 2010-07-23 00:58:01 -0700 Inline HTMLElementStack::top 255247 1 62389 abarth 2010-07-23 01:00:51 -0700 Created attachment 62389 Patch 255248 2 abarth 2010-07-23 01:01:19 -0700 == pre == Running 20 times Ignoring warm-up run (4734) 4185 4244 4196 4192 4210 4200 4240 4217 4254 4240 4260 4263 4259 4280 4265 4253 4321 4268 4288 4289 avg 4246.2 stdev 35.68697241291281 == post == Running 20 times Ignoring warm-up run (4740) 4217 4172 4206 4189 4222 4199 4202 4214 4200 4222 4219 4230 4264 4230 4261 4260 4255 4300 4268 4317 avg 4232.35 stdev 36.32117151194328 255326 3 62389 eric 2010-07-23 05:04:40 -0700 Comment on attachment 62389 Patch OK, again a comment would be nice. I guess the comments could grow old rather quickly, but I hate how the rest of WebKit has so many needlessly inline functions. You can never tell which were inline because the person was lazy, and which because they tested a benchmark and found it to be a speedup. 255450 4 62439 abarth 2010-07-23 10:08:39 -0700 Created attachment 62439 Patch for landing 255493 5 62439 commit-queue 2010-07-23 11:54:15 -0700 Comment on attachment 62439 Patch for landing Clearing flags on attachment: 62439 Committed r63990: <http://trac.webkit.org/changeset/63990> 255494 6 commit-queue 2010-07-23 11:54:20 -0700 All reviewed patches have been landed. Closing bug. 62389 2010-07-23 01:00:51 -0700 2010-07-23 10:08:27 -0700 Patch bug-42879-20100723010050.patch text/plain 2094 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTJmNTdhMWU0MmM5ZWRmMzI5Mzc3YjQ2ZGJlMDMyYjAxOTRlZTAzYy4uNjI0ZTUxMDI1NWI3NGRk OGY3OGRhZjBiZmZiOWFjN2RmMjdjZTg3ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyMSBAQAogCiAgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgIElubGluZSBIVE1MRWxlbWVudFN0YWNr Ojp0b3AKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQy ODc5CisKKyAgICAgICAgQWNjb3JkaW5nIHRvIHNhbXBsaW5nLCBIVE1MRWxlbWVudFN0YWNrOjp0 b3AgaXMgdGhlIGhvdGVzdCBmdW5jdGlvbiBpbgorICAgICAgICB0aGUgdHJlZWJ1aWxkZXIuICBJ bmxpbmluZyBpdCBpcyBhYm91dCBhIDAuMyUgaW1wcm92ZW1lbnQgdG8gdGhlCisgICAgICAgIHBh cnNpbmcgYmVuY2htYXJrLiAgVGhpcyBzcXVhcmVzIHdpdGggaG93IG9mdGVuIGl0IG9jY3VycyBp biBzYW1wbGVzLgorCisgICAgICAgICogaHRtbC9IVE1MRWxlbWVudFN0YWNrLmNwcDoKKyAgICAg ICAgKiBodG1sL0hUTUxFbGVtZW50U3RhY2suaDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxFbGVt ZW50U3RhY2s6OnRvcCk6CisKKzIwMTAtMDctMjMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0 Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogICAgICAgICBS ZXNlcnZlIGNhcGFjaXR5IGZvciBhdHRyaWJ1dGVzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Mjg3NwogCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwv SFRNTEVsZW1lbnRTdGFjay5jcHAgYi9XZWJDb3JlL2h0bWwvSFRNTEVsZW1lbnRTdGFjay5jcHAK aW5kZXggZjNlNzhmNTBiZTkwYmY1YWM5NzVhMDI1ODRiN2JjN2Y0MTdmNTVhMC4uNzVhZTc1MTQy YzA5NmYwZWI5YmI3ZDMwYWJiNDdlNjYwOTU3NWRhNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1s L0hUTUxFbGVtZW50U3RhY2suY3BwCisrKyBiL1dlYkNvcmUvaHRtbC9IVE1MRWxlbWVudFN0YWNr LmNwcApAQCAtMjc4LDEyICsyNzgsNiBAQCBIVE1MRWxlbWVudFN0YWNrOjpFbGVtZW50UmVjb3Jk KiBIVE1MRWxlbWVudFN0YWNrOjp0b3BSZWNvcmQoKSBjb25zdAogICAgIHJldHVybiBtX3RvcC5n ZXQoKTsKIH0KIAotRWxlbWVudCogSFRNTEVsZW1lbnRTdGFjazo6dG9wKCkgY29uc3QKLXsKLSAg ICBBU1NFUlQobV90b3AtPmVsZW1lbnQoKSk7Ci0gICAgcmV0dXJuIG1fdG9wLT5lbGVtZW50KCk7 Ci19Ci0KIEVsZW1lbnQqIEhUTUxFbGVtZW50U3RhY2s6Om9uZUJlbG93VG9wKCkgY29uc3QKIHsK ICAgICAvLyBXZSBzaG91bGQgbmV2ZXIgYmUgY2FsbGluZyB0aGlzIGlmIGl0IGNvdWxkIGJlIDAu CmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvSFRNTEVsZW1lbnRTdGFjay5oIGIvV2ViQ29yZS9o dG1sL0hUTUxFbGVtZW50U3RhY2suaAppbmRleCA1OTY5YzgwZWQxMzdjNWNkMTM4ODE2NzFiMmEw MDA1N2Y0ZTg4ZjA1Li40MDhhZGJhMWUwNDIzOGI1NWEyNTA5MjdlMTk0NzI4ZjFjZTk0YjhjIDEw MDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvSFRNTEVsZW1lbnRTdGFjay5oCisrKyBiL1dlYkNvcmUv aHRtbC9IVE1MRWxlbWVudFN0YWNrLmgKQEAgLTY2LDggKzY2LDEzIEBAIHB1YmxpYzoKICAgICAg ICAgUmVmUHRyPEVsZW1lbnQ+IG1fZWxlbWVudDsKICAgICAgICAgT3duUHRyPEVsZW1lbnRSZWNv cmQ+IG1fbmV4dDsKICAgICB9OwotICAgIAotICAgIEVsZW1lbnQqIHRvcCgpIGNvbnN0OworCisg ICAgRWxlbWVudCogdG9wKCkgY29uc3QKKyAgICB7CisgICAgICAgIEFTU0VSVChtX3RvcC0+ZWxl bWVudCgpKTsKKyAgICAgICAgcmV0dXJuIG1fdG9wLT5lbGVtZW50KCk7CisgICAgfQorCiAgICAg RWxlbWVudCogb25lQmVsb3dUb3AoKSBjb25zdDsKICAgICBFbGVtZW50UmVjb3JkKiB0b3BSZWNv cmQoKSBjb25zdDsKICAgICBFbGVtZW50KiBib3R0b20oKSBjb25zdDsK 62439 2010-07-23 10:08:39 -0700 2010-07-23 11:54:15 -0700 Patch for landing bug-42879-20100723100838.patch text/plain 2002 abarth SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2Mzk4NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDctMjMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KKworICAgICAgICBJbmxpbmUg SFRNTEVsZW1lbnRTdGFjazo6dG9wCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00Mjg3OQorCisgICAgICAgIEFjY29yZGluZyB0byBzYW1wbGluZywgSFRN TEVsZW1lbnRTdGFjazo6dG9wIGlzIHRoZSBob3Rlc3QgZnVuY3Rpb24gaW4KKyAgICAgICAgdGhl IHRyZWVidWlsZGVyLiAgSW5saW5pbmcgaXQgaXMgYWJvdXQgYSAwLjMlIGltcHJvdmVtZW50IHRv IHRoZQorICAgICAgICBwYXJzaW5nIGJlbmNobWFyay4gIFRoaXMgc3F1YXJlcyB3aXRoIGhvdyBv ZnRlbiBpdCBvY2N1cnMgaW4gc2FtcGxlcy4KKworICAgICAgICAqIGh0bWwvSFRNTEVsZW1lbnRT dGFjay5jcHA6CisgICAgICAgICogaHRtbC9IVE1MRWxlbWVudFN0YWNrLmg6CisgICAgICAgIChX ZWJDb3JlOjpIVE1MRWxlbWVudFN0YWNrOjp0b3ApOgorCiAyMDEwLTA3LTIzICBKdXN0aW4gU2No dWggIDxqc2NodWhAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcg b3V0IHI2MzkyNS4KSW5kZXg6IFdlYkNvcmUvaHRtbC9IVE1MRWxlbWVudFN0YWNrLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvSFRNTEVsZW1lbnRTdGFjay5jcHAJKHJldmlzaW9uIDYz OTg0KQorKysgV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50U3RhY2suY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yNzgsMTIgKzI3OCw2IEBAIEhUTUxFbGVtZW50U3RhY2s6OkVsZW1lbnRSZWNvcmQqIEhU TUxFbGUKICAgICByZXR1cm4gbV90b3AuZ2V0KCk7CiB9CiAKLUVsZW1lbnQqIEhUTUxFbGVtZW50 U3RhY2s6OnRvcCgpIGNvbnN0Ci17Ci0gICAgQVNTRVJUKG1fdG9wLT5lbGVtZW50KCkpOwotICAg IHJldHVybiBtX3RvcC0+ZWxlbWVudCgpOwotfQotCiBFbGVtZW50KiBIVE1MRWxlbWVudFN0YWNr OjpvbmVCZWxvd1RvcCgpIGNvbnN0CiB7CiAgICAgLy8gV2Ugc2hvdWxkIG5ldmVyIGJlIGNhbGxp bmcgdGhpcyBpZiBpdCBjb3VsZCBiZSAwLgpJbmRleDogV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50 U3RhY2suaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvSFRNTEVsZW1lbnRTdGFjay5oCShy ZXZpc2lvbiA2Mzk4NCkKKysrIFdlYkNvcmUvaHRtbC9IVE1MRWxlbWVudFN0YWNrLmgJKHdvcmtp bmcgY29weSkKQEAgLTY2LDggKzY2LDE1IEBAIHB1YmxpYzoKICAgICAgICAgUmVmUHRyPEVsZW1l bnQ+IG1fZWxlbWVudDsKICAgICAgICAgT3duUHRyPEVsZW1lbnRSZWNvcmQ+IG1fbmV4dDsKICAg ICB9OwotICAgIAotICAgIEVsZW1lbnQqIHRvcCgpIGNvbnN0OworCisgICAgLy8gSW5saW5pbmcg dGhpcyBmdW5jdGlvbiBpcyBhIChzbWFsbCkgcGVyZm9ybWFuY2Ugd2luIG9uIHRoZSBwYXJzaW5n CisgICAgLy8gYmVuY2htYXJrLgorICAgIEVsZW1lbnQqIHRvcCgpIGNvbnN0CisgICAgeworICAg ICAgICBBU1NFUlQobV90b3AtPmVsZW1lbnQoKSk7CisgICAgICAgIHJldHVybiBtX3RvcC0+ZWxl bWVudCgpOworICAgIH0KKwogICAgIEVsZW1lbnQqIG9uZUJlbG93VG9wKCkgY29uc3Q7CiAgICAg RWxlbWVudFJlY29yZCogdG9wUmVjb3JkKCkgY29uc3Q7CiAgICAgRWxlbWVudCogYm90dG9tKCkg Y29uc3Q7Cg==