42773 2010-07-21 12:24:36 -0700 Fix the last tree HTML5 tree builder crashes 2010-07-21 13:23:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41123 1 abarth abarth commit-queue eric oldest_to_newest 254449 0 abarth 2010-07-21 12:24:36 -0700 Fix the last tree HTML5 tree builder crashes 254450 1 62218 abarth 2010-07-21 12:27:28 -0700 Created attachment 62218 Patch 254453 2 62218 eric 2010-07-21 12:29:35 -0700 Comment on attachment 62218 Patch What a gorgeous patch! If I'm crying, it's tears of joy, good sir. 254487 3 62218 commit-queue 2010-07-21 13:23:51 -0700 Comment on attachment 62218 Patch Clearing flags on attachment: 62218 Committed r63851: <http://trac.webkit.org/changeset/63851> 254488 4 commit-queue 2010-07-21 13:23:56 -0700 All reviewed patches have been landed. Closing bug. 62218 2010-07-21 12:27:28 -0700 2010-07-21 13:23:51 -0700 Patch bug-42773-20100721122727.patch text/plain 6810 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDU5NGQwYTQ3NjlmYTQwNWIxNmM1YzZiNmM3OTY1ZDE1ZDY0YzY4Yy4uZDYzZjJlNDVhNjllZjBm NmQ2ZTU2NWIyYjgzMjkzODAxOGRhZWQxNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzMiBAQAorMjAxMC0wNy0yMSAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeCB0aGUgbGFzdCB0cmVlIEhUTUw1IHRyZWUgYnVpbGRl ciBjcmFzaGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00Mjc3MworCisgICAgICAgIFRoaXMgcGF0Y2ggY2hhbmdlcyB0aGUgaW50ZXJuYWwgcmVwcmVz ZW50YXRpb24gb2YgYSBib29rbWFyayB0byBoYW5kbGUKKyAgICAgICAgdGhlIGNhc2Ugd2hlcmUg b25lIG9mIHRoZSBhZGplY2VudCBlbnRyaWVzIGluIHRoZSBsaXN0IG9mIGFjdGl2ZQorICAgICAg ICBmb3JtYXR0aW5nIGVsZW1lbnRzIGlzIGFjdHVhbGx5IGEgbWFya2VyLgorCisgICAgICAgIEFm dGVyIHRoaXMgcGF0Y2gsIHRoZSBib29rbWFya2luZyBtZWNoYW5pc20gaXNuJ3QgYXMgZ2VuZXJh bCwgYnV0IGl0CisgICAgICAgIHdvcmtzIGZvciB0aGUgY2FzZXMgd2UgbmVlZCBpbiB0aGUgYWRv cHRpb24gYWdlbmN5LgorCisgICAgICAgIEFsc28sIGFmdGVyIHRoaXMgcGF0Y2gsIHRoZXJlIGFy ZW4ndCBhbnkgbW9yZSBrbm93biBjcmFzaGVycyBpbiB0aGUKKyAgICAgICAgSFRNTDUgdHJlZSBi dWlsZGVyLiAgOikKKworICAgICAgICAqIGh0bWwvSFRNTEZvcm1hdHRpbmdFbGVtZW50TGlzdC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRm9ybWF0dGluZ0VsZW1lbnRMaXN0Ojpib29rbWFy a0Zvcik6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRm9ybWF0dGluZ0VsZW1lbnRMaXN0Ojpzd2Fw VG8pOgorICAgICAgICAqIGh0bWwvSFRNTEZvcm1hdHRpbmdFbGVtZW50TGlzdC5oOgorICAgICAg ICAoV2ViQ29yZTo6SFRNTEZvcm1hdHRpbmdFbGVtZW50TGlzdDo6Qm9va21hcms6OkJvb2ttYXJr KToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxGb3JtYXR0aW5nRWxlbWVudExpc3Q6OkJvb2ttYXJr Ojptb3ZlVG9BZnRlcik6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRm9ybWF0dGluZ0VsZW1lbnRM aXN0OjpCb29rbWFyazo6aGFzQmVlbk1vdmVkKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxGb3Jt YXR0aW5nRWxlbWVudExpc3Q6OkJvb2ttYXJrOjptYXJrKToKKyAgICAgICAgKFdlYkNvcmU6OkhU TUxGb3JtYXR0aW5nRWxlbWVudExpc3Q6OmZpcnN0KToKKyAgICAgICAgKiBodG1sL0hUTUxUcmVl QnVpbGRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVHJlZUJ1aWxkZXI6OmNhbGxUaGVB ZG9wdGlvbkFnZW5jeSk6CisKIDIwMTAtMDctMjAgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQg YS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1hdHRpbmdFbGVtZW50TGlzdC5jcHAgYi9XZWJDb3JlL2h0 bWwvSFRNTEZvcm1hdHRpbmdFbGVtZW50TGlzdC5jcHAKaW5kZXggMzE2YjBiZjFhODFhYjg4YTEx Zjg3ZjQ2NDg0MGU5YWMzN2Q4M2YxMS4uMjJiZjAzZWRkNzQ0MmU0ZmJhNjFhMWY0ZmVhNWUwMmIx NTJlNzE5NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL0hUTUxGb3JtYXR0aW5nRWxlbWVudExp c3QuY3BwCisrKyBiL1dlYkNvcmUvaHRtbC9IVE1MRm9ybWF0dGluZ0VsZW1lbnRMaXN0LmNwcApA QCAtNzAsMzYgKzcwLDIyIEBAIEhUTUxGb3JtYXR0aW5nRWxlbWVudExpc3Q6OkJvb2ttYXJrIEhU TUxGb3JtYXR0aW5nRWxlbWVudExpc3Q6OmJvb2ttYXJrRm9yKEVsZW1lCiB7CiAgICAgc2l6ZV90 IGluZGV4ID0gbV9lbnRyaWVzLnJldmVyc2VGaW5kKGVsZW1lbnQpOwogICAgIEFTU0VSVChpbmRl eCAhPSBub3RGb3VuZCk7Ci0gICAgRWxlbWVudCogZWxlbWVudEJlZm9yZSA9IChpbmRleCA+IDEp ID8gbV9lbnRyaWVzW2luZGV4IC0gMV0uZWxlbWVudCgpIDogMDsKLSAgICBFbGVtZW50KiBlbGVt ZW50QWZ0ZXIgPSAoaW5kZXggPCBtX2VudHJpZXMuc2l6ZSgpIC0gMSkgPyBtX2VudHJpZXNbaW5k ZXggKyAxXS5lbGVtZW50KCkgOiAwOwotICAgIHJldHVybiBCb29rbWFyayhlbGVtZW50QmVmb3Jl LCBlbGVtZW50QWZ0ZXIpOworICAgIHJldHVybiBCb29rbWFyaygmYXQoaW5kZXgpKTsKIH0KIAot dm9pZCBIVE1MRm9ybWF0dGluZ0VsZW1lbnRMaXN0OjppbnNlcnRBdChFbGVtZW50KiBlbGVtZW50 LCBjb25zdCBCb29rbWFyayYgYm9va21hcmspCit2b2lkIEhUTUxGb3JtYXR0aW5nRWxlbWVudExp c3Q6OnN3YXBUbyhFbGVtZW50KiBvbGRFbGVtZW50LCBFbGVtZW50KiBuZXdFbGVtZW50LCBjb25z dCBCb29rbWFyayYgYm9va21hcmspCiB7Ci0gICAgc2l6ZV90IGJlZm9yZUluZGV4ID0gbm90Rm91 bmQ7Ci0gICAgaWYgKGJvb2ttYXJrLmVsZW1lbnRCZWZvcmUoKSkgewotICAgICAgICBiZWZvcmVJ bmRleCA9IG1fZW50cmllcy5yZXZlcnNlRmluZChib29rbWFyay5lbGVtZW50QmVmb3JlKCkpOwot ICAgICAgICBBU1NFUlQoYmVmb3JlSW5kZXggIT0gbm90Rm91bmQpOwotICAgIH0KLSAgICBzaXpl X3QgYWZ0ZXJJbmRleCA9IG5vdEZvdW5kOwotICAgIGlmIChib29rbWFyay5lbGVtZW50QWZ0ZXIo KSkgewotICAgICAgICBhZnRlckluZGV4ID0gbV9lbnRyaWVzLnJldmVyc2VGaW5kKGJvb2ttYXJr LmVsZW1lbnRBZnRlcigpKTsKLSAgICAgICAgQVNTRVJUKGFmdGVySW5kZXggIT0gbm90Rm91bmQp OwotICAgIH0KLQotICAgIGlmICghYm9va21hcmsuZWxlbWVudEJlZm9yZSgpKSB7Ci0gICAgICAg IGlmIChib29rbWFyay5lbGVtZW50QWZ0ZXIoKSkKLSAgICAgICAgICAgIEFTU0VSVCghYWZ0ZXJJ bmRleCk7Ci0gICAgICAgIG1fZW50cmllcy5wcmVwZW5kKGVsZW1lbnQpOwotICAgIH0gZWxzZSB7 Ci0gICAgICAgIGlmIChib29rbWFyay5lbGVtZW50QWZ0ZXIoKSkgewotICAgICAgICAgICAgLy8g Qm9va21hcmtzIGFyZSBub3QgZ2VuZXJhbCBwdXJwb3NlLiAgVGhleSdyZSBvbmx5IGZvciB0aGUg QWRvcHRpb24KLSAgICAgICAgICAgIC8vIEFnZW5jeS4gQXNzdW1lIHRoZSBib29rbWFya2VkIGVs ZW1lbnQgd2FzIGFscmVhZHkgcmVtb3ZlZC4KLSAgICAgICAgICAgIEFTU0VSVChiZWZvcmVJbmRl eCArIDEgPT0gYWZ0ZXJJbmRleCk7Ci0gICAgICAgIH0KLSAgICAgICAgbV9lbnRyaWVzLmluc2Vy dChiZWZvcmVJbmRleCArIDEsIGVsZW1lbnQpOworICAgIEFTU0VSVChjb250YWlucyhvbGRFbGVt ZW50KSk7CisgICAgQVNTRVJUKCFjb250YWlucyhuZXdFbGVtZW50KSk7CisgICAgaWYgKCFib29r bWFyay5oYXNCZWVuTW92ZWQoKSkgeworICAgICAgICBBU1NFUlQoYm9va21hcmsubWFyaygpLT5l bGVtZW50KCkgPT0gb2xkRWxlbWVudCk7CisgICAgICAgIGJvb2ttYXJrLm1hcmsoKS0+cmVwbGFj ZUVsZW1lbnQobmV3RWxlbWVudCk7CisgICAgICAgIHJldHVybjsKICAgICB9CisgICAgc2l6ZV90 IGluZGV4ID0gYm9va21hcmsubWFyaygpIC0gZmlyc3QoKTsKKyAgICBBU1NFUlQoaW5kZXggPCBz aXplKCkpOworICAgIG1fZW50cmllcy5pbnNlcnQoaW5kZXggKyAxLCBuZXdFbGVtZW50KTsKKyAg ICByZW1vdmUob2xkRWxlbWVudCk7CiB9CiAKIHZvaWQgSFRNTEZvcm1hdHRpbmdFbGVtZW50TGlz dDo6YXBwZW5kKEVsZW1lbnQqIGVsZW1lbnQpCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvSFRN TEZvcm1hdHRpbmdFbGVtZW50TGlzdC5oIGIvV2ViQ29yZS9odG1sL0hUTUxGb3JtYXR0aW5nRWxl bWVudExpc3QuaAppbmRleCAxNmUyZjYyNDQ2MWE0NTUzMjI2MmE2YzdjNjIyYmM3MWVkMTBiY2Mz Li4xMzUxNjNjOWZmMDkzM2ExNDJkY2NkNTY4YzEwMjc4YWRmYjk5NTE5IDEwMDY0NAotLS0gYS9X ZWJDb3JlL2h0bWwvSFRNTEZvcm1hdHRpbmdFbGVtZW50TGlzdC5oCisrKyBiL1dlYkNvcmUvaHRt bC9IVE1MRm9ybWF0dGluZ0VsZW1lbnRMaXN0LmgKQEAgLTgwLDI0ICs4MCwyNCBAQCBwdWJsaWM6 CiAKICAgICBjbGFzcyBCb29rbWFyayB7CiAgICAgcHVibGljOgotICAgICAgICBCb29rbWFyayhF bGVtZW50KiBiZWZvcmUsIEVsZW1lbnQqIGFmdGVyKQotICAgICAgICAgICAgOiBtX2JlZm9yZShi ZWZvcmUpCi0gICAgICAgICAgICAsIG1fYWZ0ZXIoYWZ0ZXIpCisgICAgICAgIEJvb2ttYXJrKEVu dHJ5KiBlbnRyeSkKKyAgICAgICAgICAgIDogbV9oYXNCZWVuTW92ZWQoZmFsc2UpCisgICAgICAg ICAgICAsIG1fbWFyayhlbnRyeSkKICAgICAgICAgewogICAgICAgICB9CiAKLSAgICAgICAgdm9p ZCBtb3ZlVG9BZnRlcihFbGVtZW50KiBiZWZvcmUpCisgICAgICAgIHZvaWQgbW92ZVRvQWZ0ZXIo RW50cnkqIGJlZm9yZSkKICAgICAgICAgewotICAgICAgICAgICAgbV9iZWZvcmUgPSBiZWZvcmU7 Ci0gICAgICAgICAgICBtX2FmdGVyID0gMDsKKyAgICAgICAgICAgIG1faGFzQmVlbk1vdmVkID0g dHJ1ZTsKKyAgICAgICAgICAgIG1fbWFyayA9IGJlZm9yZTsKICAgICAgICAgfQogCi0gICAgICAg IEVsZW1lbnQqIGVsZW1lbnRCZWZvcmUoKSBjb25zdCB7IHJldHVybiBtX2JlZm9yZTsgfQotICAg ICAgICBFbGVtZW50KiBlbGVtZW50QWZ0ZXIoKSBjb25zdCB7IHJldHVybiBtX2FmdGVyOyB9Cisg ICAgICAgIGJvb2wgaGFzQmVlbk1vdmVkKCkgY29uc3QgeyByZXR1cm4gbV9oYXNCZWVuTW92ZWQ7 IH0KKyAgICAgICAgRW50cnkqIG1hcmsoKSBjb25zdCB7IHJldHVybiBtX21hcms7IH0KIAogICAg IHByaXZhdGU6Ci0gICAgICAgIEVsZW1lbnQqIG1fYmVmb3JlOwotICAgICAgICBFbGVtZW50KiBt X2FmdGVyOworICAgICAgICBib29sIG1faGFzQmVlbk1vdmVkOworICAgICAgICBFbnRyeSogbV9t YXJrOwogICAgIH07CiAKICAgICBib29sIGlzRW1wdHkoKSBjb25zdCB7IHJldHVybiAhc2l6ZSgp OyB9CkBAIC0xMTEsNyArMTExLDcgQEAgcHVibGljOgogICAgIHZvaWQgcmVtb3ZlKEVsZW1lbnQq KTsKIAogICAgIEJvb2ttYXJrIGJvb2ttYXJrRm9yKEVsZW1lbnQqKTsKLSAgICB2b2lkIGluc2Vy dEF0KEVsZW1lbnQqLCBjb25zdCBCb29rbWFyayYpOworICAgIHZvaWQgc3dhcFRvKEVsZW1lbnQq IG9sZEVsZW1lbnQsIEVsZW1lbnQqIG5ld0VsZW1lbnQsIGNvbnN0IEJvb2ttYXJrJik7CiAKICAg ICB2b2lkIGFwcGVuZE1hcmtlcigpOwogICAgIC8vIGNsZWFyVG9MYXN0TWFya2VyIGFsc28gY2xl YXJzIHRoZSBtYXJrZXIgKHBlciB0aGUgSFRNTDUgc3BlYykuCkBAIC0xMjUsNiArMTI1LDggQEAg cHVibGljOgogI2VuZGlmCiAKIHByaXZhdGU6CisgICAgRW50cnkqIGZpcnN0KCkgeyByZXR1cm4g JmF0KDApOyB9CisKICAgICBWZWN0b3I8RW50cnk+IG1fZW50cmllczsKIH07CiAKZGlmZiAtLWdp dCBhL1dlYkNvcmUvaHRtbC9IVE1MVHJlZUJ1aWxkZXIuY3BwIGIvV2ViQ29yZS9odG1sL0hUTUxU cmVlQnVpbGRlci5jcHAKaW5kZXggY2MyNDMzOTA5ODg1MjY5ODliYjYwNTBmNGJhY2VlM2RkNDAx YjEzNS4uOTNkYTNmNzc4Y2FlMWE5YTJhYTA0ZGY5Y2M1ZGU0MzY4NTM5MzRlNyAxMDA2NDQKLS0t IGEvV2ViQ29yZS9odG1sL0hUTUxUcmVlQnVpbGRlci5jcHAKKysrIGIvV2ViQ29yZS9odG1sL0hU TUxUcmVlQnVpbGRlci5jcHAKQEAgLTE2ODgsNyArMTY4OCw3IEBAIHZvaWQgSFRNTFRyZWVCdWls ZGVyOjpjYWxsVGhlQWRvcHRpb25BZ2VuY3koQXRvbWljSFRNTFRva2VuJiB0b2tlbikKICAgICAg ICAgICAgIC8vIHdhcyByZXBsYWNlZCBpbiA2LjUuCiAgICAgICAgICAgICAvLyBodHRwOi8vd3d3 LnczLm9yZy9CdWdzL1B1YmxpYy9zaG93X2J1Zy5jZ2k/aWQ9MTAwOTYKICAgICAgICAgICAgIGlm IChsYXN0Tm9kZSA9PSBmdXJ0aGVzdEJsb2NrKQotICAgICAgICAgICAgICAgIGJvb2ttYXJrLm1v dmVUb0FmdGVyKG5vZGUtPmVsZW1lbnQoKSk7CisgICAgICAgICAgICAgICAgYm9va21hcmsubW92 ZVRvQWZ0ZXIobm9kZUVudHJ5KTsKICAgICAgICAgICAgIC8vIDYuNgogICAgICAgICAgICAgLy8g VXNlIGFwcGVuZENoaWxkIGluc3RlYWQgb2YgcGFyc2VyQWRkQ2hpbGQgdG8gaGFuZGxlIHBvc3Np YmxlIHJlcGFyZW50aW5nLgogICAgICAgICAgICAgRXhjZXB0aW9uQ29kZSBlYzsKQEAgLTE3MjUs OCArMTcyNSw3IEBAIHZvaWQgSFRNTFRyZWVCdWlsZGVyOjpjYWxsVGhlQWRvcHRpb25BZ2VuY3ko QXRvbWljSFRNTFRva2VuJiB0b2tlbikKICAgICAgICAgICAgIG5ld0VsZW1lbnQtPmF0dGFjaCgp OwogICAgICAgICB9CiAgICAgICAgIC8vIDExCi0gICAgICAgIG1fdHJlZS5hY3RpdmVGb3JtYXR0 aW5nRWxlbWVudHMoKS0+cmVtb3ZlKGZvcm1hdHRpbmdFbGVtZW50KTsKLSAgICAgICAgbV90cmVl LmFjdGl2ZUZvcm1hdHRpbmdFbGVtZW50cygpLT5pbnNlcnRBdChuZXdFbGVtZW50LmdldCgpLCBi b29rbWFyayk7CisgICAgICAgIG1fdHJlZS5hY3RpdmVGb3JtYXR0aW5nRWxlbWVudHMoKS0+c3dh cFRvKGZvcm1hdHRpbmdFbGVtZW50LCBuZXdFbGVtZW50LmdldCgpLCBib29rbWFyayk7CiAgICAg ICAgIC8vIDEyCiAgICAgICAgIG1fdHJlZS5vcGVuRWxlbWVudHMoKS0+cmVtb3ZlKGZvcm1hdHRp bmdFbGVtZW50KTsKICAgICAgICAgbV90cmVlLm9wZW5FbGVtZW50cygpLT5pbnNlcnRBYm92ZShu ZXdFbGVtZW50LCBmdXJ0aGVzdEJsb2NrKTsK