42607 2010-07-19 16:57:56 -0700 Only set unloadEventEnd when the unload event is actually fired 2010-07-19 19:37:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 30685 1 tonyg tonyg dglazkov fishd webkit.review.bot oldest_to_newest 253476 0 tonyg 2010-07-19 16:57:56 -0700 Only set unloadEventEnd when the unload event is actually fired 253480 1 62013 tonyg 2010-07-19 17:05:52 -0700 Created attachment 62013 Patch 253481 2 webkit.review.bot 2010-07-19 17:06:37 -0700 Attachment 62013 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 253486 3 62016 tonyg 2010-07-19 17:12:47 -0700 Created attachment 62016 Fix tabs in ChangeLog 253528 4 tonyg 2010-07-19 19:37:55 -0700 Committed r63707: <http://trac.webkit.org/changeset/63707> 62013 2010-07-19 17:05:52 -0700 2010-07-19 17:12:44 -0700 Patch bug-42607-20100719170551.patch text/plain 2905 tonyg ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzY5MmMyMDQzNTVkZThhOThjZWU0ODdmNTk4MzAxY2U5Y2E1MWI4MC4uZjdkODM0ZDU2YjE1OTdj MDc5YmVjY2Y0NjA3YzI5YWY0YmJhZThiZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMSBAQAogMjAxMC0wNy0xOSAgVG9u eSBHZW50aWxjb3JlICA8dG9ueWdAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9ubHkgc2V0IHVubG9hZEV2ZW50RW5kIHdoZW4g dGhlIHVubG9hZCBldmVudCBpcyBhY3R1YWxseSBmaXJlZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI2MDcKKworCXI2MzY4OSBpbnRyb2R1Y2VkIHRo aXMgQVNTRVJUIGFuZCBpdCBiZWdhbiBmYWlsaW5nIG9uIFF0IGFuZCBNYWMgZGVidWcuCisJRm9y IHNvbWUgcmVhc29uLCBpdCBkaWQgbm90IGZhaWwgb24gV2luZG93cyAod2hpY2ggaXMgd2hlcmUg SSB3YXMKKwl0ZXN0aW5nKS4gVGhlIEFTU0VSVCB3YXMgZGlzYWJsZWQgaW4gcjYzNjk5LgorCisg ICAgICAgIFRlc3Q6IHBhZ2UtY2FjaGUgcmVsYXRlZCBsYXlvdXQgdGVzdHMgZG9uJ3QgY3Jhc2gg aW4gZGVidWcgbW9kZSBvbiBNYWMuCisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OnN0b3BMb2FkaW5nKToKKworMjAxMC0w Ny0xOSAgVG9ueSBHZW50aWxjb3JlICA8dG9ueWdAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFVu cmV2aWV3ZWQgYnVpbGQgZml4LgogCiAgICAgICAgIFJlbW92ZSBvdmVyemVhbG91cyBBU1NFUlQg ZnJvbSByNjM2ODkKZGlmZiAtLWdpdCBhL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcCBi L1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAppbmRleCA3ZDk2MGNkNGQxODRiNDk3Mzkz MDlmNjNiMWI0ZTk1NTYzYjczZTRhLi5kMzYwMjM2NzQwZjE0MTljN2UxOWY5MWE2NDQ4YWZlMjM3 NTQzNzM1IDEwMDY0NAotLS0gYS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKKysrIGIv V2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCkBAIC00NDcsMTUgKzQ0NywxNiBAQCB2b2lk IEZyYW1lTG9hZGVyOjpzdG9wTG9hZGluZyhVbmxvYWRFdmVudFBvbGljeSB1bmxvYWRFdmVudFBv bGljeSwgRGF0YWJhc2VQb2xpYwogICAgICAgICAgICAgICAgIGlmIChtX2ZyYW1lLT5kb21XaW5k b3coKSkgewogICAgICAgICAgICAgICAgICAgICBpZiAodW5sb2FkRXZlbnRQb2xpY3kgPT0gVW5s b2FkRXZlbnRQb2xpY3lVbmxvYWRBbmRQYWdlSGlkZSkKICAgICAgICAgICAgICAgICAgICAgICAg IG1fZnJhbWUtPmRvbVdpbmRvdygpLT5kaXNwYXRjaEV2ZW50KFBhZ2VUcmFuc2l0aW9uRXZlbnQ6 OmNyZWF0ZShldmVudE5hbWVzKCkucGFnZWhpZGVFdmVudCwgbV9mcmFtZS0+ZG9jdW1lbnQoKS0+ aW5QYWdlQ2FjaGUoKSksIG1fZnJhbWUtPmRvY3VtZW50KCkpOwotICAgICAgICAgICAgICAgICAg ICBpZiAoIW1fZnJhbWUtPmRvY3VtZW50KCktPmluUGFnZUNhY2hlKCkpCisgICAgICAgICAgICAg ICAgICAgIGlmICghbV9mcmFtZS0+ZG9jdW1lbnQoKS0+aW5QYWdlQ2FjaGUoKSkgewogICAgICAg ICAgICAgICAgICAgICAgICAgbV9mcmFtZS0+ZG9tV2luZG93KCktPmRpc3BhdGNoRXZlbnQoRXZl bnQ6OmNyZWF0ZShldmVudE5hbWVzKCkudW5sb2FkRXZlbnQsIGZhbHNlLCBmYWxzZSksIG1fZnJh bWUtPmRvbVdpbmRvdygpLT5kb2N1bWVudCgpKTsKLSAgICAgICAgICAgICAgICAgICAgaWYgKG1f cHJvdmlzaW9uYWxEb2N1bWVudExvYWRlcikgewotICAgICAgICAgICAgICAgICAgICAgICAgRG9j dW1lbnRMb2FkVGltaW5nKiB0aW1pbmcgPSBtX3Byb3Zpc2lvbmFsRG9jdW1lbnRMb2FkZXItPnRp bWluZygpOwotICAgICAgICAgICAgICAgICAgICAgICAgQVNTRVJUKHRpbWluZy0+bmF2aWdhdGlv blN0YXJ0KTsKLSAgICAgICAgICAgICAgICAgICAgICAgIC8vIEZJWE1FOiBUaGlzIGZhaWxzLiBV bmRlcnN0YW5kIHdoeS4KLSAgICAgICAgICAgICAgICAgICAgICAgIC8vIEFTU0VSVCghdGltaW5n LT51bmxvYWRFdmVudEVuZCk7Ci0gICAgICAgICAgICAgICAgICAgICAgICB0aW1pbmctPnVubG9h ZEV2ZW50RW5kID0gY3VycmVudFRpbWUoKTsKLSAgICAgICAgICAgICAgICAgICAgICAgIEFTU0VS VCh0aW1pbmctPnVubG9hZEV2ZW50RW5kID49IHRpbWluZy0+bmF2aWdhdGlvblN0YXJ0KTsKKwor ICAgICAgICAgICAgICAgICAgICAgICAgaWYgKG1fcHJvdmlzaW9uYWxEb2N1bWVudExvYWRlcikg eworICAgICAgICAgICAgICAgICAgICAgICAgICAgIERvY3VtZW50TG9hZFRpbWluZyogdGltaW5n ID0gbV9wcm92aXNpb25hbERvY3VtZW50TG9hZGVyLT50aW1pbmcoKTsKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICBBU1NFUlQodGltaW5nLT5uYXZpZ2F0aW9uU3RhcnQpOworICAgICAgICAg ICAgICAgICAgICAgICAgICAgIEFTU0VSVCghdGltaW5nLT51bmxvYWRFdmVudEVuZCk7CisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgdGltaW5nLT51bmxvYWRFdmVudEVuZCA9IGN1cnJlbnRU aW1lKCk7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgQVNTRVJUKHRpbWluZy0+dW5sb2Fk RXZlbnRFbmQgPj0gdGltaW5nLT5uYXZpZ2F0aW9uU3RhcnQpOworICAgICAgICAgICAgICAgICAg ICAgICAgfQogICAgICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgfQogICAgICAg ICAgICAgICAgIG1fcGFnZURpc21pc3NhbEV2ZW50QmVpbmdEaXNwYXRjaGVkID0gZmFsc2U7Cg== 62016 2010-07-19 17:12:47 -0700 2010-07-19 19:21:31 -0700 Fix tabs in ChangeLog bug-42607-20100719171246.patch text/plain 2879 tonyg ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OWJlMTIzNzRhNGRjYjEwMjUyZTkzMjE0MDRiMDhlNDBjOTNiNjExNS4uYTZmZTllNDg4NDc1OWVh MmM0ZjEyMGNlN2NmNTA3MGM1ZmU2NDU2OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wNy0xOSAgVG9u eSBHZW50aWxjb3JlICA8dG9ueWdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9ubHkgc2V0IHVubG9hZEV2ZW50RW5kIHdoZW4g dGhlIHVubG9hZCBldmVudCBpcyBhY3R1YWxseSBmaXJlZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI2MDcKKworICAgICAgICByNjM2ODkgaW50cm9k dWNlZCB0aGlzIEFTU0VSVCBhbmQgaXQgYmVnYW4gZmFpbGluZyBvbiBRdCBhbmQgTWFjIGRlYnVn LgorICAgICAgICBGb3Igc29tZSByZWFzb24sIGl0IGRpZCBub3QgZmFpbCBvbiBXaW5kb3dzICh3 aGljaCBpcyB3aGVyZSBJIHdhcworICAgICAgICB0ZXN0aW5nKS4gVGhlIEFTU0VSVCB3YXMgZGlz YWJsZWQgaW4gcjYzNjk5LgorCisgICAgICAgIFRlc3Q6IHBhZ2UtY2FjaGUgcmVsYXRlZCBsYXlv dXQgdGVzdHMgZG9uJ3QgY3Jhc2ggaW4gZGVidWcgbW9kZSBvbiBNYWMuCisKKyAgICAgICAgKiBs b2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OnN0 b3BMb2FkaW5nKToKKwogMjAxMC0wNy0xOSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBw bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9X ZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAgYi9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRl ci5jcHAKaW5kZXggN2Q5NjBjZDRkMTg0YjQ5NzM5MzA5ZjYzYjFiNGU5NTU2M2I3M2U0YS4uZDM2 MDIzNjc0MGYxNDE5YzdlMTlmOTFhNjQ0OGFmZTIzNzU0MzczNSAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCisrKyBiL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVy LmNwcApAQCAtNDQ3LDE1ICs0NDcsMTYgQEAgdm9pZCBGcmFtZUxvYWRlcjo6c3RvcExvYWRpbmco VW5sb2FkRXZlbnRQb2xpY3kgdW5sb2FkRXZlbnRQb2xpY3ksIERhdGFiYXNlUG9saWMKICAgICAg ICAgICAgICAgICBpZiAobV9mcmFtZS0+ZG9tV2luZG93KCkpIHsKICAgICAgICAgICAgICAgICAg ICAgaWYgKHVubG9hZEV2ZW50UG9saWN5ID09IFVubG9hZEV2ZW50UG9saWN5VW5sb2FkQW5kUGFn ZUhpZGUpCiAgICAgICAgICAgICAgICAgICAgICAgICBtX2ZyYW1lLT5kb21XaW5kb3coKS0+ZGlz cGF0Y2hFdmVudChQYWdlVHJhbnNpdGlvbkV2ZW50OjpjcmVhdGUoZXZlbnROYW1lcygpLnBhZ2Vo aWRlRXZlbnQsIG1fZnJhbWUtPmRvY3VtZW50KCktPmluUGFnZUNhY2hlKCkpLCBtX2ZyYW1lLT5k b2N1bWVudCgpKTsKLSAgICAgICAgICAgICAgICAgICAgaWYgKCFtX2ZyYW1lLT5kb2N1bWVudCgp LT5pblBhZ2VDYWNoZSgpKQorICAgICAgICAgICAgICAgICAgICBpZiAoIW1fZnJhbWUtPmRvY3Vt ZW50KCktPmluUGFnZUNhY2hlKCkpIHsKICAgICAgICAgICAgICAgICAgICAgICAgIG1fZnJhbWUt PmRvbVdpbmRvdygpLT5kaXNwYXRjaEV2ZW50KEV2ZW50OjpjcmVhdGUoZXZlbnROYW1lcygpLnVu bG9hZEV2ZW50LCBmYWxzZSwgZmFsc2UpLCBtX2ZyYW1lLT5kb21XaW5kb3coKS0+ZG9jdW1lbnQo KSk7Ci0gICAgICAgICAgICAgICAgICAgIGlmIChtX3Byb3Zpc2lvbmFsRG9jdW1lbnRMb2FkZXIp IHsKLSAgICAgICAgICAgICAgICAgICAgICAgIERvY3VtZW50TG9hZFRpbWluZyogdGltaW5nID0g bV9wcm92aXNpb25hbERvY3VtZW50TG9hZGVyLT50aW1pbmcoKTsKLSAgICAgICAgICAgICAgICAg ICAgICAgIEFTU0VSVCh0aW1pbmctPm5hdmlnYXRpb25TdGFydCk7Ci0gICAgICAgICAgICAgICAg ICAgICAgICAvLyBGSVhNRTogVGhpcyBmYWlscy4gVW5kZXJzdGFuZCB3aHkuCi0gICAgICAgICAg ICAgICAgICAgICAgICAvLyBBU1NFUlQoIXRpbWluZy0+dW5sb2FkRXZlbnRFbmQpOwotICAgICAg ICAgICAgICAgICAgICAgICAgdGltaW5nLT51bmxvYWRFdmVudEVuZCA9IGN1cnJlbnRUaW1lKCk7 Ci0gICAgICAgICAgICAgICAgICAgICAgICBBU1NFUlQodGltaW5nLT51bmxvYWRFdmVudEVuZCA+ PSB0aW1pbmctPm5hdmlnYXRpb25TdGFydCk7CisKKyAgICAgICAgICAgICAgICAgICAgICAgIGlm IChtX3Byb3Zpc2lvbmFsRG9jdW1lbnRMb2FkZXIpIHsKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICBEb2N1bWVudExvYWRUaW1pbmcqIHRpbWluZyA9IG1fcHJvdmlzaW9uYWxEb2N1bWVudExv YWRlci0+dGltaW5nKCk7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgQVNTRVJUKHRpbWlu Zy0+bmF2aWdhdGlvblN0YXJ0KTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBBU1NFUlQo IXRpbWluZy0+dW5sb2FkRXZlbnRFbmQpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRp bWluZy0+dW5sb2FkRXZlbnRFbmQgPSBjdXJyZW50VGltZSgpOworICAgICAgICAgICAgICAgICAg ICAgICAgICAgIEFTU0VSVCh0aW1pbmctPnVubG9hZEV2ZW50RW5kID49IHRpbWluZy0+bmF2aWdh dGlvblN0YXJ0KTsKKyAgICAgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICAg ICAgfQogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICBtX3BhZ2VEaXNtaXNzYWxF dmVudEJlaW5nRGlzcGF0Y2hlZCA9IGZhbHNlOwo=