42404 2010-07-15 14:01:29 -0700 deleteCol{1,2,3} and insertCols{1,2,3} will fail in HTML5 parser 2010-07-15 14:39:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 41123 42346 1 abarth abarth eric hyatt ian oldest_to_newest 252091 0 abarth 2010-07-15 14:01:29 -0700 deleteCol{1,2,3} and insertCols{1,2,3} will fail in HTML5 parser 252095 1 61716 abarth 2010-07-15 14:06:51 -0700 Created attachment 61716 Patch 252100 2 eric 2010-07-15 14:13:49 -0700 What does IE do? It may be expected that table.removeChild(col) works even if col is not a direct child of table. I feel like I've seen similar hacks like that in the DOM for table support. 252102 3 abarth 2010-07-15 14:17:06 -0700 The tests fail in IE8 as currently written. Let me try the new versions. 252103 4 abarth 2010-07-15 14:19:31 -0700 The new tests seem to fail in IE8 also for layout reasons. However, the DOM operations appear to work as expected. 252104 5 abarth 2010-07-15 14:20:11 -0700 Bottom line: this colgroup business appears to make us more IE-like. 252106 6 eric 2010-07-15 14:23:56 -0700 so IE adds implicit colgroup elements, but table.removeChild(col) still works? Does table.removeChild(col) remove the colgroup too? 252110 7 abarth 2010-07-15 14:27:01 -0700 (In reply to comment #6) > so IE adds implicit colgroup elements, but table.removeChild(col) still works? No. The test as written fails in IE the same way it will fail with the HTML5 parser. > Does table.removeChild(col) remove the colgroup too? No. It throws an illegal instruction exception, similar to exception we'll throw. 252112 8 61716 eric 2010-07-15 14:29:24 -0700 Comment on attachment 61716 Patch Please update the ChangeLog to explain that you tested in IE8, etc. and explain IE's exact behavior. I think it's important for us to justify this change for future readers of these tests. I wonder if old FF added implicit colgroup elements or not. Thank you for looking at this. 252124 9 abarth 2010-07-15 14:39:38 -0700 Committed r63464: <http://trac.webkit.org/changeset/63464> 61716 2010-07-15 14:06:51 -0700 2010-07-15 14:29:24 -0700 Patch bug-42404-20100715140650.patch text/plain 4771 abarth ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkNWNjYzE4NDk2OGZmYjFlZGQzMGExOTJjZDY0OTAyNTU2ZjBmYzFlLi44YzBhMzJh NDA3MjA0ZTQ5ZmJkMWU5NTM4NGFjOTUxODJmM2VhMjQ2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAK KzIwMTAtMDctMTUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBkZWxldGVDb2x7MSwyLDN9IGFu ZCBpbnNlcnRDb2xzezEsMiwzfSB3aWxsIGZhaWwgaW4gSFRNTDUgcGFyc2VyCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MjQwNAorCisgICAgICAgIFRo ZSBIVE1MNSBwYXJzZXIgYWRkcyBhbiBpbXBsaWVkIGNvbGdyb3VwIGVsZW1lbnQgYXMgYSBwYXJl bnQgb2YgdGhlCisgICAgICAgIGNvbCBlbGVtZW50LiBUaGlzIERPTSBjaGFuZ2UgYnJlYWtzIHRo ZXNlIHRlc3RzIGJlY2F1c2UgdGhleSBhc3N1bWUKKyAgICAgICAgdGhlIGNvbCBlbGVtZW50J3Mg cGFyZW50IGlzIHRoZSB0YWJsZSBlbGVtZW50LiBIb3dldmVyLCB0aGVzZSB0ZXN0cworICAgICAg ICBkb24ndCBhcHBlYXIgdG8gYmUgaW50ZW5kZWQgdG8gdGVzdCB0aGlzIGJlaGF2aW9yIHNwZWNp ZmljYWxseS4KKworICAgICAgICAqIHRhYmxlcy9tb3ppbGxhL2RvbS9kZWxldGVDb2wxLmh0bWw6 CisgICAgICAgICogdGFibGVzL21vemlsbGEvZG9tL2RlbGV0ZUNvbDIuaHRtbDoKKyAgICAgICAg KiB0YWJsZXMvbW96aWxsYS9kb20vZGVsZXRlQ29sMy5odG1sOgorICAgICAgICAqIHRhYmxlcy9t b3ppbGxhL2RvbS9pbnNlcnRDb2xzMS5odG1sOgorICAgICAgICAqIHRhYmxlcy9tb3ppbGxhL2Rv bS9pbnNlcnRDb2xzMi5odG1sOgorICAgICAgICAqIHRhYmxlcy9tb3ppbGxhL2RvbS9pbnNlcnRD b2xzMy5odG1sOgorCiAyMDEwLTA3LTE1ICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy90YWJsZXMvbW96aWxsYS9kb20vZGVsZXRlQ29sMS5odG1sIGIvTGF5b3V0VGVzdHMv dGFibGVzL21vemlsbGEvZG9tL2RlbGV0ZUNvbDEuaHRtbAppbmRleCAzY2VlOWFjNWU5YmYzNGVj YjE0MDFmMmIzNzhkZjRlYjFiNTVhNGY3Li4wMGVlYjk5YTJjNjlkYzYyY2ZjMWU3ZTJhM2Y0NThh YWM4ZTUzZTFiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy90YWJsZXMvbW96aWxsYS9kb20vZGVs ZXRlQ29sMS5odG1sCisrKyBiL0xheW91dFRlc3RzL3RhYmxlcy9tb3ppbGxhL2RvbS9kZWxldGVD b2wxLmh0bWwKQEAgLTQsOSArNCw4IEBACiA8U0NSSVBUPgogCiBmdW5jdGlvbiBkb0l0KCkgewot ICB2YXIgdGFibGUgPSBkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgiVEFCTEUiKVswXTsK ICAgdmFyIGNvbCA9IGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCJDT0wiKVswXTsKLSAg dGFibGUucmVtb3ZlQ2hpbGQoY29sKTsKKyAgY29sLnBhcmVudE5vZGUucmVtb3ZlQ2hpbGQoY29s KTsKIH0KIDwvU0NSSVBUPiAgCiA8L0hFQUQ+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy90YWJs ZXMvbW96aWxsYS9kb20vZGVsZXRlQ29sMi5odG1sIGIvTGF5b3V0VGVzdHMvdGFibGVzL21vemls bGEvZG9tL2RlbGV0ZUNvbDIuaHRtbAppbmRleCAzN2Y3NjdiNGU4ODc5MzMxMTViNWU3NjNmM2Yy Yjk1NDkyMDNlNWY1Li5lZDM1MzU4ZjAyOGQwNzc1NGY5ZDZhYTBiYjI2MDljZjk2OGMxMDAyIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy90YWJsZXMvbW96aWxsYS9kb20vZGVsZXRlQ29sMi5odG1s CisrKyBiL0xheW91dFRlc3RzL3RhYmxlcy9tb3ppbGxhL2RvbS9kZWxldGVDb2wyLmh0bWwKQEAg LTQsOSArNCw4IEBACiA8U0NSSVBUPgogCiBmdW5jdGlvbiBkb0l0KCkgewotICB2YXIgdGFibGUg PSBkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgiVEFCTEUiKVswXTsKICAgdmFyIGNvbCA9 IGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCJDT0wiKVsxXTsKLSAgdGFibGUucmVtb3Zl Q2hpbGQoY29sKTsKKyAgY29sLnBhcmVudE5vZGUucmVtb3ZlQ2hpbGQoY29sKTsKIH0KIDwvU0NS SVBUPiAgCiA8L0hFQUQ+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy90YWJsZXMvbW96aWxsYS9k b20vZGVsZXRlQ29sMy5odG1sIGIvTGF5b3V0VGVzdHMvdGFibGVzL21vemlsbGEvZG9tL2RlbGV0 ZUNvbDMuaHRtbAppbmRleCA3YTZhYjkyNjg4OTA3OWEyYWQ3ZGMwZjEzMTM4ZjJlYWFmYjYwMTE4 Li5iYWZiODE1YzEzZDI4MjBlOTkyOGJkZDY0MTY4NGE4NWIzYjFkMjRhIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy90YWJsZXMvbW96aWxsYS9kb20vZGVsZXRlQ29sMy5odG1sCisrKyBiL0xheW91 dFRlc3RzL3RhYmxlcy9tb3ppbGxhL2RvbS9kZWxldGVDb2wzLmh0bWwKQEAgLTQsOSArNCw4IEBA CiA8U0NSSVBUPgogCiBmdW5jdGlvbiBkb0l0KCkgewotICB2YXIgdGFibGUgPSBkb2N1bWVudC5n ZXRFbGVtZW50c0J5VGFnTmFtZSgiVEFCTEUiKVswXTsKICAgdmFyIGNvbCA9IGRvY3VtZW50Lmdl dEVsZW1lbnRzQnlUYWdOYW1lKCJDT0wiKVsyXTsKLSAgdGFibGUucmVtb3ZlQ2hpbGQoY29sKTsK KyAgY29sLnBhcmVudE5vZGUucmVtb3ZlQ2hpbGQoY29sKTsKIH0KIDwvU0NSSVBUPiAgCiA8L0hF QUQ+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy90YWJsZXMvbW96aWxsYS9kb20vaW5zZXJ0Q29s czEuaHRtbCBiL0xheW91dFRlc3RzL3RhYmxlcy9tb3ppbGxhL2RvbS9pbnNlcnRDb2xzMS5odG1s CmluZGV4IGFlYTA3ZTljNGJiNDRmYjA0NDBkYWRjYzY5YzRjYmEzMGMyM2U4NGEuLjQ2ZjUwYzQy ZGVlNzgwZGVjMjgzMzJiYjBkZjNjMjQ0ODUzODM0OTcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L3RhYmxlcy9tb3ppbGxhL2RvbS9pbnNlcnRDb2xzMS5odG1sCisrKyBiL0xheW91dFRlc3RzL3Rh Ymxlcy9tb3ppbGxhL2RvbS9pbnNlcnRDb2xzMS5odG1sCkBAIC00LDExICs0LDEwIEBACiA8U0NS SVBUPgogCiBmdW5jdGlvbiBkb0l0KCkgewotICB2YXIgdGFibGUgPSBkb2N1bWVudC5nZXRFbGVt ZW50c0J5VGFnTmFtZSgiVEFCTEUiKVswXTsKICAgdmFyIHJlZkNvbCA9IGRvY3VtZW50LmdldEVs ZW1lbnRzQnlUYWdOYW1lKCJDT0wiKVswXTsKICAgdmFyIGNvbCA9IGRvY3VtZW50LmNyZWF0ZUVs ZW1lbnQoIkNPTCIsIG51bGwpOwogICBjb2wud2lkdGggPSAxMDA7Ci0gIHRhYmxlLmluc2VydEJl Zm9yZShjb2wsIHJlZkNvbCk7CisgIHJlZkNvbC5wYXJlbnROb2RlLmluc2VydEJlZm9yZShjb2ws IHJlZkNvbCk7CiB9CiA8L1NDUklQVD4gIAogPC9IRUFEPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvdGFibGVzL21vemlsbGEvZG9tL2luc2VydENvbHMyLmh0bWwgYi9MYXlvdXRUZXN0cy90YWJs ZXMvbW96aWxsYS9kb20vaW5zZXJ0Q29sczIuaHRtbAppbmRleCA5YjNjYmU1NWIyMmVjNjMxODQy OTJjMDRjM2VlNDJmMmMyMDdkODgxLi4wOGJhMDZmNThjM2U1ZmM1N2FkNzJmYWQ5NjJiOWY5ODli YjU1YmFhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy90YWJsZXMvbW96aWxsYS9kb20vaW5zZXJ0 Q29sczIuaHRtbAorKysgYi9MYXlvdXRUZXN0cy90YWJsZXMvbW96aWxsYS9kb20vaW5zZXJ0Q29s czIuaHRtbApAQCAtNCwxMSArNCwxMCBAQAogPFNDUklQVD4KIAogZnVuY3Rpb24gZG9JdCgpIHsK LSAgdmFyIHRhYmxlID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoIlRBQkxFIilbMF07 CiAgIHZhciByZWZDb2wgPSBkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgiQ09MIilbMV07 CiAgIHZhciBjb2wgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJDT0wiLCBudWxsKTsKICAgY29s LndpZHRoID0gMjAwOwotICB0YWJsZS5pbnNlcnRCZWZvcmUoY29sLCByZWZDb2wpOworICByZWZD b2wucGFyZW50Tm9kZS5pbnNlcnRCZWZvcmUoY29sLCByZWZDb2wpOwogfQogPC9TQ1JJUFQ+ICAK IDwvSEVBRD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3RhYmxlcy9tb3ppbGxhL2RvbS9pbnNl cnRDb2xzMy5odG1sIGIvTGF5b3V0VGVzdHMvdGFibGVzL21vemlsbGEvZG9tL2luc2VydENvbHMz Lmh0bWwKaW5kZXggNjI0NGU5NmJhMGJiZjM1ZTFiYjAxN2VlODhkZDBlNTcyNjAzYjk1ZS4uNTli ZTg3ODk1MDhiNjI4ZDY4OWVlZjMxOGVlZGE5ZGU1NTNlMGJiZCAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvdGFibGVzL21vemlsbGEvZG9tL2luc2VydENvbHMzLmh0bWwKKysrIGIvTGF5b3V0VGVz dHMvdGFibGVzL21vemlsbGEvZG9tL2luc2VydENvbHMzLmh0bWwKQEAgLTQsMTEgKzQsMTAgQEAK IDxTQ1JJUFQ+CiAKIGZ1bmN0aW9uIGRvSXQoKSB7Ci0gIHZhciB0YWJsZSA9IGRvY3VtZW50Lmdl dEVsZW1lbnRzQnlUYWdOYW1lKCJUQUJMRSIpWzBdOwogICB2YXIgcmVmQ29sID0gZG9jdW1lbnQu Z2V0RWxlbWVudHNCeVRhZ05hbWUoIkNPTCIpWzJdOwogICB2YXIgY29sID0gZG9jdW1lbnQuY3Jl YXRlRWxlbWVudCgiQ09MIiwgbnVsbCk7CiAgIGNvbC53aWR0aCA9IDE1MDsKLSAgdGFibGUuaW5z ZXJ0QmVmb3JlKGNvbCwgcmVmQ29sKTsKKyAgcmVmQ29sLnBhcmVudE5vZGUuaW5zZXJ0QmVmb3Jl KGNvbCwgcmVmQ29sKTsKIH0KIDwvU0NSSVBUPiAgCiA8L0hFQUQ+Cg==