<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>42376</bug_id>
          
          <creation_ts>2010-07-15 07:55:41 -0700</creation_ts>
          <short_desc>svg/dynamic-updates tests are broken - pixel test not generated/compared anymore</short_desc>
          <delta_ts>2010-07-20 00:48:19 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>SVG</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Critical</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>42374</dependson>
          <blocked>42615</blocked>
    
    <blocked>42616</blocked>
    
    <blocked>42617</blocked>
    
    <blocked>42618</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Nikolas Zimmermann">zimmermann</reporter>
          <assigned_to name="Nikolas Zimmermann">zimmermann</assigned_to>
          <cc>zimmermann</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>251887</commentid>
    <comment_count>0</comment_count>
    <who name="Nikolas Zimmermann">zimmermann</who>
    <bug_when>2010-07-15 07:55:41 -0700</bug_when>
    <thetext>Since a while, can&apos;t say how long, didn&apos;t investigate - DRT doesn&apos;t generate pixel test results for tests which have dumpAsText=true set.
With the DRT change in bug 42374, I can reactivate them - and it&apos;s already visible that we have regressions *SIGH*.

The svg/dynamic-updates tests want textual results (no render tree dumps) and a pixel test result - w/o pixel tests they&apos;re useless, as they are specifically testing dynamic changes of certain attributes/properties + repainting.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>253590</commentid>
    <comment_count>1</comment_count>
      <attachid>62038</attachid>
    <who name="Nikolas Zimmermann">zimmermann</who>
    <bug_when>2010-07-20 00:34:00 -0700</bug_when>
    <thetext>Created attachment 62038
Patch

Large patch, as it contains the new pixel test baseline for svg/dynamic-updates.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>253591</commentid>
    <comment_count>2</comment_count>
      <attachid>62038</attachid>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2010-07-20 00:43:20 -0700</bug_when>
    <thetext>Comment on attachment 62038
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>253592</commentid>
    <comment_count>3</comment_count>
    <who name="Nikolas Zimmermann">zimmermann</who>
    <bug_when>2010-07-20 00:48:19 -0700</bug_when>
    <thetext>Landed in r63730.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>62038</attachid>
            <date>2010-07-20 00:34:00 -0700</date>
            <delta_ts>2010-07-20 00:43:20 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>DynUpdates.diff</filename>
            <type>text/plain</type>
            <size>0</size>
            <attacher name="Nikolas Zimmermann">zimmermann</attacher>
            
              <data encoding="base64"></data>
<flag name="review"
          id="50153"
          type_id="1"
          status="+"
          setter="mjs"
    />
          </attachment>
      

    </bug>

</bugzilla>