42298 2010-07-14 15:46:22 -0700 Regression (r63100): m_loadType being used to reset scroll position after being reset 2010-07-16 01:29:03 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 japhet japhet abarth commit-queue eric fishd mario webkit.review.bot oldest_to_newest 251473 0 japhet 2010-07-14 15:46:22 -0700 In http://trac.webkit.org/changeset/63100, I changed FrameLoader::handledOnloadEvents() to reset m_loadType to FrameLoadTypeStandard (to ensure that loads after the load event would not propagate the caching behavior of the original request). It turns out this solution won't work, since there are some other behaviors that depend on m_loadType after the load event. Notably, in didFirstLayout(), we decide whether or not to call history()->restoreScrollPositionAndViewState() based on m_loadType, so scroll position restoring for back/forward navigations broke (which caused gtk test to fail). This change should be fixable by reverting my changes to handledOnloadEvents() and being a little more careful in addExtraFieldsToRequest(). 251483 1 61577 japhet 2010-07-14 15:52:29 -0700 Created attachment 61577 Fix + uncomment the gtk test assertion that broke I don't have a gtk build, but msanchez was kind enough to patch this in and confirm the assertion now passes. 252359 2 mario 2010-07-15 23:51:27 -0700 (In reply to comment #1) > Created an attachment (id=61577) [details] > Fix + uncomment the gtk test assertion that broke > > I don't have a gtk build, but msanchez was kind enough to patch this in and > confirm the assertion now passes. Yes, I confirm both that the assertion passes and that there were no regressions found while re-running the layout tests with 'run-webkit-tests --gtk' Thanks Nate for fixing this issue 252378 3 61577 commit-queue 2010-07-16 00:46:41 -0700 Comment on attachment 61577 Fix + uncomment the gtk test assertion that broke Clearing flags on attachment: 61577 Committed r63528: <http://trac.webkit.org/changeset/63528> 252379 4 commit-queue 2010-07-16 00:46:45 -0700 All reviewed patches have been landed. Closing bug. 252390 5 webkit.review.bot 2010-07-16 01:10:43 -0700 http://trac.webkit.org/changeset/63528 might have broken Qt Linux Release 252400 6 mario 2010-07-16 01:29:03 -0700 (In reply to comment #5) > http://trac.webkit.org/changeset/63528 might have broken Qt Linux Release Output in the build bot [1] says this for the failing test(fast/dom/Range/range-compareNode.html): CONSOLE MESSAGE: line 198: TypeError: Result of expression 'layoutTestController.dumpAsText' [undefined] is not a function. I'm not 100% sure, of course, but I don't see how this patch could get this test failing this way. Hence, I've got the feeling is something else. Any guessing/idea? [1] http://build.webkit.org/results/Qt%20Linux%20Release/r63529%20(15543)/fast/dom/Range/range-compareNode-pretty-diff.html 61577 2010-07-14 15:52:29 -0700 2010-07-16 00:46:41 -0700 Fix + uncomment the gtk test assertion that broke cache.txt text/plain 4047 japhet SW5kZXg6IFdlYktpdC9ndGsvdGVzdHMvdGVzdHdlYnZpZXcuYwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJL aXQvZ3RrL3Rlc3RzL3Rlc3R3ZWJ2aWV3LmMJKHJldmlzaW9uIDYzMjUzKQorKysgV2ViS2l0L2d0 ay90ZXN0cy90ZXN0d2Vidmlldy5jCSh3b3JraW5nIGNvcHkpCkBAIC0yNjYsMTAgKzI2Niw3IEBA CiAgICAgZ19hc3NlcnRfY21wZmxvYXQobG93ZXIsID09LCBndGtfYWRqdXN0bWVudF9nZXRfbG93 ZXIoYWRqdXN0bWVudCkpOwogICAgIGdfYXNzZXJ0X2NtcGZsb2F0KHVwcGVyLCA9PSwgZ3RrX2Fk anVzdG1lbnRfZ2V0X3VwcGVyKGFkanVzdG1lbnQpKTsKIAotICAgIC8vIFRoaXMgYXNzZXJ0IGlz IHRlbXBvcmFyaWx5IGRpc2FibGVkIHVudGlsIHdlIGZpeCB0aGUgZm9sbG93aW5nIGJ1ZzoKLSAg ICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDIxMTQKLSAgICAv LyBJdCBzaG91bGQgYmUgcmUtZW5hYmxlZCBBU0FQLgotICAgIC8vIGdfYXNzZXJ0X2NtcGZsb2F0 KGd0a19hZGp1c3RtZW50X2dldF92YWx1ZShhZGp1c3RtZW50KSwgPT0sIDEwMC4wKTsKKyAgICBn X2Fzc2VydF9jbXBmbG9hdChndGtfYWRqdXN0bWVudF9nZXRfdmFsdWUoYWRqdXN0bWVudCksID09 LCAxMDAuMCk7CiAKICAgICBnX2ZyZWUoZWZmZWN0aXZlX3VyaSk7CiAgICAgZ19mcmVlKHNlY29u ZF91cmkpOwpJbmRleDogV2ViS2l0L2d0ay9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0 L2d0ay9DaGFuZ2VMb2cJKHJldmlzaW9uIDYzMzYxKQorKysgV2ViS2l0L2d0ay9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNy0xNCAgTmF0ZSBDaGFwaW4g IDxqYXBoZXRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFVuY29tbWVudCBhbiBhc3NlcnQgdGhhdCBicm9rZSBkdWUgdG8gcjYz MTAwLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 MjI5OAorCisgICAgICAgICogdGVzdHMvdGVzdHdlYnZpZXcuYzoKKwogMjAxMC0wNy0xNCAgU2Ft IFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFk bGVyLgpJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFu Z2VMb2cJKHJldmlzaW9uIDYzMzM2KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w eSkKQEAgLTEsMyArMSwyMyBAQAorMjAxMC0wNy0xNCAgTmF0ZSBDaGFwaW4gIDxqYXBoZXRAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlZ3Jlc3Npb24gaW4gcjYzMTAwOiBEb24ndCBjbGVhciBtX2xvYWRUeXBlIGluCisgICAg ICAgIEZyYW1lTG9hZGVyOjpoYW5kbGVkT25sb2FkRXZlbnRzLCBhcyBpdCBpcyB1c2VkCisgICAg ICAgIHRvIG1ha2Ugc29tZSBkZWNpc2lvbnMgYWZ0ZXIgdGhlIGxvYWQgaGFzIGFjdHVhbGx5Cisg ICAgICAgIGNvbXBsZXRlZC4KKworICAgICAgICBUaWNrbGluZyB0aGlzIGJ1ZyByZXF1aXJlcyBt YW5pcHVsYXRpb24KKyAgICAgICAgdmlhIHRoZSBBUEkgKGxheW91dCB0ZXN0cyBkb24ndCBhcHBl YXIgdG8gdHJhdmVyc2UKKyAgICAgICAgdGhlIGNvcnJlY3QgY29kZXBhdGgpLCBzbyBubyBsYXlv dXQgdGVzdC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDIyOTgKKworICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpGcmFtZUxvYWRlcjo6aGFuZGxlZE9ubG9hZEV2ZW50cyk6IERvbid0IHJlc2V0IG1f bG9hZFR5cGUuCisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6YWRkRXh0cmFGaWVsZHNU b1JlcXVlc3QpOiBTZXQgc3VicmVzb3VyY2UgY2FjaGUKKyAgICAgICAgICAgcG9saWN5IGluIG9u ZSBwbGFjZSBhbmQgZG9uJ3QgZGVwZW5kIG9uIG1fbG9hZFR5cGUuCisKIDIwMTAtMDctMTMgIEFs ZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGFyaW4gQWRsZXIuCkluZGV4OiBXZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCShyZXZpc2lvbiA2MzI1MykK KysrIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjYw OSw4ICsyNjA5LDYgQEAKIHsKICAgICBtX2NsaWVudC0+ZGlzcGF0Y2hEaWRIYW5kbGVPbmxvYWRF dmVudHMoKTsKIAotICAgIG1fbG9hZFR5cGUgPSBGcmFtZUxvYWRUeXBlU3RhbmRhcmQ7Ci0KICNp ZiBFTkFCTEUoT0ZGTElORV9XRUJfQVBQTElDQVRJT05TKQogICAgIGlmIChkb2N1bWVudExvYWRl cigpKQogICAgICAgICBkb2N1bWVudExvYWRlcigpLT5hcHBsaWNhdGlvbkNhY2hlSG9zdCgpLT5z dG9wRGVmZXJyaW5nRXZlbnRzKCk7CkBAIC0yNjkwLDcgKzI2ODgsMTQgQEAKICAgICAvLyAyLiBE ZWxlZ2F0ZXMgdGhhdCBtb2RpZnkgdGhlIGNhY2hlIHBvbGljeSB1c2luZyB3aWxsU2VuZFJlcXVl c3Q6IHNob3VsZAogICAgIC8vICAgIG5vdCBhZmZlY3QgYW55IG90aGVyIHJlc291cmNlcy4gU3Vj aCBjaGFuZ2VzIG5lZWQgdG8gYmUgZG9uZQogICAgIC8vICAgIHBlciByZXF1ZXN0LgotICAgIGlm IChsb2FkVHlwZSA9PSBGcmFtZUxvYWRUeXBlUmVsb2FkKSB7CisgICAgaWYgKCFtYWluUmVzb3Vy Y2UpIHsKKyAgICAgICAgaWYgKHJlcXVlc3QuaXNDb25kaXRpb25hbCgpKQorICAgICAgICAgICAg cmVxdWVzdC5zZXRDYWNoZVBvbGljeShSZWxvYWRJZ25vcmluZ0NhY2hlRGF0YSk7CisgICAgICAg IGVsc2UgaWYgKGRvY3VtZW50TG9hZGVyKCktPmlzTG9hZGluZ0luQVBJU2Vuc2UoKSkKKyAgICAg ICAgICAgIHJlcXVlc3Quc2V0Q2FjaGVQb2xpY3koZG9jdW1lbnRMb2FkZXIoKS0+b3JpZ2luYWxS ZXF1ZXN0KCkuY2FjaGVQb2xpY3koKSk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHJlcXVl c3Quc2V0Q2FjaGVQb2xpY3koVXNlUHJvdG9jb2xDYWNoZVBvbGljeSk7CisgICAgfSBlbHNlIGlm IChsb2FkVHlwZSA9PSBGcmFtZUxvYWRUeXBlUmVsb2FkKSB7CiAgICAgICAgIHJlcXVlc3Quc2V0 Q2FjaGVQb2xpY3koUmVsb2FkSWdub3JpbmdDYWNoZURhdGEpOwogICAgICAgICByZXF1ZXN0LnNl dEhUVFBIZWFkZXJGaWVsZCgiQ2FjaGUtQ29udHJvbCIsICJtYXgtYWdlPTAiKTsKICAgICB9IGVs c2UgaWYgKGxvYWRUeXBlID09IEZyYW1lTG9hZFR5cGVSZWxvYWRGcm9tT3JpZ2luKSB7CkBAIC0y NzAxLDggKzI3MDYsNiBAQAogICAgICAgICByZXF1ZXN0LnNldENhY2hlUG9saWN5KFJlbG9hZEln bm9yaW5nQ2FjaGVEYXRhKTsKICAgICBlbHNlIGlmIChpc0JhY2tGb3J3YXJkTG9hZFR5cGUobG9h ZFR5cGUpICYmICFyZXF1ZXN0LnVybCgpLnByb3RvY29sSXMoImh0dHBzIikpCiAgICAgICAgIHJl cXVlc3Quc2V0Q2FjaGVQb2xpY3koUmV0dXJuQ2FjaGVEYXRhRWxzZUxvYWQpOwotICAgIGVsc2Ug aWYgKCFtYWluUmVzb3VyY2UgJiYgZG9jdW1lbnRMb2FkZXIoKS0+aXNMb2FkaW5nSW5BUElTZW5z ZSgpKQotICAgICAgICByZXF1ZXN0LnNldENhY2hlUG9saWN5KGRvY3VtZW50TG9hZGVyKCktPm9y aWdpbmFsUmVxdWVzdCgpLmNhY2hlUG9saWN5KCkpOwogICAgIAogICAgIGlmIChtYWluUmVzb3Vy Y2UpCiAgICAgICAgIHJlcXVlc3Quc2V0SFRUUEFjY2VwdChkZWZhdWx0QWNjZXB0SGVhZGVyKTsK