42282 2010-07-14 13:17:29 -0700 Fix enum value names for Navigation.{idl|h} 2010-07-14 14:40:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 30685 1 tonyg tonyg bulach darin japhet oldest_to_newest 251388 0 tonyg 2010-07-14 13:17:29 -0700 Fix enum value names for Navigation.{idl|h} 251389 1 61555 tonyg 2010-07-14 13:20:45 -0700 Created attachment 61555 Patch 251406 2 61555 darin 2010-07-14 13:42:28 -0700 Comment on attachment 61555 Patch > + enum NavigationType { > + NAVIGATE = 0, > + RELOAD = 1, > + BACK_FORWARD = 2, > + }; I don’t think it’s important to have those "= 0", "= 1", "= 2" there. I’m surprised this patch doesn’t remove DontCheckEnum from the IDL file. 251411 3 tonyg 2010-07-14 13:50:09 -0700 (In reply to comment #2) > (From update of attachment 61555 [details]) > > + enum NavigationType { > > + NAVIGATE = 0, > > + RELOAD = 1, > > + BACK_FORWARD = 2, > > + }; > > I don’t think it’s important to have those "= 0", "= 1", "= 2" there. Okay, I'll pull them. > > I’m surprised this patch doesn’t remove DontCheckEnum from the IDL file. DontCheckEnum was not added to this IDL file because it is guarded by ENABLE(WEB_TIMING), which is currently off by default. I got the compile error as soon as I enabled it locally. 251434 4 tonyg 2010-07-14 14:40:30 -0700 Committed r63356: <http://trac.webkit.org/changeset/63356> 61555 2010-07-14 13:20:45 -0700 2010-07-14 13:42:27 -0700 Patch bug-42282-20100714132044.patch text/plain 2428 tonyg ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDAxZmFjZGVhMjk2ZjYxZDA3NmEyMDQ4Njk3ZWI3NWM2ODU4MjM1MS4uNmYxNDEwY2NmZTMyYjc0 MDMyYjliODkyYzVhYzFjMWIxY2Y0NGYxNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wNy0xNCAgVG9u eSBHZW50aWxjb3JlICA8dG9ueWdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBlbnVtIHZhbHVlIG5hbWVzIGZvciBOYXZp Z2F0aW9uLntpZGx8aH0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQyMjgyCisKKyAgICAgICAgVGhpcyBpcyBuZWNlc3NhcnkgYWZ0ZXIgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyMjUwLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cyBiZWNhdXNlIG5vIG5ldyBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcGFnZS9OYXZp Z2F0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5hdmlnYXRpb246OnR5cGUpOgorICAgICAg ICAqIHBhZ2UvTmF2aWdhdGlvbi5oOgorICAgICAgICAoV2ViQ29yZTo6TmF2aWdhdGlvbjo6KToK KwogMjAxMC0wNy0xNCAgQW5kcmVhcyBLbGluZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9w YWdlL05hdmlnYXRpb24uY3BwIGIvV2ViQ29yZS9wYWdlL05hdmlnYXRpb24uY3BwCmluZGV4IDEx NGU2OWY4Y2RkNDdkYWVmNzhjODU5ZGM4ODBlZjlhMzFjOTgzZTMuLjRmZWMwZWUxMzFjMmE2MDY1 ODVmMzRkOTdlYTIxZWU4NDNkMzgxNmYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9OYXZpZ2F0 aW9uLmNwcAorKysgYi9XZWJDb3JlL3BhZ2UvTmF2aWdhdGlvbi5jcHAKQEAgLTU3LDIwICs1Nywy MCBAQCB2b2lkIE5hdmlnYXRpb246OmRpc2Nvbm5lY3RGcmFtZSgpCiB1bnNpZ25lZCBzaG9ydCBO YXZpZ2F0aW9uOjp0eXBlKCkgY29uc3QKIHsKICAgICBpZiAoIW1fZnJhbWUpCi0gICAgICAgIHJl dHVybiBOYXZpZ2F0ZTsKKyAgICAgICAgcmV0dXJuIE5BVklHQVRFOwogCiAgICAgRG9jdW1lbnRM b2FkZXIqIGRvY3VtZW50TG9hZGVyID0gbV9mcmFtZS0+bG9hZGVyKCktPmRvY3VtZW50TG9hZGVy KCk7CiAgICAgaWYgKCFkb2N1bWVudExvYWRlcikKLSAgICAgICAgcmV0dXJuIE5hdmlnYXRlOwor ICAgICAgICByZXR1cm4gTkFWSUdBVEU7CiAKICAgICBXZWJDb3JlOjpOYXZpZ2F0aW9uVHlwZSBu YXZpZ2F0aW9uVHlwZSA9IGRvY3VtZW50TG9hZGVyLT50cmlnZ2VyaW5nQWN0aW9uKCkudHlwZSgp OwogICAgIHN3aXRjaCAobmF2aWdhdGlvblR5cGUpIHsKICAgICBjYXNlIE5hdmlnYXRpb25UeXBl UmVsb2FkOgotICAgICAgICByZXR1cm4gUmVsb2FkOworICAgICAgICByZXR1cm4gUkVMT0FEOwog ICAgIGNhc2UgTmF2aWdhdGlvblR5cGVCYWNrRm9yd2FyZDoKLSAgICAgICAgcmV0dXJuIEJhY2tG b3J3YXJkOworICAgICAgICByZXR1cm4gQkFDS19GT1JXQVJEOwogICAgIGRlZmF1bHQ6Ci0gICAg ICAgIHJldHVybiBOYXZpZ2F0ZTsKKyAgICAgICAgcmV0dXJuIE5BVklHQVRFOwogICAgIH0KIH0K IApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL05hdmlnYXRpb24uaCBiL1dlYkNvcmUvcGFnZS9O YXZpZ2F0aW9uLmgKaW5kZXggODVjN2I1NTQyMGRjNmU3NTJjMWRjOTYzYjEyNTdiNjc5YjhjMTQ3 NC4uMWI0NjQzYzJhMjFhZWRhODFlN2UxYzJiOTkxYTYyMTEyYzkyY2RiYSAxMDA2NDQKLS0tIGEv V2ViQ29yZS9wYWdlL05hdmlnYXRpb24uaAorKysgYi9XZWJDb3JlL3BhZ2UvTmF2aWdhdGlvbi5o CkBAIC00NywxNyArNDcsMTYgQEAgcHVibGljOgogICAgIEZyYW1lKiBmcmFtZSgpIGNvbnN0Owog ICAgIHZvaWQgZGlzY29ubmVjdEZyYW1lKCk7CiAKKyAgICBlbnVtIE5hdmlnYXRpb25UeXBlIHsK KyAgICAgICAgTkFWSUdBVEUgPSAwLAorICAgICAgICBSRUxPQUQgPSAxLAorICAgICAgICBCQUNL X0ZPUldBUkQgPSAyLAorICAgIH07CisKICAgICB1bnNpZ25lZCBzaG9ydCB0eXBlKCkgY29uc3Q7 CiAgICAgdW5zaWduZWQgc2hvcnQgcmVkaXJlY3RDb3VudCgpIGNvbnN0OwogCiBwcml2YXRlOgot ICAgIC8vIEtlZXAgaW4gc3luYyB3aXRoIHdoYXQncyBpbiB0aGUgLmlkbCBmaWxlLgotICAgIGVu dW0gTmF2aWdhdGlvblR5cGUgewotICAgICAgICBOYXZpZ2F0ZSA9IDAsCi0gICAgICAgIFJlbG9h ZCA9IDEsCi0gICAgICAgIEJhY2tGb3J3YXJkID0gMiwKLSAgICB9OwotCiAgICAgTmF2aWdhdGlv bihGcmFtZSopOwogCiAgICAgRnJhbWUqIG1fZnJhbWU7Cg==