42260 2010-07-14 07:17:21 -0700 Improve hover state handling for spin buttons 2010-07-16 14:19:03 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 38381 42259 1 tkent tkent adele dglazkov fishd oldest_to_newest 251172 0 tkent 2010-07-14 07:17:21 -0700 Improve hover state handling for spin buttons 251192 1 61519 tkent 2010-07-14 08:13:27 -0700 Created attachment 61519 Patch 252600 2 61519 fishd 2010-07-16 10:52:29 -0700 Comment on attachment 61519 Patch R=me 252697 3 61519 tkent 2010-07-16 14:18:54 -0700 Comment on attachment 61519 Patch Clearing flags on attachment: 61519 Committed r63582: <http://trac.webkit.org/changeset/63582> 252698 4 tkent 2010-07-16 14:19:03 -0700 All reviewed patches have been landed. Closing bug. 61519 2010-07-14 08:13:27 -0700 2010-07-16 14:18:54 -0700 Patch bug-42260-20100715001325.patch text/plain 6988 tkent ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDM4MzkyYWQzM2NjNDBhZWRkNDAxYTE0MmY5MTBiOWM5MGQ5ODhhNC4uNWM0Y2E3NzZiYWU0Y2Rm ZTRlNTU5ZmQ1YmNlODZlZmYwMzYzMWQ3NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSw0MyBAQAorMjAxMC0wNy0xNCAgS2Vu dCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wcm92ZSBob3ZlciBzdGF0ZSBoYW5kbGluZyBmb3Ig c3BpbiBidXR0b25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00MjI2MAorCisgICAgICAgIEJhY2tncm91bmQ6CisgICAgICAgIFdoZW4gd2UgbW92ZSB0 aGUgbW91c2UgY3Vyc29yIHRvIGEgbm9kZSBmcm9tIHRoZSBvdXRzaWRlIG9mIHRoZSBub2RlLAor ICAgICAgICB0aGUgZm9sbG93aW5nIHN0ZXBzIGFyZSBleGVjdXRlZC4KKyAgICAgICAgIDEuIHNl dEhvdmVyZWQodHJ1ZSkgaXMgY2FsbGVkLgorICAgICAgICAgMi4gVGhlIG5vZGUgaXMgcmVwYWlu dGVkIGZvciB0aGUgaG92ZXIgc3RhdGUuCisgICAgICAgICAzLiAnbW91c2Vtb3ZlJyBldmVudCBp cyBkaXNwYXRjaGVkIGZvciB0aGUgbm9kZS4KKyAgICAgICAgRm9yIGEgc3Bpbi1idXR0b24sIFJl bmRlclRoZW1lOjpwYWludHtJbm5lcixPdXRlcn1TcGluQnV0dG9uKCkgaXMKKyAgICAgICAgY2Fs bGVkIGJlZm9yZSB0aGUgZXZlbnQgaGFuZGxlciBvZiB0aGUgc3Bpbi1idXR0b24uIFNvIHdlIGNh bid0CisgICAgICAgIGRldGVjdCB3aGljaCBvZiB0aGUgdXAgcGFydCBvciB0aGUgZG93biBwYXJ0 IGlzIGhvdmVyZWQgY29ycmVjdGx5LgorCisgICAgICAgIFNvbHV0aW9uOgorICAgICAgICBUaGUg aG92ZXIgc3RhdGUgb2YgYSBzcGluLWJ1dHRvbiBpcyBvbmUgb2YgdGhyZWUgc3RhdGVzOworICAg ICAgICBJbmRldGVybWluYXRlLCBVcCwgYW5kIERvd24uIFRoZSBzdGF0ZSBpcyBJbmRldGVybWlu YXRlIHNpbmNlCisgICAgICAgIHNldEhvdmVyZWQodHJ1ZSkgaXMgY2FsbGVkIGFuZCB1bnRpbCAn bW91c2Vtb3ZlJyBldmVudCBpcworICAgICAgICBkaXNwYXRjaGVkLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cyBiZWNhdXNlIHRoZXJlIGFyZSBubyBpbXBsZW1lbnRhdGlvbiBvZiBzcGluLWJ1dHRv bnMKKyAgICAgICAgd2l0aCBob3ZlcmVkIHN0YXRlIHlldC4KKworICAgICAgICAqIHJlbmRlcmlu Zy9SZW5kZXJUaGVtZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZTo6aXNTcGlu VXBCdXR0b25QYXJ0UHJlc3NlZCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZTo6aXNI b3ZlcmVkKToKKyAgICAgICAgIFJldHVybiBmYWxzZSBpZiB0aGUgbm9kZSBpcyBhIHNwaW4tYnV0 dG9uIGFuZCB0aGUgc3RhdGUgaXMgSW5kZXRlcm1pbmF0ZS4KKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlclRoZW1lOjppc1NwaW5VcEJ1dHRvblBhcnRIb3ZlcmVkKToKKyAgICAgICAgKiByZW5kZXJp bmcvVGV4dENvbnRyb2xJbm5lckVsZW1lbnRzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNwaW5C dXR0b25FbGVtZW50OjpTcGluQnV0dG9uRWxlbWVudCk6CisgICAgICAgICBJbml0aWFsaXplIG1f dXBEb3duU3RhdGUuCisgICAgICAgIChXZWJDb3JlOjpTcGluQnV0dG9uRWxlbWVudDo6ZGVmYXVs dEV2ZW50SGFuZGxlcik6CisgICAgICAgIChXZWJDb3JlOjpTcGluQnV0dG9uRWxlbWVudDo6c2V0 SG92ZXJlZCk6CisgICAgICAgICBTZXQgdGhlIHN0YXRlIHRvIEluZGV0ZXJtaW5hdGUuCisgICAg ICAgICogcmVuZGVyaW5nL1RleHRDb250cm9sSW5uZXJFbGVtZW50cy5oOgorICAgICAgICAoV2Vi Q29yZTo6U3BpbkJ1dHRvbkVsZW1lbnQ6OnVwRG93blN0YXRlKToKKwogMjAxMC0wNy0xNCAgU3Rl dmUgQmxvY2sgIDxzdGV2ZWJsb2NrQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg SmVyZW15IE9ybG93LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWUu Y3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWUuY3BwCmluZGV4IDZkMThlNGY0NDhl MGEwNjIzYWUyODkzMTYzYjc4NWVkYzM1OTEzOWYuLmJkOTZkMTEyYzE3MTUxMTVlOTFhOWFiMmJi MmVkNTM1OWQ4NTE3MzUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1l LmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZS5jcHAKQEAgLTgyOCw3ICs4 MjgsNyBAQCBib29sIFJlbmRlclRoZW1lOjppc1NwaW5VcEJ1dHRvblBhcnRQcmVzc2VkKGNvbnN0 IFJlbmRlck9iamVjdCogbykgY29uc3QKICAgICAgICAgfHwgIXN0YXRpY19jYXN0PEVsZW1lbnQq Pihub2RlKS0+aXNTcGluQnV0dG9uRWxlbWVudCgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAg ICAgU3BpbkJ1dHRvbkVsZW1lbnQqIGVsZW1lbnQgPSBzdGF0aWNfY2FzdDxTcGluQnV0dG9uRWxl bWVudCo+KG5vZGUpOwotICAgIHJldHVybiBlbGVtZW50LT5vblVwQnV0dG9uKCk7CisgICAgcmV0 dXJuIGVsZW1lbnQtPnVwRG93blN0YXRlKCkgPT0gU3BpbkJ1dHRvbkVsZW1lbnQ6OlVwOwogfQog CiBib29sIFJlbmRlclRoZW1lOjppc1JlYWRPbmx5Q29udHJvbChjb25zdCBSZW5kZXJPYmplY3Qq IG8pIGNvbnN0CkBAIC04NDEsMTkgKzg0MSwyMiBAQCBib29sIFJlbmRlclRoZW1lOjppc1JlYWRP bmx5Q29udHJvbChjb25zdCBSZW5kZXJPYmplY3QqIG8pIGNvbnN0CiAKIGJvb2wgUmVuZGVyVGhl bWU6OmlzSG92ZXJlZChjb25zdCBSZW5kZXJPYmplY3QqIG8pIGNvbnN0CiB7Ci0gICAgaWYgKCFv LT5ub2RlKCkpCisgICAgTm9kZSogbm9kZSA9IG8tPm5vZGUoKTsKKyAgICBpZiAoIW5vZGUpCiAg ICAgICAgIHJldHVybiBmYWxzZTsKLSAgICByZXR1cm4gby0+bm9kZSgpLT5ob3ZlcmVkKCk7Cisg ICAgaWYgKCFub2RlLT5pc0VsZW1lbnROb2RlKCkgfHwgIXN0YXRpY19jYXN0PEVsZW1lbnQqPihu b2RlKS0+aXNTcGluQnV0dG9uRWxlbWVudCgpKQorICAgICAgICByZXR1cm4gbm9kZS0+aG92ZXJl ZCgpOworICAgIFNwaW5CdXR0b25FbGVtZW50KiBlbGVtZW50ID0gc3RhdGljX2Nhc3Q8U3BpbkJ1 dHRvbkVsZW1lbnQqPihub2RlKTsKKyAgICByZXR1cm4gZWxlbWVudC0+aG92ZXJlZCgpICYmIGVs ZW1lbnQtPnVwRG93blN0YXRlKCkgIT0gU3BpbkJ1dHRvbkVsZW1lbnQ6OkluZGV0ZXJtaW5hdGU7 CiB9CiAKIGJvb2wgUmVuZGVyVGhlbWU6OmlzU3BpblVwQnV0dG9uUGFydEhvdmVyZWQoY29uc3Qg UmVuZGVyT2JqZWN0KiBvKSBjb25zdAogewogICAgIE5vZGUqIG5vZGUgPSBvLT5ub2RlKCk7Ci0g ICAgaWYgKCFub2RlIHx8ICFub2RlLT5hY3RpdmUoKSB8fCAhbm9kZS0+aXNFbGVtZW50Tm9kZSgp Ci0gICAgICAgIHx8ICFzdGF0aWNfY2FzdDxFbGVtZW50Kj4obm9kZSktPmlzU3BpbkJ1dHRvbkVs ZW1lbnQoKSkKKyAgICBpZiAoIW5vZGUgfHwgIW5vZGUtPmlzRWxlbWVudE5vZGUoKSB8fCAhc3Rh dGljX2Nhc3Q8RWxlbWVudCo+KG5vZGUpLT5pc1NwaW5CdXR0b25FbGVtZW50KCkpCiAgICAgICAg IHJldHVybiBmYWxzZTsKICAgICBTcGluQnV0dG9uRWxlbWVudCogZWxlbWVudCA9IHN0YXRpY19j YXN0PFNwaW5CdXR0b25FbGVtZW50Kj4obm9kZSk7Ci0gICAgcmV0dXJuIGVsZW1lbnQtPm9uVXBC dXR0b24oKTsKKyAgICByZXR1cm4gZWxlbWVudC0+dXBEb3duU3RhdGUoKSA9PSBTcGluQnV0dG9u RWxlbWVudDo6VXA7CiB9CiAKIGJvb2wgUmVuZGVyVGhlbWU6OmlzRGVmYXVsdChjb25zdCBSZW5k ZXJPYmplY3QqIG8pIGNvbnN0CmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0Q29u dHJvbElubmVyRWxlbWVudHMuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvVGV4dENvbnRyb2xJbm5l ckVsZW1lbnRzLmNwcAppbmRleCAxZTg2ZTRkYTRhNjU1Mzg1OWMyYzNlMGY1YjEwODVlODVmNmM3 ZTc2Li5jOTkyZDQ5NTI0MTRjMDM5MjAxMmU1ZTg0M2M4ZTBiYzY3YTcxZDQ0IDEwMDY0NAotLS0g YS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0Q29udHJvbElubmVyRWxlbWVudHMuY3BwCisrKyBiL1dl YkNvcmUvcmVuZGVyaW5nL1RleHRDb250cm9sSW5uZXJFbGVtZW50cy5jcHAKQEAgLTI0Niw3ICsy NDYsNyBAQCB2b2lkIFNlYXJjaEZpZWxkQ2FuY2VsQnV0dG9uRWxlbWVudDo6ZGVmYXVsdEV2ZW50 SGFuZGxlcihFdmVudCogZXZlbnQpCiBpbmxpbmUgU3BpbkJ1dHRvbkVsZW1lbnQ6OlNwaW5CdXR0 b25FbGVtZW50KE5vZGUqIHNoYWRvd1BhcmVudCkKICAgICA6IFRleHRDb250cm9sSW5uZXJFbGVt ZW50KHNoYWRvd1BhcmVudC0+ZG9jdW1lbnQoKSwgc2hhZG93UGFyZW50KQogICAgICwgbV9jYXB0 dXJpbmcoZmFsc2UpCi0gICAgLCBtX29uVXBCdXR0b24oZmFsc2UpCisgICAgLCBtX3VwRG93blN0 YXRlKEluZGV0ZXJtaW5hdGUpCiB7CiB9CiAKQEAgLTMwNCw5ICszMDQsOSBAQCB2b2lkIFNwaW5C dXR0b25FbGVtZW50OjpkZWZhdWx0RXZlbnRIYW5kbGVyKEV2ZW50KiBldmVudCkKICAgICAgICAg ICAgICAgICAgICAgbV9jYXB0dXJpbmcgPSB0cnVlOwogICAgICAgICAgICAgICAgIH0KICAgICAg ICAgICAgIH0KLSAgICAgICAgICAgIGJvb2wgb2xkT25VcEJ1dHRvbiA9IG1fb25VcEJ1dHRvbjsK LSAgICAgICAgICAgIG1fb25VcEJ1dHRvbiA9IGxvY2FsLnkoKSA8IGJveC0+aGVpZ2h0KCkgLyAy OwotICAgICAgICAgICAgaWYgKG1fb25VcEJ1dHRvbiAhPSBvbGRPblVwQnV0dG9uKQorICAgICAg ICAgICAgVXBEb3duU3RhdGUgb2xkVXBEb3duU3RhdGUgPSBtX3VwRG93blN0YXRlOworICAgICAg ICAgICAgbV91cERvd25TdGF0ZSA9IGxvY2FsLnkoKSA8IGJveC0+aGVpZ2h0KCkgLyAyID8gVXAg OiBEb3duOworICAgICAgICAgICAgaWYgKG1fdXBEb3duU3RhdGUgIT0gb2xkVXBEb3duU3RhdGUp CiAgICAgICAgICAgICAgICAgcmVuZGVyZXIoKS0+cmVwYWludCgpOwogICAgICAgICB9IGVsc2Ug ewogICAgICAgICAgICAgaWYgKG1fY2FwdHVyaW5nKSB7CkBAIC0zMjIsNiArMzIyLDE0IEBAIHZv aWQgU3BpbkJ1dHRvbkVsZW1lbnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIoRXZlbnQqIGV2ZW50KQog ICAgICAgICBIVE1MRGl2RWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcihldmVudCk7CiB9CiAK K3ZvaWQgU3BpbkJ1dHRvbkVsZW1lbnQ6OnNldEhvdmVyZWQoYm9vbCBmbGFnKQoreworICAgIGlm ICghaG92ZXJlZCgpICYmIGZsYWcpCisgICAgICAgIG1fdXBEb3duU3RhdGUgPSBJbmRldGVybWlu YXRlOworICAgIFRleHRDb250cm9sSW5uZXJFbGVtZW50OjpzZXRIb3ZlcmVkKGZsYWcpOworfQor CisKIC8vIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIAogI2lmIEVOQUJMRShJTlBVVF9T UEVFQ0gpCmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0Q29udHJvbElubmVyRWxl bWVudHMuaCBiL1dlYkNvcmUvcmVuZGVyaW5nL1RleHRDb250cm9sSW5uZXJFbGVtZW50cy5oCmlu ZGV4IGZjNjA5ZTVjZjA2MDEwMGUxZDA0YmIwYWNkOTQ5MTI1YzA3N2U2NjMuLmM2MWZiOGFlNGRj OGM3ODMzMTgwMThmYjA3YzlkMzNmZmNiYTJmNWQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVy aW5nL1RleHRDb250cm9sSW5uZXJFbGVtZW50cy5oCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1Rl eHRDb250cm9sSW5uZXJFbGVtZW50cy5oCkBAIC04OCwxMSArODgsMTQgQEAgcHJpdmF0ZToKIAog Y2xhc3MgU3BpbkJ1dHRvbkVsZW1lbnQgOiBwdWJsaWMgVGV4dENvbnRyb2xJbm5lckVsZW1lbnQg ewogcHVibGljOgotICAgIHN0YXRpYyBQYXNzUmVmUHRyPFNwaW5CdXR0b25FbGVtZW50PiBjcmVh dGUoTm9kZSopOworICAgIGVudW0gVXBEb3duU3RhdGUgeworICAgICAgICBJbmRldGVybWluYXRl LCAvLyBIb3ZlcmVkLCBidXQgdGhlIGV2ZW50IGlzIG5vdCBoYW5kbGVkLgorICAgICAgICBEb3du LAorICAgICAgICBVcCwKKyAgICB9OwogCi0gICAgLy8gRklYTUU6ICJTcGluIGJ1dHRvbiBvbiB1 cCBidXR0b24iIGlzIG5vdCBhIHBocmFzZSB3aXRoIGEgc2luZ2xlIGNsZWFyIG1lYW5pbmcuCi0g ICAgLy8gTmVlZCBhIG5hbWUgZm9yIHRoaXMgdGhhdCBtYWtlcyBpdCBjbGVhcmVyLgotICAgIGJv b2wgb25VcEJ1dHRvbigpIGNvbnN0IHsgcmV0dXJuIG1fb25VcEJ1dHRvbjsgfQorICAgIHN0YXRp YyBQYXNzUmVmUHRyPFNwaW5CdXR0b25FbGVtZW50PiBjcmVhdGUoTm9kZSopOworICAgIFVwRG93 blN0YXRlIHVwRG93blN0YXRlKCkgY29uc3QgeyByZXR1cm4gbV91cERvd25TdGF0ZTsgfQogCiBw cml2YXRlOgogICAgIFNwaW5CdXR0b25FbGVtZW50KE5vZGUqKTsKQEAgLTEwMiw5ICsxMDUsMTAg QEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIGJvb2wgaXNFbmFibGVkRm9ybUNvbnRyb2woKSBjb25z dCB7IHJldHVybiBzdGF0aWNfY2FzdDxFbGVtZW50Kj4oY29uc3RfY2FzdDxTcGluQnV0dG9uRWxl bWVudCo+KHRoaXMpLT5zaGFkb3dBbmNlc3Rvck5vZGUoKSktPmlzRW5hYmxlZEZvcm1Db250cm9s KCk7IH0KICAgICB2aXJ0dWFsIGJvb2wgaXNSZWFkT25seUZvcm1Db250cm9sKCkgY29uc3QgeyBy ZXR1cm4gc3RhdGljX2Nhc3Q8RWxlbWVudCo+KGNvbnN0X2Nhc3Q8U3BpbkJ1dHRvbkVsZW1lbnQq Pih0aGlzKS0+c2hhZG93QW5jZXN0b3JOb2RlKCkpLT5pc1JlYWRPbmx5Rm9ybUNvbnRyb2woKTsg fQogICAgIHZpcnR1YWwgdm9pZCBkZWZhdWx0RXZlbnRIYW5kbGVyKEV2ZW50Kik7CisgICAgdmly dHVhbCB2b2lkIHNldEhvdmVyZWQoYm9vbCA9IHRydWUpOwogCiAgICAgYm9vbCBtX2NhcHR1cmlu ZzsKLSAgICBib29sIG1fb25VcEJ1dHRvbjsKKyAgICBVcERvd25TdGF0ZSBtX3VwRG93blN0YXRl OwogfTsKIAogI2lmIEVOQUJMRShJTlBVVF9TUEVFQ0gpCg==