42194 2010-07-13 13:52:28 -0700 WebKitTestRunner needs a more-complete implementation of eventSender 2020-06-01 10:46:39 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 ASSIGNED https://bugs.webkit.org/show_bug.cgi?id=157179 https://bugs.webkit.org/show_bug.cgi?id=208566 InRadar P2 Normal --- 64285 57515 57573 68108 68552 68556 69946 86881 117070 55056 56484 76986 1 mjs cshu christian.webkit cmarcelo cshu darin ddkilzer jbedard jberlin kbalazs laszlo.gombos mjs ossy rniwa sam thorton wenson_hsieh oldest_to_newest 250718 0 mjs 2010-07-13 13:52:28 -0700 WebKitTestRunner needs an implementation of eventSender. Many tests fail because of this (hundreds). 250726 1 mjs 2010-07-13 13:58:47 -0700 <rdar://problem/8186759> 363613 2 cshu 2011-03-07 14:53:09 -0800 My plan is to: 1. implement a coding mechanism for EventSender under WebKit2/WebProcess/InjectedBundle. I have tried to put this under Tools/WebKitTestRunner/InjectedBundle. However, it heavily depends on WebCore and CoreIPC code. 2. Use WKBundlePostMessage to send the EventSenderMessage over to UIProcess/WebContext. 3. When Tools/WebKitTestRunner/TestController receives message, call into WebKit2/WebProcess/InjectedBundle to decode the message and then trigger corresponding functions. Does it make sense? Thanks 375757 3 darin 2011-03-29 14:24:36 -0700 Have you made any progress on this? 375759 4 darin 2011-03-29 14:25:24 -0700 I ask because I was about to work on this myself. There is already an eventSender in WebKitTestRunner, but we haven’t hooked any events up yet. 375766 5 cshu 2011-03-29 14:28:40 -0700 (In reply to comment #4) > I ask because I was about to work on this myself. There is already an eventSender in WebKitTestRunner, but we haven’t hooked any events up yet. Yes, I started with the KeyDown function on the Qt platform. https://bugs.webkit.org/show_bug.cgi?id=56485 The patch has been there for quite some time. It will be great if you can take a look. Btw, that patch needs some polish. I also want to get some feedback on the comment#7 of the above bug before I submit the 2nd-round patch. 375768 6 cshu 2011-03-29 14:29:43 -0700 I can also provide an equivalent patch based on Mac. 377424 7 darin 2011-03-31 13:59:20 -0700 (In reply to comment #5) > The patch has been there for quite some time. It will be great if you can take a look. Btw, that patch needs some polish. I also want to get some feedback on the comment#7 of the above bug before I submit the 2nd-round patch. I’m sorry I never sent you feedback on that patch. I’m not sure what the best next step is. Sam, Maciej, your thoughts? 377431 8 cshu 2011-03-31 14:05:15 -0700 (In reply to comment #7) > (In reply to comment #5) > > The patch has been there for quite some time. It will be great if you can take a look. Btw, that patch needs some polish. I also want to get some feedback on the comment#7 of the above bug before I submit the 2nd-round patch. > > I’m sorry I never sent you feedback on that patch. I’m not sure what the best next step is. > > Sam, Maciej, your thoughts? That's fine. Actually, in my latest patch for bug 57515 (keydown), I created some generalized WK-api for decoding. Thus, I don't have to expose CoreIPC anymore. I think this approach is ok. Hope you guys agree. 381499 9 jberlin 2011-04-07 11:10:24 -0700 *** Bug 58059 has been marked as a duplicate of this bug. *** 382911 10 jberlin 2011-04-10 11:07:55 -0700 Added another test to the skipped list which uses eventSender.keyDown: http://trac.webkit.org/changeset/83402 392393 11 ossy 2011-04-26 04:36:09 -0700 (In reply to comment #10) > Added another test to the skipped list which uses eventSender.keyDown: http://trac.webkit.org/changeset/83402 One more test added: http://trac.webkit.org/changeset/84903 409227 12 rniwa 2011-05-24 14:51:22 -0700 *** Bug 61394 has been marked as a duplicate of this bug. *** 1657965 13 ap 2020-06-01 10:45:06 -0700 *** Bug 212582 has been marked as a duplicate of this bug. ***