42088 2010-07-12 09:39:19 -0700 Canvas: Move fillRect() save/restore into GraphicsContext implementations 2010-07-12 11:34:38 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling kling commit-queue oldest_to_newest 249885 0 kling 2010-07-12 09:39:19 -0700 CanvasRenderingContext2D::fillRect() will currently call save() and restore() on the GraphicsContext before and after calling fillRect(). This is unnecessary for Qt since GraphicsContextQt::fillRect() doesn't taint the QPainter. 249886 1 61240 kling 2010-07-12 09:41:12 -0700 Created attachment 61240 Proposed patch Not the prettiest patch in the world. Cosmetic suggestions welcome. 249895 2 61240 vestbo 2010-07-12 10:09:49 -0700 Comment on attachment 61240 Proposed patch I think the right approach is to have the GC do save/restore if it needs it. 249919 3 kling 2010-07-12 11:11:09 -0700 CG doesn't need this either. 249920 4 61248 kling 2010-07-12 11:16:02 -0700 Created attachment 61248 Proposed patch v2 (Qt) Results from Hixie's skelet0n animation test: http://hixie.ch/tests/adhoc/perf/video/002.html Without this patch: Elapsed wall-clock time: 996ms (ideal: 640ms). Elapsed non-idle time: 356ms (ideal: 0ms). Speed: 15.06fps (ideal: 25.00fps). With this patch: Elapsed wall-clock time: 900ms (ideal: 640ms). Elapsed non-idle time: 260ms (ideal: 0ms). Speed: 16.67fps (ideal: 25.00fps). 249927 5 61248 commit-queue 2010-07-12 11:34:34 -0700 Comment on attachment 61248 Proposed patch v2 Clearing flags on attachment: 61248 Committed r63102: <http://trac.webkit.org/changeset/63102> 249928 6 commit-queue 2010-07-12 11:34:38 -0700 All reviewed patches have been landed. Closing bug. 61240 2010-07-12 09:41:12 -0700 2010-07-12 11:16:02 -0700 Proposed patch bug-42088.diff text/plain 1362 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTlhYWJiZi4uYTBjMWM0OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNyBAQAogMjAxMC0wNy0xMiAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gQ2FudmFzOiBEb24ndCBzYXZlL3Jlc3RvcmUgUVBh aW50ZXIgZm9yIGZpbGxSZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00MjA4OAorCisgICAgICAgIFRoaXMgaXMgYW4gZXhwZW5zaXZlIG9wZXJhdGlv biBhbmQgbm90IG5lZWRlZCBieSBRdC4KKworICAgICAgICAqIGh0bWwvY2FudmFzL0NhbnZhc1Jl bmRlcmluZ0NvbnRleHQyRC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDYW52YXNSZW5kZXJpbmdD b250ZXh0MkQ6OmZpbGxSZWN0KToKKworMjAxMC0wNy0xMiAgQW5kcmVhcyBLbGluZyAgPGFuZHJl YXMua2xpbmdAbm9raWEuY29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5u LgogCiAgICAgICAgIFtRdF0gRHJhZ2dpbmcgd2l0aGluIHdlYmtpdCB3aXRoIGEgZHJhZyBjcmVh dGVkIHZpYSBKYXZhc2NyaXB0IGVuZHMgdXAgbWlzaW50ZXJwcmV0aW5nIHRoZSBkYXRhCmRpZmYg LS1naXQgYS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAg Yi9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKaW5kZXgg YmZlMzkxZC4uYWQ1NWQ3MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNS ZW5kZXJpbmdDb250ZXh0MkQuY3BwCisrKyBiL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVu ZGVyaW5nQ29udGV4dDJELmNwcApAQCAtNzY3LDkgKzc2NywxMyBAQCB2b2lkIENhbnZhc1JlbmRl cmluZ0NvbnRleHQyRDo6ZmlsbFJlY3QoZmxvYXQgeCwgZmxvYXQgeSwgZmxvYXQgd2lkdGgsIGZs b2F0IGhlaQogICAgIEZsb2F0UmVjdCByZWN0KHgsIHksIHdpZHRoLCBoZWlnaHQpOwogICAgIHdp bGxEcmF3KHJlY3QpOwogCisjaWYgIVBMQVRGT1JNKFFUKQogICAgIGMtPnNhdmUoKTsKKyNlbmRp ZgogICAgIGMtPmZpbGxSZWN0KHJlY3QpOworI2lmICFQTEFURk9STShRVCkKICAgICBjLT5yZXN0 b3JlKCk7CisjZW5kaWYKIH0KIAogdm9pZCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OnN0cm9r ZVJlY3QoZmxvYXQgeCwgZmxvYXQgeSwgZmxvYXQgd2lkdGgsIGZsb2F0IGhlaWdodCkK 61248 2010-07-12 11:16:02 -0700 2010-07-12 11:34:34 -0700 Proposed patch v2 bug-42088-v2.diff text/plain 4914 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDA2ZDc4Ni4uZDljYjVhZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAxMC0wNy0xMiAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENhbnZhczogTW92ZSBmaWxsUmVjdCgpIHNhdmUvcmVzdG9y ZSBpbnRvIEdyYXBoaWNzQ29udGV4dCBpbXBsZW1lbnRhdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyMDg4CisKKyAgICAgICAgU2F2aW5nIHRo ZSBwbGF0Zm9ybSBwYWludGVyIHN0YXRlIGlzIGFuIGV4cGVuc2l2ZSBvcGVyYXRpb24sCisgICAg ICAgIHNvIGRvbid0IGRvIGl0IGluIGZpbGxSZWN0KCkgZm9yIHBsYXRmb3JtcyB0aGF0IGRvbid0 IG5lZWQgaXQuIChDRywgUXQpCisKKyAgICAgICAgKiBodG1sL2NhbnZhcy9DYW52YXNSZW5kZXJp bmdDb250ZXh0MkQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2FudmFzUmVuZGVyaW5nQ29udGV4 dDJEOjpmaWxsUmVjdCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhp Y3NDb250ZXh0Q2Fpcm8uY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0Ojpm aWxsUmVjdCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRl eHRTa2lhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6ZmlsbFJlY3Qp OgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3dpbmNlL0dyYXBoaWNzQ29udGV4dFdpbmNl LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6ZmlsbFJlY3QpOgorICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3d4L0dyYXBoaWNzQ29udGV4dFd4LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6ZmlsbFJlY3QpOgorCiAyMDEwLTA3LTA5ICBB bGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5k ZXJpbmdDb250ZXh0MkQuY3BwIGIvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdD b250ZXh0MkQuY3BwCmluZGV4IGJmZTM5MWQuLmIzZDIxMmEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv aHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAorKysgYi9XZWJDb3JlL2h0 bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKQEAgLTc2Nyw5ICs3NjcsNyBA QCB2b2lkIENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6ZmlsbFJlY3QoZmxvYXQgeCwgZmxvYXQg eSwgZmxvYXQgd2lkdGgsIGZsb2F0IGhlaQogICAgIEZsb2F0UmVjdCByZWN0KHgsIHksIHdpZHRo LCBoZWlnaHQpOwogICAgIHdpbGxEcmF3KHJlY3QpOwogCi0gICAgYy0+c2F2ZSgpOwogICAgIGMt PmZpbGxSZWN0KHJlY3QpOwotICAgIGMtPnJlc3RvcmUoKTsKIH0KIAogdm9pZCBDYW52YXNSZW5k ZXJpbmdDb250ZXh0MkQ6OnN0cm9rZVJlY3QoZmxvYXQgeCwgZmxvYXQgeSwgZmxvYXQgd2lkdGgs IGZsb2F0IGhlaWdodCkKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fp cm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j YWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAKaW5kZXggOGI2MjI2Ny4uNmVkODkwNSAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRD YWlyby5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0Nv bnRleHRDYWlyby5jcHAKQEAgLTU2Myw4ICs1NjMsMTAgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQ6 OmZpbGxSZWN0KGNvbnN0IEZsb2F0UmVjdCYgcmVjdCkKICAgICAgICAgcmV0dXJuOwogCiAgICAg Y2Fpcm9fdCogY3IgPSBtX2RhdGEtPmNyOworICAgIGNhaXJvX3NhdmUoY3IpOwogICAgIGNhaXJv X3JlY3RhbmdsZShjciwgcmVjdC54KCksIHJlY3QueSgpLCByZWN0LndpZHRoKCksIHJlY3QuaGVp Z2h0KCkpOwogICAgIGZpbGxQYXRoKCk7CisgICAgY2Fpcm9fcmVzdG9yZShjcik7CiB9CiAKIHN0 YXRpYyB2b2lkIGRyYXdCb3JkZXJsZXNzUmVjdFNoYWRvdyhHcmFwaGljc0NvbnRleHQqIGNvbnRl eHQsIGNvbnN0IEZsb2F0UmVjdCYgcmVjdCwgY29uc3QgQ29sb3ImIHJlY3RDb2xvcikKZGlmZiAt LWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lh LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lh LmNwcAppbmRleCA3OTNmZTcyLi4wYzE4OThiIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tpYS5jcHAKKysrIGIvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBoaWNzQ29udGV4dFNraWEuY3BwCkBAIC03MzcsNiArNzM3 LDggQEAgdm9pZCBHcmFwaGljc0NvbnRleHQ6OmZpbGxSZWN0KGNvbnN0IEZsb2F0UmVjdCYgcmVj dCkKICAgICBpZiAocGFpbnRpbmdEaXNhYmxlZCgpKQogICAgICAgICByZXR1cm47CiAKKyAgICBw bGF0Zm9ybUNvbnRleHQoKS0+c2F2ZSgpOworCiAgICAgU2tSZWN0IHIgPSByZWN0OwogICAgIGlm ICghaXNSZWN0U2tpYVNhZmUoZ2V0Q1RNKCksIHIpKSB7CiAgICAgICAgIC8vIFNlZSB0aGUgb3Ro ZXIgdmVyc2lvbiBvZiBmaWxsUmVjdCBiZWxvdy4KQEAgLTc0Niw2ICs3NDgsOCBAQCB2b2lkIEdy YXBoaWNzQ29udGV4dDo6ZmlsbFJlY3QoY29uc3QgRmxvYXRSZWN0JiByZWN0KQogICAgIFNrUGFp bnQgcGFpbnQ7CiAgICAgcGxhdGZvcm1Db250ZXh0KCktPnNldHVwUGFpbnRGb3JGaWxsaW5nKCZw YWludCk7CiAgICAgcGxhdGZvcm1Db250ZXh0KCktPmNhbnZhcygpLT5kcmF3UmVjdChyLCBwYWlu dCk7CisKKyAgICBwbGF0Zm9ybUNvbnRleHQoKS0+cmVzdG9yZSgpOwogfQogCiB2b2lkIEdyYXBo aWNzQ29udGV4dDo6ZmlsbFJlY3QoY29uc3QgRmxvYXRSZWN0JiByZWN0LCBjb25zdCBDb2xvciYg Y29sb3IsIENvbG9yU3BhY2UgY29sb3JTcGFjZSkKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3Mvd2luY2UvR3JhcGhpY3NDb250ZXh0V2luY2UuY3BwIGIvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy93aW5jZS9HcmFwaGljc0NvbnRleHRXaW5jZS5jcHAKaW5kZXggN2JjNmEy Ny4uNTI5MmI4MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW5jZS9H cmFwaGljc0NvbnRleHRXaW5jZS5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93 aW5jZS9HcmFwaGljc0NvbnRleHRXaW5jZS5jcHAKQEAgLTE1NTUsMTAgKzE1NTUsMTQgQEAgdm9p ZCBHcmFwaGljc0NvbnRleHQ6OmNsaXBUb0ltYWdlQnVmZmVyKGNvbnN0IEZsb2F0UmVjdCYsIGNv bnN0IEltYWdlQnVmZmVyKikKIAogdm9pZCBHcmFwaGljc0NvbnRleHQ6OmZpbGxSZWN0KGNvbnN0 IEZsb2F0UmVjdCYgcmVjdCkKIHsKKyAgICBzYXZlUGxhdGZvcm1TdGF0ZSgpOworCiAgICAgaWYg KG1fY29tbW9uLT5zdGF0ZS5maWxsR3JhZGllbnQpCiAgICAgICAgIGZpbGxSZWN0KHJlY3QsIG1f Y29tbW9uLT5zdGF0ZS5maWxsR3JhZGllbnQuZ2V0KCkpOwogICAgIGVsc2UKICAgICAgICAgZmls bFJlY3QocmVjdCwgZmlsbENvbG9yKCksIERldmljZUNvbG9yU3BhY2UpOworCisgICAgcmVzdG9y ZVBsYXRmb3JtU3RhdGUoKTsKIH0KIAogdm9pZCBHcmFwaGljc0NvbnRleHQ6OnNldFBsYXRmb3Jt U2hhZG93KGNvbnN0IEZsb2F0U2l6ZSYsIGZsb2F0LCBjb25zdCBDb2xvciYsIENvbG9yU3BhY2Up CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3d4L0dyYXBoaWNzQ29udGV4 dFd4LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd3gvR3JhcGhpY3NDb250ZXh0V3gu Y3BwCmluZGV4IDU5NjhlZjMuLjAxZGNlOWUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvd3gvR3JhcGhpY3NDb250ZXh0V3guY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvd3gvR3JhcGhpY3NDb250ZXh0V3guY3BwCkBAIC0yNzIsOSArMjcyLDEzIEBAIHZv aWQgR3JhcGhpY3NDb250ZXh0OjpmaWxsUmVjdChjb25zdCBGbG9hdFJlY3QmIHJlY3QsIGNvbnN0 IENvbG9yJiBjb2xvciwgQ29sb3JTCiAgICAgaWYgKHBhaW50aW5nRGlzYWJsZWQoKSkKICAgICAg ICAgcmV0dXJuOwogCisgICAgc2F2ZVBsYXRmb3JtU3RhdGUoKTsKKwogICAgIG1fZGF0YS0+Y29u dGV4dC0+U2V0UGVuKCp3eFRSQU5TUEFSRU5UX1BFTik7CiAgICAgbV9kYXRhLT5jb250ZXh0LT5T ZXRCcnVzaCh3eEJydXNoKGNvbG9yKSk7CiAgICAgbV9kYXRhLT5jb250ZXh0LT5EcmF3UmVjdGFu Z2xlKHJlY3QueCgpLCByZWN0LnkoKSwgcmVjdC53aWR0aCgpLCByZWN0LmhlaWdodCgpKTsKKwor ICAgIHJlc3RvcmVQbGF0Zm9ybVN0YXRlKCk7CiB9CiAKIHZvaWQgR3JhcGhpY3NDb250ZXh0Ojpm aWxsUm91bmRlZFJlY3QoY29uc3QgSW50UmVjdCYgcmVjdCwgY29uc3QgSW50U2l6ZSYgdG9wTGVm dCwgY29uc3QgSW50U2l6ZSYgdG9wUmlnaHQsIGNvbnN0IEludFNpemUmIGJvdHRvbUxlZnQsIGNv bnN0IEludFNpemUmIGJvdHRvbVJpZ2h0LCBjb25zdCBDb2xvciYgY29sb3IsIENvbG9yU3BhY2Ug Y29sb3JTcGFjZSkK