41747 2010-07-07 00:13:14 -0700 [DRT/Chromium] Support for indeterminate checkbox 2010-07-07 20:42:51 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other Windows XP RESOLVED FIXED P2 Normal --- 38023 1 tkent webkit-unassigned dglazkov oldest_to_newest 247358 0 tkent 2010-07-07 00:13:14 -0700 [DRT/Chromium] Support for indeterminate checkbox 247362 1 60697 tkent 2010-07-07 00:35:57 -0700 Created attachment 60697 Patch 247415 2 60697 abarth 2010-07-07 02:33:03 -0700 Comment on attachment 60697 Patch WebKitTools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp:149 + This blank line seems extra and isn't in the "imported" change, as far as I can tell. 247975 3 tkent 2010-07-07 20:42:38 -0700 Thank you for reviewing. I updated the code so that it has consistent blank lines, and commited as r62751. 60697 2010-07-07 00:35:57 -0700 2010-07-07 20:42:51 -0700 Patch bug-41747-20100707163555.patch text/plain 3982 tkent ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA0MWMzNjI4N2I5ZGMzNGU4YWI5MDk5MWI3NGE1OWMxY2Y4MzM4MTdiLi43YWViMzMy OWYwZmMwMWUwYmVmMWM5NzE0Yjc3MjhmMzAxNzMxNDE5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAK KzIwMTAtMDctMDcgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtEUlQvQ2hyb21pdW1dIFN1 cHBvcnQgZm9yIGluZGV0ZXJtaW5hdGUgY2hlY2tib3gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxNzQ3CisKKyAgICAgICAgSW1wb3J0IGh0dHA6Ly9z cmMuY2hyb21pdW0ub3JnL3ZpZXd2Yy9jaHJvbWU/dmlldz1yZXYmcmV2aXNpb249NTE0OTkKKwor ICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlRoZW1lQ29udHJvbERSVC5jcHA6 CisgICAgICAgIChXZWJUaGVtZUNvbnRyb2xEUlQ6OmRyYXcpOgorICAgICAgICAqIER1bXBSZW5k ZXJUcmVlL2Nocm9taXVtL1dlYlRoZW1lQ29udHJvbERSVC5oOgorICAgICAgICAoV2ViVGhlbWVD b250cm9sRFJUOjopOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlRoZW1l RW5naW5lRFJULmNwcDoKKyAgICAgICAgKFdlYlRoZW1lRW5naW5lRFJUOjpwYWludEJ1dHRvbik6 CisKIDIwMTAtMDctMDYgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IFNoaW5pY2hpcm8gSGFtYWppLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9v bHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVGhlbWVDb250cm9sRFJULmNwcCBiL1dlYktp dFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlRoZW1lQ29udHJvbERSVC5jcHAKaW5k ZXggZGYxMjQ3NjE2NTcyZDQ2ZDMzMTEwNmEyNjg2MmE5ZjI2NjczY2EwZC4uMjAyMjQ4YWM0MTE3 ODRlZTVhMzljZjc4OWQwYjk5YTRkZjNlZTZiMCAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvRHVt cFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVGhlbWVDb250cm9sRFJULmNwcAorKysgYi9XZWJLaXRU b29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJUaGVtZUNvbnRyb2xEUlQuY3BwCkBAIC0z MzIsNiArMzMyLDExIEBAIHZvaWQgV2ViVGhlbWVDb250cm9sRFJUOjpkcmF3KCkKICAgICAgICAg bmVzdGVkQm94ZXMoY2hlY2tJbmRlbnQsIGNoZWNrSW5kZW50LCBjaGVja0luZGVudCwgY2hlY2tJ bmRlbnQsIG1fYmdDb2xvciwgbV9mZ0NvbG9yKTsKICAgICAgICAgYnJlYWs7CiAKKyAgICBjYXNl IEluZGV0ZXJtaW5hdGVDaGVja2JveFR5cGU6CisgICAgICAgIC8vIEluZGV0ZXJtaW5hdGUgY2hl Y2tib3ggaXMgYSBib3ggY29udGFpbmluZyAnLScuCisgICAgICAgIG5lc3RlZEJveGVzKGNoZWNr SW5kZW50LCBoYWxmSGVpZ2h0LCBjaGVja0luZGVudCwgaGFsZkhlaWdodCwgbV9iZ0NvbG9yLCBt X2ZnQ29sb3IpOworICAgICAgICBicmVhazsKKwogICAgIGNhc2UgVW5jaGVja2VkUmFkaW9UeXBl OgogICAgICAgICBjaXJjbGUoU2tJbnRUb1NjYWxhcihoYWxmSGVpZ2h0KSwgbV9iZ0NvbG9yKTsK ICAgICAgICAgYnJlYWs7CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9j aHJvbWl1bS9XZWJUaGVtZUNvbnRyb2xEUlQuaCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVl L2Nocm9taXVtL1dlYlRoZW1lQ29udHJvbERSVC5oCmluZGV4IDFmNzM2MTBhZGMwYzczYTU4NjNj NTVhOGQyYzUxMzU0MzdiNDNlZjguLjM4ODMxZDk1ZjA2ZTgwMzcwYmMzNDY1ODRlMDE4Y2VmOWQy ZDNkZjQgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dl YlRoZW1lQ29udHJvbERSVC5oCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9t aXVtL1dlYlRoZW1lQ29udHJvbERSVC5oCkBAIC05OCw2ICs5OCw3IEBAIHB1YmxpYzoKICAgICAg ICAgUHVzaEJ1dHRvblR5cGUsCiAgICAgICAgIFVuY2hlY2tlZEJveFR5cGUsCiAgICAgICAgIENo ZWNrZWRCb3hUeXBlLAorICAgICAgICBJbmRldGVybWluYXRlQ2hlY2tib3hUeXBlLAogICAgICAg ICBVbmNoZWNrZWRSYWRpb1R5cGUsCiAgICAgICAgIENoZWNrZWRSYWRpb1R5cGUsCiAgICAgICAg IEhvcml6b250YWxTY3JvbGxUcmFja0JhY2tUeXBlLApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMv RHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVGhlbWVFbmdpbmVEUlQuY3BwIGIvV2ViS2l0VG9v bHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVGhlbWVFbmdpbmVEUlQuY3BwCmluZGV4IGIz MDkyY2NkNzZkNWY4MTRlMGY1YWIzY2U3YmJjNGMzZWQwNzRkYjAuLjBjZjNjNjRlMTEzMDYzZTJm YjczYWUyNDE4MjkzZDc2NTRkY2Y1YjggMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5k ZXJUcmVlL2Nocm9taXVtL1dlYlRoZW1lRW5naW5lRFJULmNwcAorKysgYi9XZWJLaXRUb29scy9E dW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJUaGVtZUVuZ2luZURSVC5jcHAKQEAgLTE0Nyw2ICsx NDcsMjggQEAgdm9pZCBXZWJUaGVtZUVuZ2luZURSVDo6cGFpbnRCdXR0b24oV2ViQ2FudmFzKiBj YW52YXMsCiAgICAgICAgICAgICBjc3RhdGUgPSBXZWJUaGVtZUNvbnRyb2xEUlQ6OkRpc2FibGVk U3RhdGU7CiAgICAgICAgICAgICBicmVhazsKIAorICAgICAgICBjYXNlIENCU19NSVhFRE5PUk1B TDoKKyAgICAgICAgICAgIC8vIENsYXNzaWMgdGhlbWUgY2FuJ3QgcmVwcmVzZW50IG1peGVkIHN0 YXRlIGNoZWNrYm94LiBXZSBhc3N1bWUKKyAgICAgICAgICAgIC8vIGl0J3MgZXF1aXZhbGVudCB0 byB1bmNoZWNrZWQuCisgICAgICAgICAgICBBU1NFUlQoY2xhc3NpY1N0YXRlID09IERGQ1NfQlVU VE9OQ0hFQ0spOworICAgICAgICAgICAgY3R5cGUgPSBXZWJUaGVtZUNvbnRyb2xEUlQ6OkluZGV0 ZXJtaW5hdGVDaGVja2JveFR5cGU7CisgICAgICAgICAgICBjc3RhdGUgPSBXZWJUaGVtZUNvbnRy b2xEUlQ6Ok5vcm1hbFN0YXRlOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIGNhc2UgQ0JT X01JWEVESE9UOgorICAgICAgICAgICAgQVNTRVJUKGNsYXNzaWNTdGF0ZSA9PSAoREZDU19CVVRU T05DSEVDSyB8IERGQ1NfSE9UKSk7CisgICAgICAgICAgICBjdHlwZSA9IFdlYlRoZW1lQ29udHJv bERSVDo6SW5kZXRlcm1pbmF0ZUNoZWNrYm94VHlwZTsKKyAgICAgICAgICAgIGNzdGF0ZSA9IFdl YlRoZW1lQ29udHJvbERSVDo6SG90U3RhdGU7CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAg Y2FzZSBDQlNfTUlYRURQUkVTU0VEOgorICAgICAgICAgICAgQVNTRVJUKGNsYXNzaWNTdGF0ZSA9 PSAoREZDU19CVVRUT05DSEVDSyB8IERGQ1NfUFVTSEVEKSk7CisgICAgICAgICAgICBjdHlwZSA9 IFdlYlRoZW1lQ29udHJvbERSVDo6SW5kZXRlcm1pbmF0ZUNoZWNrYm94VHlwZTsKKyAgICAgICAg ICAgIGNzdGF0ZSA9IFdlYlRoZW1lQ29udHJvbERSVDo6UHJlc3NlZFN0YXRlOworICAgICAgICAg ICAgYnJlYWs7CisgICAgICAgIGNhc2UgQ0JTX01JWEVERElTQUJMRUQ6CisgICAgICAgICAgICBB U1NFUlQoY2xhc3NpY1N0YXRlID09IChERkNTX0JVVFRPTkNIRUNLIHwgREZDU19JTkFDVElWRSkp OworICAgICAgICAgICAgY3R5cGUgPSBXZWJUaGVtZUNvbnRyb2xEUlQ6OkluZGV0ZXJtaW5hdGVD aGVja2JveFR5cGU7CisgICAgICAgICAgICBjc3RhdGUgPSBXZWJUaGVtZUNvbnRyb2xEUlQ6OkRp c2FibGVkU3RhdGU7CisgICAgICAgICAgICBicmVhazsKICAgICAgICAgZGVmYXVsdDoKICAgICAg ICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgICAgICAgICAgYnJlYWs7Cg==