41520 2010-07-02 05:52:14 -0700 [Qt] QScriptEnginePrivate compilation fix 2010-07-02 07:11:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Normal --- 31863 1 jedrzej.nowacki jedrzej.nowacki commit-queue oldest_to_newest 245890 0 jedrzej.nowacki 2010-07-02 05:52:14 -0700 There is a compilation problem. QScriptEnginePrivate::newArray can't be const because it calls setException which is non const. WebKit-script/JavaScriptCore/qt/api/qscriptengine_p.cpp: In member function ‘QScriptValuePrivate* QScriptEnginePrivate::newArray(uint) const’: WebKit-script/JavaScriptCore/qt/api/qscriptengine_p.cpp:105: error: passing ‘const QScriptEnginePrivate’ as ‘this’ argument of ‘void QScriptEnginePrivate::setException(const OpaqueJSValue*, unsigned int)’ discards qualifiers 245891 1 60361 jedrzej.nowacki 2010-07-02 05:54:55 -0700 Created attachment 60361 Fix v1 245904 2 60361 commit-queue 2010-07-02 07:11:13 -0700 Comment on attachment 60361 Fix v1 Clearing flags on attachment: 60361 Committed r62382: <http://trac.webkit.org/changeset/62382> 245905 3 commit-queue 2010-07-02 07:11:17 -0700 All reviewed patches have been landed. Closing bug. 60361 2010-07-02 05:54:55 -0700 2010-07-02 07:11:13 -0700 Fix v1 fix.diff text/plain 2023 jedrzej.nowacki ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3F0L0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3Jl L3F0L0NoYW5nZUxvZwppbmRleCA1MzJmMGZjLi5jOTRjMGQ2IDEwMDY0NAotLS0gYS9KYXZhU2Ny aXB0Q29yZS9xdC9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvcXQvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDctMDIgIEplZHJ6ZWogTm93YWNraSAgPGplZHJ6ZWoubm93 YWNraUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQ29tcGlsYXRpb24gZml4LgorCisgICAgICAgIFFTY3JpcHRFbmdpbmVQcml2YXRl OjpuZXdBcnJheSBjYW4ndCBiZSBjb25zdCBiZWNhdXNlIGl0IGNhbgorICAgICAgICB0aHJvdyBh biBleGNlcHRpb24uCisKKyAgICAgICAgW1F0XSBRU2NyaXB0RW5naW5lUHJpdmF0ZSBjb21waWxh dGlvbiBmaXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQxNTIwCisKKyAgICAgICAgKiBhcGkvcXNjcmlwdGVuZ2luZV9wLmNwcDoKKyAgICAgICAgKFFT Y3JpcHRFbmdpbmVQcml2YXRlOjpuZXdBcnJheSk6CisgICAgICAgICogYXBpL3FzY3JpcHRlbmdp bmVfcC5oOgorCiAyMDEwLTA2LTI4ICBKZWRyemVqIE5vd2Fja2kgIDxqZWRyemVqLm5vd2Fja2lA bm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpkaWZmIC0t Z2l0IGEvSmF2YVNjcmlwdENvcmUvcXQvYXBpL3FzY3JpcHRlbmdpbmVfcC5jcHAgYi9KYXZhU2Ny aXB0Q29yZS9xdC9hcGkvcXNjcmlwdGVuZ2luZV9wLmNwcAppbmRleCBmMWRiOTllLi4yM2U0MWM0 IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9xdC9hcGkvcXNjcmlwdGVuZ2luZV9wLmNwcAor KysgYi9KYXZhU2NyaXB0Q29yZS9xdC9hcGkvcXNjcmlwdGVuZ2luZV9wLmNwcApAQCAtOTAsNyAr OTAsNyBAQCBRU2NyaXB0VmFsdWVQcml2YXRlKiBRU2NyaXB0RW5naW5lUHJpdmF0ZTo6bmV3T2Jq ZWN0KCkgY29uc3QKICAgICByZXR1cm4gbmV3IFFTY3JpcHRWYWx1ZVByaXZhdGUodGhpcywgSlNP YmplY3RNYWtlKG1fY29udGV4dCwgLyoganNDbGFzcyAqLyAwLCAvKiB1c2VyRGF0YSAqLyAwKSk7 CiB9CiAKLVFTY3JpcHRWYWx1ZVByaXZhdGUqIFFTY3JpcHRFbmdpbmVQcml2YXRlOjpuZXdBcnJh eSh1aW50IGxlbmd0aCkgY29uc3QKK1FTY3JpcHRWYWx1ZVByaXZhdGUqIFFTY3JpcHRFbmdpbmVQ cml2YXRlOjpuZXdBcnJheSh1aW50IGxlbmd0aCkKIHsKICAgICBKU1ZhbHVlUmVmIGV4Y2VwdGlv biA9IDA7CiAgICAgSlNPYmplY3RSZWYgYXJyYXkgPSBKU09iamVjdE1ha2VBcnJheShtX2NvbnRl eHQsIC8qIGFyZ3VtZW50Q291bnQgKi8gMCwgLyogYXJndW1lbnRzICovIDAsICZleGNlcHRpb24p OwpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvcXQvYXBpL3FzY3JpcHRlbmdpbmVfcC5oIGIv SmF2YVNjcmlwdENvcmUvcXQvYXBpL3FzY3JpcHRlbmdpbmVfcC5oCmluZGV4IGM1MjAyMzAuLjMw ZWUwMzkgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3F0L2FwaS9xc2NyaXB0ZW5naW5lX3Au aAorKysgYi9KYXZhU2NyaXB0Q29yZS9xdC9hcGkvcXNjcmlwdGVuZ2luZV9wLmgKQEAgLTcxLDcg KzcxLDcgQEAgcHVibGljOgogICAgIGlubGluZSBKU1ZhbHVlUmVmIG1ha2VKU1ZhbHVlKFFTY3Jp cHRWYWx1ZTo6U3BlY2lhbFZhbHVlIHZhbHVlKSBjb25zdDsKIAogICAgIFFTY3JpcHRWYWx1ZVBy aXZhdGUqIG5ld09iamVjdCgpIGNvbnN0OwotICAgIFFTY3JpcHRWYWx1ZVByaXZhdGUqIG5ld0Fy cmF5KHVpbnQgbGVuZ3RoKSBjb25zdDsKKyAgICBRU2NyaXB0VmFsdWVQcml2YXRlKiBuZXdBcnJh eSh1aW50IGxlbmd0aCk7CiAgICAgUVNjcmlwdFZhbHVlUHJpdmF0ZSogZ2xvYmFsT2JqZWN0KCkg Y29uc3Q7CiAKICAgICBpbmxpbmUgUVNjcmlwdFN0cmluZ1ByaXZhdGUqIHRvU3RyaW5nSGFuZGxl KGNvbnN0IFFTdHJpbmcmIHN0cikgY29uc3Q7Cg==