<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>41345</bug_id>
          
          <creation_ts>2010-06-29 05:52:21 -0700</creation_ts>
          <short_desc>Parameter names in frame src URLs parsed incorrectly if resembles HTML entity code followed by underscore</short_desc>
          <delta_ts>2010-07-01 02:47:50 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Frames</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Windows XP</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>41115</blocked>
          <everconfirmed>0</everconfirmed>
          <reporter name="atomicules">base</reporter>
          <assigned_to name="Adam Barth">abarth</assigned_to>
          <cc>abarth</cc>
    
    <cc>ap</cc>
    
    <cc>commit-queue</cc>
    
    <cc>eric</cc>
    
    <cc>mirthy</cc>
    
    <cc>tonyg</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>244241</commentid>
    <comment_count>0</comment_count>
      <attachid>60014</attachid>
    <who name="atomicules">base</who>
    <bug_when>2010-06-29 05:52:21 -0700</bug_when>
    <thetext>Created attachment 60014
Test case showing error.

(Note, originally filed as Issue 47509 on Chromium Issues, but then I read about Chrome using the new HTML5 parser in the Chromium-dev Google group, so verified with webkit nightly (r61877) and it is indeed a webkit bug).

Chrome Version       : 6.0.447.0 (Official Build 50594) dev
URLs (if applicable) : See attached file
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
          Safari 5: OK
  Firefox 3.7a6pre: OK
              IE 6: OK
         

What steps will reproduce the problem?
1. Open up the attached webpage
2. Developer Tools &gt; Elements will show the first paramter of the URL for the bottom frame as &quot;setno=0∏_id=&quot;
3. View source on the page, or viewing the attached file in a text editor will show the first parameters as &quot;setno=0&amp;prod_id=&quot;

What is the expected result?

The URL parameters should be parsed correctly

What happens instead?

Parsed incorrectly.


Please provide any additional information below. Attach a screenshot if
possible.

The attached file is based on an internal intranet page of the company I work for. I have just changed the URLs to something that will load for everyone (google search), but have included the parameter from the intranet page as a dummy parameter to the google search.

This issue is new with 6.0.447.0. As it was working correctly in the previous build.

In testing this parsing error seems to be caused if a parameter name resembles a HTML entity code (i.e. just missing the semi-colon) followed by an underscore:

E.g: 

&amp;pound_id  =&gt; £_id
&amp;amp_id =&gt; &amp;_id
&amp;quot_id =&gt; &quot;_id</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>244378</commentid>
    <comment_count>1</comment_count>
      <attachid>60037</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-06-29 10:50:02 -0700</bug_when>
    <thetext>Created attachment 60037
reduction

Here&apos;s a simpler reduction.  For some reason, Minefield is treating the &amp;prod; entity differently from the &amp;pound; entity.  We&apos;ll need to investigate further to understand why.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>244399</commentid>
    <comment_count>2</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2010-06-29 11:32:51 -0700</bug_when>
    <thetext>See also: bug 35831.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>244569</commentid>
    <comment_count>3</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-06-29 17:24:16 -0700</bug_when>
    <thetext>*** Bug 35831 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>244570</commentid>
    <comment_count>4</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-06-29 17:25:16 -0700</bug_when>
    <thetext>Some folks in the HTML working group explained the issue to me.  We&apos;re ignoring an important bit in the entity table.  Given that the old parser has the right behavior here, we must have that bit somewhere.  Investigating.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>244574</commentid>
    <comment_count>5</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-06-29 17:38:31 -0700</bug_when>
    <thetext>Looks like I missed this check:

http://trac.webkit.org/browser/trunk/WebCore/html/LegacyHTMLDocumentParser.cpp#L834</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>244578</commentid>
    <comment_count>6</comment_count>
      <attachid>60073</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-06-29 17:59:44 -0700</bug_when>
    <thetext>Created attachment 60073
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>244579</commentid>
    <comment_count>7</comment_count>
      <attachid>60073</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-06-29 18:01:33 -0700</bug_when>
    <thetext>Comment on attachment 60073
Patch

&gt; +                        if (entity-&gt;code &gt; 255)
&gt; +                            break;

What&apos;s the meaning of the magic number 255 here? If it was a named constant it could have a name or comment indicating why 255 is the correct number.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>244580</commentid>
    <comment_count>8</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-06-29 18:03:27 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; (From update of attachment 60073 [details])
&gt; &gt; +                        if (entity-&gt;code &gt; 255)
&gt; &gt; +                            break;
&gt; 
&gt; What&apos;s the meaning of the magic number 255 here? If it was a named constant it could have a name or comment indicating why 255 is the correct number.

I bet it&apos;s the characters that fit in Latin-1.  That&apos;s how the code in the legacy tokenizer is written (although it only applies that branch to attribute values, which doesn&apos;t match the spec or Minefield).

The spec just has a giant table:

http://www.whatwg.org/specs/web-apps/current-work/multipage/named-character-references.html#named-character-references</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>245114</commentid>
    <comment_count>9</comment_count>
      <attachid>60073</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-06-30 23:07:01 -0700</bug_when>
    <thetext>Comment on attachment 60073
Patch

Holy shit that needs a comment.  No sir, I cannot r+ such madness w/o explanation (or at least a spec link).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>245129</commentid>
    <comment_count>10</comment_count>
      <attachid>60203</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-06-30 23:25:26 -0700</bug_when>
    <thetext>Created attachment 60203
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>245131</commentid>
    <comment_count>11</comment_count>
      <attachid>60203</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-06-30 23:26:26 -0700</bug_when>
    <thetext>Comment on attachment 60203
Patch

Fantastic!  Thank you!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>245219</commentid>
    <comment_count>12</comment_count>
      <attachid>60203</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-07-01 02:29:32 -0700</bug_when>
    <thetext>Comment on attachment 60203
Patch

Clearing flags on attachment: 60203

Committed r62241: &lt;http://trac.webkit.org/changeset/62241&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>245220</commentid>
    <comment_count>13</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-07-01 02:29:43 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>245229</commentid>
    <comment_count>14</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-07-01 02:47:50 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/62241 might have broken Qt Linux Release</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>60014</attachid>
            <date>2010-06-29 05:52:21 -0700</date>
            <delta_ts>2010-06-29 05:52:21 -0700</delta_ts>
            <desc>Test case showing error.</desc>
            <filename>frameparam.htm</filename>
            <type>text/html</type>
            <size>534</size>
            <attacher name="atomicules">base</attacher>
            
              <data encoding="base64">DQo8aHRtbD4NCjxoZWFkPg0KICAgPHRpdGxlPkZyYW1lIHNyYyB1cmwgcGFyYW1ldGVyczwvdGl0
bGU+DQogICANCiAgICA8bWV0YSBodHRwLWVxdWl2PSJDb250ZW50LVR5cGUiIGNvbnRlbnQ9InRl
eHQvaHRtbDsgY2hhcnNldD1VVEYtOCI+DQogICAJCQ0KICAgPG1ldGEgaHR0cC1lcXVpdj0iRXhw
aXJlcyIgY29udGVudD0iMCI+DQo8L2hlYWQ+DQoNCgk8ZnJhbWVzZXQgZnJhbWVzcGFjaW5nPSIw
IiBmcmFtZWJvcmRlcj0wIHJvd3M9IjExNywxMDAlLCoiPg0KCQk8ZnJhbWUgbmFtZT0idG9wIiBp
ZD0idG9wIiBzY3JvbGxpbmc9Im5vIiBub3Jlc2l6ZSBzcmM9Imh0dHA6Ly93d3cuZ29vZ2xlLmNv
bSI+CQ0KCQkNCg0KCTxmcmFtZSBuYW1lPSJib3R0b20iIGlkPSJib3R0b20iIHNjcm9sbGluZz0i
eWVzIiBub3Jlc2l6ZSBzcmM9Imh0dHA6Ly93d3cuZ29vZ2xlLmNvbS9zZWFyY2g/c2V0bm89MCZw
cm9kX2lkPSZobD1lbiZzb3VyY2U9aHAmcT10ZXN0JmJ0bkc9R29vZ2xlK1NlYXJjaCI+DQoJDQo8
L2ZyYW1lc2V0Pg0KPC9odG1sPg0K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>60037</attachid>
            <date>2010-06-29 10:50:02 -0700</date>
            <delta_ts>2010-06-29 10:50:02 -0700</delta_ts>
            <desc>reduction</desc>
            <filename>reduction.html</filename>
            <type>text/html</type>
            <size>417</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">PGEgaHJlZj0iaHR0cDovL2V4YW1wbGUuY29tL2Zvbz9iYXI9YmF6JnBvdW5kX2lkPXF1eCI+bGlu
azE8L2E+PGJyPgo8YSBocmVmPSJodHRwOi8vZXhhbXBsZS5jb20vZm9vP2Jhcj1iYXomcHJvZF9p
ZD1xdXgiPmxpbmsyPC9hPjxicj4KPHRleHRhcmVhIGNvbHM9ODAgcm93cz01Pgo8L3RleHRhcmVh
Pgo8c2NyaXB0Pgp2YXIgYXJlYSA9IGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCd0ZXh0
YXJlYScpWzBdOwp2YXIgbGlua3MgPSBkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgnYScp
Owpmb3IgKHZhciBpPTA7IGkgPCBsaW5rcy5sZW5ndGg7ICsraSkgewogIGFyZWEudmFsdWUgKz0g
bGlua3NbaV0uaHJlZiArICJcbiIKfQo8L3NjcmlwdD4KPGJyPgpFbnRpdHkxOiAmcG91bmQ7PGJy
PgpFbnRpdHkyOiAmcHJvZDsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>60073</attachid>
            <date>2010-06-29 17:59:44 -0700</date>
            <delta_ts>2010-06-30 23:25:21 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-41345-20100629175943.patch</filename>
            <type>text/plain</type>
            <size>4434</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCA5NzFlZGUxNDc2NTdhN2Y1N2E1NTE4NDRlYTQxMzMwMWFiMTgxODVkLi42YjQxZDNk
OTUyZjZlMzUyNjU5OGNlYmVmY2U5NDg3MTI2NWUzYmU0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0
cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK
KzIwMTAtMDYtMjkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQYXJhbWV0ZXIgbmFtZXMgaW4g
ZnJhbWUgc3JjIFVSTHMgcGFyc2VkIGluY29ycmVjdGx5IGlmIHJlc2VtYmxlcyBIVE1MIGVudGl0
eSBjb2RlIGZvbGxvd2VkIGJ5IHVuZGVyc2NvcmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTQxMzQ1CisKKyAgICAgICAgQWRkIHNvbWUgbW9yZSBIVE1M
IGVudGl0eSB0ZXN0IGNvdmVyYWdlIGZvciB3aGVuIHRoZSB0cmFpbGluZyBzZW1pY29sb24KKyAg
ICAgICAgY2hhcmFjdGVyIGlzIHJlcXVpcmVkLgorCisgICAgICAgICogaHRtbDVsaWIvcmVzb3Vy
Y2VzL2VudGl0aWVzMDIuZGF0OgorCiAyMDEwLTA2LTI5ICBGcmFuw6dvaXMgU2F1c3NldCAgPHNh
dXNzZXRAZ21haWwuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZm
IC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHRtbDVsaWIvcmVzb3VyY2VzL2VudGl0aWVzMDIuZGF0IGIv
TGF5b3V0VGVzdHMvaHRtbDVsaWIvcmVzb3VyY2VzL2VudGl0aWVzMDIuZGF0CmluZGV4IDBiNGRk
NjY4MTk5M2U3MjhiMTAzZjRlZTQyNjU2NmQwZTIyNWFhMDYuLmUyZmI0MmEwNzhiMjI3YWJjMmZk
ZGM1NDVlMDc0MDRhMzQzYmFlMDcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0bWw1bGliL3Jl
c291cmNlcy9lbnRpdGllczAyLmRhdAorKysgYi9MYXlvdXRUZXN0cy9odG1sNWxpYi9yZXNvdXJj
ZXMvZW50aXRpZXMwMi5kYXQKQEAgLTEyNywzICsxMjcsMTIzIEBACiB8ICAgPGJvZHk+CiB8ICAg
ICA8ZGl2PgogfCAgICAgICBiYXI9IlpaPiIKKworI2RhdGEKKzxkaXYgYmFyPSJaWiZwb3VuZF9p
ZD0yMyI+PC9kaXY+CisjZXJyb3JzCisjZG9jdW1lbnQKK3wgPGh0bWw+Cit8ICAgPGhlYWQ+Cit8
ICAgPGJvZHk+Cit8ICAgICA8ZGl2PgorfCAgICAgICBiYXI9IlpawqNfaWQ9MjMiCisKKyNkYXRh
Cis8ZGl2IGJhcj0iWlomcHJvZF9pZD0yMyI+PC9kaXY+CisjZXJyb3JzCisjZG9jdW1lbnQKK3wg
PGh0bWw+Cit8ICAgPGhlYWQ+Cit8ICAgPGJvZHk+Cit8ICAgICA8ZGl2PgorfCAgICAgICBiYXI9
IlpaJnByb2RfaWQ9MjMiCisKKyNkYXRhCis8ZGl2IGJhcj0iWlomcG91bmQ7X2lkPTIzIj48L2Rp
dj4KKyNlcnJvcnMKKyNkb2N1bWVudAorfCA8aHRtbD4KK3wgICA8aGVhZD4KK3wgICA8Ym9keT4K
K3wgICAgIDxkaXY+Cit8ICAgICAgIGJhcj0iWlrCo19pZD0yMyIKKworI2RhdGEKKzxkaXYgYmFy
PSJaWiZwcm9kO19pZD0yMyI+PC9kaXY+CisjZXJyb3JzCisjZG9jdW1lbnQKK3wgPGh0bWw+Cit8
ICAgPGhlYWQ+Cit8ICAgPGJvZHk+Cit8ICAgICA8ZGl2PgorfCAgICAgICBiYXI9Ilpa4oiPX2lk
PTIzIgorCisjZGF0YQorPGRpdiBiYXI9IlpaJnBvdW5kPTIzIj48L2Rpdj4KKyNlcnJvcnMKKyNk
b2N1bWVudAorfCA8aHRtbD4KK3wgICA8aGVhZD4KK3wgICA8Ym9keT4KK3wgICAgIDxkaXY+Cit8
ICAgICAgIGJhcj0iWlomcG91bmQ9MjMiCisKKyNkYXRhCis8ZGl2IGJhcj0iWlomcHJvZD0yMyI+
PC9kaXY+CisjZXJyb3JzCisjZG9jdW1lbnQKK3wgPGh0bWw+Cit8ICAgPGhlYWQ+Cit8ICAgPGJv
ZHk+Cit8ICAgICA8ZGl2PgorfCAgICAgICBiYXI9IlpaJnByb2Q9MjMiCisKKyNkYXRhCis8ZGl2
PlpaJnBvdW5kX2lkPTIzPC9kaXY+CisjZXJyb3JzCisjZG9jdW1lbnQKK3wgPGh0bWw+Cit8ICAg
PGhlYWQ+Cit8ICAgPGJvZHk+Cit8ICAgICA8ZGl2PgorfCAgICAgICAiWlrCo19pZD0yMyIKKwor
I2RhdGEKKzxkaXY+WlomcHJvZF9pZD0yMzwvZGl2PgorI2Vycm9ycworI2RvY3VtZW50Cit8IDxo
dG1sPgorfCAgIDxoZWFkPgorfCAgIDxib2R5PgorfCAgICAgPGRpdj4KK3wgICAgICAgIlpaJnBy
b2RfaWQ9MjMiCisKKyNkYXRhCis8ZGl2PlpaJnBvdW5kO19pZD0yMzwvZGl2PgorI2Vycm9ycwor
I2RvY3VtZW50Cit8IDxodG1sPgorfCAgIDxoZWFkPgorfCAgIDxib2R5PgorfCAgICAgPGRpdj4K
K3wgICAgICAgIlpawqNfaWQ9MjMiCisKKyNkYXRhCis8ZGl2PlpaJnByb2Q7X2lkPTIzPC9kaXY+
CisjZXJyb3JzCisjZG9jdW1lbnQKK3wgPGh0bWw+Cit8ICAgPGhlYWQ+Cit8ICAgPGJvZHk+Cit8
ICAgICA8ZGl2PgorfCAgICAgICAiWlriiI9faWQ9MjMiCisKKyNkYXRhCis8ZGl2PlpaJnBvdW5k
PTIzPC9kaXY+CisjZXJyb3JzCisjZG9jdW1lbnQKK3wgPGh0bWw+Cit8ICAgPGhlYWQ+Cit8ICAg
PGJvZHk+Cit8ICAgICA8ZGl2PgorfCAgICAgICAiWlrCoz0yMyIKKworI2RhdGEKKzxkaXY+Wlom
cHJvZD0yMzwvZGl2PgorI2Vycm9ycworI2RvY3VtZW50Cit8IDxodG1sPgorfCAgIDxoZWFkPgor
fCAgIDxib2R5PgorfCAgICAgPGRpdj4KK3wgICAgICAgIlpaJnByb2Q9MjMiCmRpZmYgLS1naXQg
YS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDNlNGNjMTQ2OGZk
MDdjNDc0OTljODQzNmUwOThmY2MxMGQ4YTlhMWYuLmIwZGRkNDc2ZmFlYmU5ZWFiOTJlZTFlNjg1
NjMyNWVkN2Y4ZTc1YTcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNv
cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMDYtMjkgIEFkYW0gQmFydGggIDxh
YmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICBQYXJhbWV0ZXIgbmFtZXMgaW4gZnJhbWUgc3JjIFVSTHMgcGFyc2VkIGluY29y
cmVjdGx5IGlmIHJlc2VtYmxlcyBIVE1MIGVudGl0eSBjb2RlIGZvbGxvd2VkIGJ5IHVuZGVyc2Nv
cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxMzQ1
CisKKyAgICAgICAgQXBwYXJlbnRseSB3aGV0aGVyIGFuIEhUTUwgZW50aXR5IHJlcXVpcmVzIGEg
dHJhaWxpbmcgc2VtaWNvbG9uIHZhcmllcworICAgICAgICBkZXBlbmRpbmcgb24gdGhlIGVudGl0
eS4gIFRoZSBmdWxsIHRhYmxlIGlzIGluIHRoZSBzcGVjOgorCisgICAgICAgIGh0dHA6Ly93d3cu
d2hhdHdnLm9yZy9zcGVjcy93ZWItYXBwcy9jdXJyZW50LXdvcmsvbXVsdGlwYWdlL25hbWVkLWNo
YXJhY3Rlci1yZWZlcmVuY2VzLmh0bWwjbmFtZWQtY2hhcmFjdGVyLXJlZmVyZW5jZXMKKworICAg
ICAgICBJIGJlbGlldmUgYnJhbmNoIGFkZGVkIGluIHRoaXMgcGF0Y2ggaXMgYWNjdXJhdGUuICBB
dCBzb21lIHBvaW50LCBJJ2xsCisgICAgICAgIGFkZCBhIGZ1bGwgdGVzdCBzdWl0ZSBmb3IgYWxs
IHRoZSBuYW1lZCBlbnRpdGllcy4KKworICAgICAgICAqIGh0bWwvSFRNTEVudGl0eVBhcnNlci5j
cHA6CisgICAgICAgIChXZWJDb3JlOjpjb25zdW1lSFRNTEVudGl0eSk6CisKIDIwMTAtMDYtMjkg
IEZyYW7Dp29pcyBTYXVzc2V0ICA8c2F1c3NldEBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3
ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvSFRNTEVudGl0eVBh
cnNlci5jcHAgYi9XZWJDb3JlL2h0bWwvSFRNTEVudGl0eVBhcnNlci5jcHAKaW5kZXggM2Q4ZDQ4
ZDAwN2I3NDVlYjgyMzU3MjM4Nzc1MDVhZjJhY2JkOWY2OC4uMzkwNTc3ZjI3N2UyNDEwYTQ4Yzkw
OWMzYjM1ZTNlMDhiYzc1NDFhYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL0hUTUxFbnRpdHlQ
YXJzZXIuY3BwCisrKyBiL1dlYkNvcmUvaHRtbC9IVE1MRW50aXR5UGFyc2VyLmNwcApAQCAtMjE3
LDYgKzIxNyw4IEBAIHVuc2lnbmVkIGNvbnN1bWVIVE1MRW50aXR5KFNlZ21lbnRlZFN0cmluZyYg
c291cmNlLCBib29sJiBub3RFbm91Z2hDaGFyYWN0ZXJzLCBVCiAgICAgICAgICAgICAgICAgICAg
ICAgICAvLyBpZiB0aGUgbG9va2hlYWQgY2hhcmFjdGVyIGlzICc9Jy4KICAgICAgICAgICAgICAg
ICAgICAgICAgIGlmIChhZGRpdGlvbmFsQWxsb3dlZENoYXJhY3RlciAmJiBjYyA9PSAnPScpCiAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICAgICAgICAgICAg
ICBpZiAoZW50aXR5LT5jb2RlID4gMjU1KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJy
ZWFrOwogICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGVudGl0eS0+Y29kZTsKICAgICAg
ICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgICAgICBicmVhazsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>60203</attachid>
            <date>2010-06-30 23:25:26 -0700</date>
            <delta_ts>2010-07-01 02:29:32 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-41345-20100630232524.patch</filename>
            <type>text/plain</type>
            <size>4703</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA2MjIyOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMjEgQEAKKzIwMTAtMDYtMzAgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y
Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQYXJh
bWV0ZXIgbmFtZXMgaW4gZnJhbWUgc3JjIFVSTHMgcGFyc2VkIGluY29ycmVjdGx5IGlmIHJlc2Vt
YmxlcyBIVE1MIGVudGl0eSBjb2RlIGZvbGxvd2VkIGJ5IHVuZGVyc2NvcmUKKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxMzQ1CisKKyAgICAgICAgQXBw
YXJlbnRseSB3aGV0aGVyIGFuIEhUTUwgZW50aXR5IHJlcXVpcmVzIGEgdHJhaWxpbmcgc2VtaWNv
bG9uIHZhcmllcworICAgICAgICBkZXBlbmRpbmcgb24gdGhlIGVudGl0eS4gIFRoZSBmdWxsIHRh
YmxlIGlzIGluIHRoZSBzcGVjOgorCisgICAgICAgIGh0dHA6Ly93d3cud2hhdHdnLm9yZy9zcGVj
cy93ZWItYXBwcy9jdXJyZW50LXdvcmsvbXVsdGlwYWdlL25hbWVkLWNoYXJhY3Rlci1yZWZlcmVu
Y2VzLmh0bWwjbmFtZWQtY2hhcmFjdGVyLXJlZmVyZW5jZXMKKworICAgICAgICBJIGJlbGlldmUg
YnJhbmNoIGFkZGVkIGluIHRoaXMgcGF0Y2ggaXMgYWNjdXJhdGUuICBBdCBzb21lIHBvaW50LCBJ
J2xsCisgICAgICAgIGFkZCBhIGZ1bGwgdGVzdCBzdWl0ZSBmb3IgYWxsIHRoZSBuYW1lZCBlbnRp
dGllcy4KKworICAgICAgICAqIGh0bWwvSFRNTEVudGl0eVBhcnNlci5jcHA6CisgICAgICAgIChX
ZWJDb3JlOjpjb25zdW1lSFRNTEVudGl0eSk6CisKIDIwMTAtMDYtMzAgIEFuZHJlYXMgS2xpbmcg
IDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRo
IFJvaGRlIENocmlzdGlhbnNlbi4KSW5kZXg6IFdlYkNvcmUvaHRtbC9IVE1MRW50aXR5UGFyc2Vy
LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvSFRNTEVudGl0eVBhcnNlci5jcHAJKHJl
dmlzaW9uIDYyMjI4KQorKysgV2ViQ29yZS9odG1sL0hUTUxFbnRpdHlQYXJzZXIuY3BwCSh3b3Jr
aW5nIGNvcHkpCkBAIC0yMTcsNiArMjE3LDE0IEBAIHVuc2lnbmVkIGNvbnN1bWVIVE1MRW50aXR5
KFNlZ21lbnRlZFN0cmkKICAgICAgICAgICAgICAgICAgICAgICAgIC8vIGlmIHRoZSBsb29raGVh
ZCBjaGFyYWN0ZXIgaXMgJz0nLgogICAgICAgICAgICAgICAgICAgICAgICAgaWYgKGFkZGl0aW9u
YWxBbGxvd2VkQ2hhcmFjdGVyICYmIGNjID09ICc9JykKICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBicmVhazsKKyAgICAgICAgICAgICAgICAgICAgICAgIC8vIFNvbWUgZW50aXRpZXMgcmVx
dWlyZSBhIHRlcm1pbmF0aW5nIHNlbWljb2xvbiwgd2hlcmVhcyBvdGhlcgorICAgICAgICAgICAg
ICAgICAgICAgICAgLy8gZW50aXRpZXMgZG8gbm90LiAgVGhlIEhUTUw1IHNwZWMgaGFzIGEgZ2lh
bnQgbGlzdDoKKyAgICAgICAgICAgICAgICAgICAgICAgIC8vCisgICAgICAgICAgICAgICAgICAg
ICAgICAvLyBodHRwOi8vd3d3LndoYXR3Zy5vcmcvc3BlY3Mvd2ViLWFwcHMvY3VycmVudC13b3Jr
L211bHRpcGFnZS9uYW1lZC1jaGFyYWN0ZXItcmVmZXJlbmNlcy5odG1sI25hbWVkLWNoYXJhY3Rl
ci1yZWZlcmVuY2VzCisgICAgICAgICAgICAgICAgICAgICAgICAvLworICAgICAgICAgICAgICAg
ICAgICAgICAgLy8gSG93ZXZlciwgdGhlIGxpc3Qgc2VlbXMgdG8gYm9pbCBkb3duIHRvIHRoaXMg
YnJhbmNoOgorICAgICAgICAgICAgICAgICAgICAgICAgaWYgKGVudGl0eS0+Y29kZSA+IDI1NSkK
KyAgICAgICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgICAgICAgICAg
ICAgIHJldHVybiBlbnRpdHktPmNvZGU7CiAgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAg
ICAgICAgICAgICAgYnJlYWs7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA2MjIyOCkKKysrIExheW91dFRl
c3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEwLTA2LTMw
ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGFyYW1ldGVyIG5hbWVzIGluIGZyYW1lIHNyYyBV
UkxzIHBhcnNlZCBpbmNvcnJlY3RseSBpZiByZXNlbWJsZXMgSFRNTCBlbnRpdHkgY29kZSBmb2xs
b3dlZCBieSB1bmRlcnNjb3JlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD00MTM0NQorCisgICAgICAgIEFkZCBzb21lIG1vcmUgSFRNTCBlbnRpdHkgdGVz
dCBjb3ZlcmFnZSBmb3Igd2hlbiB0aGUgdHJhaWxpbmcgc2VtaWNvbG9uCisgICAgICAgIGNoYXJh
Y3RlciBpcyByZXF1aXJlZC4KKworICAgICAgICAqIGh0bWw1bGliL3Jlc291cmNlcy9lbnRpdGll
czAyLmRhdDoKKwogMjAxMC0wNi0zMCAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAK
ICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6IExheW91dFRlc3RzL2h0bWw1
bGliL3Jlc291cmNlcy9lbnRpdGllczAyLmRhdAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9o
dG1sNWxpYi9yZXNvdXJjZXMvZW50aXRpZXMwMi5kYXQJKHJldmlzaW9uIDYyMjI4KQorKysgTGF5
b3V0VGVzdHMvaHRtbDVsaWIvcmVzb3VyY2VzL2VudGl0aWVzMDIuZGF0CSh3b3JraW5nIGNvcHkp
CkBAIC0xMjcsMyArMTI3LDEyMyBAQAogfCAgIDxib2R5PgogfCAgICAgPGRpdj4KIHwgICAgICAg
YmFyPSJaWj4iCisKKyNkYXRhCis8ZGl2IGJhcj0iWlomcG91bmRfaWQ9MjMiPjwvZGl2PgorI2Vy
cm9ycworI2RvY3VtZW50Cit8IDxodG1sPgorfCAgIDxoZWFkPgorfCAgIDxib2R5PgorfCAgICAg
PGRpdj4KK3wgICAgICAgYmFyPSJaWsKjX2lkPTIzIgorCisjZGF0YQorPGRpdiBiYXI9IlpaJnBy
b2RfaWQ9MjMiPjwvZGl2PgorI2Vycm9ycworI2RvY3VtZW50Cit8IDxodG1sPgorfCAgIDxoZWFk
PgorfCAgIDxib2R5PgorfCAgICAgPGRpdj4KK3wgICAgICAgYmFyPSJaWiZwcm9kX2lkPTIzIgor
CisjZGF0YQorPGRpdiBiYXI9IlpaJnBvdW5kO19pZD0yMyI+PC9kaXY+CisjZXJyb3JzCisjZG9j
dW1lbnQKK3wgPGh0bWw+Cit8ICAgPGhlYWQ+Cit8ICAgPGJvZHk+Cit8ICAgICA8ZGl2PgorfCAg
ICAgICBiYXI9IlpawqNfaWQ9MjMiCisKKyNkYXRhCis8ZGl2IGJhcj0iWlomcHJvZDtfaWQ9MjMi
PjwvZGl2PgorI2Vycm9ycworI2RvY3VtZW50Cit8IDxodG1sPgorfCAgIDxoZWFkPgorfCAgIDxi
b2R5PgorfCAgICAgPGRpdj4KK3wgICAgICAgYmFyPSJaWuKIj19pZD0yMyIKKworI2RhdGEKKzxk
aXYgYmFyPSJaWiZwb3VuZD0yMyI+PC9kaXY+CisjZXJyb3JzCisjZG9jdW1lbnQKK3wgPGh0bWw+
Cit8ICAgPGhlYWQ+Cit8ICAgPGJvZHk+Cit8ICAgICA8ZGl2PgorfCAgICAgICBiYXI9IlpaJnBv
dW5kPTIzIgorCisjZGF0YQorPGRpdiBiYXI9IlpaJnByb2Q9MjMiPjwvZGl2PgorI2Vycm9ycwor
I2RvY3VtZW50Cit8IDxodG1sPgorfCAgIDxoZWFkPgorfCAgIDxib2R5PgorfCAgICAgPGRpdj4K
K3wgICAgICAgYmFyPSJaWiZwcm9kPTIzIgorCisjZGF0YQorPGRpdj5aWiZwb3VuZF9pZD0yMzwv
ZGl2PgorI2Vycm9ycworI2RvY3VtZW50Cit8IDxodG1sPgorfCAgIDxoZWFkPgorfCAgIDxib2R5
PgorfCAgICAgPGRpdj4KK3wgICAgICAgIlpawqNfaWQ9MjMiCisKKyNkYXRhCis8ZGl2PlpaJnBy
b2RfaWQ9MjM8L2Rpdj4KKyNlcnJvcnMKKyNkb2N1bWVudAorfCA8aHRtbD4KK3wgICA8aGVhZD4K
K3wgICA8Ym9keT4KK3wgICAgIDxkaXY+Cit8ICAgICAgICJaWiZwcm9kX2lkPTIzIgorCisjZGF0
YQorPGRpdj5aWiZwb3VuZDtfaWQ9MjM8L2Rpdj4KKyNlcnJvcnMKKyNkb2N1bWVudAorfCA8aHRt
bD4KK3wgICA8aGVhZD4KK3wgICA8Ym9keT4KK3wgICAgIDxkaXY+Cit8ICAgICAgICJaWsKjX2lk
PTIzIgorCisjZGF0YQorPGRpdj5aWiZwcm9kO19pZD0yMzwvZGl2PgorI2Vycm9ycworI2RvY3Vt
ZW50Cit8IDxodG1sPgorfCAgIDxoZWFkPgorfCAgIDxib2R5PgorfCAgICAgPGRpdj4KK3wgICAg
ICAgIlpa4oiPX2lkPTIzIgorCisjZGF0YQorPGRpdj5aWiZwb3VuZD0yMzwvZGl2PgorI2Vycm9y
cworI2RvY3VtZW50Cit8IDxodG1sPgorfCAgIDxoZWFkPgorfCAgIDxib2R5PgorfCAgICAgPGRp
dj4KK3wgICAgICAgIlpawqM9MjMiCisKKyNkYXRhCis8ZGl2PlpaJnByb2Q9MjM8L2Rpdj4KKyNl
cnJvcnMKKyNkb2N1bWVudAorfCA8aHRtbD4KK3wgICA8aGVhZD4KK3wgICA8Ym9keT4KK3wgICAg
IDxkaXY+Cit8ICAgICAgICJaWiZwcm9kPTIzIgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>