41187 2010-06-24 17:39:07 -0700 REGRESSION(HTML 5): HTMLDocumentParser does not report html parse errors to the console 2011-02-09 13:54:21 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P1 Major --- 41060 41115 1 eric abarth abarth ap commit-queue darin dglazkov hyatt pfeldman tonyg webkit.review.bot yurys oldest_to_newest 242763 0 eric 2010-06-24 17:39:07 -0700 HTML 5 Parser does not report html parse errors to the console This is due to LegacyHTMLTreeBuilder::reportErrorToConsole only working with the LegacyHTMLDocumentParser. 271615 1 eric 2010-08-30 13:54:02 -0700 I think I'll work on this today. 271662 2 eric 2010-08-30 14:56:14 -0700 I'm not sure how to test this. It appears there are no existing tests for this functionality and I'm not sure how to retrieve the HTML parser errors from the console object in a layout test. 345984 3 abarth 2011-02-04 18:24:00 -0800 We could test this in a layout test by piping these messages to STDOUT, like we do for console.log. 346482 4 yurys 2011-02-06 23:16:33 -0800 (In reply to comment #3) > We could test this in a layout test by piping these messages to STDOUT, like we do for console.log. Currently JavaScript errors are printed to STDOUT. If we decide to print all parser errors to STDOUT it would require rebaselining tons of html tests to include the error messages I'm not sure that we want to clutter expectations with the parser errors. 346485 5 abarth 2011-02-06 23:24:18 -0800 Remove the reporting didn't require rebaselining any tests, so somewhere there much be a branch... 346486 6 yurys 2011-02-06 23:30:53 -0800 (In reply to comment #5) > Remove the reporting didn't require rebaselining any tests Which probably means there were no tests for the parser errors. 347183 7 81603 abarth 2011-02-07 23:45:34 -0800 Created attachment 81603 Patch 347185 8 81603 eric 2011-02-07 23:47:36 -0800 Comment on attachment 81603 Patch Wonderful. :) Now how do we test this? 347187 9 webkit.review.bot 2011-02-07 23:48:54 -0800 Attachment 81603 did not build on chromium: Build output: http://queues.webkit.org/results/7863002 347190 10 abarth 2011-02-07 23:51:54 -0800 > Attachment 81603 [details] did not build on chromium: > Build output: http://queues.webkit.org/results/7863002 This bug crops up a lot. Some header is missing DOMWindow.h 347194 11 eric 2011-02-07 23:56:39 -0800 The ChromeClient is called back with every error. So I suspect some code in DumpRenderTree sees all these. Would be nice to enable certain ones via layoutTestController. Or better yet, to turn on recording and be able to grab them all later with layoutTestController.consoleMessages() or something. If it's not possible to test this, you shoudl just say so in the ChangeLog and file a bug about how to fix that. 347201 12 abarth 2011-02-08 00:03:03 -0800 I'm sure it's possible to test by hacking up DumpRenderTree. 347253 13 webkit.review.bot 2011-02-08 02:52:23 -0800 Attachment 81603 did not build on chromium: Build output: http://queues.webkit.org/results/7829038 347755 14 81603 eric 2011-02-08 15:51:11 -0800 Comment on attachment 81603 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81603&action=review This is obviously very primitive. I'm OK with approving this patch, but we absolutely need testing. The whole reason why this support got removed during the re-write is that whoever added the original error messages added *no* testing. Thus although we knew we were removing it, it was never a critical issue and only ever got really noticed 9 months after its removal! Please file a bug about testing this and link to it from the ChangeLog. Looks like this might break Chromium too. Not sure why. > Source/WebCore/ChangeLog:11 > + * html/parser/HTMLDocumentParser.h: Would be nice to mention here what you're doing (moving private to public) since you can't easily see that from the diff. > Source/WebCore/html/parser/HTMLTreeBuilder.cpp:2810 > +void HTMLTreeBuilder::parseError(AtomicHTMLToken&) Why not use the line/column information from the Token? 347760 15 81603 eric 2011-02-08 15:53:25 -0800 Comment on attachment 81603 Patch It seems we want to be passing Tokens to the error reporting instead of AtomicHTMLTokens. 347762 16 darin 2011-02-08 15:53:38 -0800 (In reply to comment #14) > whoever added the original error messages Hyatt 347774 17 eric 2011-02-08 16:03:04 -0800 Might mention in your message that this is a treebuilder error. Since we also have HTMLTokenizer::parseError() which could also report errors in this similarly simple manner. 348466 18 abarth 2011-02-09 12:30:33 -0800 > It seems we want to be passing Tokens to the error reporting instead of AtomicHTMLTokens. The problem is the synthetic tokens are AtomicHTMLTokens. Maybe we should cache the current HTMLToken on the tree builder somewhere? The benefit of using an HTMLToken is that we can get column information and/or source for the token. I'm going to land this as-is. We can iterate to improve. 348467 19 81852 abarth 2011-02-09 12:32:05 -0800 Created attachment 81852 Patch for landing 348537 20 81852 commit-queue 2011-02-09 13:54:16 -0800 Comment on attachment 81852 Patch for landing Clearing flags on attachment: 81852 Committed r78127: <http://trac.webkit.org/changeset/78127> 348538 21 commit-queue 2011-02-09 13:54:21 -0800 All reviewed patches have been landed. Closing bug. 81603 2011-02-07 23:45:34 -0800 2011-02-09 12:32:01 -0800 Patch bug-41187-20110207234533.patch text/plain 3318 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogNzc4OTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2NTAzMjcyMjM2NGI3MWIx M2MxZjUzZTQ0MDgyODJmNDEwMzkxNDNjLi40YTI3ZThjN2U3MzUwOWY0YjY3ZDFhYjUyNDM0Nzk1 OGIzNTYzYmYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDItMDcgIEFkYW0g QmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBSRUdSRVNTSU9OKEhUTUwgNSk6IEhUTUxEb2N1bWVudFBhcnNl ciBkb2VzIG5vdCByZXBvcnQgaHRtbCBwYXJzZSBlcnJvcnMgdG8gdGhlIGNvbnNvbGUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxMTg3CisKKyAgICAg ICAgV2lyZSB1cCBhIGJhc2ljIEhUTUwgcGFyc2UgZXJyb3IgbWVzc2FnZS4gIFRoZXJlJ3MgYSBs b3Qgb2Ygcm9vbSBmb3IKKyAgICAgICAgaW1wcm92ZW1lbnQgaW4gdGhpcyBhcmVhLCBidXQgdGhp cyBpcyBhIHN0YXJ0LgorCisgICAgICAgICogaHRtbC9wYXJzZXIvSFRNTERvY3VtZW50UGFyc2Vy Lmg6CisgICAgICAgICogaHRtbC9wYXJzZXIvSFRNTFRyZWVCdWlsZGVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkhUTUxUcmVlQnVpbGRlcjo6cGFyc2VFcnJvcik6CisgICAgICAgICogaHRtbC9w YXJzZXIvSFRNTFRyZWVCdWlsZGVyLmg6CisKIDIwMTEtMDItMDcgIFBhdHJpY2sgR2Fuc3RlcmVy ICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MRG9jdW1lbnRQYXJz ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxEb2N1bWVudFBhcnNlci5oCmlu ZGV4IGU5N2MxYjNlZjc0NzNkZjM2ZThiODI3ZjE3NDA2NjJlODNmYzI4ZTIuLmJlMmNhMWJhMjc5 ZGQwMzBiNmU4YWU4ZjU3MDVkMGNiYzk0NmFlNTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvcGFyc2VyL0hUTUxEb2N1bWVudFBhcnNlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvcGFyc2VyL0hUTUxEb2N1bWVudFBhcnNlci5oCkBAIC03Niw2ICs3Niw4IEBAIHB1YmxpYzoK ICAgICBTdHJpbmcgc291cmNlRm9yVG9rZW4oY29uc3QgSFRNTFRva2VuJik7CiAKICAgICB2aXJ0 dWFsIFRleHRQb3NpdGlvbjAgdGV4dFBvc2l0aW9uKCkgY29uc3Q7CisgICAgdmlydHVhbCBpbnQg bGluZU51bWJlcigpIGNvbnN0OworCiAgICAgdmlydHVhbCB2b2lkIHN1c3BlbmRTY2hlZHVsZWRU YXNrcygpOwogICAgIHZpcnR1YWwgdm9pZCByZXN1bWVTY2hlZHVsZWRUYXNrcygpOwogCkBAIC0x MDAsNyArMTAyLDYgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIGJvb2wgaXNXYWl0aW5nRm9yU2Ny aXB0cygpIGNvbnN0OwogICAgIHZpcnR1YWwgYm9vbCBpc0V4ZWN1dGluZ1NjcmlwdCgpIGNvbnN0 OwogICAgIHZpcnR1YWwgdm9pZCBleGVjdXRlU2NyaXB0c1dhaXRpbmdGb3JTdHlsZXNoZWV0cygp OwotICAgIHZpcnR1YWwgaW50IGxpbmVOdW1iZXIoKSBjb25zdDsKIAogICAgIC8vIEhUTUxTY3Jp cHRSdW5uZXJIb3N0CiAgICAgdmlydHVhbCB2b2lkIHdhdGNoRm9yTG9hZChDYWNoZWRSZXNvdXJj ZSopOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFRyZWVCdWls ZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxUcmVlQnVpbGRlci5jcHAK aW5kZXggZGQ5OWY4MDNlNjM5NzhmMTQxNTlhMTk1YTRmMjhkYTU5NzQwOWUxMS4uNmQyN2VhNDZk MDU5MjlkMWUzMmQ1MjA1YTNkODg5ODUzNTQ0OTMzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaHRtbC9wYXJzZXIvSFRNTFRyZWVCdWlsZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxkZXIuY3BwCkBAIC0yODA3LDYgKzI4MDcsMjAgQEAgdm9p ZCBIVE1MVHJlZUJ1aWxkZXI6OmZpbmlzaGVkKCkKICAgICBtX2RvY3VtZW50LT5maW5pc2hlZFBh cnNpbmcoKTsKIH0KIAordm9pZCBIVE1MVHJlZUJ1aWxkZXI6OnBhcnNlRXJyb3IoQXRvbWljSFRN TFRva2VuJikKK3sKKyAgICBERUZJTkVfU1RBVElDX0xPQ0FMKFN0cmluZywgcGFyc2VFcnJvck1l c3NhZ2UsICgiSFRNTCBwYXJzZSBlcnJvciAocmVjb3ZlcmVkIGdyYWNlZnVsbHkpIikpOworCisg ICAgaWYgKCFtX3JlcG9ydEVycm9ycykKKyAgICAgICAgcmV0dXJuOworCisgICAgRE9NV2luZG93 KiBkb21XaW5kb3cgPSBtX2RvY3VtZW50LT5kb21XaW5kb3coKTsKKyAgICBpZiAoIWRvbVdpbmRv dykKKyAgICAgICAgcmV0dXJuOworCisgICAgZG9tV2luZG93LT5jb25zb2xlKCktPmFkZE1lc3Nh Z2UoSFRNTE1lc3NhZ2VTb3VyY2UsIExvZ01lc3NhZ2VUeXBlLCBXYXJuaW5nTWVzc2FnZUxldmVs LCBwYXJzZUVycm9yTWVzc2FnZSwgbV9wYXJzZXItPmxpbmVOdW1iZXIoKSwgbV9kb2N1bWVudC0+ dXJsKCkuc3RyaW5nKCkpOworfQorCiBib29sIEhUTUxUcmVlQnVpbGRlcjo6c2NyaXB0RW5hYmxl ZChGcmFtZSogZnJhbWUpCiB7CiAgICAgaWYgKCFmcmFtZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxUcmVlQnVpbGRlci5oIGIvU291cmNlL1dlYkNvcmUvaHRt bC9wYXJzZXIvSFRNTFRyZWVCdWlsZGVyLmgKaW5kZXggMzA5YWM2ZjQzYjA2MWYzYzBlZGNhNzcx MDhhMGFiNTNlY2QzNTJkZC4uMmFmYWM5MmEwYmJhZWE0NGM1YTE5NjJmYmNmMWM4N2Q1NjJhNzhj YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFRyZWVCdWlsZGVy LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFRyZWVCdWlsZGVyLmgKQEAg LTE4Myw4ICsxODMsNyBAQCBwcml2YXRlOgogCiAgICAgYm9vbCBtX2ZyYW1lc2V0T2s7CiAKLSAg ICAvLyBGSVhNRTogSW1wbGVtZW50IGVycm9yIHJlcG9ydGluZy4KLSAgICB2b2lkIHBhcnNlRXJy b3IoQXRvbWljSFRNTFRva2VuJikgeyB9CisgICAgdm9pZCBwYXJzZUVycm9yKEF0b21pY0hUTUxU b2tlbiYpOwogCiAgICAgSW5zZXJ0aW9uTW9kZSBpbnNlcnRpb25Nb2RlKCkgY29uc3QgeyByZXR1 cm4gbV9pbnNlcnRpb25Nb2RlOyB9CiAgICAgdm9pZCBzZXRJbnNlcnRpb25Nb2RlKEluc2VydGlv bk1vZGUgbW9kZSkK 81852 2011-02-09 12:32:05 -0800 2011-02-09 13:54:16 -0800 Patch for landing bug-41187-20110209123204.patch text/plain 3341 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4MTA4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDItMDkgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRl bC4KKworICAgICAgICBSRUdSRVNTSU9OKEhUTUwgNSk6IEhUTUxEb2N1bWVudFBhcnNlciBkb2Vz IG5vdCByZXBvcnQgaHRtbCBwYXJzZSBlcnJvcnMgdG8gdGhlIGNvbnNvbGUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQxMTg3CisKKyAgICAgICAgV2ly ZSB1cCBhIGJhc2ljIEhUTUwgcGFyc2UgZXJyb3IgbWVzc2FnZS4gIFRoZXJlJ3MgYSBsb3Qgb2Yg cm9vbSBmb3IKKyAgICAgICAgaW1wcm92ZW1lbnQgaW4gdGhpcyBhcmVhLCBidXQgdGhpcyBpcyBh IHN0YXJ0LgorCisgICAgICAgIE5vIHRlc3RzISAgU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01NDEzNAorCisgICAgICAgICogaHRtbC9wYXJzZXIvSFRNTERvY3Vt ZW50UGFyc2VyLmg6CisgICAgICAgICogaHRtbC9wYXJzZXIvSFRNTFRyZWVCdWlsZGVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkhUTUxUcmVlQnVpbGRlcjo6cGFyc2VFcnJvcik6CisgICAgICAg ICogaHRtbC9wYXJzZXIvSFRNTFRyZWVCdWlsZGVyLmg6CisKIDIwMTEtMDItMDkgIE5hb2tpIFRh a2FubyAgPHRha2Fuby5uYW9raUBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2Vu bmV0aCBSdXNzZWxsLgpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTERvY3Vt ZW50UGFyc2VyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRN TERvY3VtZW50UGFyc2VyLmgJKHJldmlzaW9uIDc4MTA4KQorKysgU291cmNlL1dlYkNvcmUvaHRt bC9wYXJzZXIvSFRNTERvY3VtZW50UGFyc2VyLmgJKHdvcmtpbmcgY29weSkKQEAgLTc2LDYgKzc2 LDggQEAgcHVibGljOgogICAgIFN0cmluZyBzb3VyY2VGb3JUb2tlbihjb25zdCBIVE1MVG9rZW4m KTsKIAogICAgIHZpcnR1YWwgVGV4dFBvc2l0aW9uMCB0ZXh0UG9zaXRpb24oKSBjb25zdDsKKyAg ICB2aXJ0dWFsIGludCBsaW5lTnVtYmVyKCkgY29uc3Q7CisKICAgICB2aXJ0dWFsIHZvaWQgc3Vz cGVuZFNjaGVkdWxlZFRhc2tzKCk7CiAgICAgdmlydHVhbCB2b2lkIHJlc3VtZVNjaGVkdWxlZFRh c2tzKCk7CiAKQEAgLTEwMCw3ICsxMDIsNiBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgYm9vbCBp c1dhaXRpbmdGb3JTY3JpcHRzKCkgY29uc3Q7CiAgICAgdmlydHVhbCBib29sIGlzRXhlY3V0aW5n U2NyaXB0KCkgY29uc3Q7CiAgICAgdmlydHVhbCB2b2lkIGV4ZWN1dGVTY3JpcHRzV2FpdGluZ0Zv clN0eWxlc2hlZXRzKCk7Ci0gICAgdmlydHVhbCBpbnQgbGluZU51bWJlcigpIGNvbnN0OwogCiAg ICAgLy8gSFRNTFNjcmlwdFJ1bm5lckhvc3QKICAgICB2aXJ0dWFsIHZvaWQgd2F0Y2hGb3JMb2Fk KENhY2hlZFJlc291cmNlKik7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1M VHJlZUJ1aWxkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2Vy L0hUTUxUcmVlQnVpbGRlci5jcHAJKHJldmlzaW9uIDc4MTA4KQorKysgU291cmNlL1dlYkNvcmUv aHRtbC9wYXJzZXIvSFRNTFRyZWVCdWlsZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjcsNiAr MjcsNyBAQAogI2luY2x1ZGUgIkhUTUxUcmVlQnVpbGRlci5oIgogCiAjaW5jbHVkZSAiQ29tbWVu dC5oIgorI2luY2x1ZGUgIkRPTVdpbmRvdy5oIgogI2luY2x1ZGUgIkRvY3VtZW50RnJhZ21lbnQu aCIKICNpbmNsdWRlICJEb2N1bWVudFR5cGUuaCIKICNpbmNsdWRlICJGcmFtZS5oIgpAQCAtMjgw Nyw2ICsyODA4LDIwIEBAIHZvaWQgSFRNTFRyZWVCdWlsZGVyOjpmaW5pc2hlZCgpCiAgICAgbV9k b2N1bWVudC0+ZmluaXNoZWRQYXJzaW5nKCk7CiB9CiAKK3ZvaWQgSFRNTFRyZWVCdWlsZGVyOjpw YXJzZUVycm9yKEF0b21pY0hUTUxUb2tlbiYpCit7CisgICAgREVGSU5FX1NUQVRJQ19MT0NBTChT dHJpbmcsIHBhcnNlRXJyb3JNZXNzYWdlLCAoIkhUTUwgcGFyc2UgZXJyb3IgKHJlY292ZXJlZCBn cmFjZWZ1bGx5KSIpKTsKKworICAgIGlmICghbV9yZXBvcnRFcnJvcnMpCisgICAgICAgIHJldHVy bjsKKworICAgIERPTVdpbmRvdyogZG9tV2luZG93ID0gbV9kb2N1bWVudC0+ZG9tV2luZG93KCk7 CisgICAgaWYgKCFkb21XaW5kb3cpCisgICAgICAgIHJldHVybjsKKworICAgIGRvbVdpbmRvdy0+ Y29uc29sZSgpLT5hZGRNZXNzYWdlKEhUTUxNZXNzYWdlU291cmNlLCBMb2dNZXNzYWdlVHlwZSwg V2FybmluZ01lc3NhZ2VMZXZlbCwgcGFyc2VFcnJvck1lc3NhZ2UsIG1fcGFyc2VyLT5saW5lTnVt YmVyKCksIG1fZG9jdW1lbnQtPnVybCgpLnN0cmluZygpKTsKK30KKwogYm9vbCBIVE1MVHJlZUJ1 aWxkZXI6OnNjcmlwdEVuYWJsZWQoRnJhbWUqIGZyYW1lKQogewogICAgIGlmICghZnJhbWUpCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxkZXIuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxkZXIuaAkocmV2 aXNpb24gNzgxMDgpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxk ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMTgzLDggKzE4Myw3IEBAIHByaXZhdGU6CiAKICAgICBi b29sIG1fZnJhbWVzZXRPazsKIAotICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQgZXJyb3IgcmVwb3J0 aW5nLgotICAgIHZvaWQgcGFyc2VFcnJvcihBdG9taWNIVE1MVG9rZW4mKSB7IH0KKyAgICB2b2lk IHBhcnNlRXJyb3IoQXRvbWljSFRNTFRva2VuJik7CiAKICAgICBJbnNlcnRpb25Nb2RlIGluc2Vy dGlvbk1vZGUoKSBjb25zdCB7IHJldHVybiBtX2luc2VydGlvbk1vZGU7IH0KICAgICB2b2lkIHNl dEluc2VydGlvbk1vZGUoSW5zZXJ0aW9uTW9kZSBtb2RlKQo=