41119 2010-06-23 18:04:34 -0700 Code generator now generates jsString instead of toJS for callbacks 2010-06-25 20:40:23 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 39905 0 sswigart webkit-unassigned commit-queue dumi levin oldest_to_newest 242205 0 59591 sswigart 2010-06-23 18:04:34 -0700 Created attachment 59591 toJS -> jsString Callback code generation before generated toJS for String parameters, which cannot convert a String to DOMString. The generated file would not build. 242214 1 59591 dumi 2010-06-23 18:12:05 -0700 Comment on attachment 59591 toJS -> jsString LGTM, thanks for noticing the bug and fixing it! Will cq+ once all bots go green. 242579 2 59672 sswigart 2010-06-24 10:35:28 -0700 Created attachment 59672 Fixes callback parameter generation 243315 3 59672 commit-queue 2010-06-25 20:40:19 -0700 Comment on attachment 59672 Fixes callback parameter generation Clearing flags on attachment: 59672 Committed r61937: <http://trac.webkit.org/changeset/61937> 243316 4 commit-queue 2010-06-25 20:40:23 -0700 All reviewed patches have been landed. Closing bug. 59591 2010-06-23 18:04:34 -0700 2010-06-24 10:35:28 -0700 toJS -> jsString code-generator-patch text/plain 1498 sswigart ZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0g Yi9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCmluZGV4IDRlMmU5 MTEuLjlkODBjODMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9ySlMucG0KKysrIGIvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JK Uy5wbQpAQCAtMjE3OSw3ICsyMTc5LDExIEBAIHN1YiBHZW5lcmF0ZUNhbGxiYWNrSW1wbGVtZW50 YXRpb24KIAogICAgICAgICAgICAgZm9yZWFjaCBteSAkcGFyYW0gKEBwYXJhbXMpIHsKICAgICAg ICAgICAgICAgICBteSAkcGFyYW1OYW1lID0gJHBhcmFtLT5uYW1lOwotICAgICAgICAgICAgICAg IHB1c2goQGltcGxDb250ZW50LCAiICAgIGFyZ3MuYXBwZW5kKHRvSlMoZXhlYywgJHtwYXJhbU5h bWV9KSk7XG4iKTsKKyAgICAgICAgICAgICAgICBpZiAoJHBhcmFtLT50eXBlIGVxICJET01TdHJp bmciKSB7CisgICAgICAgICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgIGFyZ3Mu YXBwZW5kKGpzU3RyaW5nKGV4ZWMsICR7cGFyYW1OYW1lfSkpO1xuIik7CisgICAgICAgICAgICAg ICAgfSBlbHNlIHsKKyAgICAgICAgICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAg YXJncy5hcHBlbmQodG9KUyhleGVjLCAke3BhcmFtTmFtZX0pKTtcbiIpOworICAgICAgICAgICAg ICAgIH0KICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICJc biAgICBib29sIHJhaXNlZEV4Y2VwdGlvbiA9IGZhbHNlO1xuIik7CmRpZmYgLS1naXQgYS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RDYWxsYmFjay5jcHAgYi9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RDYWxsYmFjay5jcHAKaW5kZXggZGY0MDNj Ni4uMDQzYTZlZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMv SlNUZXN0Q2FsbGJhY2suY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pT L0pTVGVzdENhbGxiYWNrLmNwcApAQCAtODksNyArODksNyBAQCBib29sIEpTVGVzdENhbGxiYWNr OjpjYWxsYmFja1dpdGhDbGFzczJQYXJhbShTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0 LCBDbAogICAgIEV4ZWNTdGF0ZSogZXhlYyA9IGdsb2JhbE9iamVjdC0+Z2xvYmFsRXhlYygpOwog ICAgIE1hcmtlZEFyZ3VtZW50QnVmZmVyIGFyZ3M7CiAgICAgYXJncy5hcHBlbmQodG9KUyhleGVj LCBjbGFzczJQYXJhbSkpOwotICAgIGFyZ3MuYXBwZW5kKHRvSlMoZXhlYywgc3RyQXJnKSk7Cisg ICAgYXJncy5hcHBlbmQoanNTdHJpbmcoZXhlYywgc3RyQXJnKSk7CiAKICAgICBib29sIHJhaXNl ZEV4Y2VwdGlvbiA9IGZhbHNlOwogICAgIG1fZGF0YS0+aW52b2tlQ2FsbGJhY2soYXJncywgJnJh aXNlZEV4Y2VwdGlvbik7Cg== 59672 2010-06-24 10:35:28 -0700 2010-06-25 20:40:19 -0700 Fixes callback parameter generation code-generator-patch text/plain 2328 sswigart ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDBhODVlNC4uMjZlZjIyZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNi0yNCAgU3RlcmxpbmcgU3dp Z2FydCAgPHNzd2lnYXJ0QGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ2FsbGJhY2sgY29kZSBnZW5lcmF0aW9uIGZpeGVkIHNvIHRo YXQgbm93IHN0cmluZyBwYXJhbWV0ZXJzIGFyZSBjb252ZXJ0ZWQgdG8gSlNTdHJpbmcKKyAgICAg ICAgdXNpbmcgdGhlIGpzU3RyaW5nIG1ldGhvZCBpbnN0ZWFkIG9mIHRoZSB0b0pTIG1ldGhvZCB3 aGljaCB3b3VsZCBub3QgY29tcGlsZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQxMTE5CisgICAgICAgIAorICAgICAgICAqIGJpbmRpbmdzL3Njcmlw dHMvQ29kZUdlbmVyYXRvckpTLnBtOiBOb3cgZ2VuZXJhdGVzIGpzU3RyaW5nIGZvciBTdHJpbmcg cGFyYW1ldGVycyBpbiBjYWxsYmFja3MuCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0 L0pTL0pTVGVzdENhbGxiYWNrLmNwcDogRml4ZWQgdGVzdCBmb3IgYWJvdmUuCisgICAgICAgIChX ZWJDb3JlOjpKU1Rlc3RDYWxsYmFjazo6Y2FsbGJhY2tXaXRoQ2xhc3MyUGFyYW0pOiBEaXR0by4K KwogMjAxMC0wNi0yMyAgS3dhbmcgWXVsIFNlbyAgPHNreXVsQGNvbXBhbnkxMDAubmV0PgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEtlbnQgVGFtdXJhLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbSBiL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9Db2RlR2VuZXJhdG9ySlMucG0KaW5kZXggNGUyZTkxMS4uOWQ4MGM4MyAxMDA2NDQKLS0tIGEv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQorKysgYi9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCkBAIC0yMTc5LDcgKzIxNzksMTEg QEAgc3ViIEdlbmVyYXRlQ2FsbGJhY2tJbXBsZW1lbnRhdGlvbgogCiAgICAgICAgICAgICBmb3Jl YWNoIG15ICRwYXJhbSAoQHBhcmFtcykgewogICAgICAgICAgICAgICAgIG15ICRwYXJhbU5hbWUg PSAkcGFyYW0tPm5hbWU7Ci0gICAgICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAg YXJncy5hcHBlbmQodG9KUyhleGVjLCAke3BhcmFtTmFtZX0pKTtcbiIpOworICAgICAgICAgICAg ICAgIGlmICgkcGFyYW0tPnR5cGUgZXEgIkRPTVN0cmluZyIpIHsKKyAgICAgICAgICAgICAgICAg ICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAgYXJncy5hcHBlbmQoanNTdHJpbmcoZXhlYywgJHtw YXJhbU5hbWV9KSk7XG4iKTsKKyAgICAgICAgICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAg ICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIiAgICBhcmdzLmFwcGVuZCh0b0pTKGV4ZWMsICR7 cGFyYW1OYW1lfSkpO1xuIik7CisgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgfQogCiAg ICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIlxuICAgIGJvb2wgcmFpc2VkRXhjZXB0aW9u ID0gZmFsc2U7XG4iKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0 L0pTL0pTVGVzdENhbGxiYWNrLmNwcCBiL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pT L0pTVGVzdENhbGxiYWNrLmNwcAppbmRleCBkZjQwM2M2Li4wNDNhNmVkIDEwMDY0NAotLS0gYS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RDYWxsYmFjay5jcHAKKysrIGIv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0Q2FsbGJhY2suY3BwCkBAIC04 OSw3ICs4OSw3IEBAIGJvb2wgSlNUZXN0Q2FsbGJhY2s6OmNhbGxiYWNrV2l0aENsYXNzMlBhcmFt KFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQsIENsCiAgICAgRXhlY1N0YXRlKiBleGVj ID0gZ2xvYmFsT2JqZWN0LT5nbG9iYWxFeGVjKCk7CiAgICAgTWFya2VkQXJndW1lbnRCdWZmZXIg YXJnczsKICAgICBhcmdzLmFwcGVuZCh0b0pTKGV4ZWMsIGNsYXNzMlBhcmFtKSk7Ci0gICAgYXJn cy5hcHBlbmQodG9KUyhleGVjLCBzdHJBcmcpKTsKKyAgICBhcmdzLmFwcGVuZChqc1N0cmluZyhl eGVjLCBzdHJBcmcpKTsKIAogICAgIGJvb2wgcmFpc2VkRXhjZXB0aW9uID0gZmFsc2U7CiAgICAg bV9kYXRhLT5pbnZva2VDYWxsYmFjayhhcmdzLCAmcmFpc2VkRXhjZXB0aW9uKTsK