40846 2010-06-18 11:01:14 -0700 [Qt] GraphicsLayerQt delay seems unnecessary. 2011-04-18 19:48:40 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 CLOSED FIXED Qt, QtTriaged P2 Normal --- 38744 0 smagnuso webkit-unassigned commit-queue hausmann kevin.simons noam oldest_to_newest 240039 0 smagnuso 2010-06-18 11:01:14 -0700 I had noticed that if I had a delay in my animation it would get offset strangely. Further investigation makes me believe that the animation takes care of firing after the delay on its own and GraphicsLayerQt.cpp doesn't need to delay the animation's start. Is there a test case that shows its required? The attached test case seems to indicate otherwise. 240043 1 59137 smagnuso 2010-06-18 11:15:00 -0700 Created attachment 59137 Proposed patch (with testcase) 240046 2 smagnuso 2010-06-18 11:15:43 -0700 To actually use that testcase I will need bug #40841 to be applied as well as the items will remain transparent (and the timing won't be seen) 240233 3 noam 2010-06-18 17:40:40 -0700 Can you make sure it works with LayoutTests/animations/fill-mode-transform.html? It's an existing test case that has delay and uses AC. 240758 4 smagnuso 2010-06-21 09:59:58 -0700 (In reply to comment #3) > Can you make sure it works with LayoutTests/animations/fill-mode-transform.html? > It's an existing test case that has delay and uses AC. Thanks for the pointer to that test, however, it fails to pass. When I take out my change it continues to fail in the same way - so I'm not thinking my change is causing the failure. Has this test passed completely before? 240773 5 noam 2010-06-21 10:42:53 -0700 As long as your change doesn't create a regression wrt delays, I have no problems with it. I'll look further into that test, I think it's unstable. 240776 6 smagnuso 2010-06-21 10:53:05 -0700 (In reply to comment #5) > As long as your change doesn't create a regression wrt delays, I have no problems with it. I'll look further into that test, I think it's unstable. I'm not seeing any worse behaviour, and in the test that I included in here it makes the graphicsview behave the same as when disabled. 241518 7 59439 smagnuso 2010-06-22 16:13:20 -0700 Created attachment 59439 Rediff against trunk 243166 8 noam 2010-06-25 13:20:21 -0700 *** Bug 40778 has been marked as a duplicate of this bug. *** 243714 9 59439 commit-queue 2010-06-28 08:47:45 -0700 Comment on attachment 59439 Rediff against trunk Clearing flags on attachment: 59439 Committed r62010: <http://trac.webkit.org/changeset/62010> 243715 10 commit-queue 2010-06-28 08:47:50 -0700 All reviewed patches have been landed. Closing bug. 245194 11 hausmann 2010-07-01 01:25:51 -0700 Revision r62010 cherry-picked into qtwebkit-2.0 with commit 45fa2b8b4d6906275f948b93076c38f9539427b0 59137 2010-06-18 11:15:00 -0700 2010-06-22 16:13:20 -0700 Proposed patch (with testcase) bug-40846.patch text/plain 8539 smagnuso RnJvbSBlMjIxNzRhNDkxMWIwMzAxM2Q0ODA2Y2UyYjI2ZjA3NzAyNDE5MTdhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTYW0gTWFnbnVzb24gPHNtYWdudXNvbkBuZXRmbGl4LmNvbT4K RGF0ZTogRnJpLCAxOCBKdW4gMjAxMCAxMToxMzowMCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIFtR dF0gR3JhcGhpY3NMYXllclF0IGRlbGF5IHNlZW1zIHVubmVjZXNzYXJ5LgogYnVnLTQwODQ2Cgot LS0KIExheW91dFRlc3RzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwg ICAxMSArKysKIC4uLi9jb21wb3NpdGluZy9hbmltYXRpb24vYnVzeS1pbmRpY2F0b3Itbm8ucG5n ICAgIHwgIEJpbiAwIC0+IDE2OCBieXRlcwogLi4uL2NvbXBvc2l0aW5nL2FuaW1hdGlvbi9idXN5 LWluZGljYXRvci5odG1sICAgICAgfCAgIDkzICsrKysrKysrKysrKysrKysrKysrCiAuLi4vY29t cG9zaXRpbmcvYW5pbWF0aW9uL2J1c3ktaW5kaWNhdG9yLnBuZyAgICAgICB8ICBCaW4gMCAtPiAx OTAgYnl0ZXMKIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHwgICAxNSArKysKIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NMYXll clF0LmNwcCAgIHwgICAxMSArLS0KIDYgZmlsZXMgY2hhbmdlZCwgMTIzIGluc2VydGlvbnMoKyks IDcgZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQgTGF5b3V0VGVzdHMvY29tcG9zaXRp bmcvYW5pbWF0aW9uL2J1c3ktaW5kaWNhdG9yLW5vLnBuZwogY3JlYXRlIG1vZGUgMTAwNjQ0IExh eW91dFRlc3RzL2NvbXBvc2l0aW5nL2FuaW1hdGlvbi9idXN5LWluZGljYXRvci5odG1sCiBjcmVh dGUgbW9kZSAxMDA2NDQgTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvYW5pbWF0aW9uL2J1c3ktaW5k aWNhdG9yLnBuZwoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRl c3RzL0NoYW5nZUxvZwppbmRleCA2YzM2NDQwLi42MGMzNzdhIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTAtMDYtMTggIFNhbSBNYWdudXNvbiAgPHNtYWdudXNvbkBuZXRmbGl4LmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEdyYXBo aWNzTGF5ZXJRdCBkZWxheSBzZWVtcyB1bm5lY2Vzc2FyeS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwODQ2CisKKyAgICAgICAgKiBjb21wb3NpdGlu Zy9hbmltYXRpb24vYnVzeS1pbmRpY2F0b3Itbm8ucG5nOiBBZGRlZC4KKyAgICAgICAgKiBjb21w b3NpdGluZy9hbmltYXRpb24vYnVzeS1pbmRpY2F0b3IuaHRtbDogQWRkZWQuCisgICAgICAgICog Y29tcG9zaXRpbmcvYW5pbWF0aW9uL2J1c3ktaW5kaWNhdG9yLnBuZzogQWRkZWQuCisKIDIwMTAt MDYtMDIgIE5pY28gV2ViZXIgIDx0aGFraXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IFNpbW9uIEZyYXNlci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NvbXBvc2l0aW5n L2FuaW1hdGlvbi9idXN5LWluZGljYXRvci1uby5wbmcgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGlu Zy9hbmltYXRpb24vYnVzeS1pbmRpY2F0b3Itbm8ucG5nCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjdkM2ZkMWI2NGUz YjUxMjU4MWFhMzQyM2ZmNTNlMDM2ZTZlMmNkYmQKR0lUIGJpbmFyeSBwYXRjaApsaXRlcmFsIDE2 OAp6Y21lQVNATj8ob2xIeWB1VkJxIWlhMHZwXjVrTUA7ITNIRGAxIzdrZURhakpvaD8zeV53Mzcw fnFFclVRbD5EU3IKejE8JX5YXndnbCMjRldheWxjX2Q5TVA4bVJqdipEZC1kdEc3JWIqfkA7PChf KHw1XktAS0IjYzhiVlhMNT8waExgCnpjLXVBZnMoKkNhdVVrXlN7PihmUTh5SnxgYlBoQnlhdkxO dHZoaFNURmZ4bEo5SnMlb01TPytFUzE5QGlYUjk7TgpPUjBkQzFLYkxoKjJ+N1p0SCFfRi0KCmxp dGVyYWwgMApIY21WP2QwMDAwMQoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NvbXBvc2l0aW5n L2FuaW1hdGlvbi9idXN5LWluZGljYXRvci5odG1sIGIvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcv YW5pbWF0aW9uL2J1c3ktaW5kaWNhdG9yLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMC4uMWRlM2EzMQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2NvbXBvc2l0 aW5nL2FuaW1hdGlvbi9idXN5LWluZGljYXRvci5odG1sCkBAIC0wLDAgKzEsOTMgQEAKKzwhRE9D VFlQRSBodG1sPgorPGh0bWw+CisgICAgPGhlYWQ+CisgICAgICAgIDx0aXRsZT5CdXN5ITwvdGl0 bGU+CisgICAgICAgIDxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyIgbWVkaWE9InNjcmVlbiI+CisgICAg ICAgICAgICAgLmFwcC1zdGFydHVwICNhcHAtbG9hZGluZyB7CisgICAgICAgICAgICAgICB3aWR0 aDogMzAwcHg7CisgICAgICAgICAgICAgICBoZWlnaHQ6IDEwMHB4OworICAgICAgICAgICAgICAg cG9zaXRpb246IGFic29sdXRlOworICAgICAgICAgICAgICAgYmFja2dyb3VuZDogIzAwRkYwMDsK KyAgICAgICAgICAgICB9CisgICAgICAgICAgICAgLmFwcC1zdGFydHVwICNhcHAtbG9hZGluZy1w cm9ncmVzcyB7CisgICAgICAgICAgICAgICBwb3NpdGlvbjogYWJzb2x1dGU7CisgICAgICAgICAg ICAgICB0b3A6IDMwcHg7CisgICAgICAgICAgICAgICBsZWZ0OiAxMDBweDsKKyAgICAgICAgICAg ICB9CisgICAgICAgICAgICAucHJvZ3Jlc3MtaW5kaWNhdG9yIHsKKyAgICAgICAgICAgICAgIHdp ZHRoOiA5NHB4OworICAgICAgICAgICAgICAgaGVpZ2h0OiAzMHB4OworICAgICAgICAgICAgICAg YmFja2dyb3VuZDogdXJsKGJ1c3ktaW5kaWNhdG9yLW5vLnBuZykgbm8tcmVwZWF0IGNlbnRlciBj ZW50ZXI7CisgICAgICAgICAgICAgICBkaXNwbGF5OiBub25lOworICAgICAgICAgICAgIH0KKyAg ICAgICAgICAgICAucHJvZ3Jlc3MtaW5kaWNhdG9yID4gZGl2IHsKKyAgICAgICAgICAgICAgIHBv c2l0aW9uOiBhYnNvbHV0ZTsKKyAgICAgICAgICAgICAgIGJhY2tncm91bmQ6IHVybChidXN5LWlu ZGljYXRvci5wbmcpIG5vLXJlcGVhdDsKKyAgICAgICAgICAgICAgIHdpZHRoOiAxOHB4OworICAg ICAgICAgICAgICAgaGVpZ2h0OiAzMHB4OworICAgICAgICAgICAgICAgb3BhY2l0eTogMDsKKyAg ICAgICAgICAgICAgIC13ZWJraXQtYW5pbWF0aW9uLWR1cmF0aW9uOiAyLjRzOworICAgICAgICAg ICAgICAgLXdlYmtpdC1hbmltYXRpb24taXRlcmF0aW9uLWNvdW50OiBpbmZpbml0ZTsKKyAgICAg ICAgICAgICB9CisgICAgICAgICAgICAgLnByb2dyZXNzLWluZGljYXRvci52aXNpYmxlIC5wcm9n cmVzcy1pbmRpY2F0b3IwIHsKKyAgICAgICAgICAgICAgIGxlZnQ6IDBweDsKKyAgICAgICAgICAg ICAgIC13ZWJraXQtYW5pbWF0aW9uLWRlbGF5OiAwLjRzOworICAgICAgICAgICAgIH0KKyAgICAg ICAgICAgICAucHJvZ3Jlc3MtaW5kaWNhdG9yLnZpc2libGUgLnByb2dyZXNzLWluZGljYXRvcjEg eworICAgICAgICAgICAgICAgbGVmdDogMTlweDsKKyAgICAgICAgICAgICAgIC13ZWJraXQtYW5p bWF0aW9uLWRlbGF5OiAwLjhzOworICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAucHJvZ3Jl c3MtaW5kaWNhdG9yLnZpc2libGUgLnByb2dyZXNzLWluZGljYXRvcjIgeworICAgICAgICAgICAg ICAgbGVmdDogMzhweDsKKyAgICAgICAgICAgICAgIC13ZWJraXQtYW5pbWF0aW9uLWRlbGF5OiAx LjJzOworICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAucHJvZ3Jlc3MtaW5kaWNhdG9yLnZp c2libGUgLnByb2dyZXNzLWluZGljYXRvcjMgeworICAgICAgICAgICAgICAgbGVmdDogNTdweDsK KyAgICAgICAgICAgICAgIC13ZWJraXQtYW5pbWF0aW9uLWRlbGF5OiAxLjZzOworICAgICAgICAg ICAgIH0KKyAgICAgICAgICAgICAucHJvZ3Jlc3MtaW5kaWNhdG9yLnZpc2libGUgLnByb2dyZXNz LWluZGljYXRvcjQgeworICAgICAgICAgICAgICAgbGVmdDogNzZweDsKKyAgICAgICAgICAgICAg IC13ZWJraXQtYW5pbWF0aW9uLWRlbGF5OiAyczsKKyAgICAgICAgICAgICB9CisgICAgICAgICAg ICAgLnByb2dyZXNzLWluZGljYXRvci52aXNpYmxlIHsgZGlzcGxheTogYmxvY2s7IH0KKyAgICAg ICAgICAgICAucHJvZ3Jlc3MtaW5kaWNhdG9yLnZpc2libGUgPiBkaXYgeyAtd2Via2l0LWFuaW1h dGlvbi1wbGF5LXN0YXRlOiBydW5uaW5nOyB9CisKKyAgICAgICAgICAgICBALXdlYmtpdC1rZXlm cmFtZXMgc3Bpbm5lciB7CisgICAgICAgICAgICAgICAgIDAlIHsKKyAgICAgICAgICAgICAgICAg ICAgIC13ZWJraXQtdHJhbnNmb3JtOiBzY2FsZSgwLjcpOworICAgICAgICAgICAgICAgICAgICAg b3BhY2l0eTogMTsKKyAgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgICAxMCUgewor ICAgICAgICAgICAgICAgICAgICAgLXdlYmtpdC10cmFuc2Zvcm06IHNjYWxlKDEpOworICAgICAg ICAgICAgICAgICAgICAgb3BhY2l0eTogMTsKKyAgICAgICAgICAgICAgICAgfQorICAgICAgICAg ICAgICAgICAyNSUgeworICAgICAgICAgICAgICAgICAgICAgLXdlYmtpdC10cmFuc2Zvcm06IHNj YWxlKDAuNyk7CisgICAgICAgICAgICAgICAgICAgICBvcGFjaXR5OiAxOworICAgICAgICAgICAg ICAgICB9CisgICAgICAgICAgICAgICAgIDMwJSB7CisgICAgICAgICAgICAgICAgICAgICAtd2Vi a2l0LXRyYW5zZm9ybTogc2NhbGUoMC43KTsKKyAgICAgICAgICAgICAgICAgICAgIG9wYWNpdHk6 IDA7CisgICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICAgMTAwJSB7CisgICAgICAg ICAgICAgICAgICAgICAtd2Via2l0LXRyYW5zZm9ybTogc2NhbGUoMC43KTsKKyAgICAgICAgICAg ICAgICAgICAgIG9wYWNpdHk6IDA7CisgICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICB9 CisgICAgICAgICAgICAgLnByb2dyZXNzLWluZGljYXRvci52aXNpYmxlID4gZGl2IHsKKyAgICAg ICAgICAgICAgICAgLXdlYmtpdC1hbmltYXRpb24tbmFtZTogc3Bpbm5lcjsKKyAgICAgICAgICAg ICB9CisgICAgPC9zdHlsZT4KKyAgICA8L2hlYWQ+CisgICAgPGJvZHkgY2xhc3M9ImFwcC1zdGFy dHVwIj4KKyAgICAgICAgPGRpdiBpZD0iYXBwLWxvYWRpbmciPgorICAgICAgICAgICAgPGRpdiBp ZD0iYXBwLWxvYWRpbmctcHJvZ3Jlc3MiIGNsYXNzPSJwcm9ncmVzcy1pbmRpY2F0b3IgdmlzaWJs ZSI+CisgICAgICAgICAgICAgICAgPGRpdiBjbGFzcz0icHJvZ3Jlc3MtaW5kaWNhdG9yMCI+PC9k aXY+CisgICAgICAgICAgICAgICAgPGRpdiBjbGFzcz0icHJvZ3Jlc3MtaW5kaWNhdG9yMSI+PC9k aXY+CisgICAgICAgICAgICAgICAgPGRpdiBjbGFzcz0icHJvZ3Jlc3MtaW5kaWNhdG9yMiI+PC9k aXY+CisgICAgICAgICAgICAgICAgPGRpdiBjbGFzcz0icHJvZ3Jlc3MtaW5kaWNhdG9yMyI+PC9k aXY+CisgICAgICAgICAgICAgICAgPGRpdiBjbGFzcz0icHJvZ3Jlc3MtaW5kaWNhdG9yNCI+PC9k aXY+CisgICAgICAgICAgICA8L2Rpdj4KKyAgICAgICAgPC9kaXY+CisgICAgPC9ib2R5PgorPC9o dG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvYW5pbWF0aW9uL2J1c3kt aW5kaWNhdG9yLnBuZyBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL2FuaW1hdGlvbi9idXN5LWlu ZGljYXRvci5wbmcKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYzIwZDU1M2I2ODQzNmQwOWVlYjI0ZDAzYWQwY2E4M2My MWMzYjdiZQpHSVQgYmluYXJ5IHBhdGNoCmxpdGVyYWwgMTkwCnpjbWVBU0BOPyhvbEh5YHVWQnEh aWEwdnBeTE8/OVghMn40Tjw9dzBYUWojVUU1aGNPLVgoaT19TVgzeXFEZnZtTQp6M1pBKSU+OFV9 Zmk3QXpaQ3NTPkppVnszczk3OEhAQ0c5REZlUWtnSnw5e1BsYX5nUmp1cXgpVHY5WVBLWkRLZSoK ei1AZCtNMyhMOC1FYWYyNklsUHk/ZVNhVVg2cT54ZmNSfCppejlafFU/b009Qjwjd157c0BiMiE/ bVgjXzdqMzJUCms3a0BNWjVwS058JXAzKmBSP2hwJlImS1U/MEpNdzIpNzgmcW9sYDsrME96RGVF JnU9awoKbGl0ZXJhbCAwCkhjbVY/ZDAwMDAxCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VM b2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxZDlkNzM5Li4yYWM0MGYwIDEwMDY0NAotLS0g YS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEwLTA2LTE4ICBTYW0gTWFnbnVzb24gIDxzbWFnbnVzb25AbmV0ZmxpeC5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBHcmFw aGljc0xheWVyUXQgZGVsYXkgc2VlbXMgdW5uZWNlc3NhcnkuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDg0NgorCisgICAgICAgIFRlc3Q6IGNvbXBv c2l0aW5nL2FuaW1hdGlvbi9idXN5LWluZGljYXRvci5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9xdC9HcmFwaGljc0xheWVyUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3Jh cGhpY3NMYXllclF0SW1wbDo6cmVjYWNoZSk6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xh eWVyUXRJbXBsOjpmbHVzaENoYW5nZXMpOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXll clF0OjpzZXRDb250ZW50c1RvSW1hZ2UpOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXll clF0OjphZGRBbmltYXRpb24pOgorCiAyMDEwLTA2LTA3ICBKb2NlbHluIFR1cmNvdHRlICA8am9j ZWx5bi50dXJjb3R0ZUBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1 c21hbm4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNz TGF5ZXJRdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzTGF5ZXJR dC5jcHAKaW5kZXggYWQyZWM5Yy4uMDU4OTBhMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9xdC9HcmFwaGljc0xheWVyUXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvcXQvR3JhcGhpY3NMYXllclF0LmNwcApAQCAtMzMyLDcgKzMzMiw3IEBAIFFQaXht YXAgR3JhcGhpY3NMYXllclF0SW1wbDo6cmVjYWNoZShjb25zdCBRUmVnaW9uJiByZWdpb25Ub1Vw ZGF0ZSkKICAgICBtX2xheWVyLT5wYWludEdyYXBoaWNzTGF5ZXJDb250ZW50cyhnYywgcmVnaW9u LmJvdW5kaW5nUmVjdCgpKTsKICAgICBwYWludGVyLmVuZCgpOwogCi0gICAgbV9iYWNraW5nU3Rv cmVLZXkgPSBRUGl4bWFwQ2FjaGU6Omluc2VydChwaXhtYXApOyAgICAKKyAgICBtX2JhY2tpbmdT dG9yZUtleSA9IFFQaXhtYXBDYWNoZTo6aW5zZXJ0KHBpeG1hcCk7CiAgICAgcmV0dXJuIHBpeG1h cDsKIH0KIApAQCAtNjU1LDcgKzY1NSw3IEBAIGFmdGVyTGF5ZXJDaGFuZ2VzOgogICAgICAgICB1 cGRhdGVUcmFuc2Zvcm0oKTsKIAogICAgIGlmICghcmVjdXJzaXZlKQotICAgICAgICByZXR1cm47 ICAgIAorICAgICAgICByZXR1cm47CiAKICAgICBRTGlzdDxRR3JhcGhpY3NJdGVtKj4gY2hpbGRy ZW4gPSBjaGlsZEl0ZW1zKCk7CiAgICAgaWYgKG1fc3RhdGUubWFza0xheWVyKQpAQCAtOTI5LDcg KzkyOSw3IEBAIHZvaWQgR3JhcGhpY3NMYXllclF0OjpzZXRDb250ZW50c1RvSW1hZ2UoSW1hZ2Uq IGltYWdlKQogICAgICAgICAgICAgbV9pbXBsLT5tX3BlbmRpbmdDb250ZW50LnBpeG1hcCA9ICpw eG07CiAgICAgICAgICAgICBtX2ltcGwtPm1fcGVuZGluZ0NvbnRlbnQuY29udGVudFR5cGUgPSBH cmFwaGljc0xheWVyUXRJbXBsOjpQaXhtYXBDb250ZW50VHlwZTsKICAgICAgICAgICAgIHJldHVy bjsKLSAgICAgICAgfSAgICAgICAgCisgICAgICAgIH0KICAgICB9CiAgICAgbV9pbXBsLT5tX3Bl bmRpbmdDb250ZW50LnBpeG1hcCA9IFFQaXhtYXAoKTsKIH0KQEAgLTEzMTksMTAgKzEzMTksNyBA QCBib29sIEdyYXBoaWNzTGF5ZXJRdDo6YWRkQW5pbWF0aW9uKGNvbnN0IEtleWZyYW1lVmFsdWVM aXN0JiB2YWx1ZXMsIGNvbnN0IEludFNpegogICAgIGlmIChhbmltLT5maWxsc0JhY2t3YXJkcygp KQogICAgICAgICBuZXdBbmltLT5zZXRDdXJyZW50VGltZSgwKTsKIAotICAgIGlmIChhbmltLT5k ZWxheSgpKQotICAgICAgICBRVGltZXI6OnNpbmdsZVNob3QoYW5pbS0+ZGVsYXkoKSAqIDEwMDAs IG5ld0FuaW0sIFNMT1Qoc3RhcnQoKSkpOwotICAgIGVsc2UKLSAgICAgICAgbmV3QW5pbS0+c3Rh cnQoKTsKKyAgICBuZXdBbmltLT5zdGFydCgpOwogCiAgICAgLy8gd2Ugc3luY2hyb25pemUgdGhl IGFuaW1hdGlvbidzIGNsb2NrIHRvIFdlYkNvcmUncyB0aW1lT2Zmc2V0CiAgICAgbmV3QW5pbS0+ c2V0Q3VycmVudFRpbWUodGltZU9mZnNldCAqIDEwMDApOwotLSAKMS43LjEKCg== 59439 2010-06-22 16:13:20 -0700 2010-06-28 08:47:45 -0700 Rediff against trunk bug-40846.patch text/plain 2635 smagnuso RnJvbSA1NTkwNDJjODEzMjYwODkwMzBlN2JmN2ZjNGM5ZjdhMzU1MmUzNTJjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTYW0gTWFnbnVzb24gPHNtYWdudXNvbkBuZXRmbGl4LmNvbT4K RGF0ZTogTW9uLCAyMSBKdW4gMjAxMCAyMjo1MDoxNiAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIFtR dF0gR3JhcGhpY3NMYXllclF0IGRlbGF5IHNlZW1zIHVubmVjZXNzYXJ5LgogYnVnLTQwODQ2Cgot LS0KIExheW91dFRlc3RzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAg MTEgKysrKysrKysrKysKIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB8ICAgMTUgKysrKysrKysrKysrKysrCiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3F0L0dyYXBoaWNzTGF5ZXJRdC5jcHAgfCAgICA1ICstLS0tCiAzIGZpbGVzIGNoYW5nZWQsIDI3 IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDJhOWNiZDguLjg5M2RkZTUg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNi0xOCAgU2FtIE1hZ251c29uICA8c21hZ251 c29uQG5ldGZsaXguY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtRdF0gR3JhcGhpY3NMYXllclF0IGRlbGF5IHNlZW1zIHVubmVjZXNzYXJ5Lgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA4NDYKKwor ICAgICAgICAqIGNvbXBvc2l0aW5nL2FuaW1hdGlvbi9idXN5LWluZGljYXRvci1uby5wbmc6IEFk ZGVkLgorICAgICAgICAqIGNvbXBvc2l0aW5nL2FuaW1hdGlvbi9idXN5LWluZGljYXRvci5odG1s OiBBZGRlZC4KKyAgICAgICAgKiBjb21wb3NpdGluZy9hbmltYXRpb24vYnVzeS1pbmRpY2F0b3Iu cG5nOiBBZGRlZC4KKwogMjAxMC0wNi0yMSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJv dEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjYxNTg1Lgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2 OWIxNjc5Li41ZWY5YTQyIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEwLTA2LTE4ICBTYW0gTWFnbnVzb24g IDxzbWFnbnVzb25AbmV0ZmxpeC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW1F0XSBHcmFwaGljc0xheWVyUXQgZGVsYXkgc2VlbXMgdW5uZWNl c3NhcnkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 MDg0NgorCisgICAgICAgIFRlc3Q6IGNvbXBvc2l0aW5nL2FuaW1hdGlvbi9idXN5LWluZGljYXRv ci5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0xheWVyUXQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllclF0SW1wbDo6cmVjYWNoZSk6Cisg ICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xheWVyUXRJbXBsOjpmbHVzaENoYW5nZXMpOgorICAg ICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllclF0OjpzZXRDb250ZW50c1RvSW1hZ2UpOgorICAg ICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllclF0OjphZGRBbmltYXRpb24pOgorCiAyMDEwLTA2 LTIxICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAg ICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNjE1ODUuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzTGF5ZXJRdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3F0L0dyYXBoaWNzTGF5ZXJRdC5jcHAKaW5kZXggOGVkMGQ4OS4uNDVkMDIyMCAx MDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0xheWVyUXQu Y3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NMYXllclF0LmNw cApAQCAtMTQ0MSwxMCArMTQ0MSw3IEBAIGJvb2wgR3JhcGhpY3NMYXllclF0OjphZGRBbmltYXRp b24oY29uc3QgS2V5ZnJhbWVWYWx1ZUxpc3QmIHZhbHVlcywgY29uc3QgSW50U2l6CiAgICAgaWYg KGFuaW0tPmZpbGxzQmFja3dhcmRzKCkpCiAgICAgICAgIG5ld0FuaW0tPnNldEN1cnJlbnRUaW1l KDApOwogCi0gICAgaWYgKGFuaW0tPmRlbGF5KCkpCi0gICAgICAgIFFUaW1lcjo6c2luZ2xlU2hv dChhbmltLT5kZWxheSgpICogMTAwMCwgbmV3QW5pbSwgU0xPVChzdGFydCgpKSk7Ci0gICAgZWxz ZQotICAgICAgICBuZXdBbmltLT5zdGFydCgpOworICAgIG5ld0FuaW0tPnN0YXJ0KCk7CiAKICAg ICAvLyBXZSBzeW5jaHJvbml6ZSB0aGUgYW5pbWF0aW9uJ3MgY2xvY2sgdG8gV2ViQ29yZSdzIHRp bWVPZmZzZXQuCiAgICAgbmV3QW5pbS0+c2V0Q3VycmVudFRpbWUodGltZU9mZnNldCAqIDEwMDAp OwotLSAKMS43LjEKCg==