<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>40535</bug_id>
          
          <creation_ts>2010-06-12 20:19:21 -0700</creation_ts>
          <short_desc>[Qt] GraphicsLayer: recaching images creates an unnecessary deep copy</short_desc>
          <delta_ts>2010-06-13 14:11:03 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>CLOSED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Performance, Qt</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>38744</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Noam Rosenthal">noam</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>hausmann</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>237443</commentid>
    <comment_count>0</comment_count>
    <who name="Noam Rosenthal">noam</who>
    <bug_when>2010-06-12 20:19:21 -0700</bug_when>
    <thetext>Profiling on Mac with raster + QGLWidget shows repeating image copies.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>237444</commentid>
    <comment_count>1</comment_count>
      <attachid>58575</attachid>
    <who name="Noam Rosenthal">noam</who>
    <bug_when>2010-06-12 20:22:53 -0700</bug_when>
    <thetext>Created attachment 58575
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>237447</commentid>
    <comment_count>2</comment_count>
      <attachid>58575</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-06-12 20:35:54 -0700</bug_when>
    <thetext>Comment on attachment 58575
Patch

OK.  rs=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>237520</commentid>
    <comment_count>3</comment_count>
      <attachid>58575</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-06-13 01:20:32 -0700</bug_when>
    <thetext>Comment on attachment 58575
Patch

Clearing flags on attachment: 58575

Committed r61086: &lt;http://trac.webkit.org/changeset/61086&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>237521</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-06-13 01:20:38 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>237608</commentid>
    <comment_count>5</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-06-13 14:10:47 -0700</bug_when>
    <thetext>Revision r61086 cherry-picked into qtwebkit-2.0 with commit 661d414dc93f5f57352dbfd1600a67d5d5407b21</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>58575</attachid>
            <date>2010-06-12 20:22:53 -0700</date>
            <delta_ts>2010-06-13 01:20:31 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-40535-20100612202251.patch</filename>
            <type>text/plain</type>
            <size>1510</size>
            <attacher name="Noam Rosenthal">noam</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
OWRkYjNiMGRhMzI5ZDA1MjJlN2QwMjRiMWFmODA0YmNmMDk4MGY3YS4uZGZmYmM4NzkwYTI0MDVl
ZWM1M2IwOGM0MGIzMmY2NTE0OGMzMjhjNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK
KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyMCBAQAogCiAgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgIFtRdF0gR3JhcGhpY3NMYXllcjogcmVj
YWNoaW5nIGltYWdlcyBjcmVhdGVzIGFuIHVubmVjZXNzYXJ5IGRlZXAgY29weQorICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA1MzUKKworICAgICAgICBN
YWRlIHN1cmUgdGhlIHBhaW50ZXIgZW5kcyBpdHMgb3BlcmF0aW9uIGJlZm9yZSBjb3B5aW5nIHRo
ZSBwaXhtYXAuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzOiB0aGlzIGlzIGFuIG9wdGltaXphdGlv
bi4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzTGF5ZXJRdC5jcHA6
CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xheWVyUXRJbXBsOjpyZWNhY2hlKToKKworMjAx
MC0wNi0xMiAgTm9hbSBSb3NlbnRoYWwgIDxub2FtLnJvc2VudGhhbEBub2tpYS5jb20+CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAgW1F0XSB0ZXN0cy9o
eWJyaWRQaXhtYXAgZmFpbHMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTM3MzE2CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv
cXQvR3JhcGhpY3NMYXllclF0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3Jh
cGhpY3NMYXllclF0LmNwcAppbmRleCA2YmE2MWQ4YjYwOTQyMmU0ZTgzNjAzMzkwZjUwMDhmYjc0
YTg3MzAwLi44ZWQwZDg5NjQ1ODEzODc5ZWMyMjcwMGNmMmEwMmEyYmE4NTQ1YjJjIDEwMDY0NAot
LS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzTGF5ZXJRdC5jcHAKKysr
IGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0xheWVyUXQuY3BwCkBAIC0z
NjYsNiArMzY2LDcgQEAgUVBpeG1hcCBHcmFwaGljc0xheWVyUXRJbXBsOjpyZWNhY2hlKGNvbnN0
IFFSZWdpb24mIHJlZ2lvblRvVXBkYXRlKQogICAgIC8vIFJlbmRlciB0aGUgYWN0dWFsIGNvbnRl
bnRzIGludG8gdGhlIGNhY2hlCiAgICAgcGFpbnRlci5zZXRDb21wb3NpdGlvbk1vZGUoUVBhaW50
ZXI6OkNvbXBvc2l0aW9uTW9kZV9Tb3VyY2VPdmVyKTsKICAgICBtX2xheWVyLT5wYWludEdyYXBo
aWNzTGF5ZXJDb250ZW50cyhnYywgcmVnaW9uLmJvdW5kaW5nUmVjdCgpKTsKKyAgICBwYWludGVy
LmVuZCgpOwogCiAgICAgbV9iYWNraW5nU3RvcmVLZXkgPSBRUGl4bWFwQ2FjaGU6Omluc2VydChw
aXhtYXApOwogICAgIHJldHVybiBwaXhtYXA7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>