40385 2010-06-09 12:46:02 -0700 Fix fast/parser/hex-entities-length.html for HTML5 parser 2010-06-09 15:05:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 39259 1 tonyg tonyg abarth ian oldest_to_newest 235947 0 tonyg 2010-06-09 12:46:02 -0700 Fix fast/parser/hex-entities-length.html for HTML5 parser 235951 1 58281 tonyg 2010-06-09 12:56:02 -0700 Created attachment 58281 Patch 235960 2 tonyg 2010-06-09 13:07:55 -0700 Minefield passes this test, and it appears that if the "Preprocessing the input stream" spec were strictly followed it could not pass the test. Also, I poked around at the minefield implementation and found where these character ranges are replaced for entities (in handleNcrValue). But can't find anywhere where they are replaced in the input stream itself (they are just passed to emitOrAppendTwo). Links: http://mxr.mozilla.org/mozilla-central/source/parser/html/nsHtml5Tokenizer.cpp http://mxr.mozilla.org/mozilla-central/source/parser/html/nsHtml5StreamParser.cpp 236025 3 58281 abarth 2010-06-09 14:54:49 -0700 Comment on attachment 58281 Patch Yep. This will fix a bunch of tests, actually. Can you email public-html with this feedback on the spec? 236033 4 58281 abarth 2010-06-09 15:05:33 -0700 Comment on attachment 58281 Patch Clearing flags on attachment: 58281 Committed r60916: <http://trac.webkit.org/changeset/60916> 236034 5 abarth 2010-06-09 15:05:40 -0700 All reviewed patches have been landed. Closing bug. 58281 2010-06-09 12:56:02 -0700 2010-06-09 15:05:33 -0700 Patch bug-40385-20100609125600.patch text/plain 2046 tonyg ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZmQ5MTk4YjIxMGUxYzM2NTcxYjU2ZTk1MDk1NjRhNTU3YjI2OTI5Yy4uYWJmYjFiMzEwYzJiNzc2 NDIwZmQwNGM5NDUxY2NkZjc4YWU1ZWFkNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wNi0wOSAgVG9u eSBHZW50aWxjb3JlICA8dG9ueWdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBmYXN0L3BhcnNlci9oZXgtZW50aXRpZXMt bGVuZ3RoLmh0bWwgZm9yIEhUTUw1IHBhcnNlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDAzODUKKworICAgICAgICBTdHJpcHBpbmcgc3Vycm9nYXRl IHBhaXIgdmFsdWVzIGFwcGVhcnMgdG8gYmUgYSBwcm9ibGVtIHdpdGggdGhlIHNwZWMKKyAgICAg ICAgaW4gIlByZXByb2Nlc3NpbmcgdGhlIGlucHV0IHN0cmVhbS4iIE1pbmVmaWVsZCBkb2Vzbid0 IGFwcGVhciB0bworICAgICAgICBpbXBsZW1lbnQgdGhlIHBhcnQgaW4gcXVlc3Rpb24uIFNvIHRo aXMgcGF0Y2ggcmVtb3ZlcyB0aGF0IGd1YXJkIGFuZAorICAgICAgICBhZGRzIGEgRklYTUUgdG8g dHJhY2sgdGhlIGlzc3VlLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIGNvdmVyZWQg YnkgZmFzdC9wYXJzZXIvaGV4LWVudGl0aWVzLWxlbmd0aC5odG1sCisKKyAgICAgICAgKiBodG1s L0hUTUw1TGV4ZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUw1TGV4ZXI6OklucHV0U3RyZWFt UHJlcHJvY2Vzc29yOjpwZWVrKToKKwogMjAxMC0wNi0wOSAgS3dhbmcgWXVsIFNlbyAgPHNreXVs QGNvbXBhbnkxMDAubmV0PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbnQgVGFtdXJhLgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hUTUw1TGV4ZXIuaCBiL1dlYkNvcmUvaHRtbC9IVE1MNUxl eGVyLmgKaW5kZXggZDlkNzU5YmYwMmNkNGE1NmNiM2IyYTAwZmUyMTE3YTFkYTQxMGVjNS4uYzlj ZDMwNjkyMmY3ZjVkMjgyMjcxNzlhYWU2ZDAyMDg0OGQ4YTIwOSAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9odG1sL0hUTUw1TGV4ZXIuaAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTDVMZXhlci5oCkBAIC0x NTksNyArMTU5LDExIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgICAgICAgICAgICAg bV9za2lwTmV4dE5ld0xpbmUgPSB0cnVlOwogICAgICAgICAgICAgICAgIH0gZWxzZSB7CiAgICAg ICAgICAgICAgICAgICAgIG1fc2tpcE5leHROZXdMaW5lID0gZmFsc2U7Ci0gICAgICAgICAgICAg ICAgICAgIGlmIChtX25leHRJbnB1dENoYXJhY3RlciA9PSAnXDAnIHx8IChtX25leHRJbnB1dENo YXJhY3RlciA+PSAweEQ4MDAgJiYgbV9uZXh0SW5wdXRDaGFyYWN0ZXIgPD0gMHhERkZGKSkKKyAg ICAgICAgICAgICAgICAgICAgLy8gRklYTUU6IFRoZSBzcGVjIGluZGljYXRlcyB0aGF0IHRoZSBz dXJyb2dhdGUgcGFpciByYW5nZSBhcyB3ZWxsIGFzCisgICAgICAgICAgICAgICAgICAgIC8vIGEg bnVtYmVyIG9mIHNwZWNpZmljIGNoYXJhY3RlciB2YWx1ZXMgYXJlIHBhcnNlIGVycm9ycyBhbmQg c2hvdWxkIGJlIHJlcGxhY2VkCisgICAgICAgICAgICAgICAgICAgIC8vIGJ5IHRoZSByZXBsYWNl bWVudCBjaGFyYWN0ZXIuIFdlIHN1c3BlY3QgdGhpcyBpcyBhIHByb2JsZW0gd2l0aCB0aGUgc3Bl YyBhcyBkb2luZworICAgICAgICAgICAgICAgICAgICAvLyB0aGF0IGZpbHRlcmluZyBicmVha3Mg c3Vycm9nYXRlIHBhaXIgaGFuZGxpbmcgYW5kIGNhdXNlcyB1cyBub3QgdG8gbWF0Y2ggTWluZWZp ZWxkLgorICAgICAgICAgICAgICAgICAgICBpZiAobV9uZXh0SW5wdXRDaGFyYWN0ZXIgPT0gJ1ww JykKICAgICAgICAgICAgICAgICAgICAgICAgIG1fbmV4dElucHV0Q2hhcmFjdGVyID0gMHhGRkZE OwogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsK