40333 2010-06-08 14:14:37 -0700 [GTK] Convert WebKitWebView's private draggingDataObjects member to a pointer 2010-07-01 09:03:18 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 30623 1 mrobinson webkit-unassigned abarth eric webkit.review.bot oldest_to_newest 235518 0 mrobinson 2010-06-08 14:14:37 -0700 Converting this member to a pointer will allow for calling constructor and destructor of this HashMap. Previously a 0'd memory region was used for this object. 235523 1 58185 mrobinson 2010-06-08 14:19:33 -0700 Created attachment 58185 Convert draggingDataObjects to a pointer 236000 2 58295 mrobinson 2010-06-09 14:10:49 -0700 Created attachment 58295 Alternative approach using placement new 244323 3 58185 mrobinson 2010-06-29 09:23:40 -0700 Comment on attachment 58185 Convert draggingDataObjects to a pointer It seems like the pointer approach is preferred, so I'm re-enabling the review? flag on it. 244905 4 58185 xan.lopez 2010-06-30 13:06:47 -0700 Comment on attachment 58185 Convert draggingDataObjects to a pointer Looks good. 245103 5 mrobinson 2010-06-30 22:45:18 -0700 Committed r62226: <http://trac.webkit.org/changeset/62226> 245119 6 webkit.review.bot 2010-06-30 23:13:04 -0700 http://trac.webkit.org/changeset/62226 might have broken GTK Linux 32-bit Release 245128 7 mrobinson 2010-06-30 23:25:19 -0700 Reverted r62226 for reason: This change caused 13 new crashers. Committed r62230: <http://trac.webkit.org/changeset/62230> 245361 8 60253 mrobinson 2010-07-01 08:43:28 -0700 Created attachment 60253 Patch where delete is done in finalize instead of dispose 245365 9 60253 xan.lopez 2010-07-01 08:57:43 -0700 Comment on attachment 60253 Patch where delete is done in finalize instead of dispose 13 crashers! 245368 10 60253 mrobinson 2010-07-01 09:03:12 -0700 Comment on attachment 60253 Patch where delete is done in finalize instead of dispose Clearing flags on attachment: 60253 Committed r62262: <http://trac.webkit.org/changeset/62262> 245369 11 mrobinson 2010-07-01 09:03:18 -0700 All reviewed patches have been landed. Closing bug. 58185 2010-06-08 14:19:33 -0700 2010-07-01 08:43:24 -0700 Convert draggingDataObjects to a pointer bug-40333-20100608141933.patch text/plain 4746 mrobinson ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggZjdmNGM4ZjcwYjFhNWU2YWY1NDg0NGJiMTZlNTBiZWUyZTg4NDcyNi4uMGNmNzgwZWNj ZTQ2Zjc5NTJlMWYwMmU5MjNhODkxNDg3Yjc2NTA5ZSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAx MC0wNi0wOCAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gQ29udmVydCBX ZWJLaXRXZWJWaWV3J3MgcHJpdmF0ZSBkcmFnZ2luZ0RhdGFPYmplY3RzIG1lbWJlciB0byBhIHBv aW50ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQw MzMzCisKKyAgICAgICAgQ29udmVydCBkcmFnZ2luZ0RhdGFPYmplY3RzIHRvIGEgcG9pbnRlci4g VGhlIGNvbnN0cnVjdG9yIGFuZCBkZXN0cnVjdG9yIG9mIHRoZQorICAgICAgICBIYXNoTWFwIHNo b3VsZCBiZSBjYWxsZWQgZXhwbGljaXRseS4gR09iamVjdCBtZW1vcnkgYWxsb2NhdGlvbiBkb2Vz IG5vdCBkbyB0aGlzLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRHJhZ0NsaWVudEd0ay5j cHA6CisgICAgICAgIChXZWJLaXQ6OkRyYWdDbGllbnQ6OnN0YXJ0RHJhZyk6CisgICAgICAgICog d2Via2l0L3dlYmtpdHByaXZhdGUuaDoKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vidmlldy5j cHA6CisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfZGlzcG9zZSk6CisgICAgICAgICh3ZWJraXRf d2ViX3ZpZXdfZHJhZ19lbmQpOgorICAgICAgICAod2Via2l0X3dlYl92aWV3X2RyYWdfZGF0YV9n ZXQpOgorICAgICAgICAod2Via2l0X3dlYl92aWV3X2luaXQpOgorCiAyMDEwLTA2LTA4ICBYYW4g TG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHdXN0YXZv IE5vcm9uaGEuCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0RyYWdDbGll bnRHdGsuY3BwIGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EcmFnQ2xpZW50R3RrLmNwcApp bmRleCA2YzM5NWM3MjdlY2JlMjhiNTIwOGU2NmFkMDJkMWFiMGI5Mzk0MDJmLi40NWNlNGNkODVi OTRhNmU0MzQxMGU3NGUwY2ZhYjQwYmI0MjlkYmIwIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL1dl YkNvcmVTdXBwb3J0L0RyYWdDbGllbnRHdGsuY3BwCisrKyBiL1dlYktpdC9ndGsvV2ViQ29yZVN1 cHBvcnQvRHJhZ0NsaWVudEd0ay5jcHAKQEAgLTc3LDcgKzc3LDcgQEAgdm9pZCBEcmFnQ2xpZW50 OjpzdGFydERyYWcoRHJhZ0ltYWdlUmVmIGltYWdlLCBjb25zdCBJbnRQb2ludCYgZHJhZ0ltYWdl T3JpZ2luLAogICAgIEdPd25QdHI8R2RrRXZlbnQ+IGN1cnJlbnRFdmVudChndGtfZ2V0X2N1cnJl bnRfZXZlbnQoKSk7CiAKICAgICBHZGtEcmFnQ29udGV4dCogY29udGV4dCA9IGd0a19kcmFnX2Jl Z2luKEdUS19XSURHRVQobV93ZWJWaWV3KSwgdGFyZ2V0TGlzdC5nZXQoKSwgZHJhZ09wZXJhdGlv blRvR2RrRHJhZ0FjdGlvbnMoY2xpcGJvYXJkLT5zb3VyY2VPcGVyYXRpb24oKSksIDEsIGN1cnJl bnRFdmVudC5nZXQoKSk7Ci0gICAgd2ViVmlldy0+cHJpdi0+ZHJhZ2dpbmdEYXRhT2JqZWN0cy5z ZXQoY29udGV4dCwgZGF0YU9iamVjdCk7CisgICAgd2ViVmlldy0+cHJpdi0+ZHJhZ2dpbmdEYXRh T2JqZWN0cy0+c2V0KGNvbnRleHQsIGRhdGFPYmplY3QpOwogCiAgICAgaWYgKGltYWdlKQogICAg ICAgICBndGtfZHJhZ19zZXRfaWNvbl9waXhidWYoY29udGV4dCwgaW1hZ2UsIGV2ZW50UG9zLngo KSAtIGRyYWdJbWFnZU9yaWdpbi54KCksIGV2ZW50UG9zLnkoKSAtIGRyYWdJbWFnZU9yaWdpbi55 KCkpOwpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0cHJpdmF0ZS5oIGIvV2Vi S2l0L2d0ay93ZWJraXQvd2Via2l0cHJpdmF0ZS5oCmluZGV4IDQ0ZmZjMWVkYTZkNWY5ODNkMzIw ZmE1NjJmNTRiNTFhNjU2NWI3NGQuLjlhZTk4MzQ5YzVmYmVkYmE3ZjcyMmMyOGIyM2Y3MTViZWFm N2RlMzUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHByaXZhdGUuaAorKysg Yi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRwcml2YXRlLmgKQEAgLTE1Miw3ICsxNTIsNyBAQCBl eHRlcm4gIkMiIHsKICAgICAgICAgR0hhc2hUYWJsZSogc3ViUmVzb3VyY2VzOwogICAgICAgICBj aGFyKiB0b29sdGlwVGV4dDsKIAotICAgICAgICBIYXNoTWFwPEdka0RyYWdDb250ZXh0KiwgUmVm UHRyPFdlYkNvcmU6OkRhdGFPYmplY3RHdGs+ID4gZHJhZ2dpbmdEYXRhT2JqZWN0czsKKyAgICAg ICAgSGFzaE1hcDxHZGtEcmFnQ29udGV4dCosIFJlZlB0cjxXZWJDb3JlOjpEYXRhT2JqZWN0R3Rr PiA+KiBkcmFnZ2luZ0RhdGFPYmplY3RzOwogICAgIH07CiAKICAgICAjZGVmaW5lIFdFQktJVF9X RUJfRlJBTUVfR0VUX1BSSVZBVEUob2JqKSAgICAoR19UWVBFX0lOU1RBTkNFX0dFVF9QUklWQVRF KChvYmopLCBXRUJLSVRfVFlQRV9XRUJfRlJBTUUsIFdlYktpdFdlYkZyYW1lUHJpdmF0ZSkpCmRp ZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCBiL1dlYktpdC9n dGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCmluZGV4IDY3NDQ3MzJkZTU3ZDNhMGM5NzIzZTdi ZmI3YjExYTAzM2Y1YzAzZjYuLjhkNjlkYzYyNjhmNjBiNTg2MmI5YmIyZjQ5MWQzYzMxYWFhMDRm MTQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCisrKyBi L1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCkBAIC0xMTY4LDcgKzExNjgsOCBA QCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfZGlzcG9zZShHT2JqZWN0KiBvYmplY3QpCiAg ICAgICAgIHByaXYtPnN1YlJlc291cmNlcyA9IE5VTEw7CiAgICAgfQogCi0gICAgcHJpdi0+ZHJh Z2dpbmdEYXRhT2JqZWN0cy5jbGVhcigpOworICAgIHByaXYtPmRyYWdnaW5nRGF0YU9iamVjdHMt PmNsZWFyKCk7CisgICAgZGVsZXRlIHByaXYtPmRyYWdnaW5nRGF0YU9iamVjdHM7CiAKICAgICBH X09CSkVDVF9DTEFTUyh3ZWJraXRfd2ViX3ZpZXdfcGFyZW50X2NsYXNzKS0+ZGlzcG9zZShvYmpl Y3QpOwogfQpAQCAtMTI4NSwxMCArMTI4NiwxMCBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3Zp ZXdfZHJhZ19lbmQoR3RrV2lkZ2V0KiB3aWRnZXQsIEdka0RyYWdDb250ZXh0KiBjb250ZXh0KQog CiAgICAgLy8gVGhpcyBtaWdodCBoYXBwZW4gaWYgYSBkcmFnIGlzIHN0aWxsIGluIHByb2dyZXNz IGFmdGVyIGEgV2ViS2l0V2ViVmlldwogICAgIC8vIGlzIGRpc3Bvc2VkIGFuZCBiZWZvcmUgaXQg aXMgZmluYWxpemVkLgotICAgIGlmICghcHJpdi0+ZHJhZ2dpbmdEYXRhT2JqZWN0cy5jb250YWlu cyhjb250ZXh0KSkKKyAgICBpZiAoIXByaXYtPmRyYWdnaW5nRGF0YU9iamVjdHMtPmNvbnRhaW5z KGNvbnRleHQpKQogICAgICAgICByZXR1cm47CiAKLSAgICBwcml2LT5kcmFnZ2luZ0RhdGFPYmpl Y3RzLnJlbW92ZShjb250ZXh0KTsKKyAgICBwcml2LT5kcmFnZ2luZ0RhdGFPYmplY3RzLT5yZW1v dmUoY29udGV4dCk7CiAKICAgICBGcmFtZSogZnJhbWUgPSBjb3JlKHdlYlZpZXcpLT5mb2N1c0Nv bnRyb2xsZXIoKS0+Zm9jdXNlZE9yTWFpbkZyYW1lKCk7CiAgICAgaWYgKCFmcmFtZSkKQEAgLTEz MjMsMTAgKzEzMjQsMTAgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3X2RyYWdfZGF0YV9n ZXQoR3RrV2lkZ2V0KiB3aWRnZXQsIEdka0RyYWdDb250ZXh0KiBjb24KIAogICAgIC8vIFRoaXMg bWlnaHQgaGFwcGVuIGlmIGEgZHJhZyBpcyBzdGlsbCBpbiBwcm9ncmVzcyBhZnRlciBhIFdlYktp dFdlYlZpZXcKICAgICAvLyBpcyBkaXBvc2VkIGFuZCBiZWZvcmUgaXQgaXMgZmluYWxpemVkLgot ICAgIGlmICghcHJpdi0+ZHJhZ2dpbmdEYXRhT2JqZWN0cy5jb250YWlucyhjb250ZXh0KSkKKyAg ICBpZiAoIXByaXYtPmRyYWdnaW5nRGF0YU9iamVjdHMtPmNvbnRhaW5zKGNvbnRleHQpKQogICAg ICAgICByZXR1cm47CiAKLSAgICBwYXN0ZWJvYXJkSGVscGVySW5zdGFuY2UoKS0+ZmlsbFNlbGVj dGlvbkRhdGEoc2VsZWN0aW9uRGF0YSwgaW5mbywgcHJpdi0+ZHJhZ2dpbmdEYXRhT2JqZWN0cy5n ZXQoY29udGV4dCkuZ2V0KCkpOworICAgIHBhc3RlYm9hcmRIZWxwZXJJbnN0YW5jZSgpLT5maWxs U2VsZWN0aW9uRGF0YShzZWxlY3Rpb25EYXRhLCBpbmZvLCBwcml2LT5kcmFnZ2luZ0RhdGFPYmpl Y3RzLT5nZXQoY29udGV4dCkuZ2V0KCkpOwogfQogCiAjaWYgR1RLX0NIRUNLX1ZFUlNJT04oMiwg MTIsIDApCkBAIC0yOTAwLDYgKzI5MDEsOCBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdf aW5pdChXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3KQogICAgIHByaXYtPnN1YlJlc291cmNlcyA9IGdf aGFzaF90YWJsZV9uZXdfZnVsbChnX3N0cl9oYXNoLCBnX3N0cl9lcXVhbCwgZ19mcmVlLCBnX29i amVjdF91bnJlZik7CiAKICAgICBwcml2LT50b29sdGlwVGV4dCA9IDA7CisKKyAgICBwcml2LT5k cmFnZ2luZ0RhdGFPYmplY3RzID0gbmV3IEhhc2hNYXA8R2RrRHJhZ0NvbnRleHQqLCBSZWZQdHI8 V2ViQ29yZTo6RGF0YU9iamVjdEd0az4gPigpOwogfQogCiBHdGtXaWRnZXQqIHdlYmtpdF93ZWJf dmlld19uZXcodm9pZCkK 58295 2010-06-09 14:10:49 -0700 2010-06-29 09:23:56 -0700 Alternative approach using placement new bug-40333-20100609141048.patch text/plain 1766 mrobinson ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggYTAwYTNmZGI0OGQ1NDM5OGM4YTI3NjQ5ZjA0YWQ0Nzk1ZTFhMzlmNy4uOTM1OGQ5Mjdm Mjc5YWQzYTE1NmQyYTI0ZmU0NmQyNzZmN2NmMWJiNyAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAx MC0wNi0wOSAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gQ29udmVydCBX ZWJLaXRXZWJWaWV3J3MgcHJpdmF0ZSBkcmFnZ2luZ0RhdGFPYmplY3RzIG1lbWJlciB0byBhIHBv aW50ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQw MzMzCisKKyAgICAgICAgQ2FsbCBjb25zdHJ1Y3RvciBhbmQgZGVzdHJ1Y3RvciBleHBsaWNpdGx5 IGZvciBkcmFnZ2luZ0RhdGFPYmplY3RzIG1lbWJlci4KKworICAgICAgICAqIHdlYmtpdC93ZWJr aXR3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19maW5hbGl6ZSk6IENhbGwg ZGVzdHJ1Y3RvciBleHBsaWNpdGx5LgorICAgICAgICAod2Via2l0X3dlYl92aWV3X2luaXQpOiBD YWxsIGNvbnN0cnVjdG9yIGV4cGxpY2l0bHkgdXNpbmcgcGxhY2VtZW50IG5ldyBzeW50YXguCisK IDIwMTAtMDYtMDkgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI2MDg4OS4KZGlmZiAtLWdpdCBhL1dl YktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Vi a2l0d2Vidmlldy5jcHAKaW5kZXggNjc0NDczMmRlNTdkM2EwYzk3MjNlN2JmYjdiMTFhMDMzZjVj MDNmNi4uNDE0NzA5ODc4NTU0NzI0MTRmNGJmYTViZTc4NDMyNjM1OThhZDhiZCAxMDA2NDQKLS0t IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKKysrIGIvV2ViS2l0L2d0ay93 ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTExODQsNiArMTE4NCw4IEBAIHN0YXRpYyB2b2lk IHdlYmtpdF93ZWJfdmlld19maW5hbGl6ZShHT2JqZWN0KiBvYmplY3QpCiAgICAgZ19mcmVlKHBy aXYtPmN1c3RvbUVuY29kaW5nKTsKICAgICBnX2ZyZWUocHJpdi0+aWNvblVSSSk7CiAKKyAgICBw cml2LT5kcmFnZ2luZ0RhdGFPYmplY3RzLn5IYXNoTWFwPEdka0RyYWdDb250ZXh0KiwgUmVmUHRy PFdlYkNvcmU6OkRhdGFPYmplY3RHdGs+ID4oKTsKKwogICAgIEdfT0JKRUNUX0NMQVNTKHdlYmtp dF93ZWJfdmlld19wYXJlbnRfY2xhc3MpLT5maW5hbGl6ZShvYmplY3QpOwogfQogCkBAIC0yOTAw LDYgKzI5MDIsOCBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfaW5pdChXZWJLaXRXZWJW aWV3KiB3ZWJWaWV3KQogICAgIHByaXYtPnN1YlJlc291cmNlcyA9IGdfaGFzaF90YWJsZV9uZXdf ZnVsbChnX3N0cl9oYXNoLCBnX3N0cl9lcXVhbCwgZ19mcmVlLCBnX29iamVjdF91bnJlZik7CiAK ICAgICBwcml2LT50b29sdGlwVGV4dCA9IDA7CisKKyAgICBuZXcgKCZwcml2LT5kcmFnZ2luZ0Rh dGFPYmplY3RzKSBIYXNoTWFwPEdka0RyYWdDb250ZXh0KiwgUmVmUHRyPFdlYkNvcmU6OkRhdGFP YmplY3RHdGs+ID47CiB9CiAKIEd0a1dpZGdldCogd2Via2l0X3dlYl92aWV3X25ldyh2b2lkKQo= 60253 2010-07-01 08:43:28 -0700 2010-07-01 09:03:12 -0700 Patch where delete is done in finalize instead of dispose bug-40333-20100701084326.patch text/plain 4990 mrobinson ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggZTQ5ZWE2ZTE0MGViYjc1ZTcwMWE4NWU1NTdiNGMwZTFjYmY0MDMzZS4uOGExOTc1YjAw NTQzY2U1NmY1YWJiMzc3NDEwYWUzM2VhYzI4MjFiMyAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAx MC0wNi0zMCAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgWGFuIExvcGV6LgorCisgICAgICAgIFtHVEtdIENvbnZlcnQgV2ViS2l0 V2ViVmlldydzIHByaXZhdGUgZHJhZ2dpbmdEYXRhT2JqZWN0cyBtZW1iZXIgdG8gYSBwb2ludGVy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDMzMwor CisgICAgICAgIENvbnZlcnQgZHJhZ2dpbmdEYXRhT2JqZWN0cyB0byBhIHBvaW50ZXIuIFRoZSBj b25zdHJ1Y3RvciBhbmQgZGVzdHJ1Y3RvciBvZiB0aGUKKyAgICAgICAgSGFzaE1hcCBzaG91bGQg YmUgY2FsbGVkIGV4cGxpY2l0bHkuIEdPYmplY3QgbWVtb3J5IGFsbG9jYXRpb24gZG9lcyBub3Qg ZG8gdGhpcy4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0RyYWdDbGllbnRHdGsuY3BwOgor ICAgICAgICAoV2ViS2l0OjpEcmFnQ2xpZW50OjpzdGFydERyYWcpOgorICAgICAgICAqIHdlYmtp dC93ZWJraXRwcml2YXRlLmg6CisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwOgor ICAgICAgICAod2Via2l0X3dlYl92aWV3X2Rpc3Bvc2UpOgorICAgICAgICAod2Via2l0X3dlYl92 aWV3X2RyYWdfZW5kKToKKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19kcmFnX2RhdGFfZ2V0KToK KyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19pbml0KToKKwogMjAxMC0wNi0zMCAgWGFuIExvcGV6 ICA8eGxvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR3VzdGF2byBOb3Jv bmhhLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EcmFnQ2xpZW50R3Rr LmNwcCBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHJhZ0NsaWVudEd0ay5jcHAKaW5kZXgg NGJjYzRjMmJiZGExNDhkYTAzZWE0MWEwZmZmZjZkZmU5ODI0MjI4Ni4uZWZjZTNkY2Y2ZDMxNDIx OGNkNDg0NTIzMzc2M2EyYjRkYmIzZTRlMiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9XZWJDb3Jl U3VwcG9ydC9EcmFnQ2xpZW50R3RrLmNwcAorKysgYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0 L0RyYWdDbGllbnRHdGsuY3BwCkBAIC03Nyw3ICs3Nyw3IEBAIHZvaWQgRHJhZ0NsaWVudDo6c3Rh cnREcmFnKERyYWdJbWFnZVJlZiBpbWFnZSwgY29uc3QgSW50UG9pbnQmIGRyYWdJbWFnZU9yaWdp biwKICAgICBHT3duUHRyPEdka0V2ZW50PiBjdXJyZW50RXZlbnQoZ3RrX2dldF9jdXJyZW50X2V2 ZW50KCkpOwogCiAgICAgR2RrRHJhZ0NvbnRleHQqIGNvbnRleHQgPSBndGtfZHJhZ19iZWdpbihH VEtfV0lER0VUKG1fd2ViVmlldyksIHRhcmdldExpc3QuZ2V0KCksIGRyYWdPcGVyYXRpb25Ub0dk a0RyYWdBY3Rpb25zKGNsaXBib2FyZC0+c291cmNlT3BlcmF0aW9uKCkpLCAxLCBjdXJyZW50RXZl bnQuZ2V0KCkpOwotICAgIHdlYlZpZXctPnByaXYtPmRyYWdnaW5nRGF0YU9iamVjdHMuc2V0KGNv bnRleHQsIGRhdGFPYmplY3QpOworICAgIHdlYlZpZXctPnByaXYtPmRyYWdnaW5nRGF0YU9iamVj dHMtPnNldChjb250ZXh0LCBkYXRhT2JqZWN0KTsKIAogICAgIC8vIEEgZHJhZyBzdGFydGluZyBz aG91bGQgcHJldmVudCBhIGRvdWJsZS1jbGljayBmcm9tIGhhcHBlbmluZy4gVGhpcyBtaWdodAog ICAgIC8vIGhhcHBlbiBpZiBhIGRyYWcgaXMgZm9sbG93ZWQgdmVyeSBxdWlja2x5IGJ5IGFub3Ro ZXIgY2xpY2sgKGxpa2UgaW4gdGhlIERSVCkuCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtp dC93ZWJraXRwcml2YXRlLmggYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRwcml2YXRlLmgKaW5k ZXggNTU2NjQ4ZDhmZWJmMDU4MjhmN2RiYTMyMTk0NDFjZWIyOGJiMWI3ZC4uZmE3NGFiYzBlZjE2 ODdlM2JiMDBhNjEyZDFmYzNkOTU1MDliOGRkMyAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0cHJpdmF0ZS5oCisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHByaXZhdGUu aApAQCAtMTU4LDcgKzE1OCw3IEBAIGV4dGVybiAiQyIgewogICAgICAgICBndWludCBwcmV2aW91 c0NsaWNrQnV0dG9uOwogICAgICAgICBndWludDMyIHByZXZpb3VzQ2xpY2tUaW1lOwogCi0gICAg ICAgIEhhc2hNYXA8R2RrRHJhZ0NvbnRleHQqLCBSZWZQdHI8V2ViQ29yZTo6RGF0YU9iamVjdEd0 az4gPiBkcmFnZ2luZ0RhdGFPYmplY3RzOworICAgICAgICBIYXNoTWFwPEdka0RyYWdDb250ZXh0 KiwgUmVmUHRyPFdlYkNvcmU6OkRhdGFPYmplY3RHdGs+ID4qIGRyYWdnaW5nRGF0YU9iamVjdHM7 CiAgICAgfTsKIAogICAgICNkZWZpbmUgV0VCS0lUX1dFQl9GUkFNRV9HRVRfUFJJVkFURShvYmop ICAgIChHX1RZUEVfSU5TVEFOQ0VfR0VUX1BSSVZBVEUoKG9iaiksIFdFQktJVF9UWVBFX1dFQl9G UkFNRSwgV2ViS2l0V2ViRnJhbWVQcml2YXRlKSkKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Vi a2l0L3dlYmtpdHdlYnZpZXcuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5j cHAKaW5kZXggY2UyYmJjNmY0MmRkYmY1ZGM0ZTdkNTA2MWQyMGM5N2RhNGVjYzMwNy4uZmY0YWE4 YTgwMDFhOTliZmVkOTU1ODI1MjZjY2YwYTMwMWEwNDZiMiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0 ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0 d2Vidmlldy5jcHAKQEAgLTExOTAsNyArMTE5MCw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJf dmlld19kaXNwb3NlKEdPYmplY3QqIG9iamVjdCkKICAgICAgICAgcHJpdi0+c3ViUmVzb3VyY2Vz ID0gTlVMTDsKICAgICB9CiAKLSAgICBwcml2LT5kcmFnZ2luZ0RhdGFPYmplY3RzLmNsZWFyKCk7 CisgICAgcHJpdi0+ZHJhZ2dpbmdEYXRhT2JqZWN0cy0+Y2xlYXIoKTsKIAogICAgIEdfT0JKRUNU X0NMQVNTKHdlYmtpdF93ZWJfdmlld19wYXJlbnRfY2xhc3MpLT5kaXNwb3NlKG9iamVjdCk7CiB9 CkBAIC0xMjA3LDYgKzEyMDcsNyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfZmluYWxp emUoR09iamVjdCogb2JqZWN0KQogICAgIGdfZnJlZShwcml2LT5pY29uVVJJKTsKIAogICAgIGRl bGV0ZSBwcml2LT5wcmV2aW91c0NsaWNrUG9pbnQ7CisgICAgZGVsZXRlIHByaXYtPmRyYWdnaW5n RGF0YU9iamVjdHM7CiAKICAgICBHX09CSkVDVF9DTEFTUyh3ZWJraXRfd2ViX3ZpZXdfcGFyZW50 X2NsYXNzKS0+ZmluYWxpemUob2JqZWN0KTsKIH0KQEAgLTEzMDksMTAgKzEzMTAsMTAgQEAgc3Rh dGljIHZvaWQgd2Via2l0X3dlYl92aWV3X2RyYWdfZW5kKEd0a1dpZGdldCogd2lkZ2V0LCBHZGtE cmFnQ29udGV4dCogY29udGV4dCkKIAogICAgIC8vIFRoaXMgbWlnaHQgaGFwcGVuIGlmIGEgZHJh ZyBpcyBzdGlsbCBpbiBwcm9ncmVzcyBhZnRlciBhIFdlYktpdFdlYlZpZXcKICAgICAvLyBpcyBk aXNwb3NlZCBhbmQgYmVmb3JlIGl0IGlzIGZpbmFsaXplZC4KLSAgICBpZiAoIXByaXYtPmRyYWdn aW5nRGF0YU9iamVjdHMuY29udGFpbnMoY29udGV4dCkpCisgICAgaWYgKCFwcml2LT5kcmFnZ2lu Z0RhdGFPYmplY3RzLT5jb250YWlucyhjb250ZXh0KSkKICAgICAgICAgcmV0dXJuOwogCi0gICAg cHJpdi0+ZHJhZ2dpbmdEYXRhT2JqZWN0cy5yZW1vdmUoY29udGV4dCk7CisgICAgcHJpdi0+ZHJh Z2dpbmdEYXRhT2JqZWN0cy0+cmVtb3ZlKGNvbnRleHQpOwogCiAgICAgRnJhbWUqIGZyYW1lID0g Y29yZSh3ZWJWaWV3KS0+Zm9jdXNDb250cm9sbGVyKCktPmZvY3VzZWRPck1haW5GcmFtZSgpOwog ICAgIGlmICghZnJhbWUpCkBAIC0xMzQ3LDEwICsxMzQ4LDEwIEBAIHN0YXRpYyB2b2lkIHdlYmtp dF93ZWJfdmlld19kcmFnX2RhdGFfZ2V0KEd0a1dpZGdldCogd2lkZ2V0LCBHZGtEcmFnQ29udGV4 dCogY29uCiAKICAgICAvLyBUaGlzIG1pZ2h0IGhhcHBlbiBpZiBhIGRyYWcgaXMgc3RpbGwgaW4g cHJvZ3Jlc3MgYWZ0ZXIgYSBXZWJLaXRXZWJWaWV3CiAgICAgLy8gaXMgZGlwb3NlZCBhbmQgYmVm b3JlIGl0IGlzIGZpbmFsaXplZC4KLSAgICBpZiAoIXByaXYtPmRyYWdnaW5nRGF0YU9iamVjdHMu Y29udGFpbnMoY29udGV4dCkpCisgICAgaWYgKCFwcml2LT5kcmFnZ2luZ0RhdGFPYmplY3RzLT5j b250YWlucyhjb250ZXh0KSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgcGFzdGVib2FyZEhlbHBl ckluc3RhbmNlKCktPmZpbGxTZWxlY3Rpb25EYXRhKHNlbGVjdGlvbkRhdGEsIGluZm8sIHByaXYt PmRyYWdnaW5nRGF0YU9iamVjdHMuZ2V0KGNvbnRleHQpLmdldCgpKTsKKyAgICBwYXN0ZWJvYXJk SGVscGVySW5zdGFuY2UoKS0+ZmlsbFNlbGVjdGlvbkRhdGEoc2VsZWN0aW9uRGF0YSwgaW5mbywg cHJpdi0+ZHJhZ2dpbmdEYXRhT2JqZWN0cy0+Z2V0KGNvbnRleHQpLmdldCgpKTsKIH0KIAogI2lm IEdUS19DSEVDS19WRVJTSU9OKDIsIDEyLCAwKQpAQCAtMjkyOCw2ICsyOTI5LDggQEAgc3RhdGlj IHZvaWQgd2Via2l0X3dlYl92aWV3X2luaXQoV2ViS2l0V2ViVmlldyogd2ViVmlldykKICAgICBw cml2LT5wcmV2aW91c0NsaWNrUG9pbnQgPSBuZXcgSW50UG9pbnQoMCwgMCk7CiAgICAgcHJpdi0+ cHJldmlvdXNDbGlja0J1dHRvbiA9IDA7CiAgICAgcHJpdi0+cHJldmlvdXNDbGlja1RpbWUgPSAw OworCisgICAgcHJpdi0+ZHJhZ2dpbmdEYXRhT2JqZWN0cyA9IG5ldyBIYXNoTWFwPEdka0RyYWdD b250ZXh0KiwgUmVmUHRyPFdlYkNvcmU6OkRhdGFPYmplY3RHdGs+ID4oKTsKIH0KIAogR3RrV2lk Z2V0KiB3ZWJraXRfd2ViX3ZpZXdfbmV3KHZvaWQpCg==