40328 2010-06-08 13:28:06 -0700 GtkLauncher fails to build: Undefined references to openFile, readFromFile, and seekFile 2010-08-11 05:36:49 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 0 cmsigler webkit-unassigned gustavo kent.hansen oldest_to_newest 235480 0 cmsigler 2010-06-08 13:28:06 -0700 Hi, In trying to build WebKitGtk on generic Linux (a Gentoo Linux installation) on x86_64, linking GtkLauncher fails with these three errors in particular: ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::openFile(WebCore::String const&, WebCore::FileOpenMode)' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::readFromFile(int, char*, int)' ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::seekFile(int, long long, WebCore::FileSeekOrigin)' (Other linking errors are dealt with in Bug 40326.) These file access problems seem to be related to WebCore/platform/gtk/FileSystemGtk.cpp. These three methods aren't defined in this file as they are in, e.g., WebCore/platform/posix/FileSystemPOSIX.cpp. Of course, when I tried including the posix module in the build, there were namespace collisions. It seems the fix may be to add these missing methods to WebCore/platform/gtk/FileSystemGtk.cpp. I'm not sure how to go about coding the fix for this problem. I just hope some of the Gtk devs. read this report and can add these required methods. Thanks. Clemmitt 235762 1 cmsigler 2010-06-09 06:32:28 -0700 (In reply to comment #0) <snip> > ./.libs/libwebkit-1.0.so: undefined reference to > `WebCore::openFile(WebCore::String const&, WebCore::FileOpenMode)' > ./.libs/libwebkit-1.0.so: undefined reference to > `WebCore::readFromFile(int, char*, int)' > ./.libs/libwebkit-1.0.so: undefined reference to > `WebCore::seekFile(int, long long, WebCore::FileSeekOrigin)' <snip> > These file access problems seem to be related to > WebCore/platform/gtk/FileSystemGtk.cpp. These three > methods aren't defined in this file as they are in, > e.g., WebCore/platform/posix/FileSystemPOSIX.cpp. Additional info: As a QnD test I've added dummy stubs that return -1 (error) for these three methods to WebCore/platform/gtk/FileSystemGtk.cpp. Doing that at least gets the build to complete w/o error. A little investigation leads me to believe that: 1.) To implement 'PlatformFileHandle openFile(const String& path, FileOpenMode mode)' for the GTK platform, a wrapper for 'int g_open(const gchar *filename, int flags, int mode)' is needed. 2.) To implement 'int readFromFile(PlatformFileHandle handle, char* data, int length)' for the GTK platform, a wrapper for 'gboolean g_file_get_contents(const gchar *filename, gchar **contents, gsize *length, GError **error)' is needed. 3.) To implement 'long long seekFile(PlatformFileHandle handle, long long offset, FileSeekOrigin origin)' for the GTK platform, a wrapper for 'GIOStatus g_io_channel_seek_position(GIOChannel *channel, gint64 offset, GSeekType type, GError **error)' is needed. I'm not a low-level GTK developer, having only done some simple GUI design/use, so I'd say I'm not the best person to implement these. Any GTK developer out there, for whom this is a half-hour hack? TIA! Clemmitt 236001 2 cmsigler 2010-06-09 14:12:26 -0700 (In reply to comment #1) <snip> > A little investigation leads me to believe that: <snip> I've got some more info now. The only place the methods openFile, readFromFile and seekFile seem to be called is in WebCore/html/FileStream.cpp. I observe that these changes were introduced in Rev. 58832 --> http://trac.webkit.org/changeset/58832 Therefore, it's my speculation that since that rev. -- when building GTK with all the bells and whistles turned on, at least -- Programs/GtkLauncher hasn't been able to link without error. As for me, I hadn't run a build since rev. 55083 until recently. {FWIW, the two FileStream methods that call these three are: void FileStream::openForRead(Blob* blob) void FileStream::read(char* buffer, int length)} I'm still proposing that these three need to be implemented in WebCore/platform/gtk/FileSystemGtk.cpp by someone who knows what they're doing with basic GTK ops. to match similar implementation in, e.g., WebCore/platform/posix/FileSystemPOSIX.cpp as provided by Revision 57182. (As a lark I may try rolling my tree back to rev. 58831 and see if this problem goes away, as it should.) HTH some more. Clemmitt 237202 3 cmsigler 2010-06-11 18:37:09 -0700 (In reply to comment #1) I found some time to look at stuff, so I just did an implementation of these methods myself. Not sure if the code meets standards for GTK use. Patch is coming next. HTH. Clemmitt 237203 4 58535 cmsigler 2010-06-11 18:38:36 -0700 Created attachment 58535 Patch to add missing methods to FileSystemGtk.cpp Patch as described in previous comment. HTH. 237204 5 58536 cmsigler 2010-06-11 18:39:28 -0700 Created attachment 58536 Patch to add missing methods to FileSystemGtk.cpp Patch as described in previous comment. HTH. 237244 6 58536 krit 2010-06-11 23:19:21 -0700 Comment on attachment 58536 Patch to add missing methods to FileSystemGtk.cpp This is not an official review, but i would like to give some hints.WebCore/ChangeLog:5 + Add to FileSystemGtk.cpp methods openFile, readFromFile The order in Changelogs is normally bug title, bug link, description to the patch and added tests. The patch WebKitTools/Scripts/prepare-ChangeLog -bug <bug-number> will help you to create the changelog. WebCore/platform/gtk/FileSystemGtk.cpp:34 + #include <unistd.h> You added this include twice now. WebCore/platform/gtk/FileSystemGtk.cpp:267 + // Following the implementation for closeFile above, implement openFile Please indent all comments with the code. WebCore/platform/gtk/FileSystemGtk.cpp:286 + // as the pattern for implementing readFromFile dito. WebCore/platform/gtk/FileSystemGtk.cpp:292 + // Handle EOF on read dito. WebCore/platform/gtk/FileSystemGtk.cpp:305 + // just use code from WebCore/platform/posix/FileSystemPOSIX.cpp dito. You either added a new feature, or fixed a regression. Both need layouttesting... 237293 7 cmsigler 2010-06-12 07:21:09 -0700 (In reply to comment #6) > (From update of attachment 58536 [details]) > This is not an official review, but i would like to give some hints. Thank you very much, Dirk. I'll make all these fixes. As of now I don't know how to work with layouttests. I need to review and digest the "Writing New Tests" webpage and then find time to do the work -- which may not happen until sometime next week :^( Thanks again. Clemmitt 255356 8 kent.hansen 2010-07-23 07:04:13 -0700 (In reply to comment #7) > (In reply to comment #6) > > (From update of attachment 58536 [details] [details]) > > This is not an official review, but i would like to give some hints. > > Thank you very much, Dirk. I'll make all these fixes. > > As of now I don't know how to work with layouttests. I need to review and digest the "Writing New Tests" webpage and then find time to do the work -- which may not happen until sometime next week :^( > > Thanks again. > > Clemmitt Hi Clemmitt, Please turn off the review flag if you don't intend to have the current patch reviewed anymore. That stops it from showing up in the list of patches pending review. I've also added the gtk keyword to this bug, since it's more likely to be spotted by gtk devs then. As you commented already, the FileReader class was added in http://trac.webkit.org/changeset/58832, but it's still off by default. So the workaround until a gtk patch is landed is to build without that feature (--no-file-reader, or just don't pass --file-reader). And I don't think you can write a LayoutTest for this; essentially the patch for the missing functions is needed in order to enable file-reader for the gtk port, and once that happens, the entry for fast/files/file-reader.html can be removed from platform/gtk/Skipped. 263196 9 58536 gustavo 2010-08-11 05:28:26 -0700 Comment on attachment 58536 Patch to add missing methods to FileSystemGtk.cpp  304 // Since above methods are implemented without GLib calls and variables,  305 // just use code from WebCore/platform/posix/FileSystemPOSIX.cpp Will these work on Windows? Why not use the glib tools that enable portability here? Also, yes, I think you can just remove the test from the skipped list =) I'll r- given krit's comments and my own. 263202 10 gustavo 2010-08-11 05:36:49 -0700 Implementations for these seem to be written already. See r63308. I believe we should revisit FileSystemGtk, and implement all of it using GIO, though. 58535 2010-06-11 18:38:36 -0700 2010-06-11 18:39:28 -0700 Patch to add missing methods to FileSystemGtk.cpp filesystemgtk_fix.patch text/plain 3002 cmsigler SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MTA1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDYtMTEgIENsZW1taXR0IFNpZ2xlciAgPGNtc2lnbGVyQGdt YWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgdG8gRmlsZVN5c3RlbUd0ay5jcHAgbWV0aG9kcyBvcGVuRmlsZSwgcmVhZEZyb21GaWxl CisgICAgICAgIGFuZCBzZWVrRmlsZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQwMzI4CisKKyAgICAgICAgTm8gY2hhbmdlIGluIGZ1bmN0aW9uYWxp dHkgc28gbm8gbmV3IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL0ZpbGVTeXN0ZW1H dGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6b3BlbkZpbGUpOgorICAgICAgICAoV2ViQ29yZTo6 cmVhZEZyb21GaWxlKToKKyAgICAgICAgKFdlYkNvcmU6OnNlZWtGaWxlKToKKwogMjAxMC0wNi0x MCAgQWJoaXNoZWsgQXJ5YSAgPGluZmVybm9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERhdmUgSHlhdHQuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2d0ay9GaWxlU3lzdGVt R3RrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2d0ay9GaWxlU3lzdGVtR3Rr LmNwcAkocmV2aXNpb24gNjEwNTEpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2d0ay9GaWxlU3lzdGVt R3RrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzAsNiArMzAsOCBAQAogI2luY2x1ZGUgPGdsaWIv Z3N0ZGlvLmg+CiAKICNpbmNsdWRlIDx1bmlzdGQuaD4KKyNpbmNsdWRlIDxmY250bC5oPgorI2lu Y2x1ZGUgPHVuaXN0ZC5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKQEAgLTI1OSw0ICsyNjEs NjMgQEAgYm9vbCB1bmxvYWRNb2R1bGUoUGxhdGZvcm1Nb2R1bGUgbW9kdWxlKQogewogICAgIHJl dHVybiBnX21vZHVsZV9jbG9zZShtb2R1bGUpOwogfQorCitQbGF0Zm9ybUZpbGVIYW5kbGUgb3Bl bkZpbGUoY29uc3QgU3RyaW5nJiBwYXRoLCBGaWxlT3Blbk1vZGUgbW9kZSkKK3sKKy8vIEZvbGxv d2luZyB0aGUgaW1wbGVtZW50YXRpb24gZm9yIGNsb3NlRmlsZSBhYm92ZSwgaW1wbGVtZW50IG9w ZW5GaWxlCisvLyBuZWFybHkgaWRlbnRpY2FsbHkgdG8gUE9TSVggcGxhdGZvcm0gKG5vdCB1c2lu ZyBHTGliIGNhbGxzKQorICAgIENTdHJpbmcgZnNSZXAgPSBmaWxlbmFtZUZyb21TdHJpbmcocGF0 aCk7CisKKyAgICBpZiAoZnNSZXAuaXNOdWxsKCkpCisgICAgICAgIHJldHVybiBpbnZhbGlkUGxh dGZvcm1GaWxlSGFuZGxlOworCisgICAgaW50IHBsYXRmb3JtRmxhZyA9IDA7CisgICAgaWYgKG1v ZGUgPT0gT3BlbkZvclJlYWQpCisgICAgICAgIHBsYXRmb3JtRmxhZyB8PSBPX1JET05MWTsKKyAg ICBlbHNlIGlmIChtb2RlID09IE9wZW5Gb3JXcml0ZSkKKyAgICAgICAgcGxhdGZvcm1GbGFnIHw9 IChPX1dST05MWSB8IE9fQ1JFQVQgfCBPX1RSVU5DKTsKKyAgICByZXR1cm4gb3Blbihmc1JlcC5k YXRhKCksIHBsYXRmb3JtRmxhZywgMDY2Nik7Cit9CisKK2ludCByZWFkRnJvbUZpbGUoUGxhdGZv cm1GaWxlSGFuZGxlIGhhbmRsZSwgY2hhciogZGF0YSwgaW50IGxlbmd0aCkKK3sKKy8vIE9uIFBP U0lYIHBsYXRmb3JtLCBpbXBsZW1lbnRhdGlvbnMgb2Ygd3JpdGVUb0ZpbGUgYW5kIHJlYWRGcm9t RmlsZSBhcmUKKy8vIHNpbWlsYXIuICBTbyBJIGNob29zZSB0byB1c2UgdGhlIGltcGxlbWVudGF0 aW9uIG9mIHdyaXRlVG9GaWxlIGFib3ZlCisvLyBhcyB0aGUgcGF0dGVybiBmb3IgaW1wbGVtZW50 aW5nIHJlYWRGcm9tRmlsZQorICAgIGludCB0b3RhbEJ5dGVzUmVhZCA9IDA7CisgICAgd2hpbGUg KHRvdGFsQnl0ZXNSZWFkIDwgbGVuZ3RoKSB7CisgICAgICAgIGludCBieXRlc1JlYWQgPSByZWFk KGhhbmRsZSwgZGF0YSwgbGVuZ3RoIC0gdG90YWxCeXRlc1JlYWQpOworICAgICAgICBpZiAoYnl0 ZXNSZWFkIDwgMCkKKyAgICAgICAgICAgIHJldHVybiAtMTsKKy8vIEhhbmRsZSBFT0Ygb24gcmVh ZAorICAgICAgICBpZiAoYnl0ZXNSZWFkID09IDApCisgICAgICAgICAgICBicmVhazsKKyAgICAg ICAgdG90YWxCeXRlc1JlYWQgKz0gYnl0ZXNSZWFkOworICAgICAgICBkYXRhICs9IGJ5dGVzUmVh ZDsKKyAgICB9CisKKyAgICByZXR1cm4gdG90YWxCeXRlc1JlYWQ7Cit9CisKK2xvbmcgbG9uZyBz ZWVrRmlsZShQbGF0Zm9ybUZpbGVIYW5kbGUgaGFuZGxlLCBsb25nIGxvbmcgb2Zmc2V0LCBGaWxl U2Vla09yaWdpbiBvcmlnaW4pCit7CisvLyBTaW5jZSBhYm92ZSBtZXRob2RzIGFyZSBpbXBsZW1l bnRlZCB3aXRob3V0IEdMaWIgY2FsbHMgYW5kIHZhcmlhYmxlcywKKy8vIGp1c3QgdXNlIGNvZGUg ZnJvbSBXZWJDb3JlL3BsYXRmb3JtL3Bvc2l4L0ZpbGVTeXN0ZW1QT1NJWC5jcHAKKyAgICBpbnQg d2hlbmNlID0gU0VFS19TRVQ7CisgICAgc3dpdGNoIChvcmlnaW4pIHsKKyAgICBjYXNlIFNlZWtG cm9tQmVnaW5uaW5nOgorICAgICAgICB3aGVuY2UgPSBTRUVLX1NFVDsKKyAgICAgICAgYnJlYWs7 CisgICAgY2FzZSBTZWVrRnJvbUN1cnJlbnQ6CisgICAgICAgIHdoZW5jZSA9IFNFRUtfQ1VSOwor ICAgICAgICBicmVhazsKKyAgICBjYXNlIFNlZWtGcm9tRW5kOgorICAgICAgICB3aGVuY2UgPSBT RUVLX0VORDsKKyAgICAgICAgYnJlYWs7CisgICAgZGVmYXVsdDoKKyAgICAgICAgQVNTRVJUX05P VF9SRUFDSEVEKCk7CisgICAgfQorICAgIHJldHVybiBzdGF0aWNfY2FzdDxsb25nIGxvbmc+KGxz ZWVrKGhhbmRsZSwgb2Zmc2V0LCB3aGVuY2UpKTsKK30KKwogfQo= 58536 2010-06-11 18:39:28 -0700 2010-08-11 05:28:26 -0700 Patch to add missing methods to FileSystemGtk.cpp filesystemgtk_fix.patch text/plain 3002 cmsigler SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MTA1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDYtMTEgIENsZW1taXR0IFNpZ2xlciAgPGNtc2lnbGVyQGdt YWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgdG8gRmlsZVN5c3RlbUd0ay5jcHAgbWV0aG9kcyBvcGVuRmlsZSwgcmVhZEZyb21GaWxl CisgICAgICAgIGFuZCBzZWVrRmlsZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQwMzI4CisKKyAgICAgICAgTm8gY2hhbmdlIGluIGZ1bmN0aW9uYWxp dHkgc28gbm8gbmV3IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL0ZpbGVTeXN0ZW1H dGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6b3BlbkZpbGUpOgorICAgICAgICAoV2ViQ29yZTo6 cmVhZEZyb21GaWxlKToKKyAgICAgICAgKFdlYkNvcmU6OnNlZWtGaWxlKToKKwogMjAxMC0wNi0x MCAgQWJoaXNoZWsgQXJ5YSAgPGluZmVybm9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERhdmUgSHlhdHQuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2d0ay9GaWxlU3lzdGVt R3RrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2d0ay9GaWxlU3lzdGVtR3Rr LmNwcAkocmV2aXNpb24gNjEwNTEpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2d0ay9GaWxlU3lzdGVt R3RrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzAsNiArMzAsOCBAQAogI2luY2x1ZGUgPGdsaWIv Z3N0ZGlvLmg+CiAKICNpbmNsdWRlIDx1bmlzdGQuaD4KKyNpbmNsdWRlIDxmY250bC5oPgorI2lu Y2x1ZGUgPHVuaXN0ZC5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKQEAgLTI1OSw0ICsyNjEs NjMgQEAgYm9vbCB1bmxvYWRNb2R1bGUoUGxhdGZvcm1Nb2R1bGUgbW9kdWxlKQogewogICAgIHJl dHVybiBnX21vZHVsZV9jbG9zZShtb2R1bGUpOwogfQorCitQbGF0Zm9ybUZpbGVIYW5kbGUgb3Bl bkZpbGUoY29uc3QgU3RyaW5nJiBwYXRoLCBGaWxlT3Blbk1vZGUgbW9kZSkKK3sKKy8vIEZvbGxv d2luZyB0aGUgaW1wbGVtZW50YXRpb24gZm9yIGNsb3NlRmlsZSBhYm92ZSwgaW1wbGVtZW50IG9w ZW5GaWxlCisvLyBuZWFybHkgaWRlbnRpY2FsbHkgdG8gUE9TSVggcGxhdGZvcm0gKG5vdCB1c2lu ZyBHTGliIGNhbGxzKQorICAgIENTdHJpbmcgZnNSZXAgPSBmaWxlbmFtZUZyb21TdHJpbmcocGF0 aCk7CisKKyAgICBpZiAoZnNSZXAuaXNOdWxsKCkpCisgICAgICAgIHJldHVybiBpbnZhbGlkUGxh dGZvcm1GaWxlSGFuZGxlOworCisgICAgaW50IHBsYXRmb3JtRmxhZyA9IDA7CisgICAgaWYgKG1v ZGUgPT0gT3BlbkZvclJlYWQpCisgICAgICAgIHBsYXRmb3JtRmxhZyB8PSBPX1JET05MWTsKKyAg ICBlbHNlIGlmIChtb2RlID09IE9wZW5Gb3JXcml0ZSkKKyAgICAgICAgcGxhdGZvcm1GbGFnIHw9 IChPX1dST05MWSB8IE9fQ1JFQVQgfCBPX1RSVU5DKTsKKyAgICByZXR1cm4gb3Blbihmc1JlcC5k YXRhKCksIHBsYXRmb3JtRmxhZywgMDY2Nik7Cit9CisKK2ludCByZWFkRnJvbUZpbGUoUGxhdGZv cm1GaWxlSGFuZGxlIGhhbmRsZSwgY2hhciogZGF0YSwgaW50IGxlbmd0aCkKK3sKKy8vIE9uIFBP U0lYIHBsYXRmb3JtLCBpbXBsZW1lbnRhdGlvbnMgb2Ygd3JpdGVUb0ZpbGUgYW5kIHJlYWRGcm9t RmlsZSBhcmUKKy8vIHNpbWlsYXIuICBTbyBJIGNob29zZSB0byB1c2UgdGhlIGltcGxlbWVudGF0 aW9uIG9mIHdyaXRlVG9GaWxlIGFib3ZlCisvLyBhcyB0aGUgcGF0dGVybiBmb3IgaW1wbGVtZW50 aW5nIHJlYWRGcm9tRmlsZQorICAgIGludCB0b3RhbEJ5dGVzUmVhZCA9IDA7CisgICAgd2hpbGUg KHRvdGFsQnl0ZXNSZWFkIDwgbGVuZ3RoKSB7CisgICAgICAgIGludCBieXRlc1JlYWQgPSByZWFk KGhhbmRsZSwgZGF0YSwgbGVuZ3RoIC0gdG90YWxCeXRlc1JlYWQpOworICAgICAgICBpZiAoYnl0 ZXNSZWFkIDwgMCkKKyAgICAgICAgICAgIHJldHVybiAtMTsKKy8vIEhhbmRsZSBFT0Ygb24gcmVh ZAorICAgICAgICBpZiAoYnl0ZXNSZWFkID09IDApCisgICAgICAgICAgICBicmVhazsKKyAgICAg ICAgdG90YWxCeXRlc1JlYWQgKz0gYnl0ZXNSZWFkOworICAgICAgICBkYXRhICs9IGJ5dGVzUmVh ZDsKKyAgICB9CisKKyAgICByZXR1cm4gdG90YWxCeXRlc1JlYWQ7Cit9CisKK2xvbmcgbG9uZyBz ZWVrRmlsZShQbGF0Zm9ybUZpbGVIYW5kbGUgaGFuZGxlLCBsb25nIGxvbmcgb2Zmc2V0LCBGaWxl U2Vla09yaWdpbiBvcmlnaW4pCit7CisvLyBTaW5jZSBhYm92ZSBtZXRob2RzIGFyZSBpbXBsZW1l bnRlZCB3aXRob3V0IEdMaWIgY2FsbHMgYW5kIHZhcmlhYmxlcywKKy8vIGp1c3QgdXNlIGNvZGUg ZnJvbSBXZWJDb3JlL3BsYXRmb3JtL3Bvc2l4L0ZpbGVTeXN0ZW1QT1NJWC5jcHAKKyAgICBpbnQg d2hlbmNlID0gU0VFS19TRVQ7CisgICAgc3dpdGNoIChvcmlnaW4pIHsKKyAgICBjYXNlIFNlZWtG cm9tQmVnaW5uaW5nOgorICAgICAgICB3aGVuY2UgPSBTRUVLX1NFVDsKKyAgICAgICAgYnJlYWs7 CisgICAgY2FzZSBTZWVrRnJvbUN1cnJlbnQ6CisgICAgICAgIHdoZW5jZSA9IFNFRUtfQ1VSOwor ICAgICAgICBicmVhazsKKyAgICBjYXNlIFNlZWtGcm9tRW5kOgorICAgICAgICB3aGVuY2UgPSBT RUVLX0VORDsKKyAgICAgICAgYnJlYWs7CisgICAgZGVmYXVsdDoKKyAgICAgICAgQVNTRVJUX05P VF9SRUFDSEVEKCk7CisgICAgfQorICAgIHJldHVybiBzdGF0aWNfY2FzdDxsb25nIGxvbmc+KGxz ZWVrKGhhbmRsZSwgb2Zmc2V0LCB3aGVuY2UpKTsKK30KKwogfQo=