40226 2010-06-07 04:21:37 -0700 [BREWMP] Add PopupMenu implementation 2010-06-23 18:19:59 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 33564 0 skyul webkit-unassigned beergun commit-queue tkent oldest_to_newest 234780 0 skyul 2010-06-07 04:21:37 -0700 Delegate PopupMenu handling to ChromeClientBrew. 234794 1 58016 skyul 2010-06-07 04:51:53 -0700 Created attachment 58016 Patch Add methods to create and destory PopupMenu to ChromeClientBrew and delegate PopupMenu handling to WebKit API layer. 240434 2 58016 tkent 2010-06-20 03:46:53 -0700 Comment on attachment 58016 Patch WebCore/page/brew/ChromeClientBrew.h:43 + class ChromeClientBrew : public ChromeClient { ChromeClient[Platform] is usually used as an implementation of ChromeClient. (See WebKit/*/WebCoreSupport/ChromeClinet*) Are you determined to go on your own way? I know this follows Chromium code. 241355 3 skyul 2010-06-22 11:24:38 -0700 (In reply to comment #2) > (From update of attachment 58016 [details]) > WebCore/page/brew/ChromeClientBrew.h:43 > + class ChromeClientBrew : public ChromeClient { > ChromeClient[Platform] is usually used as an implementation of ChromeClient. (See WebKit/*/WebCoreSupport/ChromeClinet*) > Are you determined to go on your own way? I know this follows Chromium code. Yes, I followed the Chromium code because I want to delegate PopupMenu to the WebKit API layer. 241598 4 58016 tkent 2010-06-22 18:58:45 -0700 Comment on attachment 58016 Patch OK. 242176 5 58016 commit-queue 2010-06-23 17:33:29 -0700 Comment on attachment 58016 Patch Rejecting patch 58016 from commit-queue. Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1 Last 500 characters of output: 0 040000 0a86c46f41919178f80a6ab366cc7b24646dfe17 76397f755d659875386414a5f420904404342d1a M LayoutTests :040000 040000 4c049aff9073c316b2087758d9d939dc7400854d ff6f0f70de0f7096cbb2478008eda3b637007e27 M WebKit2 First, rewinding head to replay your work on top of it... error: Untracked working tree file 'LayoutTests/fast/dom/beforeload/remove-bad-object-in-beforeload-listener-expected.txt' would be overwritten by merge. could not detach HEAD rebase refs/remotes/trunk: command returned error: 1 Full output: http://webkit-commit-queue.appspot.com/results/3332693 242177 6 skyul 2010-06-23 17:35:34 -0700 (In reply to comment #5) > (From update of attachment 58016 [details]) > Rejecting patch 58016 from commit-queue. > > Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1 > Last 500 characters of output: > 0 040000 0a86c46f41919178f80a6ab366cc7b24646dfe17 76397f755d659875386414a5f420904404342d1a M LayoutTests > :040000 040000 4c049aff9073c316b2087758d9d939dc7400854d ff6f0f70de0f7096cbb2478008eda3b637007e27 M WebKit2 > First, rewinding head to replay your work on top of it... > error: Untracked working tree file 'LayoutTests/fast/dom/beforeload/remove-bad-object-in-beforeload-listener-expected.txt' would be overwritten by merge. > could not detach HEAD > rebase refs/remotes/trunk: command returned error: 1 > > > Full output: http://webkit-commit-queue.appspot.com/results/3332693 What's this message? Some problem with git? 242220 7 tkent 2010-06-23 18:19:42 -0700 It seems something was wrong with commit-queue. Anyway, the patch was landed as http://trac.webkit.org/changeset/61722 58016 2010-06-07 04:51:53 -0700 2010-06-23 18:19:59 -0700 Patch PopupMenuBrew.patch text/plain 6295 skyul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDc3NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMDYtMDcgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbQlJFV01QXSBBZGQgUG9wdXBNZW51IGltcGxlbWVudGF0aW9uCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDIyNgorCisgICAgICAgIERlbGVnYXRl IFBvcHVwTWVudSBoYW5kbGluZyB0byBDaHJvbWVDbGllbnRCcmV3LgorCisgICAgICAgICogcGFn ZS9icmV3L0Nocm9tZUNsaWVudEJyZXcuaDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vUG9w dXBNZW51Lmg6CisgICAgICAgICogcGxhdGZvcm0vYnJldy9Qb3B1cE1lbnVCcmV3LmNwcDogQWRk ZWQuCisgICAgICAgIChXZWJDb3JlOjpQb3B1cE1lbnU6OlBvcHVwTWVudSk6CisgICAgICAgIChX ZWJDb3JlOjpQb3B1cE1lbnU6On5Qb3B1cE1lbnUpOgorICAgICAgICAoV2ViQ29yZTo6UG9wdXBN ZW51OjpzaG93KToKKyAgICAgICAgKFdlYkNvcmU6OlBvcHVwTWVudTo6aGlkZSk6CisgICAgICAg IChXZWJDb3JlOjpQb3B1cE1lbnU6OnVwZGF0ZUZyb21FbGVtZW50KToKKyAgICAgICAgKFdlYkNv cmU6OlBvcHVwTWVudTo6aXRlbVdyaXRpbmdEaXJlY3Rpb25Jc05hdHVyYWwpOgorCiAyMDEwLTA2 LTA3ICBOaWtvbGFzIFppbW1lcm1hbm4gIDxuemltbWVybWFubkByaW0uY29tPgogCiAgICAgICAg IE5vdCByZXZpZXdlZC4gVXBkYXRlZCBydW4tYmluZGluZ3MtdGVzdHMgcmVzdWx0cy4KSW5kZXg6 IFdlYkNvcmUvcGFnZS9icmV3L0Nocm9tZUNsaWVudEJyZXcuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL3BhZ2UvYnJldy9DaHJvbWVDbGllbnRCcmV3LmgJKHJldmlzaW9uIDApCisrKyBXZWJDb3Jl L3BhZ2UvYnJldy9DaHJvbWVDbGllbnRCcmV3LmgJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNTEg QEAKKy8qCisgKiBDb3B5cmlnaHQgKGMpIDIwMTAsIENvbXBhbnkgMTAwLCBJbmMuIEFsbCByaWdo dHMgcmVzZXJ2ZWQuCisgKgorICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5k IGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJt aXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlCisgKiBtZXQ6 CisgKgorICogICAgICogUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWlu IHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMg YW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyAqICAgICAqIFJlZGlzdHJpYnV0aW9ucyBp biBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUKKyAqIGNvcHlyaWdodCBub3Rp Y2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIK KyAqIGluIHRoZSBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQg d2l0aCB0aGUKKyAqIGRpc3RyaWJ1dGlvbi4KKyAqICAgICAqIE5laXRoZXIgdGhlIG5hbWUgb2Yg R29vZ2xlIEluYy4gbm9yIHRoZSBuYW1lcyBvZiBpdHMKKyAqIGNvbnRyaWJ1dG9ycyBtYXkgYmUg dXNlZCB0byBlbmRvcnNlIG9yIHByb21vdGUgcHJvZHVjdHMgZGVyaXZlZCBmcm9tCisgKiB0aGlz IHNvZnR3YXJlIHdpdGhvdXQgc3BlY2lmaWMgcHJpb3Igd3JpdHRlbiBwZXJtaXNzaW9uLgorICoK KyAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgVEhFIENPUFlSSUdIVCBIT0xERVJTIEFO RCBDT05UUklCVVRPUlMKKyAqICJBUyBJUyIgQU5EIEFOWSBFWFBSRVNTIE9SIElNUExJRUQgV0FS UkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UCisgKiBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRCBX QVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IKKyAqIEEgUEFSVElD VUxBUiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJ R0hUCisgKiBPV05FUiBPUiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJ TkRJUkVDVCwgSU5DSURFTlRBTCwKKyAqIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVO VElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QKKyAqIExJTUlURUQgVE8sIFBST0NVUkVN RU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLAorICogREFU QSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBB TkQgT04gQU5ZCisgKiBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBT VFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RI RVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyAqIE9GIFRISVMgU09G VFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0Uu CisgKi8KKworI2lmbmRlZiBDaHJvbWVDbGllbnRCcmV3X2gKKyNkZWZpbmUgQ2hyb21lQ2xpZW50 QnJld19oCisKKyNpbmNsdWRlICJDaHJvbWVDbGllbnQuaCIKKyNpbmNsdWRlIDx3dGYvRm9yd2Fy ZC5oPgorCituYW1lc3BhY2UgV2ViQ29yZSB7CitjbGFzcyBJbnRSZWN0OworY2xhc3MgUG9wdXBN ZW51Q2xpZW50OworCisvLyBDb250YWlucyBCcmV3LXNwZWNpZmljIGV4dGVuc2lvbnMgdG8gdGhl IENocm9tZUNsaWVudC4gIE9ubHkgcHV0CisvLyB0aGluZ3MgaGVyZSB0aGF0IGRvbid0IG1ha2Ug c2Vuc2UgZm9yIG90aGVyIHBvcnRzLgorY2xhc3MgQ2hyb21lQ2xpZW50QnJldyA6IHB1YmxpYyBD aHJvbWVDbGllbnQgeworcHVibGljOgorICAgIHZpcnR1YWwgdm9pZCBjcmVhdGVTZWxlY3RQb3B1 cChQb3B1cE1lbnVDbGllbnQqLCBpbnQgc2VsZWN0ZWQsIGNvbnN0IEludFJlY3QmIHJlY3QpID0g MDsKKyAgICB2aXJ0dWFsIGJvb2wgZGVzdHJveVNlbGVjdFBvcHVwKCkgPSAwOworfTsKKworfSAv LyBuYW1lc3BhY2UgV2ViQ29yZQorCisjZW5kaWYKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vUG9w dXBNZW51LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9Qb3B1cE1lbnUuaAkocmV2 aXNpb24gNjA3NzQpCisrKyBXZWJDb3JlL3BsYXRmb3JtL1BvcHVwTWVudS5oCSh3b3JraW5nIGNv cHkpCkBAIC0xODIsNyArMTgyLDcgQEAgcHJpdmF0ZToKICAgICBzdGF0aWMgdm9pZCBtZW51VW5t YXBwZWQoR3RrV2lkZ2V0KiwgUG9wdXBNZW51Kik7CiAgICAgc3RhdGljIHZvaWQgbWVudVBvc2l0 aW9uRnVuY3Rpb24oR3RrTWVudSosIGdpbnQqLCBnaW50KiwgZ2Jvb2xlYW4qLCBQb3B1cE1lbnUq KTsKICAgICBzdGF0aWMgdm9pZCBtZW51UmVtb3ZlSXRlbShHdGtXaWRnZXQqLCBQb3B1cE1lbnUq KTsKLSNlbGlmIFBMQVRGT1JNKEVGTCkKKyNlbGlmIFBMQVRGT1JNKEVGTCkgfHwgUExBVEZPUk0o QlJFV01QKQogICAgIEZyYW1lVmlldyogbV92aWV3OwogI2VsaWYgUExBVEZPUk0oV1gpCiAgICAg d3hNZW51KiBtX21lbnU7CkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2JyZXcvUG9wdXBNZW51QnJl dy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9icmV3L1BvcHVwTWVudUJyZXcu Y3BwCShyZXZpc2lvbiAwKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9icmV3L1BvcHVwTWVudUJyZXcu Y3BwCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDc0IEBACisvKgorICogQ29weXJpZ2h0IChDKSAy MDA2LCAyMDA4IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAo QykgMjAwOCBJTmRUIC0gSW5zdGl0dXRvIE5va2lhIGRlIFRlY25vbG9naWEKKyAqIENvcHlyaWdo dCAoQykgMjAwOS0yMDEwIFByb0ZVU0lPTiBlbWJlZGRlZCBzeXN0ZW1zCisgKiBDb3B5cmlnaHQg KEMpIDIwMDktMjAxMCBTYW1zdW5nIEVsZWN0cm9uaWNzCisgKiBDb3B5cmlnaHQgKEMpIDIwMTAg Q29tcGFueSAxMDAsIEluYy4KKyAqCisgKiBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsg eW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCisgKiBtb2RpZnkgaXQgdW5kZXIgdGhlIHRl cm1zIG9mIHRoZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYworICogTGljZW5zZSBhcyBwdWJs aXNoZWQgYnkgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyCisgKiB2ZXJzaW9u IDIgb2YgdGhlIExpY2Vuc2UsIG9yIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24u CisgKgorICogVGhpcyBsaWJyYXJ5IGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQg d2lsbCBiZSB1c2VmdWwsCisgKiBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZl biB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorICogTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1Mg Rk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZSBHTlUKKyAqIExpYnJhcnkgR2VuZXJh bCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorICoKKyAqIFlvdSBzaG91bGQgaGF2 ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljIExpY2Vu c2UKKyAqIGFsb25nIHdpdGggdGhpcyBsaWJyYXJ5OyBzZWUgdGhlIGZpbGUgQ09QWUlORy5MSUIu ICBJZiBub3QsIHdyaXRlIHRvCisgKiB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMu LCA1OSBUZW1wbGUgUGxhY2UgLSBTdWl0ZSAzMzAsCisgKiBCb3N0b24sIE1BIDAyMTExLTEzMDcs IFVTQS4KKyAqCisgKi8KKworI2luY2x1ZGUgImNvbmZpZy5oIgorI2luY2x1ZGUgIlBvcHVwTWVu dS5oIgorCisjaW5jbHVkZSAiQ2hyb21lLmgiCisjaW5jbHVkZSAiQ2hyb21lQ2xpZW50QnJldy5o IgorI2luY2x1ZGUgIkZyYW1lVmlldy5oIgorI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgiCisK K25hbWVzcGFjZSBXZWJDb3JlIHsKKworUG9wdXBNZW51OjpQb3B1cE1lbnUoUG9wdXBNZW51Q2xp ZW50KiBtZW51TGlzdCkKKyAgICA6IG1fcG9wdXBDbGllbnQobWVudUxpc3QpCisgICAgLCBtX3Zp ZXcoMCkKK3sKK30KKworUG9wdXBNZW51Ojp+UG9wdXBNZW51KCkKK3sKK30KKwordm9pZCBQb3B1 cE1lbnU6OnNob3coY29uc3QgSW50UmVjdCYgcmVjdCwgRnJhbWVWaWV3KiB2aWV3LCBpbnQgaW5k ZXgpCit7CisgICAgQVNTRVJUKG1fcG9wdXBDbGllbnQpOworICAgIENocm9tZUNsaWVudEJyZXcq IGNocm9tZUNsaWVudCA9IHN0YXRpY19jYXN0PENocm9tZUNsaWVudEJyZXcqPih2aWV3LT5mcmFt ZSgpLT5wYWdlKCktPmNocm9tZSgpLT5jbGllbnQoKSk7CisgICAgQVNTRVJUKGNocm9tZUNsaWVu dCk7CisKKyAgICBtX3ZpZXcgPSB2aWV3OworICAgIGNocm9tZUNsaWVudC0+Y3JlYXRlU2VsZWN0 UG9wdXAobV9wb3B1cENsaWVudCwgaW5kZXgsIHJlY3QpOworfQorCit2b2lkIFBvcHVwTWVudTo6 aGlkZSgpCit7CisgICAgQVNTRVJUKG1fdmlldyk7CisgICAgQ2hyb21lQ2xpZW50QnJldyogY2hy b21lQ2xpZW50ID0gc3RhdGljX2Nhc3Q8Q2hyb21lQ2xpZW50QnJldyo+KG1fdmlldy0+ZnJhbWUo KS0+cGFnZSgpLT5jaHJvbWUoKS0+Y2xpZW50KCkpOworICAgIEFTU0VSVChjaHJvbWVDbGllbnQp OworCisgICAgY2hyb21lQ2xpZW50LT5kZXN0cm95U2VsZWN0UG9wdXAoKTsKK30KKwordm9pZCBQ b3B1cE1lbnU6OnVwZGF0ZUZyb21FbGVtZW50KCkKK3sKKyAgICBjbGllbnQoKS0+c2V0VGV4dEZy b21JdGVtKGNsaWVudCgpLT5zZWxlY3RlZEluZGV4KCkpOworfQorCitib29sIFBvcHVwTWVudTo6 aXRlbVdyaXRpbmdEaXJlY3Rpb25Jc05hdHVyYWwoKQoreworICAgIHJldHVybiB0cnVlOworfQor Cit9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==