40218 2010-06-06 20:00:35 -0700 Disable interactive form validation in non-standard modes 2010-06-16 19:00:58 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Major --- 28649 40520 1 tkent webkit-unassigned adele ayg darin mjs oldest_to_newest 234711 0 tkent 2010-06-06 20:00:35 -0700 Disable interactive form validation in the compat mode 234714 1 57992 tkent 2010-06-06 20:11:15 -0700 Created attachment 57992 Patch 236805 2 58468 tkent 2010-06-11 06:54:38 -0700 Created attachment 58468 Patch 2 236895 3 58468 dglazkov 2010-06-11 10:36:21 -0700 Comment on attachment 58468 Patch 2 ok, but let's clarify ChangeLog a bit more. WebCore/ChangeLog:9 + HTML4, and users and page authors don't expect existing sites work There is no interactive validation in HTML4. "required" is just something developers started throwing on pages without thinking. Right? WebCore/ChangeLog:12 + modes to keep compatibility as possible. Wording suggestion -- "to improve compatibility." 237268 4 tkent 2010-06-12 03:59:05 -0700 (In reply to comment #3) > (From update of attachment 58468 [details]) > ok, but let's clarify ChangeLog a bit more. > > WebCore/ChangeLog:9 > + HTML4, and users and page authors don't expect existing sites work > There is no interactive validation in HTML4. "required" is just something developers started throwing on pages without thinking. Right? Right. It seems some existing form validation JS libraries have used "required" attribute not for HTML5. > > WebCore/ChangeLog:12 > + modes to keep compatibility as possible. > Wording suggestion -- "to improve compatibility." OK, I'll change so. 237270 5 tkent 2010-06-12 04:19:50 -0700 Committed: http://trac.webkit.org/changeset/61059 237708 6 ap 2010-06-13 21:59:39 -0700 <rdar://problem/8088419> 237709 7 darin 2010-06-13 22:01:03 -0700 I’m not sure that compatibility mode vs. strict mode is the way to handle this. Maybe someone made the mistake on a website in strict mode too. 237710 8 darin 2010-06-13 22:02:21 -0700 We don’t usually make whole new features work only in strict mode. I don’t have any other suggestion at the moment, but I think doing this may reflect some misunderstanding of how effective “quirks vs. strict” really is. Mainly it’s good for slightly rendering tweaks and seems less good for turning off entire features like this one. 237715 9 tkent 2010-06-13 22:27:49 -0700 (In reply to comment #7) > I’m not sure that compatibility mode vs. strict mode is the way to handle this. Maybe someone made the mistake on a website in strict mode too. We can say "your website doesn't conform to HTML5" in that case. But we can't say it for existing HTML4 sites. Please look at Bug#40520 too. 238078 10 mjs 2010-06-14 15:20:11 -0700 (In reply to comment #9) > (In reply to comment #7) > > I’m not sure that compatibility mode vs. strict mode is the way to handle this. Maybe someone made the mistake on a website in strict mode too. > > We can say "your website doesn't conform to HTML5" in that case. But we can't say it for existing HTML4 sites. > > Please look at Bug#40520 too. Existing HTML4 sites can also be in strict mode. In fact, a fair number of HTML4 sites have a standards mode or almost standards mode doctype. I don't think we should make new features be based on a modeswitch. The philosophy of HTML5 is to make new features backwards-compatible so they can be progressively deployed on existing sites. If HTML5 @required causes too much compatibility fallout, then we should: (a) Remove HTML5 @required support entirely for now. (b) Report our findings to the HTML WG and proposed renaming the attribute. I don't think making the feature strict-mode only is an appropriate fix. 239178 11 ayg 2010-06-16 19:00:12 -0700 This violates the HTML5 spec. HTML5 clearly specifies exactly how UAs are to behave in quirks mode -- conformant UAs are expected to behave interoperably in quirks mode just as in standards mode. If WebKit is going to behave differently in quirks mode here, you should tell this to the WHATWG (or HTMLWG) so that it can be added to the spec if other implementers agree it's a good approach. (I don't think it sounds like a good approach; there are only a few sites with the problem and they'll probably fix themselves when they break in both WebKit and Gecko.) 239179 12 ayg 2010-06-16 19:00:58 -0700 Oops, I missed the discussion on bug 40520. Never mind me. 57992 2010-06-06 20:11:15 -0700 2010-06-11 06:54:32 -0700 Patch bug-40218-20100607121113.patch text/plain 4555 tkent ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkMGVmMWFkOGYyZTc5NTBiZDEwYjk5ZWE5OWVjZTZkNDgyMzA4MTg4Li44YjU2Y2My OWEyYWEyZTJkM2ZjMmJmMDdhZGI1MDAwMjk3YzM2NTFiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMDYtMDYgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERpc2FibGUgaW50ZXJhY3Rp dmUgZm9ybSB2YWxpZGF0aW9uIGluIHRoZSBjb21wYXQgbW9kZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDAyMTgKKworICAgICAgICAqIGZhc3QvZm9y bXMvaW50ZXJhY3RpdmUtdmFsaWRhdGlvbi1jb21wYXQtbW9kZS1leHBlY3RlZC50eHQ6IEFkZGVk LgorICAgICAgICAqIGZhc3QvZm9ybXMvaW50ZXJhY3RpdmUtdmFsaWRhdGlvbi1jb21wYXQtbW9k ZS5odG1sOiBBZGRlZC4KKwogMjAxMC0wNi0wNiAgRGlyayBTY2h1bHplICA8a3JpdEB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5pa29sYXMgWmltbWVybWFubi4KZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW50ZXJhY3RpdmUtdmFsaWRhdGlvbi1jb21wYXQt bW9kZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2ludGVyYWN0aXZlLXZh bGlkYXRpb24tY29tcGF0LW1vZGUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmE5NDYwYmUyMzMw ZjA3NmY4ZDFhM2EyOThmYTY2ZGVhMTc2MDlkMWEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2Zvcm1zL2ludGVyYWN0aXZlLXZhbGlkYXRpb24tY29tcGF0LW1vZGUtZXhwZWN0 ZWQudHh0CkBAIC0wLDAgKzEsOSBAQAorVGVzdCBpZiBhbiBpbnZhbGlkIGZvcm0gaW4gYSBkb2N1 bWVudCB3aXRob3V0IERPQ1RZUEUgaXMgc3VibWl0dGVkLgorCitPbiBzdWNjZXNzLCB5b3Ugd2ls bCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01Q TEVURSIuCisKKworUEFTUyBUaGUgZm9ybSBzaG91bGQgYmUgc3VibWl0dGVkLgorUEFTUyBsb2Nh dGlvbi5zZWFyY2guaW5kZXhPZigiaTA9IikgIT0gLTEgaXMgdHJ1ZQorVEVTVCBDT01QTEVURQor IApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbnRlcmFjdGl2ZS12YWxpZGF0 aW9uLWNvbXBhdC1tb2RlLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2ludGVyYWN0aXZl LXZhbGlkYXRpb24tY29tcGF0LW1vZGUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41OGQ4ODYyZDMxNGFjY2Y3 YzFiOTBiMWVhZDlhODMwZjJhNDdmMTcxCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv ZmFzdC9mb3Jtcy9pbnRlcmFjdGl2ZS12YWxpZGF0aW9uLWNvbXBhdC1tb2RlLmh0bWwKQEAgLTAs MCArMSwzNyBAQAorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0i Li4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdCBzcmM9 Ii4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVh ZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48 L2Rpdj4KKzxmb3JtIGlkPWYgYWN0aW9uPSJpbnRlcmFjdGl2ZS12YWxpZGF0aW9uLWNvbXBhdC1t b2RlLmh0bWwiPgorPGlucHV0IHR5cGU9aGlkZGVuIG5hbWU9c3VibWl0dGVkIHZhbHVlPSJ0cnVl Ij4KKzxpbnB1dCBuYW1lPWkwIHJlcXVpcmVkIGlkPSJpMCI+Cis8aW5wdXQgdHlwZT1zdWJtaXQg aWQ9InMiPgorPC9mb3JtPgorPHNjcmlwdD4KK2Rlc2NyaXB0aW9uKCdUZXN0IGlmIGFuIGludmFs aWQgZm9ybSBpbiBhIGRvY3VtZW50IHdpdGhvdXQgRE9DVFlQRSBpcyBzdWJtaXR0ZWQuJyk7CisK K2Z1bmN0aW9uIHN0YXJ0T3JWZXJpZnkoKSB7CisgICAgdmFyIHF1ZXJ5ID0gd2luZG93LmxvY2F0 aW9uLnNlYXJjaDsKKyAgICBpZiAocXVlcnkuaW5kZXhPZignc3VibWl0dGVkPXRydWUnKSAhPSAt MSkgeworICAgICAgICB0ZXN0UGFzc2VkKCdUaGUgZm9ybSBzaG91bGQgYmUgc3VibWl0dGVkLicp OworICAgICAgICBzaG91bGRCZVRydWUoJ2xvY2F0aW9uLnNlYXJjaC5pbmRleE9mKCJpMD0iKSAh PSAtMScpOworICAgICAgICBkZWJ1ZygnVEVTVCBDT01QTEVURScpOworICAgICAgICBpZiAod2lu ZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xs ZXIubm90aWZ5RG9uZSgpOworICAgIH0gZWxzZSB7CisgICAgICAgIC8vIEhUTUxGb3JtRWxlbWVu dDo6c3VibWl0KCkgc2tpcHMgdmFsaWRhdGlvbi4gVXNlIHRoZSBzdWJtaXQgYnV0dG9uLgorICAg ICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgncycpLmNsaWNrKCk7CisgICAgICAgIHRlc3RG YWlsZWQoJ1RoZSBmb3JtIHdhcyBub3Qgc3VibWl0dGVkLicpOworICAgIH0KK30KKworaWYgKHdp bmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0 VW50aWxEb25lKCk7Cit3aW5kb3cub25sb2FkID0gc3RhcnRPclZlcmlmeTsKKzwvc2NyaXB0Pgor PC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCA1MTg5OWY0ZTM2Zjk3ZDc3YWM3ZjQ5OGJiNzg1ZDE2OTEzNzUxMGZh Li4zMjBkYzNlZWUyZTk5NzgzZTJmYTY5YjUzNzA3ZGIyM2JmZDAzYWQwIDEwMDY0NAotLS0gYS9X ZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBA CisyMDEwLTA2LTA2ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEaXNhYmxlIGludGVyYWN0 aXZlIGZvcm0gdmFsaWRhdGlvbiBpbiB0aGUgY29tcGF0IG1vZGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwMjE4CisKKyAgICAgICAgVGhlIGludGVy YWN0aXZlIHZhbGlkYXRpb24gZmVhdHVyZSBvZiBIVE1MNSBpcyBub3QgY29tcGF0aWJsZSB3aXRo CisgICAgICAgIEhUTUw0LCBhbmQgdXNlcnMgYW5kIHBhZ2UgYXV0aG9ycyBkb24ndCBleHBlY3Qg ZXhpc3Rpbmcgc2l0ZXMgd29yaworICAgICAgICBkaWZmZXJlbnRseSBpbiBXZWJLaXQuIEhvd2V2 ZXIsIHRoZSBpbnRlcmFjdGl2ZSB2YWxpZGF0aW9uIGlzIHRoZQorICAgICAgICBzdGFuZGFyZCBi ZWhhdmlvci4KKyAgICAgICAgU28sIHdlIGRpc2FibGUgdGhlIGludGVyYWN0aXZlIHZhbGlkYXRp b24gZmVhdHVyZSBpbiB0aGUgY29tcGF0CisgICAgICAgIG1vZGUgdG8ga2VlcCBjb21wYXRpYmls aXR5IGFzIHBvc3NpYmxlLgorCisgICAgICAgIFRlc3Q6IGZhc3QvZm9ybXMvaW50ZXJhY3RpdmUt dmFsaWRhdGlvbi1jb21wYXQtbW9kZS5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxGb3JtRWxl bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRm9ybUVsZW1lbnQ6OnZhbGlkYXRlSW50 ZXJhY3RpdmVseSk6CisKIDIwMTAtMDYtMDYgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91 Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoUXQgYnVpbGQgZml4 IHB0IDIpLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hUTUxGb3JtRWxlbWVudC5jcHAgYi9X ZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50LmNwcAppbmRleCBjMTk5MzNhZGI0ODMzY2M0MGYx NmUwZTliNjU4ZDU3YzhlNmIwZjUwLi5mMDU3OWYzODQ0YzY5MjZjMmU0YjQyZDFiOTk1YzRiYmZm MDZmOWFjIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50LmNwcAorKysg Yi9XZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50LmNwcApAQCAtMjM0LDcgKzIzNCw3IEBAIHN0 YXRpYyBpbmxpbmUgSFRNTEZvcm1Db250cm9sRWxlbWVudCogc3VibWl0RWxlbWVudEZyb21FdmVu dChjb25zdCBFdmVudCogZXZlbnQpCiBib29sIEhUTUxGb3JtRWxlbWVudDo6dmFsaWRhdGVJbnRl cmFjdGl2ZWx5KEV2ZW50KiBldmVudCkKIHsKICAgICBBU1NFUlQoZXZlbnQpOwotICAgIGlmIChu b1ZhbGlkYXRlKCkpCisgICAgaWYgKGRvY3VtZW50KCktPmluQ29tcGF0TW9kZSgpIHx8IG5vVmFs aWRhdGUoKSkKICAgICAgICAgcmV0dXJuIHRydWU7CiAKICAgICBIVE1MRm9ybUNvbnRyb2xFbGVt ZW50KiBzdWJtaXRFbGVtZW50ID0gc3VibWl0RWxlbWVudEZyb21FdmVudChldmVudCk7Cg== 58468 2010-06-11 06:54:38 -0700 2010-06-12 04:20:09 -0700 Patch 2 bug-40218-20100611225436.patch text/plain 6949 tkent ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2YzVjOTk3NDg1NWM1NzU4MWFkOTJiMDUxYjZmN2QzNjJhYzdiOWJmLi4xZTM4NGM2 NTliNTNhMTRhMzc5MDc4MWI0NTJjYzA5ZTBhZjBlZGUxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMDYtMTEgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERpc2FibGUgaW50ZXJhY3Rp dmUgZm9ybSB2YWxpZGF0aW9uIGluIG5vbi1zdHJpY3QgbW9kZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwMjE4CisKKyAgICAgICAgKiBmYXN0L2Zv cm1zL2ludGVyYWN0aXZlLXZhbGlkYXRpb24tY29tcGF0LW1vZGUtZXhwZWN0ZWQudHh0OiBBZGRl ZC4KKyAgICAgICAgKiBmYXN0L2Zvcm1zL2ludGVyYWN0aXZlLXZhbGlkYXRpb24tY29tcGF0LW1v ZGUuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9mb3Jtcy9pbnRlcmFjdGl2ZS12YWxpZGF0 aW9uLWh0bWw0LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9mb3Jtcy9pbnRl cmFjdGl2ZS12YWxpZGF0aW9uLWh0bWw0Lmh0bWw6IEFkZGVkLgorCiAyMDEwLTA2LTEwICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFl1cnkgU2VtaWtoYXRza3kuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lu dGVyYWN0aXZlLXZhbGlkYXRpb24tY29tcGF0LW1vZGUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvZmFzdC9mb3Jtcy9pbnRlcmFjdGl2ZS12YWxpZGF0aW9uLWNvbXBhdC1tb2RlLWV4cGVjdGVk LnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi5hOTQ2MGJlMjMzMGYwNzZmOGQxYTNhMjk4ZmE2NmRlYTE3NjA5ZDFh Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbnRlcmFjdGl2ZS12 YWxpZGF0aW9uLWNvbXBhdC1tb2RlLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDkgQEAKK1Rlc3Qg aWYgYW4gaW52YWxpZCBmb3JtIGluIGEgZG9jdW1lbnQgd2l0aG91dCBET0NUWVBFIGlzIHN1Ym1p dHRlZC4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNz YWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgVGhlIGZvcm0gc2hv dWxkIGJlIHN1Ym1pdHRlZC4KK1BBU1MgbG9jYXRpb24uc2VhcmNoLmluZGV4T2YoImkwPSIpICE9 IC0xIGlzIHRydWUKK1RFU1QgQ09NUExFVEUKKyAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3QvZm9ybXMvaW50ZXJhY3RpdmUtdmFsaWRhdGlvbi1jb21wYXQtbW9kZS5odG1sIGIvTGF5b3V0 VGVzdHMvZmFzdC9mb3Jtcy9pbnRlcmFjdGl2ZS12YWxpZGF0aW9uLWNvbXBhdC1tb2RlLmh0bWwK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uNThkODg2MmQzMTRhY2NmN2MxYjkwYjFlYWQ5YTgzMGYyYTQ3ZjE3MQotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW50ZXJhY3RpdmUtdmFsaWRh dGlvbi1jb21wYXQtbW9kZS5odG1sCkBAIC0wLDAgKzEsMzcgQEAKKzxodG1sPgorPGhlYWQ+Cis8 bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRl c3Qtc3R5bGUuY3NzIj4KKzxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10 ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwIGlkPSJkZXNjcmlwdGlv biI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8Zm9ybSBpZD1mIGFjdGlvbj0iaW50 ZXJhY3RpdmUtdmFsaWRhdGlvbi1jb21wYXQtbW9kZS5odG1sIj4KKzxpbnB1dCB0eXBlPWhpZGRl biBuYW1lPXN1Ym1pdHRlZCB2YWx1ZT0idHJ1ZSI+Cis8aW5wdXQgbmFtZT1pMCByZXF1aXJlZCBp ZD0iaTAiPgorPGlucHV0IHR5cGU9c3VibWl0IGlkPSJzIj4KKzwvZm9ybT4KKzxzY3JpcHQ+Citk ZXNjcmlwdGlvbignVGVzdCBpZiBhbiBpbnZhbGlkIGZvcm0gaW4gYSBkb2N1bWVudCB3aXRob3V0 IERPQ1RZUEUgaXMgc3VibWl0dGVkLicpOworCitmdW5jdGlvbiBzdGFydE9yVmVyaWZ5KCkgewor ICAgIHZhciBxdWVyeSA9IHdpbmRvdy5sb2NhdGlvbi5zZWFyY2g7CisgICAgaWYgKHF1ZXJ5Lmlu ZGV4T2YoJ3N1Ym1pdHRlZD10cnVlJykgIT0gLTEpIHsKKyAgICAgICAgdGVzdFBhc3NlZCgnVGhl IGZvcm0gc2hvdWxkIGJlIHN1Ym1pdHRlZC4nKTsKKyAgICAgICAgc2hvdWxkQmVUcnVlKCdsb2Nh dGlvbi5zZWFyY2guaW5kZXhPZigiaTA9IikgIT0gLTEnKTsKKyAgICAgICAgZGVidWcoJ1RFU1Qg Q09NUExFVEUnKTsKKyAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAg ICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKKyAgICB9IGVsc2Ug eworICAgICAgICAvLyBIVE1MRm9ybUVsZW1lbnQ6OnN1Ym1pdCgpIHNraXBzIHZhbGlkYXRpb24u IFVzZSB0aGUgc3VibWl0IGJ1dHRvbi4KKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo J3MnKS5jbGljaygpOworICAgICAgICB0ZXN0RmFpbGVkKCdUaGUgZm9ybSB3YXMgbm90IHN1Ym1p dHRlZC4nKTsKKyAgICB9Cit9CisKK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisg ICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOword2luZG93Lm9ubG9hZCA9 IHN0YXJ0T3JWZXJpZnk7Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW50ZXJhY3RpdmUtdmFsaWRhdGlvbi1odG1sNC1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2ludGVyYWN0aXZlLXZhbGlkYXRpb24t aHRtbDQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmE5NDYwYmUyMzMwZjA3NmY4ZDFhM2EyOThm YTY2ZGVhMTc2MDlkMWEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1z L2ludGVyYWN0aXZlLXZhbGlkYXRpb24taHRtbDQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsOSBA QAorVGVzdCBpZiBhbiBpbnZhbGlkIGZvcm0gaW4gYSBkb2N1bWVudCB3aXRob3V0IERPQ1RZUEUg aXMgc3VibWl0dGVkLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBB U1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBUaGUg Zm9ybSBzaG91bGQgYmUgc3VibWl0dGVkLgorUEFTUyBsb2NhdGlvbi5zZWFyY2guaW5kZXhPZigi aTA9IikgIT0gLTEgaXMgdHJ1ZQorVEVTVCBDT01QTEVURQorIApkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC9mb3Jtcy9pbnRlcmFjdGl2ZS12YWxpZGF0aW9uLWh0bWw0Lmh0bWwgYi9MYXlv dXRUZXN0cy9mYXN0L2Zvcm1zL2ludGVyYWN0aXZlLXZhbGlkYXRpb24taHRtbDQuaHRtbApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi4zM2ZhNDRkMzI3ODk2ZThkNzQ1ZjNhNjdmODc3NjAyY2U5OGJhZTUyCi0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbnRlcmFjdGl2ZS12YWxpZGF0aW9u LWh0bWw0Lmh0bWwKQEAgLTAsMCArMSwzOSBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9X M0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFsLy9FTiIKKyAiaHR0cDovL3d3dy53My5vcmcv VFIvaHRtbDQvbG9vc2UuZHRkIj4KKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hl ZXQiIGhyZWY9Ii4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4KKzxz Y3JpcHQgc3JjPSIuLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3Jp cHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0i Y29uc29sZSI+PC9kaXY+Cis8Zm9ybSBpZD1mIGFjdGlvbj0iaW50ZXJhY3RpdmUtdmFsaWRhdGlv bi1jb21wYXQtbW9kZS5odG1sIj4KKzxpbnB1dCB0eXBlPWhpZGRlbiBuYW1lPXN1Ym1pdHRlZCB2 YWx1ZT0idHJ1ZSI+Cis8aW5wdXQgbmFtZT1pMCByZXF1aXJlZCBpZD0iaTAiPgorPGlucHV0IHR5 cGU9c3VibWl0IGlkPSJzIj4KKzwvZm9ybT4KKzxzY3JpcHQ+CitkZXNjcmlwdGlvbignVGVzdCBp ZiBhbiBpbnZhbGlkIGZvcm0gaW4gYSBkb2N1bWVudCB3aXRoIEhUTUw0LjAxIERPQ1RZUEUgaXMg c3VibWl0dGVkLicpOworCitmdW5jdGlvbiBzdGFydE9yVmVyaWZ5KCkgeworICAgIHZhciBxdWVy eSA9IHdpbmRvdy5sb2NhdGlvbi5zZWFyY2g7CisgICAgaWYgKHF1ZXJ5LmluZGV4T2YoJ3N1Ym1p dHRlZD10cnVlJykgIT0gLTEpIHsKKyAgICAgICAgdGVzdFBhc3NlZCgnVGhlIGZvcm0gc2hvdWxk IGJlIHN1Ym1pdHRlZC4nKTsKKyAgICAgICAgc2hvdWxkQmVUcnVlKCdsb2NhdGlvbi5zZWFyY2gu aW5kZXhPZigiaTA9IikgIT0gLTEnKTsKKyAgICAgICAgZGVidWcoJ1RFU1QgQ09NUExFVEUnKTsK KyAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgICAgIGxh eW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKKyAgICB9IGVsc2UgeworICAgICAgICAv LyBIVE1MRm9ybUVsZW1lbnQ6OnN1Ym1pdCgpIHNraXBzIHZhbGlkYXRpb24uIFVzZSB0aGUgc3Vi bWl0IGJ1dHRvbi4KKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3MnKS5jbGljaygp OworICAgICAgICB0ZXN0RmFpbGVkKCdUaGUgZm9ybSB3YXMgbm90IHN1Ym1pdHRlZC4nKTsKKyAg ICB9Cit9CisKK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgbGF5b3V0VGVz dENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOword2luZG93Lm9ubG9hZCA9IHN0YXJ0T3JWZXJp Znk7Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hh bmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWQ1MGUzMGEyZmZhN2FmYjcwNDY4YmJj YmVhODE3NjY0NjNlMzc0OS4uMTQ1OTA0NjlhYzI3MDczMTk4NmE5OWM2Zjc2NTZjMTViNDIxYjFk ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwyMiBAQAorMjAxMC0wNi0xMSAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg RGlzYWJsZSBpbnRlcmFjdGl2ZSBmb3JtIHZhbGlkYXRpb24gaW4gbm9uLXN0cmljdCBtb2Rlcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDAyMTgKKwor ICAgICAgICBUaGUgaW50ZXJhY3RpdmUgdmFsaWRhdGlvbiBmZWF0dXJlIG9mIEhUTUw1IGlzIG5v dCBjb21wYXRpYmxlIHdpdGgKKyAgICAgICAgSFRNTDQsIGFuZCB1c2VycyBhbmQgcGFnZSBhdXRo b3JzIGRvbid0IGV4cGVjdCBleGlzdGluZyBzaXRlcyB3b3JrCisgICAgICAgIGRpZmZlcmVudGx5 IGluIFdlYktpdC4KKyAgICAgICAgU28sIHdlIGRpc2FibGUgdGhlIGludGVyYWN0aXZlIHZhbGlk YXRpb24gZmVhdHVyZSBpbiBub24tc3RyaWN0CisgICAgICAgIG1vZGVzIHRvIGtlZXAgY29tcGF0 aWJpbGl0eSBhcyBwb3NzaWJsZS4KKworICAgICAgICBUZXN0OiBmYXN0L2Zvcm1zL2ludGVyYWN0 aXZlLXZhbGlkYXRpb24tY29tcGF0LW1vZGUuaHRtbAorCisgICAgICAgICogaHRtbC9IVE1MRm9y bUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTEZvcm1FbGVtZW50Ojp2YWxpZGF0 ZUludGVyYWN0aXZlbHkpOgorICAgICAgICAgUHJvY2VzcyBpbnRlcmFjdGl2ZSB2YWxpZGF0aW9u IG9ubHkgaW4gdGhlIHN0cmljdCBtb2RlLgorCiAyMDEwLTA2LTEwICBQYXZlbCBGZWxkbWFuICA8 cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFl1cnkgU2VtaWto YXRza3kuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50LmNwcCBiL1dl YkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQuY3BwCmluZGV4IDhiNjA2ZjU5MDIxMTI5MzY4NjY2 OWY1MzZjNzU0NzJiOTUyNzJmNWYuLjA4NDQ3MGMzNzJjMzBhMDcwZWVmMWJmZDc3Y2E2NjhkMTgx ZDFjNjEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQuY3BwCisrKyBi L1dlYkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQuY3BwCkBAIC0yMzQsNyArMjM0LDcgQEAgc3Rh dGljIGlubGluZSBIVE1MRm9ybUNvbnRyb2xFbGVtZW50KiBzdWJtaXRFbGVtZW50RnJvbUV2ZW50 KGNvbnN0IEV2ZW50KiBldmVudCkKIGJvb2wgSFRNTEZvcm1FbGVtZW50Ojp2YWxpZGF0ZUludGVy YWN0aXZlbHkoRXZlbnQqIGV2ZW50KQogewogICAgIEFTU0VSVChldmVudCk7Ci0gICAgaWYgKG5v VmFsaWRhdGUoKSkKKyAgICBpZiAoIWRvY3VtZW50KCktPmluU3RyaWN0TW9kZSgpIHx8IG5vVmFs aWRhdGUoKSkKICAgICAgICAgcmV0dXJuIHRydWU7CiAKICAgICBIVE1MRm9ybUNvbnRyb2xFbGVt ZW50KiBzdWJtaXRFbGVtZW50ID0gc3VibWl0RWxlbWVudEZyb21FdmVudChldmVudCk7Cg==