40196 2010-06-04 18:10:55 -0700 REGRESSION(r60684): This patch broke chromium reliability tests (Requested by tonyg-cr on #webkit). 2010-06-08 10:59:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 38661 1 webkit.review.bot webkit.review.bot abarth commit-queue eric imxiangpeng oldest_to_newest 234450 0 webkit.review.bot 2010-06-04 18:10:55 -0700 http://trac.webkit.org/changeset/60684 broke the build: This patch broke chromium reliability tests (Requested by tonyg-cr on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 234451 1 57931 webkit.review.bot 2010-06-04 18:11:09 -0700 Created attachment 57931 ROLLOUT of r60684 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment. 234459 2 57931 commit-queue 2010-06-04 18:28:44 -0700 Comment on attachment 57931 ROLLOUT of r60684 Clearing flags on attachment: 57931 Committed r60728: <http://trac.webkit.org/changeset/60728> 234460 3 commit-queue 2010-06-04 18:28:54 -0700 All reviewed patches have been landed. Closing bug. 235362 4 laszlo.gombos 2010-06-08 10:59:33 -0700 *** Bug 40096 has been marked as a duplicate of this bug. *** 57931 2010-06-04 18:11:09 -0700 2010-06-04 18:28:44 -0700 ROLLOUT of r60684 bug-40196-20100605011107.patch text/plain 6810 webkit.review.bot ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTViYzEyMGFlYmM1MjE1ZDdlMTc3YTFiY2U5YTk5ZjE5YWI1YWZjNy4uMzM0ODNlYTE4OGZmNDI0 ZTFkMjcwYjJhZjJlZGYyYjM2NzljNmUyZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wNi0wNCAgU2hl cmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CisKKyAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjYwNjg0LgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC82MDY4NAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDAxOTYKKworICAgICAgICBUaGlzIHBhdGNoIGJyb2tlIGNocm9taXVtIHJlbGlh YmlsaXR5IHRlc3RzIChSZXF1ZXN0ZWQgYnkKKyAgICAgICAgdG9ueWctY3Igb24gI3dlYmtpdCku CisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9TY3JpcHRTb3VyY2VDb2RlLmg6CisgICAgICAgIChX ZWJDb3JlOjpTY3JpcHRTb3VyY2VDb2RlOjpTY3JpcHRTb3VyY2VDb2RlKToKKyAgICAgICAgKiBi aW5kaW5ncy92OC9WOFByb3h5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4UHJveHk6OmNvbXBp bGVTY3JpcHQpOgorICAgICAgICAoV2ViQ29yZTo6VjhQcm94eTo6ZXZhbHVhdGUpOgorICAgICAg ICAqIGJpbmRpbmdzL3Y4L1Y4UHJveHkuaDoKKwogMjAxMC0wNi0wNCAgQW5kcmVhcyBLbGluZyAg PGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvciBBcm5l IFZlc3Riw7guCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdFNvdXJjZUNv ZGUuaCBiL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0U291cmNlQ29kZS5oCmluZGV4IGRiYzlk NWU2ZmM2MDA3ZmNmZGQ2NjAyNGRiMDc4MjZjNjYyNjNiNWIuLjVjMTYxNjhlNDFmMDZiNDI2MWRl NGE5NzBkZTZkZTFhNTY0YzcyNjIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvU2Ny aXB0U291cmNlQ29kZS5oCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0U291cmNlQ29k ZS5oCkBAIC0zMSw3ICszMSw2IEBACiAjaWZuZGVmIFNjcmlwdFNvdXJjZUNvZGVfaAogI2RlZmlu ZSBTY3JpcHRTb3VyY2VDb2RlX2gKIAotI2luY2x1ZGUgIkNhY2hlZFJlc291cmNlSGFuZGxlLmgi CiAjaW5jbHVkZSAiQ2FjaGVkU2NyaXB0LmgiCiAjaW5jbHVkZSAiS1VSTC5oIgogI2luY2x1ZGUg IlBsYXRmb3JtU3RyaW5nLmgiCkBAIC00Miw3ICs0MSw2IEBAIGNsYXNzIFNjcmlwdFNvdXJjZUNv ZGUgewogcHVibGljOgogICAgIFNjcmlwdFNvdXJjZUNvZGUoY29uc3QgU3RyaW5nJiBzb3VyY2Us IGNvbnN0IEtVUkwmIHVybCA9IEtVUkwoKSwgaW50IHN0YXJ0TGluZSA9IDEpCiAgICAgICAgIDog bV9zb3VyY2Uoc291cmNlKQotICAgICAgICAsIG1fY2FjaGVkU2NyaXB0KDApCiAgICAgICAgICwg bV91cmwodXJsKQogICAgICAgICAsIG1fc3RhcnRMaW5lKHN0YXJ0TGluZSkKICAgICB7CkBAIC01 Miw3ICs1MCw2IEBAIHB1YmxpYzoKICAgICAvLyBOb3Qgc3VyZSBpZiB0aGF0IG1hdHRlcnMuCiAg ICAgU2NyaXB0U291cmNlQ29kZShDYWNoZWRTY3JpcHQqIGNzKQogICAgICAgICA6IG1fc291cmNl KGNzLT5zY3JpcHQoKSkKLSAgICAgICAgLCBtX2NhY2hlZFNjcmlwdChjcykKICAgICAgICAgLCBt X3VybChQYXJzZWRVUkxTdHJpbmcsIGNzLT51cmwoKSkKICAgICAgICAgLCBtX3N0YXJ0TGluZSgx KQogICAgIHsKQEAgLTYxLDEzICs1OCwxMSBAQCBwdWJsaWM6CiAgICAgYm9vbCBpc0VtcHR5KCkg Y29uc3QgeyByZXR1cm4gbV9zb3VyY2UuaXNFbXB0eSgpOyB9CiAKICAgICBjb25zdCBTdHJpbmcm IHNvdXJjZSgpIGNvbnN0IHsgcmV0dXJuIG1fc291cmNlOyB9Ci0gICAgQ2FjaGVkU2NyaXB0KiBj YWNoZWRTY3JpcHQoKSBjb25zdCB7IHJldHVybiBtX2NhY2hlZFNjcmlwdC5nZXQoKTsgfQogICAg IGNvbnN0IEtVUkwmIHVybCgpIGNvbnN0IHsgcmV0dXJuIG1fdXJsOyB9CiAgICAgaW50IHN0YXJ0 TGluZSgpIGNvbnN0IHsgcmV0dXJuIG1fc3RhcnRMaW5lOyB9CiAKIHByaXZhdGU6CiAgICAgU3Ry aW5nIG1fc291cmNlOwotICAgIENhY2hlZFJlc291cmNlSGFuZGxlPENhY2hlZFNjcmlwdD4gbV9j YWNoZWRTY3JpcHQ7CiAgICAgS1VSTCBtX3VybDsKICAgICBpbnQgbV9zdGFydExpbmU7CiB9Owpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmNwcCBiL1dlYkNvcmUvYmlu ZGluZ3MvdjgvVjhQcm94eS5jcHAKaW5kZXggMGIxNmYzYTBkYTFlZWY5Y2E3NmZkNTg3MmEzYzdj MGU4YTQ4YzhjOS4uZDdlZjZmNjc4ZDE2OTlhYWRhM2MzZjYxYTZkMzQyZmQ5M2RkOWIwYSAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmNwcAorKysgYi9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4UHJveHkuY3BwCkBAIC0zMSw3ICszMSw2IEBACiAjaW5jbHVkZSAiY29uZmln LmgiCiAjaW5jbHVkZSAiVjhQcm94eS5oIgogCi0jaW5jbHVkZSAiQ2FjaGVkTWV0YWRhdGEuaCIK ICNpbmNsdWRlICJDU1NNdXRhYmxlU3R5bGVEZWNsYXJhdGlvbi5oIgogI2luY2x1ZGUgIkRhdGVF eHRlbnNpb24uaCIKICNpbmNsdWRlICJEb2N1bWVudExvYWRlci5oIgpAQCAtNzEsNyArNzAsNiBA QAogI2luY2x1ZGUgPHY4Lmg+CiAjaW5jbHVkZSA8d3RmL0Fzc2VydGlvbnMuaD4KICNpbmNsdWRl IDx3dGYvT3duQXJyYXlQdHIuaD4KLSNpbmNsdWRlIDx3dGYvT3duUHRyLmg+CiAjaW5jbHVkZSA8 d3RmL1N0ZExpYkV4dHJhcy5oPgogI2luY2x1ZGUgPHd0Zi9TdHJpbmdFeHRyYXMuaD4KICNpbmNs dWRlIDx3dGYvVW51c2VkUGFyYW0uaD4KQEAgLTIzNSwxMyArMjMzLDEzIEBAIFY4UHJveHk6On5W OFByb3h5KCkKICAgICB3aW5kb3dTaGVsbCgpLT5kZXN0cm95R2xvYmFsKCk7CiB9CiAKLXY4OjpI YW5kbGU8djg6OlNjcmlwdD4gVjhQcm94eTo6Y29tcGlsZVNjcmlwdCh2ODo6SGFuZGxlPHY4OjpT dHJpbmc+IGNvZGUsIGNvbnN0IFN0cmluZyYgZmlsZU5hbWUsIGludCBiYXNlTGluZSwgdjg6OlNj cmlwdERhdGEqIHNjcmlwdERhdGEpCit2ODo6SGFuZGxlPHY4OjpTY3JpcHQ+IFY4UHJveHk6OmNv bXBpbGVTY3JpcHQodjg6OkhhbmRsZTx2ODo6U3RyaW5nPiBjb2RlLCBjb25zdCBTdHJpbmcmIGZp bGVOYW1lLCBpbnQgYmFzZUxpbmUpCiB7CiAgICAgY29uc3QgdWludDE2X3QqIGZpbGVOYW1lU3Ry aW5nID0gZnJvbVdlYkNvcmVTdHJpbmcoZmlsZU5hbWUpOwogICAgIHY4OjpIYW5kbGU8djg6OlN0 cmluZz4gbmFtZSA9IHY4OjpTdHJpbmc6Ok5ldyhmaWxlTmFtZVN0cmluZywgZmlsZU5hbWUubGVu Z3RoKCkpOwogICAgIHY4OjpIYW5kbGU8djg6OkludGVnZXI+IGxpbmUgPSB2ODo6SW50ZWdlcjo6 TmV3KGJhc2VMaW5lKTsKICAgICB2ODo6U2NyaXB0T3JpZ2luIG9yaWdpbihuYW1lLCBsaW5lKTsK LSAgICB2ODo6SGFuZGxlPHY4OjpTY3JpcHQ+IHNjcmlwdCA9IHY4OjpTY3JpcHQ6OkNvbXBpbGUo Y29kZSwgJm9yaWdpbiwgc2NyaXB0RGF0YSk7CisgICAgdjg6OkhhbmRsZTx2ODo6U2NyaXB0PiBz Y3JpcHQgPSB2ODo6U2NyaXB0OjpDb21waWxlKGNvZGUsICZvcmlnaW4pOwogICAgIHJldHVybiBz Y3JpcHQ7CiB9CiAKQEAgLTM0MCwzMyArMzM4LDYgQEAgYm9vbCBWOFByb3h5OjpzZXRJbmplY3Rl ZFNjcmlwdENvbnRleHREZWJ1Z0lkKHY4OjpIYW5kbGU8djg6OkNvbnRleHQ+IHRhcmdldENvbnQK ICAgICByZXR1cm4gdHJ1ZTsKIH0KIAotUGFzc093blB0cjx2ODo6U2NyaXB0RGF0YT4gVjhQcm94 eTo6cHJlY29tcGlsZVNjcmlwdChjb25zdCBTY3JpcHRTb3VyY2VDb2RlJiBzb3VyY2UpCi17Ci0g ICAgLy8gQSBwc2V1ZG8tcmFuZG9tbHkgY2hvc2VuIElEIHVzZWQgdG8gc3RvcmUgYW5kIHJldHJp ZXZlIFY4IFNjcmlwdERhdGEgZnJvbQotICAgIC8vIHRoZSBDYWNoZWRTY3JpcHQuIElmIHRoZSBm b3JtYXQgY2hhbmdlcywgdGhpcyBJRCBzaG91bGQgYmUgY2hhbmdlZCB0b28uCi0gICAgc3RhdGlj IGNvbnN0IHVuc2lnbmVkIGRhdGFUeXBlSUQgPSAweEVDQzEzQkQ3OwotCi0gICAgLy8gVmVyeSBz bWFsbCBzY3JpcHRzIGFyZSBub3Qgd29ydGggdGhlIGVmZm9ydCB0byBwcmVwYXJzZS4KLSAgICBz dGF0aWMgY29uc3QgdW5zaWduZWQgbWluUHJlcGFyc2VMZW5ndGggPSAxMDI0OwotCi0gICAgQ2Fj aGVkU2NyaXB0KiBjYWNoZWRTY3JpcHQgPSBzb3VyY2UuY2FjaGVkU2NyaXB0KCk7Ci0gICAgaWYg KCFjYWNoZWRTY3JpcHQpCi0gICAgICAgIHJldHVybiAwOwotCi0gICAgQ2FjaGVkTWV0YWRhdGEq IGNhY2hlZE1ldGFkYXRhID0gY2FjaGVkU2NyaXB0LT5jYWNoZWRNZXRhZGF0YShkYXRhVHlwZUlE KTsKLSAgICBpZiAoY2FjaGVkTWV0YWRhdGEpCi0gICAgICAgIHJldHVybiB2ODo6U2NyaXB0RGF0 YTo6TmV3KGNhY2hlZE1ldGFkYXRhLT5kYXRhKCksIGNhY2hlZE1ldGFkYXRhLT5zaXplKCkpOwot Ci0gICAgY29uc3QgQ1N0cmluZyYgdXRmOFNvdXJjZSA9IHNvdXJjZS5zb3VyY2UoKS51dGY4KCk7 Ci0gICAgaWYgKHV0ZjhTb3VyY2UubGVuZ3RoKCkgPCBtaW5QcmVwYXJzZUxlbmd0aCkKLSAgICAg ICAgcmV0dXJuIDA7Ci0KLSAgICB2ODo6U2NyaXB0RGF0YSogc2NyaXB0RGF0YSA9IHY4OjpTY3Jp cHREYXRhOjpQcmVDb21waWxlKHV0ZjhTb3VyY2UuZGF0YSgpLCB1dGY4U291cmNlLmxlbmd0aCgp KTsKLSAgICBjYWNoZWRTY3JpcHQtPnNldENhY2hlZE1ldGFkYXRhKGRhdGFUeXBlSUQsIHNjcmlw dERhdGEtPkRhdGEoKSwgc2NyaXB0RGF0YS0+TGVuZ3RoKCkpOwotCi0gICAgcmV0dXJuIHNjcmlw dERhdGE7Ci19Ci0KIHY4OjpMb2NhbDx2ODo6VmFsdWU+IFY4UHJveHk6OmV2YWx1YXRlKGNvbnN0 IFNjcmlwdFNvdXJjZUNvZGUmIHNvdXJjZSwgTm9kZSogbm9kZSkKIHsKICAgICBBU1NFUlQodjg6 OkNvbnRleHQ6OkluQ29udGV4dCgpKTsKQEAgLTM5MiwxMSArMzYzLDEwIEBAIHY4OjpMb2NhbDx2 ODo6VmFsdWU+IFY4UHJveHk6OmV2YWx1YXRlKGNvbnN0IFNjcmlwdFNvdXJjZUNvZGUmIHNvdXJj ZSwgTm9kZSogbm9kCiAjaWYgUExBVEZPUk0oQ0hST01JVU0pCiAgICAgICAgIFBsYXRmb3JtQnJp ZGdlOjp0cmFjZUV2ZW50QmVnaW4oInY4LmNvbXBpbGUiLCBub2RlLCAiIik7CiAjZW5kaWYKLSAg ICAgICAgT3duUHRyPHY4OjpTY3JpcHREYXRhPiBzY3JpcHREYXRhID0gcHJlY29tcGlsZVNjcmlw dChzb3VyY2UpOwogCiAgICAgICAgIC8vIE5PVEU6IEZvciBjb21wYXRpYmlsaXR5IHdpdGggV2Vi Q29yZSwgU2NyaXB0U291cmNlQ29kZSdzIGxpbmUgc3RhcnRzIGF0CiAgICAgICAgIC8vIDEsIHdo ZXJlYXMgdjggc3RhcnRzIGF0IDAuCi0gICAgICAgIHY4OjpIYW5kbGU8djg6OlNjcmlwdD4gc2Ny aXB0ID0gY29tcGlsZVNjcmlwdChjb2RlLCBzb3VyY2UudXJsKCksIHNvdXJjZS5zdGFydExpbmUo KSAtIDEsIHNjcmlwdERhdGEuZ2V0KCkpOworICAgICAgICB2ODo6SGFuZGxlPHY4OjpTY3JpcHQ+ IHNjcmlwdCA9IGNvbXBpbGVTY3JpcHQoY29kZSwgc291cmNlLnVybCgpLCBzb3VyY2Uuc3RhcnRM aW5lKCkgLSAxKTsKICNpZiBQTEFURk9STShDSFJPTUlVTSkKICAgICAgICAgUGxhdGZvcm1Ccmlk Z2U6OnRyYWNlRXZlbnRFbmQoInY4LmNvbXBpbGUiLCBub2RlLCAiIik7CiAKZGlmZiAtLWdpdCBh L1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5oIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFBy b3h5LmgKaW5kZXggNTkyYTIyNmYwY2I1MGE0NWY0ODIzMTQyZWNhZjVlYjZlYzFjZTk3YS4uMDk4 ZDk1NmUyYzYyMGQ3MTU0YzYyZTJlZTZkNGE1MzMyYTMwYzIwNCAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOFByb3h5LmgKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5 LmgKQEAgLTI4NSw3ICsyODUsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICAgICAgc3Rh dGljIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBjaGVja05ld0xlZ2FsKGNvbnN0IHY4OjpBcmd1bWVu dHMmKTsKIAotICAgICAgICBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6U2NyaXB0PiBjb21waWxlU2Ny aXB0KHY4OjpIYW5kbGU8djg6OlN0cmluZz4gY29kZSwgY29uc3QgU3RyaW5nJiBmaWxlTmFtZSwg aW50IGJhc2VMaW5lLCB2ODo6U2NyaXB0RGF0YSogc2NyaXB0RGF0YSA9IDApOworICAgICAgICBz dGF0aWMgdjg6OkhhbmRsZTx2ODo6U2NyaXB0PiBjb21waWxlU2NyaXB0KHY4OjpIYW5kbGU8djg6 OlN0cmluZz4gY29kZSwgY29uc3QgU3RyaW5nJiBmaWxlTmFtZSwgaW50IGJhc2VMaW5lKTsKIAog ICAgICAgICAvLyBJZiB0aGUgZXhjZXB0aW9uIGNvZGUgaXMgZGlmZmVyZW50IGZyb20gemVybywg YSBET00gZXhjZXB0aW9uIGlzCiAgICAgICAgIC8vIHNjaGVkdWxlIHRvIGJlIHRocm93bi4KQEAg LTMzNyw4ICszMzcsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICAgICAgdm9pZCByZXNl dElzb2xhdGVkV29ybGRzKCk7CiAKLSAgICAgICAgUGFzc093blB0cjx2ODo6U2NyaXB0RGF0YT4g cHJlY29tcGlsZVNjcmlwdChjb25zdCBTY3JpcHRTb3VyY2VDb2RlJiBzb3VyY2UpOwotCiAgICAg ICAgIC8vIFJldHVybnMgZmFsc2Ugd2hlbiB3ZSdyZSBvdXQgb2YgbWVtb3J5IGluIFY4LgogICAg ICAgICBib29sIHNldEluamVjdGVkU2NyaXB0Q29udGV4dERlYnVnSWQodjg6OkhhbmRsZTx2ODo6 Q29udGV4dD4gdGFyZ2V0Q29udGV4dCk7CiAK